)]}'
{"lib/puppet/provider/swift_ring_builder.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b012a07775dfdd2d9306704d2e9d722f7b84df97","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      # Swift \u003c 2.2.2 Skip first 4 info lines from swift-ring-builder output"},{"line_number":24,"context_line":"      if rows \u003d swift_ring_builder(builder_file_path).split(\"\\n\")[4..-1]"},{"line_number":25,"context_line":"        # Skip \"Ring file ... is up-to-date\" message, if printed."},{"line_number":26,"context_line":"        if !rows[0].nil? and rows[0].start_with?(\u0027Ring\u0027)"},{"line_number":27,"context_line":"             rows.shift"},{"line_number":28,"context_line":"        end"},{"line_number":29,"context_line":"        # Swift 2.2.2+ Skip additional line to account for Overload info"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dab17558_92cca362","line":26,"updated":"2016-05-15 08:43:55.000000000","message":"The regex is not strong enough, see:\nhttps://github.com/openstack/swift/blob/master/swift/cli/ringbuilder.py#L456-L469\n\nIt matches with other messages that we don\u0027t want to ignore.\nPlease be more specific.","commit_id":"cda488497385f6210c652ac3c82a75a95c374cf9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"11c95d969b59f188507795f4446ee6bcacc5b051","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      # Swift \u003c 2.2.2 Skip first 4 info lines from swift-ring-builder output"},{"line_number":24,"context_line":"      if rows \u003d swift_ring_builder(builder_file_path).split(\"\\n\")[4..-1]"},{"line_number":25,"context_line":"        # Skip \"Ring file ... is up-to-date\" message, if printed."},{"line_number":26,"context_line":"        if !rows[0].nil? and rows[0].start_with?(\u0027Ring\u0027)"},{"line_number":27,"context_line":"             rows.shift"},{"line_number":28,"context_line":"        end"},{"line_number":29,"context_line":"        # Swift 2.2.2+ Skip additional line to account for Overload info"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dab17558_4311a651","line":26,"in_reply_to":"dab17558_92cca362","updated":"2016-05-16 14:11:51.000000000","message":"+1 to Emilien suggestion.","commit_id":"cda488497385f6210c652ac3c82a75a95c374cf9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7429b2e913eef17febdd043729b4208bb8eacbea","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      # Swift \u003c 2.2.2 Skip first 4 info lines from swift-ring-builder output"},{"line_number":24,"context_line":"      if rows \u003d swift_ring_builder(builder_file_path).split(\"\\n\")[4..-1]"},{"line_number":25,"context_line":"        # Skip \"Ring file ... is up-to-date\" message, if printed."},{"line_number":26,"context_line":"        if !rows[0].nil? and rows[0].end_with?(\u0027is up-to-date\u0027)"},{"line_number":27,"context_line":"             rows.shift"},{"line_number":28,"context_line":"        end"},{"line_number":29,"context_line":"        # Swift 2.2.2+ Skip additional line to account for Overload info"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dab17558_0e9b3519","line":26,"updated":"2016-05-16 18:22:45.000000000","message":"why you want end_with? and start_with? :D why not full regexp here?\n\n/Ring file\\b.*\\bis up-to-date/ - try this","commit_id":"195466982b98d375ad4b3cb4b39382e856904fda"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"532249099f35967b215591bf178d0deab99faf88","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      # Swift \u003c 2.2.2 Skip first 4 info lines from swift-ring-builder output"},{"line_number":24,"context_line":"      if rows \u003d swift_ring_builder(builder_file_path).split(\"\\n\")[4..-1]"},{"line_number":25,"context_line":"        # Skip \"Ring file ... is up-to-date\" message, if printed."},{"line_number":26,"context_line":"        if !rows[0].nil? and rows[0].end_with?(\u0027is up-to-date\u0027)"},{"line_number":27,"context_line":"             rows.shift"},{"line_number":28,"context_line":"        end"},{"line_number":29,"context_line":"        # Swift 2.2.2+ Skip additional line to account for Overload info"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dab17558_35f45cef","line":26,"in_reply_to":"dab17558_0e9b3519","updated":"2016-05-17 13:46:42.000000000","message":"Much better idea, thank you for the guidance.","commit_id":"195466982b98d375ad4b3cb4b39382e856904fda"}]}
