)]}'
{"manifests/deps.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b4ab92a4677fe2d33c32798361682bb448be345f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  -\u003e Package\u003c| tag \u003d\u003d \u0027swift-package\u0027|\u003e"},{"line_number":15,"context_line":"  ~\u003e anchor { \u0027swift::install::end\u0027: }"},{"line_number":16,"context_line":"  -\u003e anchor { \u0027swift::config::begin\u0027: }"},{"line_number":17,"context_line":"  -\u003e Swift_config\u003c||\u003e"},{"line_number":18,"context_line":"  ~\u003e anchor { \u0027swift::config::end\u0027: }"},{"line_number":19,"context_line":"  ~\u003e anchor { \u0027swift::service::begin\u0027: }"},{"line_number":20,"context_line":"  ~\u003e Service\u003c| tag \u003d\u003d \u0027swift-service\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_211c9511","line":17,"updated":"2016-05-19 15:56:12.000000000","message":"we also have swift dispersion config, but as i understand, this config has no effect on swift services.\n\nif so, just skip my comment :)","commit_id":"bebc595a7d67d91d88642c04d0a7945c2e11e6d6"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"f4cdd65f626e0599b8517c28b16eefce17d6a1ac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  -\u003e Package\u003c| tag \u003d\u003d \u0027swift-package\u0027|\u003e"},{"line_number":15,"context_line":"  ~\u003e anchor { \u0027swift::install::end\u0027: }"},{"line_number":16,"context_line":"  -\u003e anchor { \u0027swift::config::begin\u0027: }"},{"line_number":17,"context_line":"  -\u003e Swift_config\u003c||\u003e"},{"line_number":18,"context_line":"  ~\u003e anchor { \u0027swift::config::end\u0027: }"},{"line_number":19,"context_line":"  ~\u003e anchor { \u0027swift::service::begin\u0027: }"},{"line_number":20,"context_line":"  ~\u003e Service\u003c| tag \u003d\u003d \u0027swift-service\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_2033daac","line":17,"in_reply_to":"bab6814e_211c9511","updated":"2016-05-19 22:37:25.000000000","message":"Next patch should address this.. I agree there were more to add here.","commit_id":"bebc595a7d67d91d88642c04d0a7945c2e11e6d6"}],"manifests/dispersion.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"35bd01651c65ebd60d97ca2c7692f9a8d547159a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    ensure \u003d\u003e file,"},{"line_number":90,"context_line":"    owner  \u003d\u003e \u0027swift\u0027,"},{"line_number":91,"context_line":"    group  \u003d\u003e \u0027swift\u0027,"},{"line_number":92,"context_line":"    tag    \u003d\u003e \u0027swift-file\u0027,"},{"line_number":93,"context_line":"  }"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  swift_dispersion_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_1055551c","line":92,"updated":"2016-05-19 17:04:51.000000000","message":"not sure about this file.\n\nas i understand, this utility should be installed and configured on last stage.\n\nmay be we can add here anchor { \u0027swift::service::end\u0027: } ?\n\nbecause in exec i see swift api calling.","commit_id":"bebc595a7d67d91d88642c04d0a7945c2e11e6d6"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"f4cdd65f626e0599b8517c28b16eefce17d6a1ac","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    ensure \u003d\u003e file,"},{"line_number":90,"context_line":"    owner  \u003d\u003e \u0027swift\u0027,"},{"line_number":91,"context_line":"    group  \u003d\u003e \u0027swift\u0027,"},{"line_number":92,"context_line":"    tag    \u003d\u003e \u0027swift-file\u0027,"},{"line_number":93,"context_line":"  }"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  swift_dispersion_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_800d66ea","line":92,"in_reply_to":"bab6814e_1055551c","updated":"2016-05-19 22:37:25.000000000","message":"I think that this file should be in place during the config stage, so it is written and can be run before dispersion populate/report.","commit_id":"bebc595a7d67d91d88642c04d0a7945c2e11e6d6"}],"manifests/proxy.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b4ab92a4677fe2d33c32798361682bb448be345f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    # this is to ensure the user gets reasonable elements if he"},{"line_number":205,"context_line":"    # does not specify the backends for every specified element of"},{"line_number":206,"context_line":"    # the pipeline"},{"line_number":207,"context_line":"    before  \u003d\u003e Class[$required_classes],"},{"line_number":208,"context_line":"  }"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"  Concat[\u0027/etc/swift/proxy-server.conf\u0027] -\u003e Swift_proxy_config \u003c||\u003e"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_24c66348","line":207,"range":{"start_line":207,"start_character":21,"end_line":207,"end_character":38},"updated":"2016-05-19 15:56:12.000000000","message":"we will have dependency cycle, if we will use swift3 class here.\n\n (Anchor[swift::config::begin]\n\u003d\u003e Concat[/etc/swift/proxy-server.conf]\n \u003d\u003e File[/var/lib/puppet/concat/_etc_swift_proxy-server.conf/fragments]\n  \u003d\u003e File[/var/lib/puppet/concat/_etc_swift_proxy-server.conf/fragments/00_swift_proxy]\n   \u003d\u003e Concat::Fragment[swift_proxy]\n    \u003d\u003e Class[Swift::Proxy::Swift3]\n     \u003d\u003e Package[swift-plugin-s3]\n      \u003d\u003e Anchor[swift::install::end]\n       \u003d\u003e Anchor[swift::config::begin])\n\nthat\u0027s one of the reason, why fuel ci failed.","commit_id":"bebc595a7d67d91d88642c04d0a7945c2e11e6d6"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"f4cdd65f626e0599b8517c28b16eefce17d6a1ac","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    # this is to ensure the user gets reasonable elements if he"},{"line_number":205,"context_line":"    # does not specify the backends for every specified element of"},{"line_number":206,"context_line":"    # the pipeline"},{"line_number":207,"context_line":"    before  \u003d\u003e Class[$required_classes],"},{"line_number":208,"context_line":"  }"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"  Concat[\u0027/etc/swift/proxy-server.conf\u0027] -\u003e Swift_proxy_config \u003c||\u003e"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_c0d00e22","line":207,"range":{"start_line":207,"start_character":21,"end_line":207,"end_character":38},"in_reply_to":"bab6814e_24c66348","updated":"2016-05-19 22:37:25.000000000","message":"removing the require/before above on the concat itself was the way to go.  I am investigating adding a tag for the concat resources.  Though this might not be necessary because they are applied before their respective \u003c||\u003e configs.  Collecting those in deps should manage that order.","commit_id":"bebc595a7d67d91d88642c04d0a7945c2e11e6d6"}],"spec/classes/swift_proxy_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"34e322e038e55baf87960aa49d34b763d7c652a6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"         :tag        \u003d\u003e \u0027swift-service\u0027,"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":"      )}"},{"line_number":52,"context_line":"      it { is_expected.to contain_file(\u0027/etc/swift/proxy-server.conf\u0027).with("},{"line_number":53,"context_line":"        {:ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":54,"context_line":"         :owner   \u003d\u003e \u0027swift\u0027,"},{"line_number":55,"context_line":"         :group   \u003d\u003e \u0027swift\u0027,"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"bab6814e_e459065d","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":38},"updated":"2016-05-25 11:00:00.000000000","message":"looks like should be concat","commit_id":"a98748f4f78c6b0e70a7762843c0d61ebbababa8"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6519706f82124ab3d5c20b15d627344c1bdc9f09","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        {:ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":54,"context_line":"         :owner   \u003d\u003e \u0027swift\u0027,"},{"line_number":55,"context_line":"         :group   \u003d\u003e \u0027swift\u0027,"},{"line_number":56,"context_line":"         :tag     \u003d\u003e \u0027swift-file\u0027,"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"      )}"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"bab6814e_cb916a9c","line":56,"updated":"2016-05-25 12:50:49.000000000","message":"you need to drop this tag :)","commit_id":"757a0b7bd095ce780732f11bab2ea8a1cc3e69d8"}]}