)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"8c1fcde685660b70ddbf6f30e78925e97c7403bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove deprecated swift_hash_suffix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"swift_hash_suffix was deprecated in Mitaka and"},{"line_number":10,"context_line":"should be removed in Newton."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3b5c55607bcd8a2aa5288cdfefa96a152d1682cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_4f402e08","line":10,"updated":"2016-06-02 16:00:00.000000000","message":"could you please add link you the docs?","commit_id":"e49f3e07e11798757b0d6c3aa368ec506550e8bf"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e78d653f81374a26f2c21b56340a9b926acadf78","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove deprecated swift_hash_suffix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"swift_hash_suffix was deprecated in Mitaka and"},{"line_number":10,"context_line":"should be removed in Newton."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3b5c55607bcd8a2aa5288cdfefa96a152d1682cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_cb7b7128","line":10,"in_reply_to":"9abb7d3a_4f402e08","updated":"2016-06-02 16:12:37.000000000","message":"https://github.com/openstack/puppet-swift/commit/c41983cd87f9f6cea61e19945985962529dc5aac\n\nhttp://docs.openstack.org/icehouse/config-reference/content/swift-general-service-configuration.html\n\nshould i update with those links?","commit_id":"e49f3e07e11798757b0d6c3aa368ec506550e8bf"}],"manifests/init.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4dbf6ed404e33cd1c598a3f55eeec817b88b589a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# Copyright 2011 Puppetlabs Inc, unless otherwise noted."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"class swift("},{"line_number":54,"context_line":"  $swift_hash_path_suffix \u003d undef,"},{"line_number":55,"context_line":"  $swift_hash_path_prefix \u003d undef,"},{"line_number":56,"context_line":"  $package_ensure         \u003d \u0027present\u0027,"},{"line_number":57,"context_line":"  $client_package_ensure  \u003d \u0027present\u0027,"},{"line_number":58,"context_line":"  $max_header_size        \u003d \u00278192\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_848fc173","line":55,"range":{"start_line":54,"start_character":2,"end_line":55,"end_character":34},"updated":"2016-06-02 04:39:01.000000000","message":"@Vinsh,\nthe docs says that both are required but here is undef, should i change to required?","commit_id":"c1bf4c85f4fe90b5c836cd88929b852164cfc36f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2268000c020d43c6acd2c81ef89ce0f9486cd9b6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# Copyright 2011 Puppetlabs Inc, unless otherwise noted."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"class swift("},{"line_number":54,"context_line":"  $swift_hash_path_suffix \u003d undef,"},{"line_number":55,"context_line":"  $swift_hash_path_prefix \u003d undef,"},{"line_number":56,"context_line":"  $package_ensure         \u003d \u0027present\u0027,"},{"line_number":57,"context_line":"  $client_package_ensure  \u003d \u0027present\u0027,"},{"line_number":58,"context_line":"  $max_header_size        \u003d \u00278192\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_9b4a6e54","line":55,"range":{"start_line":54,"start_character":2,"end_line":55,"end_character":34},"in_reply_to":"9abb7d3a_188164fc","updated":"2016-06-02 10:12:39.000000000","message":"https://github.com/openstack/swift/blob/master/swift/common/utils.py#L129-L146","commit_id":"c1bf4c85f4fe90b5c836cd88929b852164cfc36f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f52d1d400380debf844c24a3173b84fe402d64a4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# Copyright 2011 Puppetlabs Inc, unless otherwise noted."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"class swift("},{"line_number":54,"context_line":"  $swift_hash_path_suffix \u003d undef,"},{"line_number":55,"context_line":"  $swift_hash_path_prefix \u003d undef,"},{"line_number":56,"context_line":"  $package_ensure         \u003d \u0027present\u0027,"},{"line_number":57,"context_line":"  $client_package_ensure  \u003d \u0027present\u0027,"},{"line_number":58,"context_line":"  $max_header_size        \u003d \u00278192\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_87c96c5d","line":55,"range":{"start_line":54,"start_character":2,"end_line":55,"end_character":34},"in_reply_to":"9abb7d3a_7be34a34","updated":"2016-06-02 13:07:30.000000000","message":"I\u0027ll update to raise fail when both are undef \u003d)","commit_id":"c1bf4c85f4fe90b5c836cd88929b852164cfc36f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8c89018c011acd47c47e72223aab72e39772ae12","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# Copyright 2011 Puppetlabs Inc, unless otherwise noted."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"class swift("},{"line_number":54,"context_line":"  $swift_hash_path_suffix \u003d undef,"},{"line_number":55,"context_line":"  $swift_hash_path_prefix \u003d undef,"},{"line_number":56,"context_line":"  $package_ensure         \u003d \u0027present\u0027,"},{"line_number":57,"context_line":"  $client_package_ensure  \u003d \u0027present\u0027,"},{"line_number":58,"context_line":"  $max_header_size        \u003d \u00278192\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_188164fc","line":55,"range":{"start_line":54,"start_character":2,"end_line":55,"end_character":34},"in_reply_to":"9abb7d3a_848fc173","updated":"2016-06-02 10:04:14.000000000","message":"Yep, they were undef for backward compatibility, not set it as required.","commit_id":"c1bf4c85f4fe90b5c836cd88929b852164cfc36f"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"51976664f02d993ec00747d33b571f31555cf434","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# Copyright 2011 Puppetlabs Inc, unless otherwise noted."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"class swift("},{"line_number":54,"context_line":"  $swift_hash_path_suffix \u003d undef,"},{"line_number":55,"context_line":"  $swift_hash_path_prefix \u003d undef,"},{"line_number":56,"context_line":"  $package_ensure         \u003d \u0027present\u0027,"},{"line_number":57,"context_line":"  $client_package_ensure  \u003d \u0027present\u0027,"},{"line_number":58,"context_line":"  $max_header_size        \u003d \u00278192\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_5e346249","line":55,"range":{"start_line":54,"start_character":2,"end_line":55,"end_character":34},"in_reply_to":"9abb7d3a_87c96c5d","updated":"2016-06-02 15:17:16.000000000","message":"+1","commit_id":"c1bf4c85f4fe90b5c836cd88929b852164cfc36f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d6923d908009b7c508cdb147d3ebc5c8419090b1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# Copyright 2011 Puppetlabs Inc, unless otherwise noted."},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"class swift("},{"line_number":54,"context_line":"  $swift_hash_path_suffix \u003d undef,"},{"line_number":55,"context_line":"  $swift_hash_path_prefix \u003d undef,"},{"line_number":56,"context_line":"  $package_ensure         \u003d \u0027present\u0027,"},{"line_number":57,"context_line":"  $client_package_ensure  \u003d \u0027present\u0027,"},{"line_number":58,"context_line":"  $max_header_size        \u003d \u00278192\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_7be34a34","line":55,"range":{"start_line":54,"start_character":2,"end_line":55,"end_character":34},"in_reply_to":"9abb7d3a_9b4a6e54","updated":"2016-06-02 10:15:29.000000000","message":"So, looks like we should raise fail when both parameters are not set.","commit_id":"c1bf4c85f4fe90b5c836cd88929b852164cfc36f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8c89018c011acd47c47e72223aab72e39772ae12","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  include ::swift::deps"},{"line_number":62,"context_line":"  include ::swift::params"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if ($swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":65,"context_line":"    fail(\u0027You must specify swift_hash_path_suffix\u0027)"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  if !defined(Package[\u0027swift\u0027]) {"},{"line_number":69,"context_line":"    package { \u0027swift\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_d88d1c2c","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":3},"updated":"2016-06-02 10:04:14.000000000","message":"remove this, it useless now.","commit_id":"c1bf4c85f4fe90b5c836cd88929b852164cfc36f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f52d1d400380debf844c24a3173b84fe402d64a4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  include ::swift::deps"},{"line_number":62,"context_line":"  include ::swift::params"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if ($swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":65,"context_line":"    fail(\u0027You must specify swift_hash_path_suffix\u0027)"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  if !defined(Package[\u0027swift\u0027]) {"},{"line_number":69,"context_line":"    package { \u0027swift\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_a7547021","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":3},"in_reply_to":"9abb7d3a_d88d1c2c","updated":"2016-06-02 13:07:30.000000000","message":"I\u0027ll only edit to add swift_hash_path_prefix","commit_id":"c1bf4c85f4fe90b5c836cd88929b852164cfc36f"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"8c1fcde685660b70ddbf6f30e78925e97c7403bf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#   services. Recommended size is 32768 for PKI keystone tokens."},{"line_number":37,"context_line":"#   Defaults to 8192"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"## DEPRECATED PARAMETERS"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# \u003d\u003d Dependencies"},{"line_number":42,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_cf8ffe73","line":39,"updated":"2016-06-02 16:00:00.000000000","message":"this line probably could be removed as well","commit_id":"e49f3e07e11798757b0d6c3aa368ec506550e8bf"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e78d653f81374a26f2c21b56340a9b926acadf78","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#   services. Recommended size is 32768 for PKI keystone tokens."},{"line_number":37,"context_line":"#   Defaults to 8192"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"## DEPRECATED PARAMETERS"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# \u003d\u003d Dependencies"},{"line_number":42,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_4b8e6128","line":39,"in_reply_to":"9abb7d3a_cf8ffe73","updated":"2016-06-02 16:12:37.000000000","message":"Done","commit_id":"e49f3e07e11798757b0d6c3aa368ec506550e8bf"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"8c1fcde685660b70ddbf6f30e78925e97c7403bf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  include ::swift::deps"},{"line_number":62,"context_line":"  include ::swift::params"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if ($swift_hash_path_prefix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":65,"context_line":"    fail(\u0027You must specify swift_hash_path_prefix and  swift_hash_path_suffix\u0027)"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_6f9ff250","line":64,"updated":"2016-06-02 16:00:00.000000000","message":"if both params are required, we should use \u0027or\u0027 instead of \u0027and\u0027","commit_id":"e49f3e07e11798757b0d6c3aa368ec506550e8bf"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5fa5c1adce0a30a01d2bbcb2708960b3fefdd935","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  include ::swift::deps"},{"line_number":62,"context_line":"  include ::swift::params"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if ($swift_hash_path_prefix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":65,"context_line":"    fail(\u0027You must specify swift_hash_path_prefix and  swift_hash_path_suffix\u0027)"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_4aa3f24f","line":64,"in_reply_to":"9abb7d3a_2ae82e16","updated":"2016-06-02 19:18:28.000000000","message":"Oh ok Denis \u003d)","commit_id":"e49f3e07e11798757b0d6c3aa368ec506550e8bf"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e78d653f81374a26f2c21b56340a9b926acadf78","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  include ::swift::deps"},{"line_number":62,"context_line":"  include ::swift::params"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if ($swift_hash_path_prefix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":65,"context_line":"    fail(\u0027You must specify swift_hash_path_prefix and  swift_hash_path_suffix\u0027)"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_8be689e6","line":64,"in_reply_to":"9abb7d3a_6f9ff250","updated":"2016-06-02 16:12:37.000000000","message":"yeah, sorry","commit_id":"e49f3e07e11798757b0d6c3aa368ec506550e8bf"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2412e6c3946a1807cbd6ce9e622adff2684f6277","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  include ::swift::deps"},{"line_number":62,"context_line":"  include ::swift::params"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if ($swift_hash_path_prefix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":65,"context_line":"    fail(\u0027You must specify swift_hash_path_prefix and  swift_hash_path_suffix\u0027)"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_2ae82e16","line":64,"in_reply_to":"9abb7d3a_8be689e6","updated":"2016-06-02 19:08:46.000000000","message":"Nope nope nope. It should fail ONLY if BOTH params are not set. So this if is ok.","commit_id":"e49f3e07e11798757b0d6c3aa368ec506550e8bf"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4c4c402a12ddcbe75149f720171b6d6e15f8768a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  include ::swift::params"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  if ($swift_hash_path_prefix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":63,"context_line":"    fail(\u0027You must specify swift_hash_path_prefix and  swift_hash_path_suffix\u0027)"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  if !defined(Package[\u0027swift\u0027]) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9abb7d3a_1f88e621","line":63,"range":{"start_line":63,"start_character":50,"end_line":63,"end_character":53},"updated":"2016-06-03 09:52:59.000000000","message":"You must specify at least swift_hash_path_prefix or  swift_hash_path_suffix","commit_id":"732c5025cdb58e704a92aa43f55324db22b9d6ef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b106ed4bb3b97adceaea63540a446683452eee0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  include ::swift::params"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  if ($swift_hash_path_prefix \u003d\u003d undef and $swift_hash_path_suffix \u003d\u003d undef) {"},{"line_number":63,"context_line":"    fail(\u0027You must specify swift_hash_path_prefix and  swift_hash_path_suffix\u0027)"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  if !defined(Package[\u0027swift\u0027]) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9abb7d3a_13abba1f","line":63,"range":{"start_line":63,"start_character":50,"end_line":63,"end_character":53},"in_reply_to":"9abb7d3a_1f88e621","updated":"2016-06-03 12:55:42.000000000","message":"Done","commit_id":"732c5025cdb58e704a92aa43f55324db22b9d6ef"}]}