)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a98faede05a27bc99e355ace34d1a6765d7c8982","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    service_name        \u003d\u003e $service_name_s3,"},{"line_number":314,"context_line":"    service_type        \u003d\u003e \u0027s3\u0027,"},{"line_number":315,"context_line":"    service_description \u003d\u003e $service"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"_description_s3,"},{"line_number":318,"context_line":"    region              \u003d\u003e $region,"},{"line_number":319,"context_line":"    public_url          \u003d\u003e $public_url_s3_real,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_64b915cc","line":316,"updated":"2016-06-08 17:20:04.000000000","message":"fix this unneeded line :)","commit_id":"c13060451228a54e43208f817f59817d3c56bfa3"},{"author":{"_account_id":18324,"name":"Venkata Mahesh Jonnalagadda","email":"Venkata.Jonnalagadda@intl.att.com","username":"vj884x"},"change_message_id":"c6410db8a15ea57af901d6e51da0f91301d977d6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"# [*service_name_s3*]"},{"line_number":55,"context_line":"#   (optional) Name of the s3 service."},{"line_number":56,"context_line":"#   Defaults to \u0027swift_s3"},{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# [*service_description*]"},{"line_number":59,"context_line":"#   (optional) Description for keystone service."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_18c70699","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":25},"updated":"2016-06-13 19:24:36.000000000","message":"properly end with single quote (\u0027)","commit_id":"5329b923d5d0314c7f3a4c01d815376c01cf9fc5"},{"author":{"_account_id":18324,"name":"Venkata Mahesh Jonnalagadda","email":"Venkata.Jonnalagadda@intl.att.com","username":"vj884x"},"change_message_id":"c6410db8a15ea57af901d6e51da0f91301d977d6","unresolved":false,"context_lines":[{"line_number":276,"context_line":"  }"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"  if $service_name \u003d\u003d $service_name_s3 {"},{"line_number":279,"context_line":"      fail(\u0027cinder::keystone::auth parameters service_name and service_name_s3 must be different.\u0027)"},{"line_number":280,"context_line":"  }"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"  # Establish that keystone auth and endpoints are properly setup before"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_584cee41","line":279,"range":{"start_line":279,"start_character":12,"end_line":279,"end_character":18},"updated":"2016-06-13 19:24:36.000000000","message":"replace with \"swift\"","commit_id":"5329b923d5d0314c7f3a4c01d815376c01cf9fc5"},{"author":{"_account_id":18324,"name":"Venkata Mahesh Jonnalagadda","email":"Venkata.Jonnalagadda@intl.att.com","username":"vj884x"},"change_message_id":"47b950c89bcccf681666beb1f958f4af404e096e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"  }"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"  if $service_name \u003d\u003d $service_name_s3 {"},{"line_number":279,"context_line":"      fail(\u0027cinder::keystone::auth parameters service_name and service_name_s3 must be different.\u0027)"},{"line_number":280,"context_line":"  }"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"  # Establish that keystone auth and endpoints are properly setup before"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_33494332","line":279,"range":{"start_line":279,"start_character":12,"end_line":279,"end_character":18},"updated":"2016-06-13 19:43:53.000000000","message":"change to swift","commit_id":"20c03d4a26767f7d4b7f0ec23b67f7a0f284a399"}],"spec/classes/swift_keystone_auth_spec.rb":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1c156835d61df97c0a8f5b42dfc02ef84fe7d358","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        it { is_expected.to contain_keystone_role(role_name).with_ensure(\u0027present\u0027) }"},{"line_number":60,"context_line":"      end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"      it { is_expected.to contain_keystone_endpoint(\"#{params[:region]}/#{params[:service_name]}::object-store\").with("},{"line_number":63,"context_line":"        :ensure       \u003d\u003e \u0027present\u0027,"},{"line_number":64,"context_line":"        :public_url   \u003d\u003e params[:public_url],"},{"line_number":65,"context_line":"        :admin_url    \u003d\u003e params[:admin_url],"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7aa08908_4570370b","line":62,"range":{"start_line":62,"start_character":74,"end_line":62,"end_character":80},"updated":"2016-06-09 08:09:51.000000000","message":"you want to use default_params and not params here","commit_id":"16f3fa4776ae7d534d42b7dfd349ed9ad0b9ebb4"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1c156835d61df97c0a8f5b42dfc02ef84fe7d358","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        :internal_url \u003d\u003e params[:internal_url],"},{"line_number":67,"context_line":"      )}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"      it { is_expected.to contain_keystone_endpoint(\"#{params[:region]}/#{params[:service_name_s3]}::s3\").with("},{"line_number":70,"context_line":"        :ensure       \u003d\u003e \u0027present\u0027,"},{"line_number":71,"context_line":"        :public_url   \u003d\u003e params[:public_url_s3],"},{"line_number":72,"context_line":"        :admin_url    \u003d\u003e params[:admin_url_s3],"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7aa08908_05590f8e","line":69,"range":{"start_line":69,"start_character":74,"end_line":69,"end_character":80},"updated":"2016-06-09 08:09:51.000000000","message":"same as above","commit_id":"16f3fa4776ae7d534d42b7dfd349ed9ad0b9ebb4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"85aee972f8701841d94eb90d5c02729ef5e27a9a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    before do"},{"line_number":218,"context_line":"      params.merge!({"},{"line_number":219,"context_line":"        :service_name    \u003d\u003e \u0027swift_service\u0027,"},{"line_number":220,"context_line":"        :service_name_s3 \u003d\u003e \u0027swift_service_s3\u0027,"},{"line_number":221,"context_line":"      })"},{"line_number":222,"context_line":"    end"},{"line_number":223,"context_line":"    it \u0027configures correct user name\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7aa08908_d57beef2","side":"PARENT","line":220,"updated":"2016-06-10 10:40:13.000000000","message":"please use overridden values","commit_id":"fbc530a9d3912ccaaa00df463237d1339e88be52"},{"author":{"_account_id":18324,"name":"Venkata Mahesh Jonnalagadda","email":"Venkata.Jonnalagadda@intl.att.com","username":"vj884x"},"change_message_id":"c6410db8a15ea57af901d6e51da0f91301d977d6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        :internal_url \u003d\u003e params[:internal_url],"},{"line_number":67,"context_line":"      )}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  it { is_expected.to contain_keystone_endpoint(\"#{params[:region]}/#{default_params[:service_name_s3]}::s3\").with("},{"line_number":70,"context_line":"        :ensure       \u003d\u003e \u0027present\u0027,"},{"line_number":71,"context_line":"        :public_url   \u003d\u003e params[:public_url_s3],"},{"line_number":72,"context_line":"        :admin_url    \u003d\u003e params[:admin_url_s3],"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"7aa08908_f8b5daec","line":69,"range":{"start_line":69,"start_character":1,"end_line":69,"end_character":4},"updated":"2016-06-13 19:24:36.000000000","message":"indent properly with above \"it\" block","commit_id":"5329b923d5d0314c7f3a4c01d815376c01cf9fc5"},{"author":{"_account_id":18324,"name":"Venkata Mahesh Jonnalagadda","email":"Venkata.Jonnalagadda@intl.att.com","username":"vj884x"},"change_message_id":"c6410db8a15ea57af901d6e51da0f91301d977d6","unresolved":false,"context_lines":[{"line_number":226,"context_line":"      is_expected.to contain_keystone_user_role(\u0027swift@services\u0027)"},{"line_number":227,"context_line":"    end"},{"line_number":228,"context_line":"    it \u0027configures correct service name\u0027 do"},{"line_number":229,"context_line":"      is_expected.to contain_keystone_service(\u0027swift_service::object-store\u0027)"},{"line_number":230,"context_line":"      is_expected.to contain_keystone_service(\u0027swift_service_s3::s3\u0027)"},{"line_number":231,"context_line":"    end"},{"line_number":232,"context_line":"    it \u0027configures correct endpoint name\u0027 do"},{"line_number":233,"context_line":"      is_expected.to contain_keystone_endpoint(\u0027RegionOne/swift_service::object-store\u0027)"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"7aa08908_38e5a208","line":230,"range":{"start_line":229,"start_character":6,"end_line":230,"end_character":69},"updated":"2016-06-13 19:24:36.000000000","message":"this tests will fail due to unavailability of override parameters","commit_id":"5329b923d5d0314c7f3a4c01d815376c01cf9fc5"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"7c3e5592b06b0e6735ba1c107cf7d322c3e4b60b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    context \u0027when user configuration is set to default\u0027 do"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"      it { is_expected.to contain_keystone_user(p[:auth_name]).with("},{"line_number":145,"context_line":"        :ensure          \u003d\u003e \u0027present\u0027,"},{"line_number":146,"context_line":"        :password        \u003d\u003e p[:password],"},{"line_number":147,"context_line":"        :email           \u003d\u003e p[:email],"},{"line_number":148,"context_line":"      )}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"      it { is_expected.to contain_keystone_user_role(\"#{p[:auth_name]}@#{p[:tenant]}\").with("}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7aa08908_0a3dd3c3","line":147,"range":{"start_line":145,"start_character":0,"end_line":147,"end_character":38},"updated":"2016-06-14 08:39:03.000000000","message":"the alignment is incorrect here, the previous one was correct","commit_id":"bd929ad737d8064e04b5f1a4abf8fd2b1137c947"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"7c3e5592b06b0e6735ba1c107cf7d322c3e4b60b","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    context \u0027when user configuration is disabled\u0027 do"},{"line_number":169,"context_line":"      before do"},{"line_number":170,"context_line":"        params.merge!( :configure_user  \u003d\u003e false )"},{"line_number":171,"context_line":"      end"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"      it { is_expected.to_not contain_keystone_user(p[:auth_name]) }"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7aa08908_aa58ff31","line":170,"updated":"2016-06-14 08:39:03.000000000","message":"why an space was added here?","commit_id":"bd929ad737d8064e04b5f1a4abf8fd2b1137c947"}]}