)]}'
{"manifests/proxy/keystone.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"df46e63ce94cc973300235982f63ba0b0f2f2626","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class swift::proxy::keystone("},{"line_number":27,"context_line":"  $operator_roles      \u003d [\u0027admin\u0027, \u0027SwiftOperator\u0027],"},{"line_number":28,"context_line":"  $is_admin            \u003d true,"},{"line_number":29,"context_line":"  $reseller_prefix     \u003d \u0027AUTH_\u0027"},{"line_number":30,"context_line":") {"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_e34c04ca","side":"PARENT","line":28,"updated":"2016-07-20 20:26:50.000000000","message":"please deprecate correctly.\n\nhttp://docs.openstack.org/developer/puppet-openstack-guide/coding-style.html#deprecation\n\nExample: https://review.openstack.org/#/c/340631/\n\nYou\u0027re welcome to look at how we deprecate parameters in other modules or ask us on IRC #puppet-openstack (freenode).\n\nThanks","commit_id":"e8959ee6317ca6af10910f6e4af48419b9ccb528"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"38ffc3ffa1a00fea187315e8775433f9f567c36b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"class swift::proxy::keystone("},{"line_number":26,"context_line":"  $operator_roles      \u003d [\u0027admin\u0027, \u0027SwiftOperator\u0027],"},{"line_number":27,"context_line":"  $is_admin            \u003d false,"},{"line_number":28,"context_line":"  $reseller_prefix     \u003d \u0027AUTH_\u0027"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_de11bc05","line":27,"range":{"start_line":27,"start_character":30,"end_line":27,"end_character":31},"updated":"2016-07-21 10:29:04.000000000","message":"undef\n\nalso move it under last parameter:\n\n $reseller_prefix     \u003d \u0027AUTH_\u0027\n # DEPRECATED PARAMETERS\n $is_admin            \u003d undef","commit_id":"a77f341e23ee349f92f5146afbc3ae5d4efcebb4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"38ffc3ffa1a00fea187315e8775433f9f567c36b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  $is_admin            \u003d false,"},{"line_number":28,"context_line":"  $reseller_prefix     \u003d \u0027AUTH_\u0027"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::swift::deps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  concat::fragment { \u0027swift_keystone\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_1e1fd408","line":30,"updated":"2016-07-21 10:29:04.000000000","message":"if $is_admin !\u003d undef {\n  warning(\u0027Parameter is_admin is remove and does not have any effect ....\u0027)\n}","commit_id":"a77f341e23ee349f92f5146afbc3ae5d4efcebb4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4a8711cb061bcac77094245281c2b4ba9b710c10","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    Must be an array of strings"},{"line_number":10,"context_line":"#    Swift operator roles must be defined in swift::keystone::auth because"},{"line_number":11,"context_line":"#    keystone API access is usually not available on Swift proxy nodes."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"#  [*is_admin*]"},{"line_number":14,"context_line":"#   Deprecated, this parameter does nothing."},{"line_number":15,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_872247a1","line":12,"updated":"2016-07-21 14:43:20.000000000","message":"add # DEPRECATED PARAMETERS here, it helps to track our deprecated parameters, like we do in other modules.","commit_id":"de74d8b7d861d2337f1327435ccfa318fb6c382d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4a8711cb061bcac77094245281c2b4ba9b710c10","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::swift::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $is_admin !\u003d undef {"},{"line_number":35,"context_line":"        warning(\u0027Parameter is_admin is removed and does not have any effect.\u0027)"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_e73d03c5","line":34,"updated":"2016-07-21 14:43:20.000000000","message":"if $is_admin {} is enough. In a conditionnal, it\u0027s a boolean.","commit_id":"de74d8b7d861d2337f1327435ccfa318fb6c382d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4a8711cb061bcac77094245281c2b4ba9b710c10","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  include ::swift::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $is_admin !\u003d undef {"},{"line_number":35,"context_line":"        warning(\u0027Parameter is_admin is removed and does not have any effect.\u0027)"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  concat::fragment { \u0027swift_keystone\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_c738bfd5","line":35,"updated":"2016-07-21 14:43:20.000000000","message":"is_admin parameter is deprecated, has no effect and will be removed in a future release.","commit_id":"de74d8b7d861d2337f1327435ccfa318fb6c382d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4a8711cb061bcac77094245281c2b4ba9b710c10","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $is_admin !\u003d undef {"},{"line_number":35,"context_line":"        warning(\u0027Parameter is_admin is removed and does not have any effect.\u0027)"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  concat::fragment { \u0027swift_keystone\u0027:"},{"line_number":39,"context_line":"    target  \u003d\u003e \u0027/etc/swift/proxy-server.conf\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_27343bdc","line":36,"updated":"2016-07-21 14:43:20.000000000","message":"please also add a release note about this deprecation.","commit_id":"de74d8b7d861d2337f1327435ccfa318fb6c382d"}],"spec/classes/swift_proxy_keystone_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"38ffc3ffa1a00fea187315e8775433f9f567c36b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  describe \u0027with defaults\u0027 do"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    it { is_expected.to contain_concat_fragment(\u0027swift_keystone\u0027).with_content(/operator_roles \u003d admin, SwiftOperator/) }"},{"line_number":18,"context_line":"    it { is_expected.to_not contain_concat_fragment(\u0027swift_keystone\u0027).with_content(/is_admin/) }"},{"line_number":19,"context_line":"    it { is_expected.to contain_concat_fragment(\u0027swift_keystone\u0027).with_content(/reseller_prefix \u003d AUTH_/) }"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"dada55a8_be0848db","line":18,"updated":"2016-07-21 10:29:04.000000000","message":"you can simply remove test, as this parameter removed from template","commit_id":"a77f341e23ee349f92f5146afbc3ae5d4efcebb4"}]}