)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"6c25b17b81bdd7fca2282bc9bfab06fbf62b30db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marcus Furlong \u003cfurlongm@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-27 17:55:49 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"memcache_servers support in object-expirer and container-reconciler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie139f018c4a742b014dd4d682970e154d66a8c6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a98d1f4_bbc0ca7d","line":7,"updated":"2016-09-30 10:17:12.000000000","message":"please add more detailed commit message","commit_id":"a0ed96e0eb5c106acd818290e980adbce9b4a627"}],"manifests/containerreconciler.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4bb3f564aee07ce4022b130b0b55dd9d6c871a77","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  Swift_container_reconciler_config\u003c||\u003e ~\u003e Service[\u0027swift-container-reconciler\u0027]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  # require the memcached class if it is on the same machine"},{"line_number":67,"context_line":"  if grep(any2array($memcache_servers), \u0027^127\\.0\\.0\\.1\u0027) {"},{"line_number":68,"context_line":"    Class[\u0027memcached\u0027] -\u003e Class[\u0027swift::containerreconciler\u0027]"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a98d1f4_65711876","line":67,"updated":"2016-09-30 22:25:37.000000000","message":"This is a bad grep line, should be !empty(grep(any2array($memcache_servers), \u0027127.0.0.1\u0027)). Also this should be properly tested in the spec tests.  We found the issue with this statement recently and the fix shows how to test it properly. https://review.openstack.org/#/c/379796/","commit_id":"a0ed96e0eb5c106acd818290e980adbce9b4a627"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"100f769a39f47999b0915f8578e25ab96ad6e1a6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  $request_tries                 \u003d 3,"},{"line_number":57,"context_line":"  $service_provider              \u003d $::swift::params::service_provider,"},{"line_number":58,"context_line":"  $memcache_servers              \u003d [\u0027127.0.0.1:11211\u0027],"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":") inherits ::swift::params {"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6895a0_ffd96e84","line":59,"updated":"2016-10-25 14:59:14.000000000","message":"nit: we don\u0027t need this blank line and the excessive space between the vars and \u003d. should remove some of that","commit_id":"bf6cf80563806bc46967e634ae0453c9331dd0ea"}],"manifests/objectexpirer.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4bb3f564aee07ce4022b130b0b55dd9d6c871a77","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  # require the memcached class if it is on the same machine"},{"line_number":106,"context_line":"  if grep(any2array($memcache_servers), \u0027^127\\.0\\.0\\.1\u0027) {"},{"line_number":107,"context_line":"    Class[\u0027memcached\u0027] -\u003e Class[\u0027swift::objectexpirer\u0027]"},{"line_number":108,"context_line":"  }"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a98d1f4_856aa47f","line":106,"updated":"2016-09-30 22:25:37.000000000","message":"this is a bad grep, it needs to be !empty(grep(any2array($memcache_servers), \u0027127.0.0.1\u0027))","commit_id":"a0ed96e0eb5c106acd818290e980adbce9b4a627"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1e8e28f23565d423236629d82178265c98d4c9f3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  $recon_cache_path              \u003d \u0027/var/cache/swift\u0027,"},{"line_number":86,"context_line":"  $report_interval               \u003d 300,"},{"line_number":87,"context_line":"  $service_provider              \u003d $::swift::params::service_provider,"},{"line_number":88,"context_line":"  $memcache_servers              \u003d [\u0027127.0.0.1:11211\u0027],"},{"line_number":89,"context_line":") inherits ::swift::params {"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a74a57a_ee6c750a","line":88,"updated":"2016-12-01 00:23:18.000000000","message":"maybe this shouldn\u0027t default to localhost by default as someone could include this without memcache then get a deployment failure because the memcache class is not defined.","commit_id":"9cebde0a91459b5493e64ff242285775f0a7bf34"}],"spec/classes/swift_containerreconciler_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"100f769a39f47999b0915f8578e25ab96ad6e1a6","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  end"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":52,"context_line":"    let :facts do"},{"line_number":53,"context_line":"      OSDefaults.get_facts({"},{"line_number":54,"context_line":"        :operatingsystem \u003d\u003e \u0027Ubuntu\u0027,"},{"line_number":55,"context_line":"        :osfamily        \u003d\u003e \u0027Debian\u0027,"},{"line_number":56,"context_line":"      })"},{"line_number":57,"context_line":"    end"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    let :platform_params do"},{"line_number":60,"context_line":"      { :service_name     \u003d\u003e \u0027swift-container-reconciler\u0027,"},{"line_number":61,"context_line":"        :service_provider \u003d\u003e nil }"},{"line_number":62,"context_line":"    end"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    it_configures \u0027swift-container-reconciler\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    context \u0027when overridding parameters\u0027 do"},{"line_number":67,"context_line":"      before do"},{"line_number":68,"context_line":"        params.merge!("},{"line_number":69,"context_line":"          :interval      \u003d\u003e \u0027600\u0027,"},{"line_number":70,"context_line":"          :reclaim_age   \u003d\u003e \u002710000\u0027,"},{"line_number":71,"context_line":"          :request_tries \u003d\u003e \u00273\u0027,"},{"line_number":72,"context_line":"        )"},{"line_number":73,"context_line":"      end"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      it_configures \u0027swift-container-reconciler\u0027"},{"line_number":76,"context_line":"    end"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    context \u0027on debian using swiftinit service provider\u0027 do"},{"line_number":79,"context_line":"      before do"},{"line_number":80,"context_line":"        params.merge!({ :service_provider \u003d\u003e \u0027swiftinit\u0027 })"},{"line_number":81,"context_line":"      end"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      before do"},{"line_number":84,"context_line":"        platform_params.merge!({ :service_provider \u003d\u003e \u0027swiftinit\u0027 })"},{"line_number":85,"context_line":"      end"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"      it_configures \u0027swift-container-reconciler\u0027"},{"line_number":88,"context_line":"    end"},{"line_number":89,"context_line":"  end"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":92,"context_line":"        let :facts do"},{"line_number":93,"context_line":"          OSDefaults.get_facts({"},{"line_number":94,"context_line":"            :osfamily        \u003d\u003e \u0027RedHat\u0027,"},{"line_number":95,"context_line":"            :operatingsystem \u003d\u003e \u0027RedHat\u0027,"},{"line_number":96,"context_line":"          })"},{"line_number":97,"context_line":"        end"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        let :platform_params do"},{"line_number":100,"context_line":"          { :service_name     \u003d\u003e \u0027openstack-swift-container-reconciler\u0027,"},{"line_number":101,"context_line":"            :service_provider \u003d\u003e nil }"},{"line_number":102,"context_line":"        end"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    it_configures \u0027swift-container-reconciler\u0027"},{"line_number":105,"context_line":"    context \u0027when overridding parameters\u0027 do"},{"line_number":106,"context_line":"      before do"},{"line_number":107,"context_line":"        params.merge!("},{"line_number":108,"context_line":"          :interval      \u003d\u003e \u0027600\u0027,"},{"line_number":109,"context_line":"          :reclaim_age   \u003d\u003e \u002710000\u0027,"},{"line_number":110,"context_line":"          :request_tries \u003d\u003e \u00273\u0027,"},{"line_number":111,"context_line":"        )"},{"line_number":112,"context_line":"      end"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"      it_configures \u0027swift-container-reconciler\u0027"},{"line_number":115,"context_line":"    end"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    context \u0027on redhat using swiftinit service provider\u0027 do"},{"line_number":118,"context_line":"      before do"},{"line_number":119,"context_line":"        params.merge!({ :service_provider \u003d\u003e \u0027swiftinit\u0027 })"},{"line_number":120,"context_line":"      end"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"      let :platform_params do"},{"line_number":123,"context_line":"        { :service_name     \u003d\u003e \u0027swift-container-reconciler\u0027,"},{"line_number":124,"context_line":"          :service_provider \u003d\u003e \u0027swiftinit\u0027 }"},{"line_number":125,"context_line":"      end"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"      it_configures \u0027swift-container-reconciler\u0027"},{"line_number":128,"context_line":"    end"},{"line_number":129,"context_line":"  end"},{"line_number":130,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"da6895a0_dfd2eaff","line":129,"range":{"start_line":51,"start_character":2,"end_line":129,"end_character":5},"updated":"2016-10-25 14:59:14.000000000","message":"Should use on_support_os instead of duplicating this. We\u0027re trying to use that pattern going forward so for new tests it should use rspec-puppet-facts.  An example would be https://review.openstack.org/#/c/390382/2/spec/classes/vitrage_db_mysql_spec.rb","commit_id":"bf6cf80563806bc46967e634ae0453c9331dd0ea"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f9c6ca1b9308be63ff65b8853d11e758ca6271a2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  shared_examples_for \u0027swift-container-reconciler\u0027 do"},{"line_number":25,"context_line":"    let (:p) { default_params.merge!(params) }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    it \u0027configures container-reconciler.conf\u0027 do"},{"line_number":28,"context_line":"      is_expected.to contain_swift_container_reconciler_config("},{"line_number":29,"context_line":"        \u0027pipeline:main/pipeline\u0027).with_value(p[:pipeline].join(\u0027 \u0027))"},{"line_number":30,"context_line":"      is_expected.to contain_swift_container_reconciler_config("},{"line_number":31,"context_line":"        \u0027container-reconciler/interval\u0027).with_value(p[:interval])"},{"line_number":32,"context_line":"      is_expected.to contain_swift_container_reconciler_config("},{"line_number":33,"context_line":"        \u0027container-reconciler/reclaim_age\u0027).with_value(p[:reclaim_age])"},{"line_number":34,"context_line":"      is_expected.to contain_swift_container_reconciler_config("},{"line_number":35,"context_line":"        \u0027container-reconciler/request_tries\u0027).with_value(p[:request_tries])"},{"line_number":36,"context_line":"      is_expected.to contain_swift_container_reconciler_config("},{"line_number":37,"context_line":"        \u0027filter:cache/memcache_servers\u0027).with_value(p[:memcache_servers])"},{"line_number":38,"context_line":"    end"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    it \u0027configures container-reconciler service\u0027 do"},{"line_number":41,"context_line":"      is_expected.to contain_service(\u0027swift-container-reconciler\u0027).with("},{"line_number":42,"context_line":"        :ensure    \u003d\u003e (p[:manage_service] \u0026\u0026 p[:enabled]) ? \u0027running\u0027 : \u0027stopped\u0027,"},{"line_number":43,"context_line":"        :name      \u003d\u003e platform_params[:service_name],"},{"line_number":44,"context_line":"        :provider  \u003d\u003e platform_params[:service_provider],"},{"line_number":45,"context_line":"        :enable    \u003d\u003e p[:enabled]"},{"line_number":46,"context_line":"      )"},{"line_number":47,"context_line":"    end"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  end"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ba5da102_d08dd27c","line":47,"range":{"start_line":27,"start_character":0,"end_line":47,"end_character":7},"updated":"2016-10-26 16:54:30.000000000","message":"should just wrap this in a context \u0027with defaults\u0027 do ... end","commit_id":"67dbcc57432e7f8bc54944667e5272476d161f0c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f9c6ca1b9308be63ff65b8853d11e758ca6271a2","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    it_configures \u0027swift-container-reconciler\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    context \u0027when overridding parameters\u0027 do"},{"line_number":75,"context_line":"      before do"},{"line_number":76,"context_line":"        params.merge!("},{"line_number":77,"context_line":"          :interval      \u003d\u003e \u0027600\u0027,"},{"line_number":78,"context_line":"          :reclaim_age   \u003d\u003e \u002710000\u0027,"},{"line_number":79,"context_line":"          :request_tries \u003d\u003e \u00273\u0027,"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"      end"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      it_configures \u0027swift-container-reconciler\u0027"},{"line_number":84,"context_line":"    end"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    context \u0027using swiftinit service provider\u0027 do"},{"line_number":87,"context_line":"      before do"},{"line_number":88,"context_line":"        params.merge!({ :service_provider \u003d\u003e \u0027swiftinit\u0027 })"},{"line_number":89,"context_line":"      end"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"      before do"},{"line_number":92,"context_line":"        platform_params.merge!({ :service_provider \u003d\u003e \u0027swiftinit\u0027 })"},{"line_number":93,"context_line":"      end"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"      it_configures \u0027swift-container-reconciler\u0027"},{"line_number":96,"context_line":"    end"},{"line_number":97,"context_line":"  end"},{"line_number":98,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ba5da102_f0e81619","line":96,"range":{"start_line":74,"start_character":0,"end_line":96,"end_character":7},"updated":"2016-10-26 16:54:30.000000000","message":"move these into the shared_examples_for swift-container-reconciler ~L48","commit_id":"67dbcc57432e7f8bc54944667e5272476d161f0c"}]}
