)]}'
{"manifests/proxy.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"07bfe02cee094b208caa71b00df7ea1783b463aa","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    }"},{"line_number":226,"context_line":"  } else {"},{"line_number":227,"context_line":"    swift_proxy_config {"},{"line_number":228,"context_line":"      \u0027DEFAULT/cors_allow_origin\u0027: value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027;"},{"line_number":229,"context_line":"      \u0027DEFAULT/strict_cors_mode\u0027:  value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027;"},{"line_number":230,"context_line":"    }"},{"line_number":231,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a98d1f4_923868a2","line":228,"range":{"start_line":228,"start_character":44,"end_line":228,"end_character":63},"updated":"2016-09-29 22:24:13.000000000","message":"You can just use $::os_service_default for these, don\u0027t need to write this out.  For the tests you just need to make sure that the os_service_default fact is defined, which do if you use the OSDefaults.get_facts() which the test for this class already does","commit_id":"b4c146c24f684f1751905242c3830ed5a089569e"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"0ea7a7125dc5b262d6d31cc89de7216619154fa9","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    }"},{"line_number":226,"context_line":"  } else {"},{"line_number":227,"context_line":"    swift_proxy_config {"},{"line_number":228,"context_line":"      \u0027DEFAULT/cors_allow_origin\u0027: value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027;"},{"line_number":229,"context_line":"      \u0027DEFAULT/strict_cors_mode\u0027:  value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027;"},{"line_number":230,"context_line":"    }"},{"line_number":231,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a98d1f4_52c6e048","line":228,"range":{"start_line":228,"start_character":44,"end_line":228,"end_character":63},"in_reply_to":"3a98d1f4_923868a2","updated":"2016-09-29 22:28:03.000000000","message":"Done","commit_id":"b4c146c24f684f1751905242c3830ed5a089569e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5f5e7ddcbd1832b98ac31c0b4a0006a1052a5ab3","unresolved":false,"context_lines":[{"line_number":193,"context_line":"  }"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"  swift_proxy_config {"},{"line_number":196,"context_line":"    \u0027DEFAULT/bind_port\u0027:                          value \u003d\u003e $port;"},{"line_number":197,"context_line":"    \u0027DEFAULT/bind_ip\u0027:                            value \u003d\u003e $proxy_local_net_ip;"},{"line_number":198,"context_line":"    \u0027DEFAULT/workers\u0027:                            value \u003d\u003e $workers;"},{"line_number":199,"context_line":"    \u0027DEFAULT/user\u0027:                               value \u003d\u003e \u0027swift\u0027;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_87457718","line":196,"updated":"2016-09-30 09:38:00.000000000","message":"i also don\u0027t see statsd parameters here\n\nhttps://github.com/openstack/puppet-swift/blob/master/templates/proxy-server.conf.erb#L27-L31","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"405b0bae11f0d41527d50c7a11f44a55f9756477","unresolved":false,"context_lines":[{"line_number":193,"context_line":"  }"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"  swift_proxy_config {"},{"line_number":196,"context_line":"    \u0027DEFAULT/bind_port\u0027:                          value \u003d\u003e $port;"},{"line_number":197,"context_line":"    \u0027DEFAULT/bind_ip\u0027:                            value \u003d\u003e $proxy_local_net_ip;"},{"line_number":198,"context_line":"    \u0027DEFAULT/workers\u0027:                            value \u003d\u003e $workers;"},{"line_number":199,"context_line":"    \u0027DEFAULT/user\u0027:                               value \u003d\u003e \u0027swift\u0027;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_857b93f4","line":196,"in_reply_to":"3a98d1f4_87457718","updated":"2016-10-03 17:03:11.000000000","message":"I found there was no config to enable them in the proxy class anyway so I dropped them.","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5f5e7ddcbd1832b98ac31c0b4a0006a1052a5ab3","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    \u0027app:proxy-server/log_handoffs\u0027:              value \u003d\u003e $log_handoffs;"},{"line_number":214,"context_line":"    \u0027app:proxy-server/allow_account_management\u0027:  value \u003d\u003e $allow_account_management;"},{"line_number":215,"context_line":"    \u0027app:proxy-server/account_autocreate\u0027:        value \u003d\u003e $account_autocreate;"},{"line_number":216,"context_line":"    \u0027app:proxy-server/write_affinity\u0027:            value \u003d\u003e $write_affinity;"},{"line_number":217,"context_line":"    \u0027app:proxy-server/write_affinity_node_count\u0027: value \u003d\u003e $write_affinity_node_count;"},{"line_number":218,"context_line":"    \u0027app:proxy-server/node_timeout\u0027:              value \u003d\u003e $node_timeout;"},{"line_number":219,"context_line":"  }"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_47d44f46","line":217,"range":{"start_line":216,"start_character":0,"end_line":217,"end_character":86},"updated":"2016-09-30 09:38:00.000000000","message":"should not it also we wrapped out in if construction, like it done for read affinity?","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"405b0bae11f0d41527d50c7a11f44a55f9756477","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    \u0027app:proxy-server/log_handoffs\u0027:              value \u003d\u003e $log_handoffs;"},{"line_number":214,"context_line":"    \u0027app:proxy-server/allow_account_management\u0027:  value \u003d\u003e $allow_account_management;"},{"line_number":215,"context_line":"    \u0027app:proxy-server/account_autocreate\u0027:        value \u003d\u003e $account_autocreate;"},{"line_number":216,"context_line":"    \u0027app:proxy-server/write_affinity\u0027:            value \u003d\u003e $write_affinity;"},{"line_number":217,"context_line":"    \u0027app:proxy-server/write_affinity_node_count\u0027: value \u003d\u003e $write_affinity_node_count;"},{"line_number":218,"context_line":"    \u0027app:proxy-server/node_timeout\u0027:              value \u003d\u003e $node_timeout;"},{"line_number":219,"context_line":"  }"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_25b0ff89","line":217,"range":{"start_line":216,"start_character":0,"end_line":217,"end_character":86},"in_reply_to":"3a98d1f4_47d44f46","updated":"2016-10-03 17:03:11.000000000","message":"I would keep the write_affinity stuff here like this.  They are set to undef so won\u0027t show up by default.  It was important to have read_affinity wrapped so that it can include the setting of \"sorting_method \u003d affinity\" which isn\u0027t configurable for that option here.","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2e202e9fc861154b6fe6ec214db46dbf5756ea6d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"  $enabled                   \u003d true,"},{"line_number":155,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"},{"line_number":156,"context_line":"  $service_provider          \u003d $::swift::params::service_provider,"},{"line_number":157,"context_line":"  $purge_config              \u003d false,"},{"line_number":158,"context_line":") inherits ::swift::params {"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a98d1f4_307a9724","line":157,"updated":"2016-10-04 10:34:51.000000000","message":"nice solution :)","commit_id":"4f6541b556ce518263b718b22c8c4092fb835647"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dd528ff6a92b69a04ea0478baf8b9d7046b34623","unresolved":false,"context_lines":[{"line_number":154,"context_line":"  $enabled                   \u003d true,"},{"line_number":155,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"},{"line_number":156,"context_line":"  $service_provider          \u003d $::swift::params::service_provider,"},{"line_number":157,"context_line":"  $purge_config              \u003d false,"},{"line_number":158,"context_line":") inherits ::swift::params {"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1a95cdbc_3a542853","line":157,"in_reply_to":"1a95cdbc_a7ef45af","updated":"2016-10-04 16:30:33.000000000","message":"If we planned on switching this, I would recommend a cycle of a warning before making this true. I think it should be false for now","commit_id":"4f6541b556ce518263b718b22c8c4092fb835647"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e3024a47c91aa34362d231c4e8c99dcddf69347d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"  $enabled                   \u003d true,"},{"line_number":155,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"},{"line_number":156,"context_line":"  $service_provider          \u003d $::swift::params::service_provider,"},{"line_number":157,"context_line":"  $purge_config              \u003d false,"},{"line_number":158,"context_line":") inherits ::swift::params {"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1a95cdbc_a7ef45af","line":157,"in_reply_to":"3a98d1f4_307a9724","updated":"2016-10-04 16:12:28.000000000","message":"I\u0027m wondering if we should update it to True by default to perform an upgrade from template to inifile driven deployment.","commit_id":"4f6541b556ce518263b718b22c8c4092fb835647"}],"manifests/proxy/cache.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5f5e7ddcbd1832b98ac31c0b4a0006a1052a5ab3","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  swift_proxy_config {"},{"line_number":33,"context_line":"    \u0027filter:cache/use\u0027:              value \u003d\u003e \u0027egg:swift#memcache\u0027;"},{"line_number":34,"context_line":"    \u0027filter:cache/memcache_servers\u0027: value \u003d\u003e join(any2array($memcache_servers), \u0027,\u0027);"},{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_c7e3ff03","line":34,"updated":"2016-09-30 09:38:00.000000000","message":"not sure that it is important, but for which reasons were added .flatten in template?","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"405b0bae11f0d41527d50c7a11f44a55f9756477","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  swift_proxy_config {"},{"line_number":33,"context_line":"    \u0027filter:cache/use\u0027:              value \u003d\u003e \u0027egg:swift#memcache\u0027;"},{"line_number":34,"context_line":"    \u0027filter:cache/memcache_servers\u0027: value \u003d\u003e join(any2array($memcache_servers), \u0027,\u0027);"},{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_a88066c1","line":34,"in_reply_to":"3a98d1f4_c7e3ff03","updated":"2016-10-03 17:03:11.000000000","message":"That would have converted an array of arrays in to a single flat array, I don\u0027t see it being necessary here.","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"}],"manifests/proxy/gatekeeper.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5f5e7ddcbd1832b98ac31c0b4a0006a1052a5ab3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  include ::swift::deps"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  swift_proxy_config {"},{"line_number":49,"context_line":"    \u0027filter:gatekeeper/use\u0027:          value \u003d\u003e \u0027egg:swift#gatekeeper\u0027;"},{"line_number":50,"context_line":"    \u0027filter:gatekeeper/set log_name\u0027:     value \u003d\u003e $log_name;"},{"line_number":51,"context_line":"    \u0027filter:gatekeeper/set log_facility\u0027: value \u003d\u003e $log_facility;"},{"line_number":52,"context_line":"    \u0027filter:gatekeeper/set log_level\u0027:    value \u003d\u003e $log_level;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_c7221f01","line":49,"updated":"2016-09-30 09:38:00.000000000","message":"nit: alignment","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"405b0bae11f0d41527d50c7a11f44a55f9756477","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  include ::swift::deps"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  swift_proxy_config {"},{"line_number":49,"context_line":"    \u0027filter:gatekeeper/use\u0027:          value \u003d\u003e \u0027egg:swift#gatekeeper\u0027;"},{"line_number":50,"context_line":"    \u0027filter:gatekeeper/set log_name\u0027:     value \u003d\u003e $log_name;"},{"line_number":51,"context_line":"    \u0027filter:gatekeeper/set log_facility\u0027: value \u003d\u003e $log_facility;"},{"line_number":52,"context_line":"    \u0027filter:gatekeeper/set log_level\u0027:    value \u003d\u003e $log_level;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_286d3631","line":49,"in_reply_to":"3a98d1f4_c7221f01","updated":"2016-10-03 17:03:11.000000000","message":"Done","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"}],"manifests/proxy/keystone.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5f5e7ddcbd1832b98ac31c0b4a0006a1052a5ab3","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  swift_proxy_config {"},{"line_number":40,"context_line":"    \u0027filter:keystone/use\u0027:             value \u003d\u003e \u0027egg:swift#keystoneauth\u0027;"},{"line_number":41,"context_line":"    \u0027filter:keystone/operator_roles\u0027:  value \u003d\u003e join($operator_roles, \u0027, \u0027);"},{"line_number":42,"context_line":"    \u0027filter:keystone/reseller_prefix\u0027: value \u003d\u003e $reseller_prefix;"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_e7fd5b3b","line":41,"updated":"2016-09-30 09:38:00.000000000","message":"may be add any2array or validate array here?","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"405b0bae11f0d41527d50c7a11f44a55f9756477","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  swift_proxy_config {"},{"line_number":40,"context_line":"    \u0027filter:keystone/use\u0027:             value \u003d\u003e \u0027egg:swift#keystoneauth\u0027;"},{"line_number":41,"context_line":"    \u0027filter:keystone/operator_roles\u0027:  value \u003d\u003e join($operator_roles, \u0027, \u0027);"},{"line_number":42,"context_line":"    \u0027filter:keystone/reseller_prefix\u0027: value \u003d\u003e $reseller_prefix;"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_a8f5c657","line":41,"in_reply_to":"3a98d1f4_e7fd5b3b","updated":"2016-10-03 17:03:11.000000000","message":"Good idea, added.","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"}],"manifests/proxy/tempauth.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5f5e7ddcbd1832b98ac31c0b4a0006a1052a5ab3","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  swift_proxy_config {"},{"line_number":111,"context_line":"    \u0027filter:tempauth/use\u0027:                value \u003d\u003e \u0027egg:swift#tempauth\u0027;"},{"line_number":112,"context_line":"    \u0027filter:tempauth/reseller_prefix\u0027:    value \u003d\u003e $reseller_prefix_upcase;"},{"line_number":113,"context_line":"    \u0027filter:tempauth/token_life\u0027:         value \u003d\u003e $token_life;"},{"line_number":114,"context_line":"    \u0027filter:tempauth/auth_prefix\u0027:        value \u003d\u003e $auth_prefix;"},{"line_number":115,"context_line":"    \u0027filter:tempauth/storage_url_scheme\u0027: value \u003d\u003e $storage_url_scheme;"},{"line_number":116,"context_line":"  }"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  # tempauth account_users end up in the following format"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_6a21129f","line":115,"range":{"start_line":112,"start_character":0,"end_line":115,"end_character":71},"updated":"2016-09-30 09:38:00.000000000","message":"those parameters are undef by default, but also have validation, may be just set as required?","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"405b0bae11f0d41527d50c7a11f44a55f9756477","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  swift_proxy_config {"},{"line_number":111,"context_line":"    \u0027filter:tempauth/use\u0027:                value \u003d\u003e \u0027egg:swift#tempauth\u0027;"},{"line_number":112,"context_line":"    \u0027filter:tempauth/reseller_prefix\u0027:    value \u003d\u003e $reseller_prefix_upcase;"},{"line_number":113,"context_line":"    \u0027filter:tempauth/token_life\u0027:         value \u003d\u003e $token_life;"},{"line_number":114,"context_line":"    \u0027filter:tempauth/auth_prefix\u0027:        value \u003d\u003e $auth_prefix;"},{"line_number":115,"context_line":"    \u0027filter:tempauth/storage_url_scheme\u0027: value \u003d\u003e $storage_url_scheme;"},{"line_number":116,"context_line":"  }"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  # tempauth account_users end up in the following format"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_db857a07","line":115,"range":{"start_line":112,"start_character":0,"end_line":115,"end_character":71},"in_reply_to":"3a98d1f4_6a21129f","updated":"2016-10-03 17:03:11.000000000","message":"It might be better to leave them as undef.  This way a user can set some item and accept the defaults for the others.  See http://docs.openstack.org/kilo/config-reference/content/proxy-server-configuration.html  Table 10.61. Description of configuration options for [filter-tempauth] in proxy-server.conf","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"}],"manifests/proxy/tempurl.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5f5e7ddcbd1832b98ac31c0b4a0006a1052a5ab3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Copyright 2012 eNovance licensing@enovance.com"},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"class swift::proxy::tempurl ("},{"line_number":48,"context_line":"  $methods                 \u003d undef,"},{"line_number":49,"context_line":"  $incoming_remove_headers \u003d undef,"},{"line_number":50,"context_line":"  $incoming_allow_headers  \u003d undef,"},{"line_number":51,"context_line":"  $outgoing_remove_headers \u003d undef,"},{"line_number":52,"context_line":"  $outgoing_allow_headers  \u003d undef,"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_ea6d2299","line":52,"range":{"start_line":48,"start_character":0,"end_line":52,"end_character":35},"updated":"2016-09-30 09:38:00.000000000","message":"may be os::service::default? otherwise in case of re-deploy will not be unsetted.","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"405b0bae11f0d41527d50c7a11f44a55f9756477","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Copyright 2012 eNovance licensing@enovance.com"},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"class swift::proxy::tempurl ("},{"line_number":48,"context_line":"  $methods                 \u003d undef,"},{"line_number":49,"context_line":"  $incoming_remove_headers \u003d undef,"},{"line_number":50,"context_line":"  $incoming_allow_headers  \u003d undef,"},{"line_number":51,"context_line":"  $outgoing_remove_headers \u003d undef,"},{"line_number":52,"context_line":"  $outgoing_allow_headers  \u003d undef,"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_427a1989","line":52,"range":{"start_line":48,"start_character":0,"end_line":52,"end_character":35},"in_reply_to":"3a98d1f4_ea6d2299","updated":"2016-10-03 17:03:11.000000000","message":"Going to handle this case across the filters by adding this to proxy.pp class\n\n  resources { \u0027swift_proxy_config\u0027:\n    purge \u003d\u003e $purge_config,\n  }","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"}],"manifests/service.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5f5e7ddcbd1832b98ac31c0b4a0006a1052a5ab3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      provider  \u003d\u003e $service_provider,"},{"line_number":56,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":57,"context_line":"      subscribe \u003d\u003e $subscribe,"},{"line_number":58,"context_line":"      require   \u003d\u003e $require,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":61,"context_line":"    service { $name:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_0a17aeed","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":27},"updated":"2016-09-30 09:38:00.000000000","message":"what is \u0027$require\u0027 ?","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"405b0bae11f0d41527d50c7a11f44a55f9756477","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      provider  \u003d\u003e $service_provider,"},{"line_number":56,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":57,"context_line":"      subscribe \u003d\u003e $subscribe,"},{"line_number":58,"context_line":"      require   \u003d\u003e $require,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":61,"context_line":"    service { $name:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_62f2b507","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":27},"in_reply_to":"3a98d1f4_0a17aeed","updated":"2016-10-03 17:03:11.000000000","message":"This is passed in a service definition and needed to be included here to link them.\nhttps://review.openstack.org/#/c/378950/8/manifests/proxy.pp  line 270 for example","commit_id":"aae1a0797f97901ec523f3479d462ccc15b5ef4a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"70a602893d18649eba74df81afb42baf1e2862e3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      provider  \u003d\u003e $service_provider,"},{"line_number":56,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":57,"context_line":"      subscribe \u003d\u003e $subscribe,"},{"line_number":58,"context_line":"      require   \u003d\u003e $require,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":61,"context_line":"    service { $name:"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1a95cdbc_e71ced79","line":58,"updated":"2016-10-04 16:19:09.000000000","message":"I know this has been previously mentioned, but are you sure $require makes it to here?  The require on https://review.openstack.org/#/c/378950/8/manifests/proxy.pp i think only gets applied to the swift::service resource and i\u0027m not sure it gets passed in like the magic $title or $name variables.  I guess this one is a question for the puppet guys.  I don\u0027t suppose you could wrap a test around this to make sure it works as you think it does","commit_id":"4f6541b556ce518263b718b22c8c4092fb835647"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dd528ff6a92b69a04ea0478baf8b9d7046b34623","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      provider  \u003d\u003e $service_provider,"},{"line_number":56,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":57,"context_line":"      subscribe \u003d\u003e $subscribe,"},{"line_number":58,"context_line":"      require   \u003d\u003e $require,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":61,"context_line":"    service { $name:"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1a95cdbc_fae640e7","line":58,"in_reply_to":"1a95cdbc_e71ced79","updated":"2016-10-04 16:30:33.000000000","message":"Nevermind, it\u0027s covered in https://review.openstack.org/#/c/378950/10/spec/classes/swift_proxy_spec.rb on line 81. This still seems like something magic and will probably bite us some d ay. Bug i guess we are using $subscribe here as well","commit_id":"4f6541b556ce518263b718b22c8c4092fb835647"}]}