)]}'
{"manifests/proxy/staticweb.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"09bd75a3363ad585ffd6d16576a2a8fdce0b57a4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# \u003d\u003d Parameters"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*url_base*]"},{"line_number":14,"context_line":"# At times when it\u0027s impossible for staticweb to guess the outside"},{"line_number":15,"context_line":"# endpoint correctly, the url_base may be used to supply the URL"},{"line_number":16,"context_line":"# scheme and/or the host name (and port number) in order to generate"},{"line_number":17,"context_line":"# redirects."},{"line_number":18,"context_line":"# Example values:"},{"line_number":19,"context_line":"#    http://www.example.com    - redirect to www.example.com"},{"line_number":20,"context_line":"#    https:                    - changes the schema only"},{"line_number":21,"context_line":"#    https://                  - same, changes the schema only"},{"line_number":22,"context_line":"#    //www.example.com:8080    - redirect www.example.com on port 8080"},{"line_number":23,"context_line":"#                                (schema unchanged)"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# \u003d\u003d Authors"},{"line_number":26,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_5f611fa8","line":23,"range":{"start_line":14,"start_character":2,"end_line":23,"end_character":51},"updated":"2016-11-02 21:33:20.000000000","message":"identation, look at other files \u003d)\nwe normaly do\n\n# [*parameter*]\n#   (Optional)/(Required) \u003cdescription\u003e\n#   Defaults to ...\n#","commit_id":"97a52dda3cb6dea539fffa87cf800a4e5bda6df9"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"e114f08a8f30e6e772f295411b454864e571dc90","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# \u003d\u003d Parameters"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*url_base*]"},{"line_number":14,"context_line":"# At times when it\u0027s impossible for staticweb to guess the outside"},{"line_number":15,"context_line":"# endpoint correctly, the url_base may be used to supply the URL"},{"line_number":16,"context_line":"# scheme and/or the host name (and port number) in order to generate"},{"line_number":17,"context_line":"# redirects."},{"line_number":18,"context_line":"# Example values:"},{"line_number":19,"context_line":"#    http://www.example.com    - redirect to www.example.com"},{"line_number":20,"context_line":"#    https:                    - changes the schema only"},{"line_number":21,"context_line":"#    https://                  - same, changes the schema only"},{"line_number":22,"context_line":"#    //www.example.com:8080    - redirect www.example.com on port 8080"},{"line_number":23,"context_line":"#                                (schema unchanged)"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# \u003d\u003d Authors"},{"line_number":26,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_a4e1242c","line":23,"range":{"start_line":14,"start_character":2,"end_line":23,"end_character":51},"in_reply_to":"ba5da102_5f611fa8","updated":"2016-11-03 18:59:19.000000000","message":"done","commit_id":"97a52dda3cb6dea539fffa87cf800a4e5bda6df9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ce4c5fa11409919814fa7bcb8b32616c549f9ea4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Copyright 2012 eNovance licensing@enovance.com"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"class swift::proxy::staticweb("},{"line_number":34,"context_line":"  $url_base \u003d \u0027https://\u0027"},{"line_number":35,"context_line":") {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_9ff2d704","line":34,"updated":"2016-11-02 21:28:00.000000000","message":"what is the default in swift?","commit_id":"97a52dda3cb6dea539fffa87cf800a4e5bda6df9"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"e114f08a8f30e6e772f295411b454864e571dc90","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Copyright 2012 eNovance licensing@enovance.com"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"class swift::proxy::staticweb("},{"line_number":34,"context_line":"  $url_base \u003d \u0027https://\u0027"},{"line_number":35,"context_line":") {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_a44f6432","line":34,"in_reply_to":"ba5da102_1846c84e","updated":"2016-11-03 18:59:19.000000000","message":"thanks for the feedback, I\u0027ve made the changes as I understood, undef in line 24 and $::os_service_default in line 41, let me know if I got something wrong","commit_id":"97a52dda3cb6dea539fffa87cf800a4e5bda6df9"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"af24e8eecffc884f09b3b9d71694da69dd8a26b1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Copyright 2012 eNovance licensing@enovance.com"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"class swift::proxy::staticweb("},{"line_number":34,"context_line":"  $url_base \u003d \u0027https://\u0027"},{"line_number":35,"context_line":") {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_1846c84e","line":34,"in_reply_to":"ba5da102_891ff459","updated":"2016-11-03 12:01:03.000000000","message":"agree with Denis","commit_id":"97a52dda3cb6dea539fffa87cf800a4e5bda6df9"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"d2c4e470f596ad0d9b6948d0f7df831c2ee7e56a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Copyright 2012 eNovance licensing@enovance.com"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"class swift::proxy::staticweb("},{"line_number":34,"context_line":"  $url_base \u003d \u0027https://\u0027"},{"line_number":35,"context_line":") {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_a5e0622a","line":34,"in_reply_to":"ba5da102_9ff2d704","updated":"2016-11-03 06:54:27.000000000","message":"This is not defined by default, I think this should be undef therefore to avoid changing the default behavior.","commit_id":"97a52dda3cb6dea539fffa87cf800a4e5bda6df9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1428a6f6939cf64609b81fada58b3db780aba832","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Copyright 2012 eNovance licensing@enovance.com"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"class swift::proxy::staticweb("},{"line_number":34,"context_line":"  $url_base \u003d \u0027https://\u0027"},{"line_number":35,"context_line":") {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_891ff459","line":34,"in_reply_to":"ba5da102_a5e0622a","updated":"2016-11-03 10:17:29.000000000","message":"then use can use $::os_service_default","commit_id":"97a52dda3cb6dea539fffa87cf800a4e5bda6df9"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"48019a548c12c494d392c1c788e128bfb7691da7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*url_base*]"},{"line_number":14,"context_line":"#   (optional) The URL scheme and/or the host name used to generate redirects."},{"line_number":15,"context_line":"#   Defaults to undef."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# \u003d\u003d Authors"},{"line_number":18,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5da102_27599635","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":22},"updated":"2016-11-03 19:24:37.000000000","message":"$::os_service_default","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"9e98e5ab6ddda2443466d7669342e2caf5b097aa","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*url_base*]"},{"line_number":14,"context_line":"#   (optional) The URL scheme and/or the host name used to generate redirects."},{"line_number":15,"context_line":"#   Defaults to undef."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# \u003d\u003d Authors"},{"line_number":18,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5da102_67cc6e89","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":22},"in_reply_to":"ba5da102_27599635","updated":"2016-11-03 19:34:46.000000000","message":"Done","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"48019a548c12c494d392c1c788e128bfb7691da7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# Copyright 2012 eNovance licensing@enovance.com"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"class swift::proxy::staticweb("},{"line_number":26,"context_line":"  $url_base \u003d undef"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5da102_4744ca48","line":26,"range":{"start_line":26,"start_character":14,"end_line":26,"end_character":19},"updated":"2016-11-03 19:24:37.000000000","message":"$::os_service_default","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"9e98e5ab6ddda2443466d7669342e2caf5b097aa","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# Copyright 2012 eNovance licensing@enovance.com"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"class swift::proxy::staticweb("},{"line_number":26,"context_line":"  $url_base \u003d undef"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  include ::swift::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5da102_87c7c262","line":26,"range":{"start_line":26,"start_character":14,"end_line":26,"end_character":19},"in_reply_to":"ba5da102_4744ca48","updated":"2016-11-03 19:34:46.000000000","message":"Done","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"48019a548c12c494d392c1c788e128bfb7691da7","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  swift_proxy_config {"},{"line_number":32,"context_line":"    \u0027filter:staticweb/use\u0027:              value \u003d\u003e \u0027egg:swift#staticweb\u0027;"},{"line_number":33,"context_line":"    \u0027filter:staticweb/url_base\u0027:         value \u003d\u003e $::os_service_default;"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5da102_874a6253","line":33,"range":{"start_line":33,"start_character":49,"end_line":33,"end_character":71},"updated":"2016-11-03 19:24:37.000000000","message":"$url_base","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"9e98e5ab6ddda2443466d7669342e2caf5b097aa","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  swift_proxy_config {"},{"line_number":32,"context_line":"    \u0027filter:staticweb/use\u0027:              value \u003d\u003e \u0027egg:swift#staticweb\u0027;"},{"line_number":33,"context_line":"    \u0027filter:staticweb/url_base\u0027:         value \u003d\u003e $::os_service_default;"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5da102_c7a37ab0","line":33,"range":{"start_line":33,"start_character":49,"end_line":33,"end_character":71},"in_reply_to":"ba5da102_874a6253","updated":"2016-11-03 19:34:46.000000000","message":"Done","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"}],"spec/classes/swift_proxy_staticweb_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d691db1a75c2d3702c35531b0024aeca54b6fca9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  it { is_expected.to contain_swift_proxy_config(\u0027filter:staticweb/use\u0027).with_value(\u0027egg:swift#staticweb\u0027) }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  describe \"when using default parameters\" do"},{"line_number":12,"context_line":"    it { is_expected.to contain_swift_proxy_config(\u0027filter:staticweb/url_base\u0027).with_value(\u0027https://\u0027) }"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  end"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba5da102_a75cc619","line":12,"range":{"start_line":12,"start_character":92,"end_line":12,"end_character":101},"updated":"2016-11-03 19:25:22.000000000","message":"\u003cSERVICE DEFAULT\u003e","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8884bedd9ec066a75a973744ced7f3bce528d2d6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  it { is_expected.to contain_swift_proxy_config(\u0027filter:staticweb/use\u0027).with_value(\u0027egg:swift#staticweb\u0027) }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  describe \"when using default parameters\" do"},{"line_number":12,"context_line":"    it { is_expected.to contain_swift_proxy_config(\u0027filter:staticweb/url_base\u0027).with_value(\u0027https://\u0027) }"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  end"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba5da102_c7145aa1","line":12,"range":{"start_line":12,"start_character":92,"end_line":12,"end_character":101},"in_reply_to":"ba5da102_07b3b20a","updated":"2016-11-03 19:39:32.000000000","message":"Well its good ensure what is expected when using the default value.\n\nFor ruby the evaluation of $::os_service_default is the string \u0027\u003cSERVICE DEFAULT\u003e\u0027. Your parameter should be $::os_service_default and not undef \u003d)","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"9e98e5ab6ddda2443466d7669342e2caf5b097aa","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  it { is_expected.to contain_swift_proxy_config(\u0027filter:staticweb/use\u0027).with_value(\u0027egg:swift#staticweb\u0027) }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  describe \"when using default parameters\" do"},{"line_number":12,"context_line":"    it { is_expected.to contain_swift_proxy_config(\u0027filter:staticweb/url_base\u0027).with_value(\u0027https://\u0027) }"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  end"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba5da102_07b3b20a","line":12,"range":{"start_line":12,"start_character":92,"end_line":12,"end_character":101},"in_reply_to":"ba5da102_a75cc619","updated":"2016-11-03 19:34:46.000000000","message":"if using the default parameters, should this option would not even be included in the config, should it still be expected here? or should it be like in my patchset4? I was going by other examples I found in /spec/classes where when an option is set to undef, then the default is not tested. please clarify...","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"6666d7755004ae79a24b80839cc995f5f24fafd4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  it { is_expected.to contain_swift_proxy_config(\u0027filter:staticweb/use\u0027).with_value(\u0027egg:swift#staticweb\u0027) }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  describe \"when using default parameters\" do"},{"line_number":12,"context_line":"    it { is_expected.to contain_swift_proxy_config(\u0027filter:staticweb/url_base\u0027).with_value(\u0027https://\u0027) }"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  end"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba5da102_922e1e8a","line":12,"range":{"start_line":12,"start_character":92,"end_line":12,"end_character":101},"in_reply_to":"ba5da102_c7145aa1","updated":"2016-11-03 19:48:52.000000000","message":"Done","commit_id":"918df5063e1e835c84393b8c4583da3e062c772e"}]}