)]}'
{"manifests/service.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2c45312399d6beae51a8e1b40908f974c2c51c04","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      enable    \u003d\u003e $enabled,"},{"line_number":55,"context_line":"      provider  \u003d\u003e $service_provider,"},{"line_number":56,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":57,"context_line":"      subscribe \u003d\u003e $subscribe,"},{"line_number":58,"context_line":"      require   \u003d\u003e $require,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":61,"context_line":"    service { $name:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a77a97e_247de5e7","side":"PARENT","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":28},"updated":"2016-11-21 16:59:26.000000000","message":"this means $subscribe and $require which are specified for \n\nswift::service { \u0027name\u0027:\n  require \u003d\u003e \u0027some_res\u0027,\n  subscribe \u003d\u003e \u0027some_res\u0027\n}\n\nThose attributes were added by Adam, if i remember correctly. Let\u0027s wait for his opinion there.","commit_id":"8b1f4f3acb4b888707c3e01014f88dea18d181ab"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"a271d13c39eee07fd8040283c377d81090b6852d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      enable    \u003d\u003e $enabled,"},{"line_number":55,"context_line":"      provider  \u003d\u003e $service_provider,"},{"line_number":56,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":57,"context_line":"      subscribe \u003d\u003e $subscribe,"},{"line_number":58,"context_line":"      require   \u003d\u003e $require,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":61,"context_line":"    service { $name:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a77a97e_63d7cc23","side":"PARENT","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":28},"in_reply_to":"7a77a97e_23e4f439","updated":"2016-11-21 20:03:00.000000000","message":"We do want all of the resources in swift::service to inherit these... but the ordering already imposed on swift:service might not be enough without this inheritance.  Notice the spec test failures show that the requirements are not passed in to the service provider without these.","commit_id":"8b1f4f3acb4b888707c3e01014f88dea18d181ab"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3a4b023bf59d23a05b95123a85a97c5a82b2427e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      enable    \u003d\u003e $enabled,"},{"line_number":55,"context_line":"      provider  \u003d\u003e $service_provider,"},{"line_number":56,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":57,"context_line":"      subscribe \u003d\u003e $subscribe,"},{"line_number":58,"context_line":"      require   \u003d\u003e $require,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":61,"context_line":"    service { $name:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a77a97e_ff729aaf","side":"PARENT","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":28},"in_reply_to":"7a77a97e_247de5e7","updated":"2016-11-21 17:04:18.000000000","message":"Yea in previous versions, the $require and $subscribe were bubbled down into the class automagically. It looks like that may no longer be the case. Given containment rules, I\u0027m not sure we need these or if we need to expose these","commit_id":"8b1f4f3acb4b888707c3e01014f88dea18d181ab"},{"author":{"_account_id":11176,"name":"Adam Vinsh","email":"adam.vinsh@viasat.com","username":"vinsh"},"change_message_id":"88ea37efd6a5bbc1f2ee7a7eb8d95796af38f15b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      enable    \u003d\u003e $enabled,"},{"line_number":55,"context_line":"      provider  \u003d\u003e $service_provider,"},{"line_number":56,"context_line":"      tag       \u003d\u003e \u0027swift-service\u0027,"},{"line_number":57,"context_line":"      subscribe \u003d\u003e $subscribe,"},{"line_number":58,"context_line":"      require   \u003d\u003e $require,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"  } elsif $service_provider \u003d\u003d \u0027swiftinit\u0027 {"},{"line_number":61,"context_line":"    service { $name:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a77a97e_23e4f439","side":"PARENT","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":28},"in_reply_to":"7a77a97e_ff729aaf","updated":"2016-11-21 19:54:48.000000000","message":"I just tried adding these parameters to the define for this class above... the warnings change to this: \n\nWarning: subscribe is a metaparam; this value will inherit to all contained resources in the swift::service definition\nWarning: require is a metaparam; this value will inherit to all contained resources in the swift::service definition","commit_id":"8b1f4f3acb4b888707c3e01014f88dea18d181ab"}]}