)]}'
{"manifests/proxy/s3token.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"90791018b0c314a76e891868dab7293a1a47671f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  include ::swift::deps"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if $auth_host {"},{"line_number":45,"context_line":"        warning(\u0027Use of the auth_host, auth_port, and auth_protocol options have been deprecated in favor of auth_uri.\u0027)"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5f7c97a3_79dae3e9","line":45,"updated":"2018-05-04 13:57:46.000000000","message":"This will always throw a warning and would break people.  You should switch the defaults for the host/port/protocol to be undef. Then if they are defined, use them to construct an auth_uri_real for backwards compatibility.\n\nif $auth_host || $auth_port || $auth_protocol {\n  warning(\u0027stuff\u0027)\n  $auth_uri_real \u003d \"${auth_protocol}://${auth_host}:${auth_port}\"\n} else {\n  $auth_uri_real \u003d $auth_uri\n}\n\nthen use $auth_uri_real in the config setting.","commit_id":"25b828a03173dd580c34da37c7eca56836751250"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"9615e044d13d1553737b5a430b026072c33bbaa5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  include ::swift::deps"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if $auth_host {"},{"line_number":45,"context_line":"        warning(\u0027Use of the auth_host, auth_port, and auth_protocol options have been deprecated in favor of auth_uri.\u0027)"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5f7c97a3_d3dc3048","line":45,"in_reply_to":"5f7c97a3_79dae3e9","updated":"2018-05-04 19:24:54.000000000","message":"Done","commit_id":"25b828a03173dd580c34da37c7eca56836751250"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"038f0bed479549d58cd1ec43697c3dd49280030c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  include ::swift::deps"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if $auth_host || $auth_port || $auth_protocol {"},{"line_number":45,"context_line":"    warning(\u0027Use of the auth_host, auth_port, and auth_protocol options have been deprecated in favor of auth_uri.\u0027)"},{"line_number":46,"context_line":"    $auth_uri_real \u003d \"${auth_protocol}://${auth_host}:${auth_port}\""},{"line_number":47,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5f7c97a3_aef6e78e","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":18},"updated":"2018-05-04 20:48:19.000000000","message":"sorry these should be \u0027or\u0027 not \u0027||\u0027. I mixed up my language/operators :D  Also in thinking about this, it might need to be an \u0027and\u0027 because if a user was previously using the defaults you\u0027ll end up with a partial url.  Make sure to add a release note about the deprecation","commit_id":"50dcdaddee0aee01a612c5d3e83f2248e06e1ea1"}],"manifests/proxy/swift3.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8100883db6dbc65dec807bc09810fd8c2fc6b7a9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class swift::proxy::swift3("},{"line_number":24,"context_line":"  $ensure \u003d \u0027present\u0027"},{"line_number":25,"context_line":") {"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  include ::swift::deps"},{"line_number":28,"context_line":"  include ::swift::params"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_db5eab44","side":"PARENT","line":26,"updated":"2018-05-03 02:19:01.000000000","message":"So even if this doesn\u0027t work anymore, we should leave it, throw a warning about it\u0027s future removal and just noop the class.  Removing it will break anyone who may have it still defined in their catalog","commit_id":"d3961785fe7d179035d35f5da4d8a40e7e89d407"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"d37a5bfa2a471736feb7e006327b2c08f75ae1c1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class swift::proxy::swift3("},{"line_number":24,"context_line":"  $ensure \u003d \u0027present\u0027"},{"line_number":25,"context_line":") {"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  include ::swift::deps"},{"line_number":28,"context_line":"  include ::swift::params"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_72ebe8af","side":"PARENT","line":26,"in_reply_to":"5f7c97a3_db5eab44","updated":"2018-05-03 21:21:05.000000000","message":"Done","commit_id":"d3961785fe7d179035d35f5da4d8a40e7e89d407"}]}