)]}'
{"manifests/proxy.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"68c947cd6c6cc6f076998b8f1237a05a35b65611","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  $cors_allow_origin          \u003d undef,"},{"line_number":156,"context_line":"  $strict_cors_mode           \u003d true,"},{"line_number":157,"context_line":"  $max_containers_per_account \u003d 0,"},{"line_number":158,"context_line":"  $max_containers_whitelist   \u003d undef,"},{"line_number":159,"context_line":"  $read_affinity              \u003d undef,"},{"line_number":160,"context_line":"  $write_affinity             \u003d undef,"},{"line_number":161,"context_line":"  $write_affinity_node_count  \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_0771b2ab","line":158,"range":{"start_line":158,"start_character":32,"end_line":158,"end_character":37},"updated":"2018-10-23 09:15:06.000000000","message":"Just a small note. In other Puppet modules we are using $::os_service_default as an default value that is simply a string fact that contains \u0027\u003cSERVICE DEFAULT\u003e\u0027 instead of undef.\n\nThis is fine since puppet-swift is mostly not using this approach, atleast yet.","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"},{"author":{"_account_id":29349,"name":"Simeon Gourlin","email":"simeon.gourlin@infomaniak.com","username":"6meon"},"change_message_id":"7e3e9d593d7fe8e931d2433099ef043ad018ce45","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  $cors_allow_origin          \u003d undef,"},{"line_number":156,"context_line":"  $strict_cors_mode           \u003d true,"},{"line_number":157,"context_line":"  $max_containers_per_account \u003d 0,"},{"line_number":158,"context_line":"  $max_containers_whitelist   \u003d undef,"},{"line_number":159,"context_line":"  $read_affinity              \u003d undef,"},{"line_number":160,"context_line":"  $write_affinity             \u003d undef,"},{"line_number":161,"context_line":"  $write_affinity_node_count  \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_07c21203","line":158,"range":{"start_line":158,"start_character":32,"end_line":158,"end_character":37},"in_reply_to":"3f79a3b5_0771b2ab","updated":"2018-10-23 09:44:24.000000000","message":"Done","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"}],"spec/classes/swift_proxy_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"68c947cd6c6cc6f076998b8f1237a05a35b65611","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        it { should contain_swift_proxy_config(\u0027app:proxy-server/log_handoffs\u0027).with_value(\u0027true\u0027) }"},{"line_number":66,"context_line":"        it { should contain_swift_proxy_config(\u0027app:proxy-server/allow_account_management\u0027).with_value(\u0027true\u0027) }"},{"line_number":67,"context_line":"        it { should contain_swift_proxy_config(\u0027app:proxy-server/account_autocreate\u0027).with_value(\u0027true\u0027) }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        it { should contain_service(\u0027swift-proxy-server\u0027).with_require(["},{"line_number":70,"context_line":"          \u0027Class[Swift::Proxy::Healthcheck]\u0027,"},{"line_number":71,"context_line":"          \u0027Class[Swift::Proxy::Cache]\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_8764e2e7","line":68,"updated":"2018-10-23 09:15:06.000000000","message":"We could add a check here that simply tests that the default values for your two new parameters are correct when they are not supplied in the params.","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"68c947cd6c6cc6f076998b8f1237a05a35b65611","unresolved":false,"context_lines":[{"line_number":104,"context_line":"              :account_autocreate         \u003d\u003e false,"},{"line_number":105,"context_line":"              :log_level                  \u003d\u003e \u0027DEBUG\u0027,"},{"line_number":106,"context_line":"              :log_name                   \u003d\u003e \u0027swift-proxy-server\u0027,"},{"line_number":107,"context_line":"              :max_containers_per_account \u003d\u003e \u00270\u0027,"},{"line_number":108,"context_line":"              :max_containers_whitelist   \u003d\u003e \u0027\u0027,"},{"line_number":109,"context_line":"              :read_affinity              \u003d\u003e \u0027r1z1\u003d100, r1\u003d200\u0027,"},{"line_number":110,"context_line":"              :write_affinity             \u003d\u003e \u0027r1\u0027,"},{"line_number":111,"context_line":"              :write_affinity_node_count  \u003d\u003e \u00272 * replicas\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_e7f036ff","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":48},"updated":"2018-10-23 09:15:06.000000000","message":"Great!","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"68c947cd6c6cc6f076998b8f1237a05a35b65611","unresolved":false,"context_lines":[{"line_number":134,"context_line":"          it { should contain_swift_proxy_config(\u0027app:proxy-server/log_handoffs\u0027).with_value(\u0027true\u0027) }"},{"line_number":135,"context_line":"          it { should contain_swift_proxy_config(\u0027app:proxy-server/allow_account_management\u0027).with_value(\u0027false\u0027) }"},{"line_number":136,"context_line":"          it { should contain_swift_proxy_config(\u0027app:proxy-server/account_autocreate\u0027).with_value(\u0027false\u0027) }"},{"line_number":137,"context_line":"          it { should contain_swift_proxy_config(\u0027app:proxy-server/max_containers_per_account\u0027).with_value(\u00270\u0027) }"},{"line_number":138,"context_line":"          it { should contain_swift_proxy_config(\u0027app:proxy-server/max_containers_whitelist\u0027).with_value(\u0027\u0027) }"},{"line_number":139,"context_line":"          it { should contain_swift_proxy_config(\u0027app:proxy-server/sorting_method\u0027).with_value(\u0027affinity\u0027) }"},{"line_number":140,"context_line":"          it { should contain_swift_proxy_config(\u0027app:proxy-server/read_affinity\u0027).with_value(\u0027r1z1\u003d100, r1\u003d200\u0027) }"},{"line_number":141,"context_line":"          it { should contain_swift_proxy_config(\u0027app:proxy-server/write_affinity\u0027).with_value(\u0027r1\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_c7edfa24","line":138,"range":{"start_line":137,"start_character":0,"end_line":138,"end_character":110},"updated":"2018-10-23 09:15:06.000000000","message":"Great!","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"68c947cd6c6cc6f076998b8f1237a05a35b65611","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                :log_level                  \u003d\u003e \u0027DEBUG\u0027,"},{"line_number":157,"context_line":"                :log_name                   \u003d\u003e \u0027swift-proxy-server\u0027,"},{"line_number":158,"context_line":"                :log_udp_port               \u003d\u003e \u0027514\u0027,"},{"line_number":159,"context_line":"                :max_containers_per_account \u003d\u003e \u00270\u0027,"},{"line_number":160,"context_line":"                :max_containers_whitelist   \u003d\u003e \u0027\u0027,"},{"line_number":161,"context_line":"                :read_affinity              \u003d\u003e \u0027r1z1\u003d100, r1\u003d200\u0027,"},{"line_number":162,"context_line":"                :write_affinity             \u003d\u003e \u0027r1\u0027,"},{"line_number":163,"context_line":"                :write_affinity_node_count  \u003d\u003e \u00272 * replicas\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_c79f3ab1","line":160,"range":{"start_line":159,"start_character":0,"end_line":160,"end_character":50},"updated":"2018-10-23 09:15:06.000000000","message":"These are not required since nothing is done in this context.","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"},{"author":{"_account_id":29349,"name":"Simeon Gourlin","email":"simeon.gourlin@infomaniak.com","username":"6meon"},"change_message_id":"7e3e9d593d7fe8e931d2433099ef043ad018ce45","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                :log_level                  \u003d\u003e \u0027DEBUG\u0027,"},{"line_number":157,"context_line":"                :log_name                   \u003d\u003e \u0027swift-proxy-server\u0027,"},{"line_number":158,"context_line":"                :log_udp_port               \u003d\u003e \u0027514\u0027,"},{"line_number":159,"context_line":"                :max_containers_per_account \u003d\u003e \u00270\u0027,"},{"line_number":160,"context_line":"                :max_containers_whitelist   \u003d\u003e \u0027\u0027,"},{"line_number":161,"context_line":"                :read_affinity              \u003d\u003e \u0027r1z1\u003d100, r1\u003d200\u0027,"},{"line_number":162,"context_line":"                :write_affinity             \u003d\u003e \u0027r1\u0027,"},{"line_number":163,"context_line":"                :write_affinity_node_count  \u003d\u003e \u00272 * replicas\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_c7997a1e","line":160,"range":{"start_line":159,"start_character":0,"end_line":160,"end_character":50},"in_reply_to":"3f79a3b5_c79f3ab1","updated":"2018-10-23 09:44:24.000000000","message":"Done","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"68c947cd6c6cc6f076998b8f1237a05a35b65611","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                :log_name                   \u003d\u003e \u0027swift-proxy-server\u0027,"},{"line_number":183,"context_line":"                :log_udp_host               \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":184,"context_line":"                :log_udp_port               \u003d\u003e \u0027514\u0027,"},{"line_number":185,"context_line":"                :max_containers_per_account \u003d\u003e \u00270\u0027,"},{"line_number":186,"context_line":"                :max_containers_whitelist   \u003d\u003e \u0027\u0027,"},{"line_number":187,"context_line":"                :read_affinity              \u003d\u003e \u0027r1z1\u003d100, r1\u003d200\u0027,"},{"line_number":188,"context_line":"                :write_affinity             \u003d\u003e \u0027r1\u0027,"},{"line_number":189,"context_line":"                :write_affinity_node_count  \u003d\u003e \u00272 * replicas\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_67ae66e5","line":186,"range":{"start_line":185,"start_character":1,"end_line":186,"end_character":50},"updated":"2018-10-23 09:15:06.000000000","message":"These are not required to be tested here since there is no different code path your previous testing will cover this.","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"},{"author":{"_account_id":29349,"name":"Simeon Gourlin","email":"simeon.gourlin@infomaniak.com","username":"6meon"},"change_message_id":"7e3e9d593d7fe8e931d2433099ef043ad018ce45","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                :log_name                   \u003d\u003e \u0027swift-proxy-server\u0027,"},{"line_number":183,"context_line":"                :log_udp_host               \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":184,"context_line":"                :log_udp_port               \u003d\u003e \u0027514\u0027,"},{"line_number":185,"context_line":"                :max_containers_per_account \u003d\u003e \u00270\u0027,"},{"line_number":186,"context_line":"                :max_containers_whitelist   \u003d\u003e \u0027\u0027,"},{"line_number":187,"context_line":"                :read_affinity              \u003d\u003e \u0027r1z1\u003d100, r1\u003d200\u0027,"},{"line_number":188,"context_line":"                :write_affinity             \u003d\u003e \u0027r1\u0027,"},{"line_number":189,"context_line":"                :write_affinity_node_count  \u003d\u003e \u00272 * replicas\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_878382aa","line":186,"range":{"start_line":185,"start_character":1,"end_line":186,"end_character":50},"in_reply_to":"3f79a3b5_67ae66e5","updated":"2018-10-23 09:44:24.000000000","message":"Done","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"68c947cd6c6cc6f076998b8f1237a05a35b65611","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            it { should contain_swift_proxy_config(\u0027app:proxy-server/log_handoffs\u0027).with_value(\u0027true\u0027) }"},{"line_number":221,"context_line":"            it { should contain_swift_proxy_config(\u0027app:proxy-server/allow_account_management\u0027).with_value(\u0027false\u0027) }"},{"line_number":222,"context_line":"            it { should contain_swift_proxy_config(\u0027app:proxy-server/account_autocreate\u0027).with_value(\u0027false\u0027) }"},{"line_number":223,"context_line":"            it { should contain_swift_proxy_config(\u0027app:proxy-server/max_containers_per_account\u0027).with_value(\u00270\u0027) }"},{"line_number":224,"context_line":"            it { should contain_swift_proxy_config(\u0027app:proxy-server/max_containers_whitelist\u0027).with_value(\u0027\u0027) }"},{"line_number":225,"context_line":"            it { should contain_swift_proxy_config(\u0027app:proxy-server/sorting_method\u0027).with_value(\u0027affinity\u0027) }"},{"line_number":226,"context_line":"            it { should contain_swift_proxy_config(\u0027app:proxy-server/read_affinity\u0027).with_value(\u0027r1z1\u003d100, r1\u003d200\u0027) }"},{"line_number":227,"context_line":"            it { should contain_swift_proxy_config(\u0027app:proxy-server/write_affinity\u0027).with_value(\u0027r1\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_8792a29f","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":112},"updated":"2018-10-23 09:15:06.000000000","message":"See comment above.","commit_id":"066a4e27fdb37e6b9284694c4b36450546520a35"}]}