)]}'
{"manifests/proxy/domain_remap.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b5ee4a5a9fa18621deac94579f129338b0833f9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"#"},{"line_number":75,"context_line":"#"},{"line_number":76,"context_line":"class swift::proxy::domain_remap("},{"line_number":77,"context_line":"  $log_name                \u003d \u0027domain_remap\u0027,"},{"line_number":78,"context_line":"  $log_facility            \u003d \u0027LOG_LOCAL0\u0027,"},{"line_number":79,"context_line":"  $log_level               \u003d \u0027INFO\u0027,"},{"line_number":80,"context_line":"  $log_headers             \u003d false,"},{"line_number":81,"context_line":"  $log_address             \u003d \u0027/dev/log\u0027,"},{"line_number":82,"context_line":"  $storage_domain          \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $path_root               \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $reseller_prefixes       \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f493fa4_361c6e11","line":81,"range":{"start_line":77,"start_character":0,"end_line":81,"end_character":40},"updated":"2020-04-23 06:27:08.000000000","message":"Can we use $::os_service_default instead of re-defining actual default values here?","commit_id":"193d62c6110322b3a4c519fa36fc6cf13fe055a6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7a744a2a2a213e1d649f10dd71dfda694f611a9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# Default to $::os_service_default"},{"line_number":50,"context_line":"#"},{"line_number":51,"context_line":"# [*reseller_prefixes*]"},{"line_number":52,"context_line":"# Browsers can convert a host header to lowercase, so check that reseller"},{"line_number":53,"context_line":"# prefix on the account is the correct case. This is done by comparing the"},{"line_number":54,"context_line":"# items in the reseller_prefixes config option to the found prefix. If they"},{"line_number":55,"context_line":"# match except for case, the item from reseller_prefixes will be used"},{"line_number":56,"context_line":"# instead of the found reseller prefix. When none match, the default reseller"},{"line_number":57,"context_line":"# prefix is used. When no default reseller prefix is configured, any request"},{"line_number":58,"context_line":"# with an account prefix not in that list will be ignored by this middleware."},{"line_number":59,"context_line":"# Default to $::os_service_default"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*default_reseller_prefix*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_5c5af44e","line":58,"range":{"start_line":52,"start_character":0,"end_line":58,"end_character":77},"updated":"2020-04-23 13:14:41.000000000","message":"I\u0027m afraid that it\u0027s not a good idea to have this all description copied from swift, because it makes it difficult to maintain consistency with latest swift.\n\nHow about to say;\n\nA list of reseller_prefixes to lookup a reseller_prefix from the given account name.","commit_id":"d9297a77bb60f6aa5fa3d7059e0309587c24a5c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7a744a2a2a213e1d649f10dd71dfda694f611a9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# Default to $::os_service_default"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*default_reseller_prefix*]"},{"line_number":62,"context_line":"# Default to $::os_service_default"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*mangle_client_paths*]"},{"line_number":65,"context_line":"# Enable legacy remapping behavior for versioned path requests:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_3ca72852","line":62,"updated":"2020-04-23 13:14:41.000000000","message":"Please add description of the parameter like;\n\nThe default reseller_prefix used if none of reseller_prexies match","commit_id":"d9297a77bb60f6aa5fa3d7059e0309587c24a5c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7a744a2a2a213e1d649f10dd71dfda694f611a9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# Default to $::os_service_default"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*mangle_client_paths*]"},{"line_number":65,"context_line":"# Enable legacy remapping behavior for versioned path requests:"},{"line_number":66,"context_line":"#   c.a.example.com/v1/o -\u003e /v1/AUTH_a/c/o"},{"line_number":67,"context_line":"# instead of"},{"line_number":68,"context_line":"#   c.a.example.com/v1/o -\u003e /v1/AUTH_a/c/v1/o"},{"line_number":69,"context_line":"# ... by default all path parts after a remapped domain are considered part of"},{"line_number":70,"context_line":"# the object name with no special case for the path \"v1\""},{"line_number":71,"context_line":"# Default to $::os_service_default"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# \u003d\u003d Authors"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_7f9ec2b8","line":70,"range":{"start_line":65,"start_character":62,"end_line":70,"end_character":56},"updated":"2020-04-23 13:14:41.000000000","message":"Can we remove this part to simplify parameter description?","commit_id":"d9297a77bb60f6aa5fa3d7059e0309587c24a5c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7a744a2a2a213e1d649f10dd71dfda694f611a9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  $mangle_client_paths     \u003d $::os_service_default,"},{"line_number":89,"context_line":") {"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  include ::swift::deps"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  swift_proxy_config {"},{"line_number":94,"context_line":"    \u0027filter:domain_remap/use\u0027:                      value \u003d\u003e \u0027egg:swift#domain_remap\u0027;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_5c50345e","line":91,"range":{"start_line":91,"start_character":11,"end_line":91,"end_character":12},"updated":"2020-04-23 13:14:41.000000000","message":"As I mentioned in the parent patch, this should be removed.","commit_id":"d9297a77bb60f6aa5fa3d7059e0309587c24a5c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7a744a2a2a213e1d649f10dd71dfda694f611a9","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  swift_proxy_config {"},{"line_number":94,"context_line":"    \u0027filter:domain_remap/use\u0027:                      value \u003d\u003e \u0027egg:swift#domain_remap\u0027;"},{"line_number":95,"context_line":"    \u0027filter:domain_remap/set log_name\u0027:             value \u003d\u003e $log_name;"},{"line_number":96,"context_line":"    \u0027filter:domain_remap/set log_facility\u0027:         value \u003d\u003e $log_facility;"},{"line_number":97,"context_line":"    \u0027filter:domain_remap/set log_level\u0027:            value \u003d\u003e $log_level;"},{"line_number":98,"context_line":"    \u0027filter:domain_remap/set log_headers\u0027:          value \u003d\u003e $log_headers;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_bcedf88c","line":95,"range":{"start_line":95,"start_character":25,"end_line":95,"end_character":29},"updated":"2020-04-23 13:14:41.000000000","message":"I believe this \u0027set \u0027 should be removed","commit_id":"d9297a77bb60f6aa5fa3d7059e0309587c24a5c1"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"8db0e7ef141a2194fc19c859b25f5ae78ff0fba9","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  swift_proxy_config {"},{"line_number":94,"context_line":"    \u0027filter:domain_remap/use\u0027:                      value \u003d\u003e \u0027egg:swift#domain_remap\u0027;"},{"line_number":95,"context_line":"    \u0027filter:domain_remap/set log_name\u0027:             value \u003d\u003e $log_name;"},{"line_number":96,"context_line":"    \u0027filter:domain_remap/set log_facility\u0027:         value \u003d\u003e $log_facility;"},{"line_number":97,"context_line":"    \u0027filter:domain_remap/set log_level\u0027:            value \u003d\u003e $log_level;"},{"line_number":98,"context_line":"    \u0027filter:domain_remap/set log_headers\u0027:          value \u003d\u003e $log_headers;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_30b2a995","line":95,"range":{"start_line":95,"start_character":25,"end_line":95,"end_character":29},"in_reply_to":"1f493fa4_35f9fb4c","updated":"2020-04-23 15:04:23.000000000","message":"no worries, thanks for your comprehensive comments","commit_id":"d9297a77bb60f6aa5fa3d7059e0309587c24a5c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ef309c0cf2bcb321e3daac897778f5a4e019206","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  swift_proxy_config {"},{"line_number":94,"context_line":"    \u0027filter:domain_remap/use\u0027:                      value \u003d\u003e \u0027egg:swift#domain_remap\u0027;"},{"line_number":95,"context_line":"    \u0027filter:domain_remap/set log_name\u0027:             value \u003d\u003e $log_name;"},{"line_number":96,"context_line":"    \u0027filter:domain_remap/set log_facility\u0027:         value \u003d\u003e $log_facility;"},{"line_number":97,"context_line":"    \u0027filter:domain_remap/set log_level\u0027:            value \u003d\u003e $log_level;"},{"line_number":98,"context_line":"    \u0027filter:domain_remap/set log_headers\u0027:          value \u003d\u003e $log_headers;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_35f9fb4c","line":95,"range":{"start_line":95,"start_character":25,"end_line":95,"end_character":29},"in_reply_to":"1f493fa4_752ee3fa","updated":"2020-04-23 14:29:18.000000000","message":"Sorry that I was confused with how we define these parameters in DEFAULT section.\nYou are correct and we need \"set\" when we define these log parameters in specific sections.","commit_id":"d9297a77bb60f6aa5fa3d7059e0309587c24a5c1"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"9022e2abe5af8ba9e030acde3debc100185f3955","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  swift_proxy_config {"},{"line_number":94,"context_line":"    \u0027filter:domain_remap/use\u0027:                      value \u003d\u003e \u0027egg:swift#domain_remap\u0027;"},{"line_number":95,"context_line":"    \u0027filter:domain_remap/set log_name\u0027:             value \u003d\u003e $log_name;"},{"line_number":96,"context_line":"    \u0027filter:domain_remap/set log_facility\u0027:         value \u003d\u003e $log_facility;"},{"line_number":97,"context_line":"    \u0027filter:domain_remap/set log_level\u0027:            value \u003d\u003e $log_level;"},{"line_number":98,"context_line":"    \u0027filter:domain_remap/set log_headers\u0027:          value \u003d\u003e $log_headers;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_752ee3fa","line":95,"range":{"start_line":95,"start_character":25,"end_line":95,"end_character":29},"in_reply_to":"1f493fa4_bcedf88c","updated":"2020-04-23 14:21:45.000000000","message":"I didn\u0027t change this, as from the swift configuration, it should be with \"set\"?","commit_id":"d9297a77bb60f6aa5fa3d7059e0309587c24a5c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7a744a2a2a213e1d649f10dd71dfda694f611a9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \u0027filter:domain_remap/set log_address\u0027:          value \u003d\u003e $log_address;"},{"line_number":100,"context_line":"    \u0027filter:domain_remap/storage_domain\u0027 :          value \u003d\u003e $storage_domain;"},{"line_number":101,"context_line":"    \u0027filter:domain_remap/path_root\u0027:                value \u003d\u003e $path_root;"},{"line_number":102,"context_line":"    \u0027filter:domain_remap/reseller_prefixes\u0027:        value \u003d\u003e $reseller_prefixes;"},{"line_number":103,"context_line":"    \u0027filter:domain_remap/default_reseller_prefix\u0027:  value \u003d\u003e $default_reseller_prefix;"},{"line_number":104,"context_line":"    \u0027filter:domain_remap/mangle_client_paths\u0027:      value \u003d\u003e $mangle_client_paths;"},{"line_number":105,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_9f2e2e41","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":80},"updated":"2020-04-23 13:14:41.000000000","message":"I think it is useful to add a logic to accept list for reseller_prefixes parameter, like\n\n\n\n  if ! is_service_default($reseller_prefixes) and is_array($reseller_prefixes) {\n    $reseller_prefixes_str \u003d join($reseller_prefixes, \u0027,\u0027)\n  } else {\n    $reseller_prefixes_str \u003d $reseller_prefixes\n  }\n\n  swift_proxy_config{\n    ...\n    \u0027filter:domain_remap/reseller_prefixes\u0027:        value \u003d\u003e $reseller_prefixes_str;\n    ...\n  }","commit_id":"d9297a77bb60f6aa5fa3d7059e0309587c24a5c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ee339c662a68af2dcca81278db5f8f6d112bdaf","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  include swift::deps"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  if !is_service_default($reseller_prefixes) and is_array($reseller_prefixes) {"},{"line_number":86,"context_line":"    $reseller_prefixes_str \u003d join($reseller_prefixes, \u0027,\u0027)"},{"line_number":87,"context_line":"  } else {"},{"line_number":88,"context_line":"    $reseller_prefixes_str \u003d $reseller_prefixes"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f493fa4_982f3ba0","line":85,"range":{"start_line":85,"start_character":6,"end_line":85,"end_character":24},"updated":"2020-04-25 12:25:17.000000000","message":"Seems like this is causing failure in puppet 5 job...","commit_id":"473e4d05d1501f41f86fc412091a620d78c49bf1"}]}