)]}'
{"manifests/proxy.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b18fa65415b83e4669acfe4bdb2258bea7b10d9e","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"  # TODO(tkajinam): Remove this when we remove swift::proxy::swift3"},{"line_number":211,"context_line":"  if(! member($pipeline, \u0027swift3\u0027)){"},{"line_number":212,"context_line":"    fail(\u0027swift3 is no longer supported by puppet-swift. Use s3api middleware \\"},{"line_number":213,"context_line":"and swift::proxy::s3api instead\u0027)"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_e4414c3b","line":212,"range":{"start_line":212,"start_character":4,"end_line":212,"end_character":8},"updated":"2020-04-28 12:32:06.000000000","message":"Other possible options are;\n\n- Do not fail even if swift3 is set\n\nI\u0027m afraid that it causes invalid configuration which shouldn\u0027t work correctly.\n\n- Replace swift3 by s3api automatically\n\nThis sounds like a overkill. Also s3api has some parameters implemented, and we are not sure how these parameter should be set.","commit_id":"6e640c74c4d59fccff8604236f200cc2a1325c93"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d3e66983d47f983fe079b66dd4e2322cc9692655","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    warning(\u0027pipeline parameter must contain proxy-server\u0027)"},{"line_number":208,"context_line":"  }"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"  # TODO(tkajinam): Remove this when we remove swift::proxy::swift3"},{"line_number":211,"context_line":"  if(! member($pipeline, \u0027swift3\u0027)){"},{"line_number":212,"context_line":"    fail(\u0027swift3 is no longer supported by puppet-swift. Use s3api middleware \\"},{"line_number":213,"context_line":"and swift::proxy::s3api instead\u0027)"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  if($auth_type \u003d\u003d \u0027tempauth\u0027 and ! $account_autocreate ){"},{"line_number":217,"context_line":"    fail(\u0027account_autocreate must be set to true when auth_type is tempauth\u0027)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_9d16bb48","line":214,"range":{"start_line":210,"start_character":2,"end_line":214,"end_character":3},"updated":"2020-04-29 12:24:25.000000000","message":"Might not be needed, can probably assume a working deployment with this module doesn\u0027t have swift3 in it\u0027s pipeline","commit_id":"6e640c74c4d59fccff8604236f200cc2a1325c93"}],"manifests/proxy/swift3.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d3e66983d47f983fe079b66dd4e2322cc9692655","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027,\u0027swift-package\u0027]"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  swift_proxy_config {"},{"line_number":37,"context_line":"    \u0027filter:swift3/use\u0027: value \u003d\u003e \u0027egg:swift3#swift3\u0027;"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_7d3e4fc1","side":"PARENT","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":3},"updated":"2020-04-29 12:24:25.000000000","message":"If we want to make sure the puppet interface is intact but the service can start, would we do ensure \u003d\u003e absent on this config?","commit_id":"26b821dabbcbfb434d241eb9b733f187612aef62"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"061e5381fecad7a5cc672415ab2fcd047f6d464e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027,\u0027swift-package\u0027]"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  swift_proxy_config {"},{"line_number":37,"context_line":"    \u0027filter:swift3/use\u0027: value \u003d\u003e \u0027egg:swift3#swift3\u0027;"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_c7e5fadd","side":"PARENT","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":3},"in_reply_to":"1f493fa4_7d3e4fc1","updated":"2020-04-30 12:03:43.000000000","message":"I\u0027m afraid it doesn\u0027t help because swift can\u0027t load apps correctly if swift3 is included in pipeline while filter:swift3 is not defined.","commit_id":"26b821dabbcbfb434d241eb9b733f187612aef62"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bb29a11e37801e9e22c2894e0723e8a60277d95f","unresolved":false,"context_lines":[{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  warning(\u0027swift::proxy::swift3 is deprecated and has no effect. \\"},{"line_number":29,"context_line":"Use swift::proxy::s3api to use s3api middleware implemented in swift.)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f493fa4_443da08d","line":29,"range":{"start_line":29,"start_character":24,"end_line":29,"end_character":59},"updated":"2020-04-28 12:38:21.000000000","message":"I think I can remove this to make the description more simple.","commit_id":"6e640c74c4d59fccff8604236f200cc2a1325c93"}]}