)]}'
{"manifests/proxy/s3token.pp":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"6286e9630d8d47a54ba8e65289d452d820641b3f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  $auth_url              \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":102,"context_line":"  $auth_type             \u003d \u0027password\u0027,"},{"line_number":103,"context_line":"  $username              \u003d \u0027swift\u0027,"},{"line_number":104,"context_line":"  $password              \u003d \u0027password\u0027,"},{"line_number":105,"context_line":"  $project_name          \u003d \u0027services\u0027,"},{"line_number":106,"context_line":"  $project_domain_id     \u003d \u0027default\u0027,"},{"line_number":107,"context_line":"  $user_domain_id        \u003d \u0027default\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_0885faad","line":104,"range":{"start_line":104,"start_character":28,"end_line":104,"end_character":36},"updated":"2020-05-11 16:06:45.000000000","message":"I don\u0027t think it\u0027s a good idea to have a default value for the password.","commit_id":"704352edb66fdd43019433e7b98304cd7a6f6823"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aed2e3d9be07b77a5b8470629a187aecbeb87dae","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  $auth_url              \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":102,"context_line":"  $auth_type             \u003d \u0027password\u0027,"},{"line_number":103,"context_line":"  $username              \u003d \u0027swift\u0027,"},{"line_number":104,"context_line":"  $password              \u003d \u0027password\u0027,"},{"line_number":105,"context_line":"  $project_name          \u003d \u0027services\u0027,"},{"line_number":106,"context_line":"  $project_domain_id     \u003d \u0027default\u0027,"},{"line_number":107,"context_line":"  $user_domain_id        \u003d \u0027default\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_bd9404ea","line":104,"range":{"start_line":104,"start_character":28,"end_line":104,"end_character":36},"in_reply_to":"ff570b3c_0885faad","updated":"2020-05-12 04:23:58.000000000","message":"This is a cherry pick of the change in master, so we should fix master first.\nAlso, unfortunately we use this default value in authtoken middleware, so to keep consistency with it using this default would make some sense at the moment.\n\nIMO changing the default value is another topic, and should be done in another patch.","commit_id":"704352edb66fdd43019433e7b98304cd7a6f6823"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64240e91bd6d5d61e4aa4334f8b80792a17b164f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  $auth_url              \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":102,"context_line":"  $auth_type             \u003d \u0027password\u0027,"},{"line_number":103,"context_line":"  $username              \u003d \u0027swift\u0027,"},{"line_number":104,"context_line":"  $password              \u003d \u0027password\u0027,"},{"line_number":105,"context_line":"  $project_name          \u003d \u0027services\u0027,"},{"line_number":106,"context_line":"  $project_domain_id     \u003d \u0027default\u0027,"},{"line_number":107,"context_line":"  $user_domain_id        \u003d \u0027default\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff570b3c_ec39a841","line":104,"range":{"start_line":104,"start_character":28,"end_line":104,"end_character":36},"in_reply_to":"ff570b3c_bd9404ea","updated":"2020-05-12 10:07:46.000000000","message":"One more note, This password parameter is not used if secret_cache_duration\u003d0. This means that this parameter is not refereed by default, and it should be safe to have this default unless the user explicitly configures s3token with new parameters.","commit_id":"704352edb66fdd43019433e7b98304cd7a6f6823"}]}