)]}'
{"manifests/storage/mount.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d9c08c133fa0eb4552bd02a8bccce0a59acd11d0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  include swift::deps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if($loopback){"},{"line_number":34,"context_line":"    $options \u003d \u0027noatime,nodiratime,nofail,loop\u0027"},{"line_number":35,"context_line":"  } else {"},{"line_number":36,"context_line":"    $options \u003d \u0027noatime,nodiratime,nofail\u0027"},{"line_number":37,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff570b3c_12590434","line":34,"range":{"start_line":34,"start_character":35,"end_line":34,"end_character":41},"updated":"2020-05-19 13:59:46.000000000","message":"IIUC CentOS8 is based on kernel 4.18 and nobarrier should be available on it.\n\nSo IMO it\u0027s better to select default options based on distro, instead of changing common default.","commit_id":"fa5e35582bcd8013941fb6218f44f13ea5b5174f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"43ceadb917f7cc6c26ffd46bcbf8930c0a8d4fb7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  include swift::deps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if($loopback){"},{"line_number":34,"context_line":"    $options \u003d \u0027noatime,nodiratime,nofail,loop\u0027"},{"line_number":35,"context_line":"  } else {"},{"line_number":36,"context_line":"    $options \u003d \u0027noatime,nodiratime,nofail\u0027"},{"line_number":37,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff570b3c_32dc0845","line":34,"range":{"start_line":34,"start_character":35,"end_line":34,"end_character":41},"in_reply_to":"ff570b3c_12590434","updated":"2020-05-19 14:10:36.000000000","message":"ok. so seems like nobarrier has no effect since 4.10, and we can remove it.\n\nhttps://github.com/torvalds/linux/commit/4cf4573","commit_id":"fa5e35582bcd8013941fb6218f44f13ea5b5174f"}],"releasenotes/notes/default-mount-options-changed-23d7969ef826f8be.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"43ceadb917f7cc6c26ffd46bcbf8930c0a8d4fb7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The nobarrier XFS mount option is removed from kernel 4.19.0 and beyond."},{"line_number":5,"context_line":"    Therefore, it is now removed from the default mount options."},{"line_number":6,"context_line":"    Also, puppet-swift now adds the nofail option, so that a swift store node"},{"line_number":7,"context_line":"    finishes to boot even if an HDD mount is failed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_d2c14c56","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":76},"updated":"2020-05-19 14:10:36.000000000","message":"Can you also mention that the option has no effect since 4.10.0 ?","commit_id":"fa5e35582bcd8013941fb6218f44f13ea5b5174f"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"fde1fe3ec4ec2ea02b4217aa3af785b2d4d0d466","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The nobarrier XFS mount option is removed from kernel 4.19.0 and beyond."},{"line_number":5,"context_line":"    Therefore, it is now removed from the default mount options."},{"line_number":6,"context_line":"    Also, puppet-swift now adds the nofail option, so that a swift store node"},{"line_number":7,"context_line":"    finishes to boot even if an HDD mount is failed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_350eb2e4","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":76},"in_reply_to":"ff570b3c_d2c14c56","updated":"2020-05-19 14:37:20.000000000","message":"Done","commit_id":"fa5e35582bcd8013941fb6218f44f13ea5b5174f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"43ceadb917f7cc6c26ffd46bcbf8930c0a8d4fb7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The nobarrier XFS mount option is removed from kernel 4.19.0 and beyond."},{"line_number":5,"context_line":"    Therefore, it is now removed from the default mount options."},{"line_number":6,"context_line":"    Also, puppet-swift now adds the nofail option, so that a swift store node"},{"line_number":7,"context_line":"    finishes to boot even if an HDD mount is failed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_12862414","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":52},"updated":"2020-05-19 14:10:36.000000000","message":"(nit) Can you make this independent item ? I mean I want to see two topics, instead of one topic, in this release note, because these two are actually independent.","commit_id":"fa5e35582bcd8013941fb6218f44f13ea5b5174f"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"fde1fe3ec4ec2ea02b4217aa3af785b2d4d0d466","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The nobarrier XFS mount option is removed from kernel 4.19.0 and beyond."},{"line_number":5,"context_line":"    Therefore, it is now removed from the default mount options."},{"line_number":6,"context_line":"    Also, puppet-swift now adds the nofail option, so that a swift store node"},{"line_number":7,"context_line":"    finishes to boot even if an HDD mount is failed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_95fcdeb5","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":52},"in_reply_to":"ff570b3c_12862414","updated":"2020-05-19 14:37:20.000000000","message":"I prefer not to have 2 different patches, because they will obviously conflict one another.","commit_id":"fa5e35582bcd8013941fb6218f44f13ea5b5174f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a0ff9ba5d4bd449393d0ff51cd05b414dafcdc62","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The nobarrier XFS mount option is removed from kernel 4.19.0 and beyond."},{"line_number":5,"context_line":"    Therefore, it is now removed from the default mount options."},{"line_number":6,"context_line":"    Also, puppet-swift now adds the nofail option, so that a swift store node"},{"line_number":7,"context_line":"    finishes to boot even if an HDD mount is failed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_d5365603","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":52},"in_reply_to":"ff570b3c_95fcdeb5","updated":"2020-05-19 14:50:56.000000000","message":"I meant to say something like\n\n```\nfeatures:\n  - |\n    The nobarrier ...\n\n  - |\n    Now puppet-swift addes the nofail option ...\n```\n\nbut I\u0027m ok with having one item.","commit_id":"fa5e35582bcd8013941fb6218f44f13ea5b5174f"}]}