)]}'
{"manifests/keymaster.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9451187aa8eceb0839c77143c0aa72d2822cf350","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  $user_domain_name      \u003d undef,"},{"line_number":81,"context_line":"  $project_domain_id     \u003d \u0027default\u0027,"},{"line_number":82,"context_line":"  $user_domain_id        \u003d \u0027default\u0027,"},{"line_number":83,"context_line":"  $meta_version_to_write \u003d 1,"},{"line_number":84,"context_line":") {"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  include swift::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_f9b4d3d3","line":83,"range":{"start_line":83,"start_character":27,"end_line":83,"end_character":29},"updated":"2020-08-31 08:40:20.000000000","message":"Should we really enforce default value of 1 here?","commit_id":"8e9f7d57573251043df30cf263b2f84a8f727687"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"864ad7ccd8aaaab6b9c1ad26bd4b6db5fe36c265","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  $user_domain_name      \u003d undef,"},{"line_number":81,"context_line":"  $project_domain_id     \u003d \u0027default\u0027,"},{"line_number":82,"context_line":"  $user_domain_id        \u003d \u0027default\u0027,"},{"line_number":83,"context_line":"  $meta_version_to_write \u003d 1,"},{"line_number":84,"context_line":") {"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  include swift::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_bd900350","line":83,"updated":"2020-09-08 18:27:19.000000000","message":"doing with the lowest common value is probably best","commit_id":"8e9f7d57573251043df30cf263b2f84a8f727687"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"00b25264c03a627181f7950f99c9ba2c668451e7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  $user_domain_name      \u003d undef,"},{"line_number":81,"context_line":"  $project_domain_id     \u003d \u0027default\u0027,"},{"line_number":82,"context_line":"  $user_domain_id        \u003d \u0027default\u0027,"},{"line_number":83,"context_line":"  $meta_version_to_write \u003d 1,"},{"line_number":84,"context_line":") {"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  include swift::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f560f44_17d68754","line":83,"range":{"start_line":83,"start_character":27,"end_line":83,"end_character":29},"in_reply_to":"9f560f44_f9b4d3d3","updated":"2020-09-02 12:17:08.000000000","message":"The version of 1 is the safest. ie: the proxies are going to write version 1 of the crypto metadata, which is compatible with older Swift releases, so it will work when upgrading. However, one can use version 3 if all proxies are upgraded.\n\nSo I do believe that a default of 1 is the most sensitive value we can have.\n\nAnother possibility would be to force our users to set a value, and crash if none is provided. That\u0027s not backward compatible though, but that\u0027s probably what we want, as this is a quite touchy parameter.\n\nYour thoughts are welcome.","commit_id":"8e9f7d57573251043df30cf263b2f84a8f727687"}]}