)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e06fe981c9a499187b70ba815e04a9d94f256ea8","unresolved":true,"context_lines":[{"line_number":9,"context_line":"- Rename the package python-cm -\u003e python3-cm, using params.pp."},{"line_number":10,"context_line":"- Use ::swift::params for the ceilo-middleware package name, keep"},{"line_number":11,"context_line":"using ${pyvers} for consistency (as we agree to remove it in a"},{"line_number":12,"context_line":"later patch)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7c99aaf5f02b29a5901aee3e1d9f581079375f17"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"14d1ab03_5d10166b","line":12,"updated":"2021-03-17 13:12:08.000000000","message":"I updated the commit message because of the following intention.\n\n- It would be better to explain the issue the fix solves instead of actual implementation\n\n- Because we should backport this to stable branches, especially stable/train which still supports both python2 and python3, mentioning that we\u0027ll remove this would be confusing, I\u0027m afraid\n\nFor the latter part we already has agreement on ml thus I don\u0027t think it\u0027s mandatory to keep it here.","commit_id":"3b85292907eda32cdc679cd292f579add4dd975b"}],"manifests/params.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"54395075785ab8cf3a0393658d914351e4b23a59","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      $account_auditor_service_name      \u003d \u0027swift-account-auditor\u0027"},{"line_number":35,"context_line":"      $account_reaper_service_name       \u003d \u0027swift-account-reaper\u0027"},{"line_number":36,"context_line":"      $account_replicator_service_name   \u003d \u0027swift-account-replicator\u0027"},{"line_number":37,"context_line":"      $ceilo_middleware_package_name     \u003d \u0027python3-ceilometermiddleware\u0027"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":40,"context_line":"      $package_name                      \u003d \u0027openstack-swift\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"4b37e6f1_3caf2516","line":37,"range":{"start_line":37,"start_character":44,"end_line":37,"end_character":72},"updated":"2021-02-28 14:16:35.000000000","message":"As I mentioned in the thread in openstack-discuss I now agree to get rid of pyvers in a very near future since all distros now use python3 .\n\nHowever I\u0027d suggest you leave that removal in this patch. This is because that we still have the client_package parameter used both for CentOS and Ubuntu still relies on pyvers. If we get rid of pyvers then we should remove all its usage from at least puppet-ceilometer. IMO that transition is too bigger than the original scope of this change, and should be done in a separate change.","commit_id":"7a51e156e44b5647818f2c1794874a6a57b42718"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6db729488ea4045b34c154728b6e8770e6c593d5","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      $account_auditor_service_name      \u003d \u0027swift-account-auditor\u0027"},{"line_number":35,"context_line":"      $account_reaper_service_name       \u003d \u0027swift-account-reaper\u0027"},{"line_number":36,"context_line":"      $account_replicator_service_name   \u003d \u0027swift-account-replicator\u0027"},{"line_number":37,"context_line":"      $ceilo_middleware_package_name     \u003d \u0027python3-ceilometermiddleware\u0027"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":40,"context_line":"      $package_name                      \u003d \u0027openstack-swift\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"a794d64a_0b52bbf3","line":37,"range":{"start_line":37,"start_character":44,"end_line":37,"end_character":72},"in_reply_to":"4b37e6f1_3caf2516","updated":"2021-02-28 14:26:48.000000000","message":"s/puppet-ceilometer/puppet-swift/","commit_id":"7a51e156e44b5647818f2c1794874a6a57b42718"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"19a5eb5aa34cc4b93cb81328a00e23c96f13fe00","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      $account_auditor_service_name      \u003d \u0027swift-account-auditor\u0027"},{"line_number":35,"context_line":"      $account_reaper_service_name       \u003d \u0027swift-account-reaper\u0027"},{"line_number":36,"context_line":"      $account_replicator_service_name   \u003d \u0027swift-account-replicator\u0027"},{"line_number":37,"context_line":"      $ceilo_middleware_package_name     \u003d \u0027python3-ceilometermiddleware\u0027"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":40,"context_line":"      $package_name                      \u003d \u0027openstack-swift\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"a57da290_b1eae1e4","line":37,"range":{"start_line":37,"start_character":44,"end_line":37,"end_character":72},"in_reply_to":"a794d64a_0b52bbf3","updated":"2021-03-16 11:22:44.000000000","message":"Done","commit_id":"7a51e156e44b5647818f2c1794874a6a57b42718"}],"manifests/proxy/ceilometer.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"1ea38e496ce1ba03b07c7b1bb6436c5d0dc197b7","unresolved":true,"context_lines":[{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"  }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  package { \u0027ceilometermiddleware\u0027:"},{"line_number":209,"context_line":"    name   \u003d\u003e $::swift::param::ceilo_middleware_package_name,"},{"line_number":210,"context_line":"    ensure \u003d\u003e $ensure,"},{"line_number":211,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027swift-support-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5cfcf9d5_74fe2312","line":208,"range":{"start_line":208,"start_character":2,"end_line":208,"end_character":35},"updated":"2021-02-25 16:24:34.000000000","message":"don\u0027t rename python-ceilometermiddleware resource, that breaks the interface","commit_id":"d8c2c34bef84b8cfb24030c410bc004a9ebcb615"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"54395075785ab8cf3a0393658d914351e4b23a59","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  package { \u0027python-ceilometermiddleware\u0027:"},{"line_number":209,"context_line":"    name   \u003d\u003e $::swift::param::ceilo_middleware_package_name,"},{"line_number":210,"context_line":"    ensure \u003d\u003e $ensure,"},{"line_number":211,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027swift-support-package\u0027],"},{"line_number":212,"context_line":"  }"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"d1048ad2_5e37fbe5","line":210,"range":{"start_line":210,"start_character":4,"end_line":210,"end_character":22},"updated":"2021-02-28 14:16:35.000000000","message":"ensure should be placed in the first line, and this is causing error in lint.","commit_id":"7a51e156e44b5647818f2c1794874a6a57b42718"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"19a5eb5aa34cc4b93cb81328a00e23c96f13fe00","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  package { \u0027python-ceilometermiddleware\u0027:"},{"line_number":209,"context_line":"    name   \u003d\u003e $::swift::param::ceilo_middleware_package_name,"},{"line_number":210,"context_line":"    ensure \u003d\u003e $ensure,"},{"line_number":211,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027swift-support-package\u0027],"},{"line_number":212,"context_line":"  }"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7cee7a8f_5a4c4517","line":210,"range":{"start_line":210,"start_character":4,"end_line":210,"end_character":22},"in_reply_to":"d1048ad2_5e37fbe5","updated":"2021-03-16 11:22:44.000000000","message":"Done","commit_id":"7a51e156e44b5647818f2c1794874a6a57b42718"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b16698b12a19e3ebc487741158b84f4f32dcb9d2","unresolved":true,"context_lines":[{"line_number":158,"context_line":"    Package[\u0027python-ceilometermiddleware\u0027] -\u003e Service[\u0027swift-proxy-server\u0027]"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  file { \u0027/var/log/ceilometer/swift-proxy-server.log\u0027:"},{"line_number":162,"context_line":"    ensure \u003d\u003e file,"},{"line_number":163,"context_line":"    mode   \u003d\u003e \u00270664\u0027,"},{"line_number":164,"context_line":"    owner  \u003d\u003e \u0027swift\u0027,"},{"line_number":165,"context_line":"    group  \u003d\u003e \u0027swift\u0027,"},{"line_number":166,"context_line":"  }"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  if $auth_uri {"},{"line_number":169,"context_line":"    warning(\u0027The swift::proxy::ceilometer::auth_uri parameter was deperecated, and has no effect\u0027)"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"a8957091_5c1c0a9d","side":"PARENT","line":166,"range":{"start_line":161,"start_character":0,"end_line":166,"end_character":3},"updated":"2021-03-01 13:12:17.000000000","message":"unrelated? do in a separate commit","commit_id":"3bcbf44125c5e96c66c55f6cf4dc5017524937f3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"45eb18c6f0b2c007cfd7b5e853bc60df2440153a","unresolved":true,"context_lines":[{"line_number":158,"context_line":"    Package[\u0027python-ceilometermiddleware\u0027] -\u003e Service[\u0027swift-proxy-server\u0027]"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  file { \u0027/var/log/ceilometer/swift-proxy-server.log\u0027:"},{"line_number":162,"context_line":"    ensure \u003d\u003e file,"},{"line_number":163,"context_line":"    mode   \u003d\u003e \u00270664\u0027,"},{"line_number":164,"context_line":"    owner  \u003d\u003e \u0027swift\u0027,"},{"line_number":165,"context_line":"    group  \u003d\u003e \u0027swift\u0027,"},{"line_number":166,"context_line":"  }"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  if $auth_uri {"},{"line_number":169,"context_line":"    warning(\u0027The swift::proxy::ceilometer::auth_uri parameter was deperecated, and has no effect\u0027)"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"f71173a6_9578bcb6","side":"PARENT","line":166,"range":{"start_line":161,"start_character":0,"end_line":166,"end_character":3},"in_reply_to":"a8957091_5c1c0a9d","updated":"2021-03-15 12:06:41.000000000","message":"I agree that this should be done in a separate patch.\n\nThis logic was added by https://github.com/openstack/puppet-swift/commit/499386a89d2b5059445c887ff383655610f3fcb9 but I\u0027m afraid this was wrong.\nceilometermiddlware is supposed to use the same logger as proxy-server and doesn\u0027t directly touch log files but rely on rsyslog.\n\nI think it\u0027s better to revert this commit in a separate patch.","commit_id":"3bcbf44125c5e96c66c55f6cf4dc5017524937f3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"19a5eb5aa34cc4b93cb81328a00e23c96f13fe00","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    Package[\u0027python-ceilometermiddleware\u0027] -\u003e Service[\u0027swift-proxy-server\u0027]"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  file { \u0027/var/log/ceilometer/swift-proxy-server.log\u0027:"},{"line_number":162,"context_line":"    ensure \u003d\u003e file,"},{"line_number":163,"context_line":"    mode   \u003d\u003e \u00270664\u0027,"},{"line_number":164,"context_line":"    owner  \u003d\u003e \u0027swift\u0027,"},{"line_number":165,"context_line":"    group  \u003d\u003e \u0027swift\u0027,"},{"line_number":166,"context_line":"  }"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  if $auth_uri {"},{"line_number":169,"context_line":"    warning(\u0027The swift::proxy::ceilometer::auth_uri parameter was deperecated, and has no effect\u0027)"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ac66a15c_9ac951d8","side":"PARENT","line":166,"range":{"start_line":161,"start_character":0,"end_line":166,"end_character":3},"in_reply_to":"f71173a6_9578bcb6","updated":"2021-03-16 11:22:44.000000000","message":"Done","commit_id":"3bcbf44125c5e96c66c55f6cf4dc5017524937f3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"651c71c00e3ef0501bba4c670c1e4a457c6c984f","unresolved":true,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"  package { \u0027python-ceilometermiddleware\u0027:"},{"line_number":216,"context_line":"    ensure \u003d\u003e $ensure,"},{"line_number":217,"context_line":"    name   \u003d\u003e $::swift::param::ceilo_middleware_package_name,"},{"line_number":218,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027swift-support-package\u0027],"},{"line_number":219,"context_line":"  }"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"4539be87_50d3282c","line":217,"range":{"start_line":217,"start_character":24,"end_line":217,"end_character":29},"updated":"2021-03-17 13:25:53.000000000","message":"s/param/params/","commit_id":"3b85292907eda32cdc679cd292f579add4dd975b"}],"spec/classes/swift_proxy_ceilometer_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e06fe981c9a499187b70ba815e04a9d94f256ea8","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":118,"context_line":"      end"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"      let(:platform_params) do"},{"line_number":121,"context_line":"        case facts[:osfamily]"},{"line_number":122,"context_line":"        when \u0027Debian\u0027"},{"line_number":123,"context_line":"          { :ceilometermiddleware_package_name \u003d\u003e \u0027python3-ceilometermiddleware\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"0c15100d_6887056a","line":120,"range":{"start_line":120,"start_character":6,"end_line":120,"end_character":30},"updated":"2021-03-17 13:12:08.000000000","message":"This implementation is not required in master, but worth implementing now because we still have these compatibility logic left and this helps backuport.","commit_id":"f72868bd24a7ba1463501a2c6ae9d43f1a1ebdca"}]}