)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8e220af4ba7b091916bd266e66647a8e86e2158","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This add the cname_lookup middleware for swift proxy."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add the manifest to install and use the cname_lookup middleware"},{"line_number":10,"context_line":"for swift proxy pipeline."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It includes the cname_lookup middleware parameters available in swift-proxy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bf7210b5_4fe2af2c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"updated":"2021-03-28 11:59:05.000000000","message":"It is recommended to wrap commit messages in 72 characters.","commit_id":"b07bb2ca53b26d172947267a9c40115daeea64c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8e220af4ba7b091916bd266e66647a8e86e2158","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It also install the required dependency python-dnspython."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"I added a spec file copied from domain_remap one, hope it is good like this."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: If68511fb97bae688e0201fb32928acc9cf68cafc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d17f1821_7ca5ce38","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":76},"updated":"2021-03-28 11:59:05.000000000","message":"I removed this line because it is a response to a review comment and not something we usually keep in commit messages.","commit_id":"b07bb2ca53b26d172947267a9c40115daeea64c7"}],"manifests/proxy/cname_lookup.pp":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e0cb9cdf5aee971190df1d387e3d6ea8cb2384ea","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    \u0027filter:cname_lookup/nameservers\u0027 :     value \u003d\u003e $nameservers; "},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  package { \u0027python-dnspython\u0027:"},{"line_number":79,"context_line":"    ensure \u003d\u003e \u0027present\u0027,"},{"line_number":80,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027swift-support-package\u0027],"},{"line_number":81,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"c3485c8d_a825f2f2","line":78,"range":{"start_line":78,"start_character":13,"end_line":78,"end_character":29},"updated":"2021-03-16 17:04:42.000000000","message":"In Debian and Ubuntu, this package must be python3-dnspython, not just python-dnspython. Besides this, perhaps writing the name of the package in params.pp would be appropriate. So the way to do it is probably:\n\npackage { \u0027python-dnspython\u0027:\n  name \u003d\u003e $::swift::params:dnspython_pakage_name,\n  ...","commit_id":"e8cb3726b1f1e8a8f9019c664175843c3c57adaf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7436bd13c60f9f2ed0f509375f7c2e933aabc55f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configure CNAME Lookup middleware for swift"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Dependencies"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# python3-dnspython"},{"line_number":8,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"25b52d67_f9347d63","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":18},"updated":"2021-03-17 13:44:45.000000000","message":"This is not dependencies of this puppet class but ones of software it is configuring.\nWe don\u0027t need to explain what packages will be installed, so I think we should remove this.","commit_id":"aa8f77350f1eee04ab70f451fc15a4fff803f88a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7436bd13c60f9f2ed0f509375f7c2e933aabc55f","unresolved":true,"context_lines":[{"line_number":34,"context_line":"# Default to $::os_service_default"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*lookup_depth*]"},{"line_number":37,"context_line":"# Because CNAMES can be recursive, specifies the number of levels "},{"line_number":38,"context_line":"# through which to search."},{"line_number":39,"context_line":"# Default to $::os_service_default"},{"line_number":40,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"b6631d48_0f004cc5","line":37,"range":{"start_line":37,"start_character":65,"end_line":37,"end_character":66},"updated":"2021-03-17 13:44:45.000000000","message":"(nit) too many spaces","commit_id":"aa8f77350f1eee04ab70f451fc15a4fff803f88a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7436bd13c60f9f2ed0f509375f7c2e933aabc55f","unresolved":true,"context_lines":[{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"class swift::proxy::cname_lookup("},{"line_number":50,"context_line":"  $log_name                \u003d $::os_service_default,"},{"line_number":51,"context_line":"  $log_facility            \u003d $::os_service_default,"},{"line_number":52,"context_line":"  $log_level               \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $log_headers             \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"6135cc0b_f38d78a2","line":50,"range":{"start_line":50,"start_character":18,"end_line":50,"end_character":27},"updated":"2021-03-17 13:44:45.000000000","message":"(nit) too many spaces","commit_id":"aa8f77350f1eee04ab70f451fc15a4fff803f88a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7436bd13c60f9f2ed0f509375f7c2e933aabc55f","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    \u0027filter:cname_lookup/nameservers\u0027 :     value \u003d\u003e $nameservers;"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  package { \u0027python3-dnspython\u0027:"},{"line_number":79,"context_line":"    ensure \u003d\u003e \u0027present\u0027,"},{"line_number":80,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027swift-support-package\u0027],"},{"line_number":81,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"f053c1d9_b3999e3c","line":78,"range":{"start_line":78,"start_character":13,"end_line":78,"end_character":20},"updated":"2021-03-17 13:44:45.000000000","message":"For resource names we use python- instead of python3- .\nIt\u0027s better to use python- to make this consistent with the other classes.","commit_id":"aa8f77350f1eee04ab70f451fc15a4fff803f88a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7436bd13c60f9f2ed0f509375f7c2e933aabc55f","unresolved":true,"context_lines":[{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  package { \u0027python3-dnspython\u0027:"},{"line_number":79,"context_line":"    ensure \u003d\u003e \u0027present\u0027,"},{"line_number":80,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027swift-support-package\u0027],"},{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e977aa6a_267f4e61","line":79,"updated":"2021-03-17 13:44:45.000000000","message":"Please defined the package name parameter in swift::params and use the parameter as suggested by Thomas .\n\nNote that you should add \"include swift::params\" into the top to look up the parameter from the swift::params class.","commit_id":"aa8f77350f1eee04ab70f451fc15a4fff803f88a"}],"spec/classes/swift_proxy_cname_lookup_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7436bd13c60f9f2ed0f509375f7c2e933aabc55f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/set log_address\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":12,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/storage_domain\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":13,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/lookup_depth\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":14,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/nameservers\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":15,"context_line":"    end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    describe \"when overriding default parameters\" do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"2e0109d8_0df16f90","line":14,"updated":"2021-03-17 13:44:45.000000000","message":"Please consider adding test about the package resource.","commit_id":"aa8f77350f1eee04ab70f451fc15a4fff803f88a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7436bd13c60f9f2ed0f509375f7c2e933aabc55f","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    describe \"when overriding default parameters\" do"},{"line_number":18,"context_line":"      let :params do"},{"line_number":19,"context_line":"        {"},{"line_number":20,"context_line":"          :log_name                \u003d\u003e \u0027newcname_lookup\u0027,"},{"line_number":21,"context_line":"          :log_facility            \u003d\u003e \u0027LOG_LOCAL3\u0027,"},{"line_number":22,"context_line":"          :log_level               \u003d\u003e \u0027WARN\u0027,"},{"line_number":23,"context_line":"          :log_headers             \u003d\u003e \u0027True\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"0a7c83b3_8b78d3d0","line":20,"range":{"start_line":20,"start_character":26,"end_line":20,"end_character":35},"updated":"2021-03-17 13:44:45.000000000","message":"(nit) too many spaces.","commit_id":"aa8f77350f1eee04ab70f451fc15a4fff803f88a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7436bd13c60f9f2ed0f509375f7c2e933aabc55f","unresolved":true,"context_lines":[{"line_number":27,"context_line":"          :nameservers             \u003d\u003e \u00278.8.8.8\u0027,"},{"line_number":28,"context_line":"        }"},{"line_number":29,"context_line":"      end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/set log_name\u0027).with_value(\u0027newcname_lookup\u0027) }"},{"line_number":32,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/set log_facility\u0027).with_value(\u0027LOG_LOCAL3\u0027) }"},{"line_number":33,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/set log_level\u0027).with_value(\u0027WARN\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"e059759f_39d9fa18","line":30,"updated":"2021-03-17 13:44:45.000000000","message":"the use parameter should be tested here as well","commit_id":"aa8f77350f1eee04ab70f451fc15a4fff803f88a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8e220af4ba7b091916bd266e66647a8e86e2158","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/storage_domain\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":12,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/lookup_depth\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":13,"context_line":"      it { is_expected.to contain_swift_proxy_config(\u0027filter:cname_lookup/nameservers\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":14,"context_line":"      it { is_expected.to contain_package(\u0027python-dnspython\u0027).with_ensure(\u0027present\u0027) }"},{"line_number":15,"context_line":"    end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    describe \"when overriding default parameters\" do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"4d969dca_807afe77","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":86},"updated":"2021-03-28 11:59:05.000000000","message":"Would be better to test name and tags as well.","commit_id":"b07bb2ca53b26d172947267a9c40115daeea64c7"}]}