)]}'
{"manifests/storage/disk.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6d53e2cfd46d554ec8766ea582695385550e0016","unresolved":true,"context_lines":[{"line_number":58,"context_line":"  $mnt_base_dir        \u003d \u0027/srv/node\u0027,"},{"line_number":59,"context_line":"  $byte_size           \u003d \u00271024\u0027,"},{"line_number":60,"context_line":"  $ext_args            \u003d \u0027\u0027,"},{"line_number":61,"context_line":"  $run_parted_and_mkfs \u003d true,"},{"line_number":62,"context_line":") {"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  include swift::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"2f78bc93_3ba9611c","line":61,"range":{"start_line":61,"start_character":3,"end_line":61,"end_character":22},"updated":"2021-06-15 11:31:01.000000000","message":"I prefer something like manage_partition (or manage_disk_partition) instead of explaining the actual behavior too much in detail.\n\nAdding two options like manage_partition and manage_filesystem might be a better option.","commit_id":"fe6036e150954d5876c8bd88e86ebab86a1e0a5a"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a38264c5ee0365a869f522e62bf6acaa2d41b550","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  $mnt_base_dir        \u003d \u0027/srv/node\u0027,"},{"line_number":59,"context_line":"  $byte_size           \u003d \u00271024\u0027,"},{"line_number":60,"context_line":"  $ext_args            \u003d \u0027\u0027,"},{"line_number":61,"context_line":"  $run_parted_and_mkfs \u003d true,"},{"line_number":62,"context_line":") {"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  include swift::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f5399f66_51a52b73","line":61,"range":{"start_line":61,"start_character":3,"end_line":61,"end_character":22},"in_reply_to":"2f78bc93_3ba9611c","updated":"2021-06-15 11:48:53.000000000","message":"Done","commit_id":"fe6036e150954d5876c8bd88e86ebab86a1e0a5a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6d53e2cfd46d554ec8766ea582695385550e0016","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    mnt_base_dir        \u003d\u003e $mnt_base_dir,"},{"line_number":88,"context_line":"    byte_size           \u003d\u003e $byte_size,"},{"line_number":89,"context_line":"    loopback            \u003d\u003e false,"},{"line_number":90,"context_line":"    subscribe           \u003d\u003e Exec[\"create_partition_label-${name}\"],"},{"line_number":91,"context_line":"    run_parted_and_mkfs \u003d\u003e $run_parted_and_mkfs,"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"6a406d05_5d6e9e60","line":90,"range":{"start_line":90,"start_character":4,"end_line":90,"end_character":66},"updated":"2021-06-15 11:31:01.000000000","message":"This should not set when run_parted_and_mkfs. I think it\u0027s better to set dependency not here but separately.","commit_id":"fe6036e150954d5876c8bd88e86ebab86a1e0a5a"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a38264c5ee0365a869f522e62bf6acaa2d41b550","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    mnt_base_dir        \u003d\u003e $mnt_base_dir,"},{"line_number":88,"context_line":"    byte_size           \u003d\u003e $byte_size,"},{"line_number":89,"context_line":"    loopback            \u003d\u003e false,"},{"line_number":90,"context_line":"    subscribe           \u003d\u003e Exec[\"create_partition_label-${name}\"],"},{"line_number":91,"context_line":"    run_parted_and_mkfs \u003d\u003e $run_parted_and_mkfs,"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"b5e7cc69_8b503b98","line":90,"range":{"start_line":90,"start_character":4,"end_line":90,"end_character":66},"in_reply_to":"6a406d05_5d6e9e60","updated":"2021-06-15 11:48:53.000000000","message":"Done","commit_id":"fe6036e150954d5876c8bd88e86ebab86a1e0a5a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9238fd287be8a3c225a7d2febbb0897637e52412","unresolved":true,"context_lines":[{"line_number":33,"context_line":"#   (optional) The external command that will be used in parted command."},{"line_number":34,"context_line":"#   Default to \u0027\u0027. For making partitions, it would be \u0027mkpart primary 0% 100%\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*manage_partition_and_filesystem*]"},{"line_number":37,"context_line":"#   (optional) If set to false, skip calling parted ans mkfs.xfs, which can, in some"},{"line_number":38,"context_line":"#   cases, increase the load on the server. This is to set to false only after the"},{"line_number":39,"context_line":"#   server is fully setup."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"31485fe6_115e1d20","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":35},"updated":"2021-06-15 12:17:26.000000000","message":"Can we split this parameter to two parmaeters, manage_partition and manage_filesystem ?\nThe current one looks too long and having separate options looks cleaner.","commit_id":"69b278b09bb075eeea5a46e73a994a8ae4a9ed5e"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"c668dbbd7c82dbbad250b9538e2cfe81a277c8bf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#   (optional) The external command that will be used in parted command."},{"line_number":34,"context_line":"#   Default to \u0027\u0027. For making partitions, it would be \u0027mkpart primary 0% 100%\u0027."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*manage_partition_and_filesystem*]"},{"line_number":37,"context_line":"#   (optional) If set to false, skip calling parted ans mkfs.xfs, which can, in some"},{"line_number":38,"context_line":"#   cases, increase the load on the server. This is to set to false only after the"},{"line_number":39,"context_line":"#   server is fully setup."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"f01e4794_da008197","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":35},"in_reply_to":"31485fe6_115e1d20","updated":"2021-06-15 12:44:58.000000000","message":"Done","commit_id":"69b278b09bb075eeea5a46e73a994a8ae4a9ed5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9238fd287be8a3c225a7d2febbb0897637e52412","unresolved":true,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*manage_partition_and_filesystem*]"},{"line_number":37,"context_line":"#   (optional) If set to false, skip calling parted ans mkfs.xfs, which can, in some"},{"line_number":38,"context_line":"#   cases, increase the load on the server. This is to set to false only after the"},{"line_number":39,"context_line":"#   server is fully setup."},{"line_number":40,"context_line":"#   Defaults to true."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# \u003dExample\u003d"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"6f134815_da231c80","line":39,"range":{"start_line":38,"start_character":44,"end_line":39,"end_character":26},"updated":"2021-06-15 12:17:26.000000000","message":"Please update this as well accoding to my suggestion in the other file.","commit_id":"69b278b09bb075eeea5a46e73a994a8ae4a9ed5e"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"c668dbbd7c82dbbad250b9538e2cfe81a277c8bf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*manage_partition_and_filesystem*]"},{"line_number":37,"context_line":"#   (optional) If set to false, skip calling parted ans mkfs.xfs, which can, in some"},{"line_number":38,"context_line":"#   cases, increase the load on the server. This is to set to false only after the"},{"line_number":39,"context_line":"#   server is fully setup."},{"line_number":40,"context_line":"#   Defaults to true."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# \u003dExample\u003d"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"f7ceee57_d7ad3a6c","line":39,"range":{"start_line":38,"start_character":44,"end_line":39,"end_character":26},"in_reply_to":"6f134815_da231c80","updated":"2021-06-15 12:44:58.000000000","message":"Done","commit_id":"69b278b09bb075eeea5a46e73a994a8ae4a9ed5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9be2dac54d02e361d60ba58c08e3eb507249bf9a","unresolved":true,"context_lines":[{"line_number":36,"context_line":"# [*manage_partition*]"},{"line_number":37,"context_line":"#   (optional) If set to false, skip calling parted which can, in some cases,"},{"line_number":38,"context_line":"#   increase the load on the server. This is to set to false only after the"},{"line_number":39,"context_line":"#   server is fully setup."},{"line_number":40,"context_line":"#   Defaults to true."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*manage_filesystem*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"aacc1080_d4590dd3","line":39,"range":{"start_line":39,"start_character":25,"end_line":39,"end_character":26},"updated":"2021-06-15 13:13:13.000000000","message":"or if the partition was created outside of puppet.","commit_id":"cef461860d8ceb217273609234c051be3daac38f"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"9433fd46710ce3e826ec84e035cc94a87f368091","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# [*manage_partition*]"},{"line_number":37,"context_line":"#   (optional) If set to false, skip calling parted which can, in some cases,"},{"line_number":38,"context_line":"#   increase the load on the server. This is to set to false only after the"},{"line_number":39,"context_line":"#   server is fully setup."},{"line_number":40,"context_line":"#   Defaults to true."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*manage_filesystem*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1e9b2afa_122741fa","line":39,"range":{"start_line":39,"start_character":25,"end_line":39,"end_character":26},"in_reply_to":"aacc1080_d4590dd3","updated":"2021-06-15 13:16:44.000000000","message":"Done","commit_id":"cef461860d8ceb217273609234c051be3daac38f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9be2dac54d02e361d60ba58c08e3eb507249bf9a","unresolved":true,"context_lines":[{"line_number":88,"context_line":"      onlyif  \u003d\u003e [\"test -b ${base_dir}/${name}\",\"parted ${base_dir}/${name} print|tail -1|grep \u0027Error\u0027\"],"},{"line_number":89,"context_line":"      before  \u003d\u003e Anchor[\u0027swift::config::end\u0027],"},{"line_number":90,"context_line":"    }"},{"line_number":91,"context_line":"    Exec[\"create_partition_label-${name}\"] ~\u003e Class[\u0027swift::storage::xfs\u0027]"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  swift::storage::xfs { $name:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"91460ac7_3e395854","line":91,"range":{"start_line":91,"start_character":46,"end_line":91,"end_character":51},"updated":"2021-06-15 13:13:13.000000000","message":"This is not the class so this should be something like\n\nSwift::Storage::Xfs[${name}]\n\nor \n\nSwift::Storage::Xfs\u003c| title \u003d\u003d $name |\u003e\n\nI guess","commit_id":"cef461860d8ceb217273609234c051be3daac38f"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"9433fd46710ce3e826ec84e035cc94a87f368091","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      onlyif  \u003d\u003e [\"test -b ${base_dir}/${name}\",\"parted ${base_dir}/${name} print|tail -1|grep \u0027Error\u0027\"],"},{"line_number":89,"context_line":"      before  \u003d\u003e Anchor[\u0027swift::config::end\u0027],"},{"line_number":90,"context_line":"    }"},{"line_number":91,"context_line":"    Exec[\"create_partition_label-${name}\"] ~\u003e Class[\u0027swift::storage::xfs\u0027]"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  swift::storage::xfs { $name:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"cc835e14_2de814f8","line":91,"range":{"start_line":91,"start_character":46,"end_line":91,"end_character":51},"in_reply_to":"91460ac7_3e395854","updated":"2021-06-15 13:16:44.000000000","message":"Done","commit_id":"cef461860d8ceb217273609234c051be3daac38f"}],"manifests/storage/xfs.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6d53e2cfd46d554ec8766ea582695385550e0016","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  $mnt_base_dir        \u003d \u0027/srv/node\u0027,"},{"line_number":46,"context_line":"  $loopback            \u003d false,"},{"line_number":47,"context_line":"  $mount_type          \u003d \u0027path\u0027,"},{"line_number":48,"context_line":"  $run_parted_and_mkfs \u003d true,"},{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  include swift::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"848953ab_0dad4ea2","line":48,"range":{"start_line":48,"start_character":3,"end_line":48,"end_character":22},"updated":"2021-06-15 11:31:01.000000000","message":"Because this resource type doesn\u0027t manage xfs filesystem, this name looks a little confusing.\nHowe about renaming this to manage_filesystem ?","commit_id":"fe6036e150954d5876c8bd88e86ebab86a1e0a5a"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a38264c5ee0365a869f522e62bf6acaa2d41b550","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  $mnt_base_dir        \u003d \u0027/srv/node\u0027,"},{"line_number":46,"context_line":"  $loopback            \u003d false,"},{"line_number":47,"context_line":"  $mount_type          \u003d \u0027path\u0027,"},{"line_number":48,"context_line":"  $run_parted_and_mkfs \u003d true,"},{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  include swift::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1b8e34a5_dc4bf2c5","line":48,"range":{"start_line":48,"start_character":3,"end_line":48,"end_character":22},"in_reply_to":"848953ab_0dad4ea2","updated":"2021-06-15 11:48:53.000000000","message":"Done","commit_id":"fe6036e150954d5876c8bd88e86ebab86a1e0a5a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9238fd287be8a3c225a7d2febbb0897637e52412","unresolved":true,"context_lines":[{"line_number":22,"context_line":"#   Defaults to \u0027path\u0027."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*manage_filesystem*]"},{"line_number":25,"context_line":"#   (optional) If set to false, skip calling parted ans mkfs.xfs, which can, in some"},{"line_number":26,"context_line":"#   cases, increase the load on the server. This is to set to false only after the"},{"line_number":27,"context_line":"#   server is fully setup."},{"line_number":28,"context_line":"#   Defaults to true."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bf05b2c7_e7e8ebcf","line":25,"range":{"start_line":25,"start_character":45,"end_line":25,"end_character":55},"updated":"2021-06-15 12:17:26.000000000","message":"Remove this.","commit_id":"69b278b09bb075eeea5a46e73a994a8ae4a9ed5e"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"c668dbbd7c82dbbad250b9538e2cfe81a277c8bf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   Defaults to \u0027path\u0027."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*manage_filesystem*]"},{"line_number":25,"context_line":"#   (optional) If set to false, skip calling parted ans mkfs.xfs, which can, in some"},{"line_number":26,"context_line":"#   cases, increase the load on the server. This is to set to false only after the"},{"line_number":27,"context_line":"#   server is fully setup."},{"line_number":28,"context_line":"#   Defaults to true."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"269a225d_45c1541f","line":25,"range":{"start_line":25,"start_character":45,"end_line":25,"end_character":55},"in_reply_to":"bf05b2c7_e7e8ebcf","updated":"2021-06-15 12:44:58.000000000","message":"Done","commit_id":"69b278b09bb075eeea5a46e73a994a8ae4a9ed5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9238fd287be8a3c225a7d2febbb0897637e52412","unresolved":true,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*manage_filesystem*]"},{"line_number":25,"context_line":"#   (optional) If set to false, skip calling parted ans mkfs.xfs, which can, in some"},{"line_number":26,"context_line":"#   cases, increase the load on the server. This is to set to false only after the"},{"line_number":27,"context_line":"#   server is fully setup."},{"line_number":28,"context_line":"#   Defaults to true."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# Sample usage:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"35d13288_c1c409c1","line":27,"range":{"start_line":26,"start_character":44,"end_line":27,"end_character":26},"updated":"2021-06-15 12:17:26.000000000","message":"When this parameter is set to false the filesystem should be created outside of puppet.","commit_id":"69b278b09bb075eeea5a46e73a994a8ae4a9ed5e"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"c668dbbd7c82dbbad250b9538e2cfe81a277c8bf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*manage_filesystem*]"},{"line_number":25,"context_line":"#   (optional) If set to false, skip calling parted ans mkfs.xfs, which can, in some"},{"line_number":26,"context_line":"#   cases, increase the load on the server. This is to set to false only after the"},{"line_number":27,"context_line":"#   server is fully setup."},{"line_number":28,"context_line":"#   Defaults to true."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# Sample usage:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"91e8fff9_32b19482","line":27,"range":{"start_line":26,"start_character":44,"end_line":27,"end_character":26},"in_reply_to":"35d13288_c1c409c1","updated":"2021-06-15 12:44:58.000000000","message":"Done","commit_id":"69b278b09bb075eeea5a46e73a994a8ae4a9ed5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9be2dac54d02e361d60ba58c08e3eb507249bf9a","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    Package\u003c| title \u003d\u003d \u0027xfsprogs\u0027 |\u003e"},{"line_number":96,"context_line":"    ~\u003e Exec\u003c| title \u003d\u003d \"mkfs-${name}\" |\u003e"},{"line_number":97,"context_line":"    ~\u003e Swift::Storage::Mount\u003c| title \u003d\u003d $name |\u003e"},{"line_number":98,"context_line":"  }else{"},{"line_number":99,"context_line":"    Package\u003c| title \u003d\u003d \u0027xfsprogs\u0027 |\u003e"},{"line_number":100,"context_line":"    ~\u003e Swift::Storage::Mount\u003c| title \u003d\u003d $name |\u003e"},{"line_number":101,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"c2685df4_753ec0fa","line":98,"range":{"start_line":98,"start_character":3,"end_line":98,"end_character":7},"updated":"2021-06-15 13:13:13.000000000","message":"(nit) Please add one space before and after else like\n\n} else {","commit_id":"cef461860d8ceb217273609234c051be3daac38f"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"9433fd46710ce3e826ec84e035cc94a87f368091","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    Package\u003c| title \u003d\u003d \u0027xfsprogs\u0027 |\u003e"},{"line_number":96,"context_line":"    ~\u003e Exec\u003c| title \u003d\u003d \"mkfs-${name}\" |\u003e"},{"line_number":97,"context_line":"    ~\u003e Swift::Storage::Mount\u003c| title \u003d\u003d $name |\u003e"},{"line_number":98,"context_line":"  }else{"},{"line_number":99,"context_line":"    Package\u003c| title \u003d\u003d \u0027xfsprogs\u0027 |\u003e"},{"line_number":100,"context_line":"    ~\u003e Swift::Storage::Mount\u003c| title \u003d\u003d $name |\u003e"},{"line_number":101,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"4429a6af_653fde7e","line":98,"range":{"start_line":98,"start_character":3,"end_line":98,"end_character":7},"in_reply_to":"c2685df4_753ec0fa","updated":"2021-06-15 13:16:44.000000000","message":"Done","commit_id":"cef461860d8ceb217273609234c051be3daac38f"}]}