)]}'
{"manifests/ringserver.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a7bca3a61f58b08000b6bc3b22eb1b52cc9fd42f","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  include swift::deps"},{"line_number":39,"context_line":"  Class[\u0027swift::ringbuilder\u0027] -\u003e Class[\u0027swift::ringserver\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  # Since CentOS 8, rsyncd systemd unit is shipped in a different package."},{"line_number":42,"context_line":"  if !$rsync_use_xinetd {"},{"line_number":43,"context_line":"    if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and (Integer($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027])) \u003e\u003d 8) {"},{"line_number":44,"context_line":"      ensure_packages(\u0027rsync-daemon\u0027, {"},{"line_number":45,"context_line":"        ensure \u003d\u003e present,"},{"line_number":46,"context_line":"        before \u003d\u003e Class[\u0027rsync::server\u0027]})"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if !defined(Class[\u0027rsync::server\u0027]) {"},{"line_number":51,"context_line":"    class { \u0027rsync::server\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"53e2e7ea_c83587b8","line":48,"range":{"start_line":41,"start_character":0,"end_line":48,"end_character":3},"updated":"2021-06-15 11:49:07.000000000","message":"IMO we should implement this not here but in puppetlabs-rsync, because rsync package is currently managed by that external module.","commit_id":"e6a4b047d282f76dedeb884a38fb3613f781cd07"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe68428034c00db8eb9eeed8c120d21e8b847be2","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  include swift::deps"},{"line_number":39,"context_line":"  Class[\u0027swift::ringbuilder\u0027] -\u003e Class[\u0027swift::ringserver\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  # Since CentOS 8, rsyncd systemd unit is shipped in a different package."},{"line_number":42,"context_line":"  if !$rsync_use_xinetd {"},{"line_number":43,"context_line":"    if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and (Integer($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027])) \u003e\u003d 8) {"},{"line_number":44,"context_line":"      ensure_packages(\u0027rsync-daemon\u0027, {"},{"line_number":45,"context_line":"        ensure \u003d\u003e present,"},{"line_number":46,"context_line":"        before \u003d\u003e Class[\u0027rsync::server\u0027]})"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if !defined(Class[\u0027rsync::server\u0027]) {"},{"line_number":51,"context_line":"    class { \u0027rsync::server\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"8dd1565a_02fe60b9","line":48,"range":{"start_line":41,"start_character":0,"end_line":48,"end_character":3},"in_reply_to":"09f61911_b01a46d8","updated":"2021-06-15 12:13:08.000000000","message":"I\u0027ve let a comment on that PR to ping the person who approved the last PR... let\u0027s see how it goes. If that module is no longer maintained then we should seriously consider replacing it...","commit_id":"e6a4b047d282f76dedeb884a38fb3613f781cd07"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b830497246a7401e6d544557dd44a01f10ede1e0","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  include swift::deps"},{"line_number":39,"context_line":"  Class[\u0027swift::ringbuilder\u0027] -\u003e Class[\u0027swift::ringserver\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  # Since CentOS 8, rsyncd systemd unit is shipped in a different package."},{"line_number":42,"context_line":"  if !$rsync_use_xinetd {"},{"line_number":43,"context_line":"    if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and (Integer($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027])) \u003e\u003d 8) {"},{"line_number":44,"context_line":"      ensure_packages(\u0027rsync-daemon\u0027, {"},{"line_number":45,"context_line":"        ensure \u003d\u003e present,"},{"line_number":46,"context_line":"        before \u003d\u003e Class[\u0027rsync::server\u0027]})"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if !defined(Class[\u0027rsync::server\u0027]) {"},{"line_number":51,"context_line":"    class { \u0027rsync::server\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9e4ff4ad_138b787a","line":48,"range":{"start_line":41,"start_character":0,"end_line":48,"end_character":3},"in_reply_to":"53e2e7ea_c83587b8","updated":"2021-06-15 11:50:45.000000000","message":"As is proposed by Alfredo here...\n\nhttps://github.com/puppetlabs/puppetlabs-rsync/pull/139","commit_id":"e6a4b047d282f76dedeb884a38fb3613f781cd07"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"9ae11b9071675f98c202befd053ca70ff1182cb9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  include swift::deps"},{"line_number":39,"context_line":"  Class[\u0027swift::ringbuilder\u0027] -\u003e Class[\u0027swift::ringserver\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  # Since CentOS 8, rsyncd systemd unit is shipped in a different package."},{"line_number":42,"context_line":"  if !$rsync_use_xinetd {"},{"line_number":43,"context_line":"    if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and (Integer($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027])) \u003e\u003d 8) {"},{"line_number":44,"context_line":"      ensure_packages(\u0027rsync-daemon\u0027, {"},{"line_number":45,"context_line":"        ensure \u003d\u003e present,"},{"line_number":46,"context_line":"        before \u003d\u003e Class[\u0027rsync::server\u0027]})"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if !defined(Class[\u0027rsync::server\u0027]) {"},{"line_number":51,"context_line":"    class { \u0027rsync::server\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"b479b074_5b25c556","line":48,"range":{"start_line":41,"start_character":0,"end_line":48,"end_character":3},"in_reply_to":"8dd1565a_02fe60b9","updated":"2021-09-28 09:31:12.000000000","message":"It\u0027s now updated in PS9","commit_id":"e6a4b047d282f76dedeb884a38fb3613f781cd07"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"5936bfab7741ee389e5e0d19c0dc2ef0cfacfb8f","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  include swift::deps"},{"line_number":39,"context_line":"  Class[\u0027swift::ringbuilder\u0027] -\u003e Class[\u0027swift::ringserver\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  # Since CentOS 8, rsyncd systemd unit is shipped in a different package."},{"line_number":42,"context_line":"  if !$rsync_use_xinetd {"},{"line_number":43,"context_line":"    if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and (Integer($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027])) \u003e\u003d 8) {"},{"line_number":44,"context_line":"      ensure_packages(\u0027rsync-daemon\u0027, {"},{"line_number":45,"context_line":"        ensure \u003d\u003e present,"},{"line_number":46,"context_line":"        before \u003d\u003e Class[\u0027rsync::server\u0027]})"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if !defined(Class[\u0027rsync::server\u0027]) {"},{"line_number":51,"context_line":"    class { \u0027rsync::server\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"09f61911_b01a46d8","line":48,"range":{"start_line":41,"start_character":0,"end_line":48,"end_character":3},"in_reply_to":"9e4ff4ad_138b787a","updated":"2021-06-15 11:53:42.000000000","message":"yes, i agree that rsync module is better but it seems that gate is mostly broken and tbh, i\u0027m not getting any attention from maintainers. Any idea about how to get it merged?","commit_id":"e6a4b047d282f76dedeb884a38fb3613f781cd07"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"59368efd129a48d1fc2e94f78f1a306c0e12a65e","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  $local_net_ip,"},{"line_number":35,"context_line":"  $max_connections \u003d 5,"},{"line_number":36,"context_line":"  $rsync_use_xinetd \u003d $::swift::params::xinetd_available,"},{"line_number":37,"context_line":") {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  include swift::deps"},{"line_number":40,"context_line":"  Class[\u0027swift::ringbuilder\u0027] -\u003e Class[\u0027swift::ringserver\u0027]"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7159ae12_e84d3b0c","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":1},"updated":"2021-09-30 11:05:57.000000000","message":"this class should inherit swift::params to access the parameter from swift::params to initialize the parameters.","commit_id":"230596cb6fb09ef7f9cbf70ed010c48a184450b2"}],"manifests/storage.pp":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"3ecb3ce70aec006cf569b3a509c15c09f34dc55b","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  # Since CentOS 8, rsyncd systemd unit is shipped in a different package."},{"line_number":34,"context_line":"  if !$rsync_use_xinetd {"},{"line_number":35,"context_line":"    if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and (Integer($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027])) \u003e\u003d 8) {"},{"line_number":36,"context_line":"      package { \u0027rsync-daemon\u0027:"},{"line_number":37,"context_line":"        ensure \u003d\u003e present,"},{"line_number":38,"context_line":"        before \u003d\u003e Class[\u0027rsync::server\u0027],"},{"line_number":39,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"c61d2d4d_087d255f","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":31},"updated":"2021-06-11 11:13:19.000000000","message":"i think you should use ensure_package or ensure_resource or it will fail with duplicate declaration in case both manifests are included with rsync_use_xinetd to false","commit_id":"5c1b14969aafd24403cb3411d8ffeba23ce92ef9"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"291cda18d78098c4e25343b717c3919f7541d61e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  # Since CentOS 8, rsyncd systemd unit is shipped in a different package."},{"line_number":34,"context_line":"  if !$rsync_use_xinetd {"},{"line_number":35,"context_line":"    if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and (Integer($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027])) \u003e\u003d 8) {"},{"line_number":36,"context_line":"      package { \u0027rsync-daemon\u0027:"},{"line_number":37,"context_line":"        ensure \u003d\u003e present,"},{"line_number":38,"context_line":"        before \u003d\u003e Class[\u0027rsync::server\u0027],"},{"line_number":39,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fd3d288e_34cd8799","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":31},"in_reply_to":"c61d2d4d_087d255f","updated":"2021-06-11 12:22:24.000000000","message":"Ok I understand now, I updated it in PS8","commit_id":"5c1b14969aafd24403cb3411d8ffeba23ce92ef9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"59368efd129a48d1fc2e94f78f1a306c0e12a65e","unresolved":true,"context_lines":[{"line_number":27,"context_line":"class swift::storage("},{"line_number":28,"context_line":"  $storage_local_net_ip,"},{"line_number":29,"context_line":"  $rsync_use_xinetd \u003d $::swift::params::xinetd_available,"},{"line_number":30,"context_line":") {"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include swift::deps"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ccc4120a_0c1899c8","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":3},"updated":"2021-09-30 11:05:57.000000000","message":"ditto","commit_id":"230596cb6fb09ef7f9cbf70ed010c48a184450b2"}],"manifests/storage/all.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"59368efd129a48d1fc2e94f78f1a306c0e12a65e","unresolved":true,"context_lines":[{"line_number":154,"context_line":"  $splice                         \u003d false,"},{"line_number":155,"context_line":"  $max_connections                \u003d 25,"},{"line_number":156,"context_line":"  $rsync_use_xinetd               \u003d $::swift::params::xinetd_available,"},{"line_number":157,"context_line":") {"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  include swift::deps"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"9f2d1520_6619dc50","line":157,"range":{"start_line":157,"start_character":2,"end_line":157,"end_character":3},"updated":"2021-09-30 11:05:57.000000000","message":"ditto","commit_id":"230596cb6fb09ef7f9cbf70ed010c48a184450b2"}],"releasenotes/notes/switch_rsync_use_xinetd-a3c857e5ef13b0a8.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fdab6dd23d0c6279bbb2d80b6490bbb88a024383","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add the ability to switch rsync_use_xinetd (i.e true/false)"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"23e56f64_24007ee5","line":1,"updated":"2021-10-01 07:18:28.000000000","message":"I\u0027d prefer mentioning specific classes to help users understand the new interface more easily.","commit_id":"73c62d02e8489aa67c139d3fd55b275dddb80eb6"}],"spec/classes/swift_ringserver_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"59368efd129a48d1fc2e94f78f1a306c0e12a65e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"WebMock.disable_net_connect!(:allow \u003d\u003e \"169.254.169.254\")"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"describe \u0027swift::ringserver\u0027 do"},{"line_number":7,"context_line":"  let :params do"},{"line_number":8,"context_line":"    { :local_net_ip      \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":9,"context_line":"      :max_connections   \u003d\u003e 5,"},{"line_number":10,"context_line":"      :rsync_use_xinetd  \u003d\u003e true,"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"  end"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  shared_examples \u0027swift::ringserver\u0027 do"},{"line_number":15,"context_line":"    context \u0027when storage.pp was already included\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"ee7e9d56_c6633f8d","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":5},"updated":"2021-09-30 11:05:57.000000000","message":"I don\u0027t see much benefit of this change.\n\nthis can be kept now. We need to fix this when we add support for CentOS9 but we can leave it as TODO.","commit_id":"230596cb6fb09ef7f9cbf70ed010c48a184450b2"}]}