)]}'
{"manifests/proxy/keystone.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"daa7023aa1910761b5198e3a8bc1079219123ffb","unresolved":true,"context_lines":[{"line_number":19,"context_line":"#    This role defines who has the ability to manage other swift accounts."},{"line_number":20,"context_line":"#    (Optional)"},{"line_number":21,"context_line":"#    Defaults to Undef."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"#  [*system_reader_roles*]"},{"line_number":24,"context_line":"#    System reader roles are similar to reseller_admin_roles, but are not"},{"line_number":25,"context_line":"#    allowed to write any data."},{"line_number":26,"context_line":"#    (Optional)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"b978332c_f7fa9799","line":23,"range":{"start_line":22,"start_character":1,"end_line":23,"end_character":26},"updated":"2021-08-27 13:22:08.000000000","message":"Please insert these parameters into the consistent position.","commit_id":"382326405f2b423f56d353a2ce019321cbb4f2d2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"daa7023aa1910761b5198e3a8bc1079219123ffb","unresolved":true,"context_lines":[{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"class swift::proxy::keystone("},{"line_number":41,"context_line":"  $operator_roles      \u003d [\u0027admin\u0027, \u0027SwiftOperator\u0027],"},{"line_number":42,"context_line":"  $system_reader_roles \u003d [],"},{"line_number":43,"context_line":"  $project_reader_roles \u003d [],"},{"line_number":44,"context_line":"  $reseller_prefix     \u003d \u0027AUTH_\u0027,"},{"line_number":45,"context_line":"  $reseller_admin_role \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"cd7a1dc5_2edf17dc","line":42,"range":{"start_line":42,"start_character":25,"end_line":42,"end_character":28},"updated":"2021-08-27 13:22:08.000000000","message":"So this definition makes the parameter set by an empty value.\n https://zuul.opendev.org/t/openstack/build/cf5fda79b91e4d58a91a17ea5ff3ea88/log/logs/etc/swift/proxy-server.conf.txt#115-116\n\nIf we can just rely on the default defined in swift, $::os_service_default would be a better option here.","commit_id":"382326405f2b423f56d353a2ce019321cbb4f2d2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"daa7023aa1910761b5198e3a8bc1079219123ffb","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  $operator_roles      \u003d [\u0027admin\u0027, \u0027SwiftOperator\u0027],"},{"line_number":42,"context_line":"  $system_reader_roles \u003d [],"},{"line_number":43,"context_line":"  $project_reader_roles \u003d [],"},{"line_number":44,"context_line":"  $reseller_prefix     \u003d \u0027AUTH_\u0027,"},{"line_number":45,"context_line":"  $reseller_admin_role \u003d undef,"},{"line_number":46,"context_line":") {"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4e426bbd_65a4a692","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":24},"updated":"2021-08-27 13:22:08.000000000","message":"It\u0027d better align \"\u003d\" to follow standard style.","commit_id":"382326405f2b423f56d353a2ce019321cbb4f2d2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"daa7023aa1910761b5198e3a8bc1079219123ffb","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    \u0027filter:keystone/use\u0027:                 value \u003d\u003e \u0027egg:swift#keystoneauth\u0027;"},{"line_number":52,"context_line":"    \u0027filter:keystone/operator_roles\u0027:      value \u003d\u003e join(any2array($operator_roles), \u0027, \u0027);"},{"line_number":53,"context_line":"    \u0027filter:keystone/system_reader_roles\u0027: value \u003d\u003e join(any2array($system_reader_roles), \u0027, \u0027);"},{"line_number":54,"context_line":"    \u0027filter:keystone/project_reader_roles\u0027:value \u003d\u003e join(any2array($project_reader_roles), \u0027, \u0027);"},{"line_number":55,"context_line":"    \u0027filter:keystone/reseller_prefix\u0027:     value \u003d\u003e $reseller_prefix;"},{"line_number":56,"context_line":"    \u0027filter:keystone/reseller_admin_role\u0027: value \u003d\u003e $reseller_admin_role;"},{"line_number":57,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fdc068a_7b84412b","line":54,"updated":"2021-08-27 13:22:08.000000000","message":"put one space and align \"value \u003d\u003e\"","commit_id":"382326405f2b423f56d353a2ce019321cbb4f2d2"}],"spec/classes/swift_proxy_keystone_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"daa7023aa1910761b5198e3a8bc1079219123ffb","unresolved":true,"context_lines":[{"line_number":15,"context_line":"          :operator_roles      \u003d\u003e \u0027foo\u0027,"},{"line_number":16,"context_line":"          :reseller_prefix     \u003d\u003e \u0027SWIFT_\u0027,"},{"line_number":17,"context_line":"          :reseller_admin_role \u003d\u003e \u0027ResellerAdmin\u0027,"},{"line_number":18,"context_line":"\t  :system_reader_roles \u003d\u003e [\u0027SwiftSystemReader\u0027],"},{"line_number":19,"context_line":"\t  :project_reader_roles \u003d\u003e [\u0027SwiftProjectReader\u0027]"},{"line_number":20,"context_line":"        }"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"8e3ce91a_b1651db2","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":3},"updated":"2021-08-27 13:22:08.000000000","message":"Please use space instead of tab.","commit_id":"382326405f2b423f56d353a2ce019321cbb4f2d2"}]}