)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f99cb1b5145ec099baf0b2a995aa504e583d24a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ae74edf_f42e9fc7","updated":"2021-12-14 05:33:08.000000000","message":"Please add a release note file to explain the new parameters.\n\nAlso, it\u0027d be nice if you can add test cases to spec/defines/swift_storage_server_spec.rb as well","commit_id":"76bc6185ca61b7c1c12400a15cdaf70cd61ca58c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"34ef657d8938e0b07e525beab6371e5460df63b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ddd5e911_6067e7e9","updated":"2021-12-17 05:30:03.000000000","message":"It seems there is an actual issue with this patch.","commit_id":"3347aedd99fa482f5d12e5654536b539801fa0b8"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"f78ea5d236011b3d49f3b85e8a3f32f3c3c7d783","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"442f2818_29840915","updated":"2021-12-17 04:20:29.000000000","message":"recheck","commit_id":"3347aedd99fa482f5d12e5654536b539801fa0b8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e82dd0a560f00105e28d83a0a5e2918293f9f9e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6b80e3a0_9ebd27ff","updated":"2021-12-16 02:12:07.000000000","message":"recheck","commit_id":"3347aedd99fa482f5d12e5654536b539801fa0b8"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"efb0ea43d744ce4f291eaf5e2a4b81546a470077","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6c13e2f3_fb8aaa4b","updated":"2021-12-15 23:15:05.000000000","message":"recheck","commit_id":"3347aedd99fa482f5d12e5654536b539801fa0b8"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"18a1fb36792ba06b2ef3dc84e1c1b85b90276ba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e3817bc2_3803219e","updated":"2021-12-16 06:02:28.000000000","message":"recheck","commit_id":"3347aedd99fa482f5d12e5654536b539801fa0b8"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"5bedab68e72ae180b559b6fd887e0555f3da1115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e52ef4ff_ef90e6ff","updated":"2021-12-15 03:57:45.000000000","message":"recheck","commit_id":"3347aedd99fa482f5d12e5654536b539801fa0b8"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"fc47bd8bb1bfecc54d7e9e19ce3b0327a607eb58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c1edb8b_ca422cb5","updated":"2021-12-19 22:29:01.000000000","message":"recheck","commit_id":"54c75b9f1f72f927d10edbaab7ddde4934b5e7e5"}],"manifests/storage/all.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"34ef657d8938e0b07e525beab6371e5460df63b9","unresolved":true,"context_lines":[{"line_number":108,"context_line":"#"},{"line_number":109,"context_line":"# [*rsync_timeout*]"},{"line_number":110,"context_line":"#   (optional) Max duration of a partition rsync."},{"line_number":111,"context_line":"#   Default to $::os_service_default"},{"line_number":112,"context_line":"#"},{"line_number":113,"context_line":"# [*rsync_bwlimit*]"},{"line_number":114,"context_line":"#   (optional) Bandwidth limit for rsync in kB/s. 0 means unlimited."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"a3b07e50_fbedc4cf","line":111,"range":{"start_line":111,"start_character":18,"end_line":111,"end_character":36},"updated":"2021-12-17 05:30:03.000000000","message":"This should not be $::os_service_default. This is passed to templating and directly put to the conf file.\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_69d/821646/3/check/puppet-swift-tripleo-standalone/69d446b/logs/undercloud/var/lib/config-data/puppet-generated/swift/etc/swift/object-server.conf","commit_id":"3347aedd99fa482f5d12e5654536b539801fa0b8"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"3356db55f9145df490ec9262c49bafe7ca43d314","unresolved":true,"context_lines":[{"line_number":108,"context_line":"#"},{"line_number":109,"context_line":"# [*rsync_timeout*]"},{"line_number":110,"context_line":"#   (optional) Max duration of a partition rsync."},{"line_number":111,"context_line":"#   Default to $::os_service_default"},{"line_number":112,"context_line":"#"},{"line_number":113,"context_line":"# [*rsync_bwlimit*]"},{"line_number":114,"context_line":"#   (optional) Bandwidth limit for rsync in kB/s. 0 means unlimited."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"32b7b347_4bbff4ee","line":111,"range":{"start_line":111,"start_character":18,"end_line":111,"end_character":36},"in_reply_to":"a3b07e50_fbedc4cf","updated":"2021-12-17 05:43:48.000000000","message":"Ah Thanks Takashi, did not know that can see this test conf. Will update the patch again.","commit_id":"3347aedd99fa482f5d12e5654536b539801fa0b8"}],"manifests/storage/server.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f99cb1b5145ec099baf0b2a995aa504e583d24a8","unresolved":true,"context_lines":[{"line_number":212,"context_line":"  $disk_chunk_size                \u003d 65536,"},{"line_number":213,"context_line":"  $client_timeout                 \u003d 60,"},{"line_number":214,"context_line":"  $auditor_disk_chunk_size        \u003d undef,"},{"line_number":215,"context_line":"  $rsync_timeout                  \u003d 900,"},{"line_number":216,"context_line":"  $rsync_bwlimit                  \u003d 0,"},{"line_number":217,"context_line":"  $splice                         \u003d false,"},{"line_number":218,"context_line":"  $object_server_mb_per_sync      \u003d 512,"},{"line_number":219,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ec1cfe93_05646c4c","line":216,"range":{"start_line":215,"start_character":0,"end_line":216,"end_character":38},"updated":"2021-12-14 05:33:08.000000000","message":"You should add documentation of these parameters.","commit_id":"76bc6185ca61b7c1c12400a15cdaf70cd61ca58c"}]}