)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ad361df251d38aea97c125a21d5937257c34209","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6eb51cd5_9bd55fee","updated":"2024-02-16 14:55:33.000000000","message":"Please also add unit tests and release note","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b08251239872bcc0973beb980b5f61f4809591e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e513a59_ed92f790","in_reply_to":"6eb51cd5_9bd55fee","updated":"2024-02-19 12:02:16.000000000","message":"Will do in the next patch iteration, pushing without the tests first, to see if the {\u0027ensure\u0027 \u003d\u003e \u0027absent\u0027} works or what (which will be in use since I\u0027m not forcing it to true during tests).","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1391d2e69dbeaadd7d7b6a428eec54ce869c6bc0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9396e34d_e2b427a3","updated":"2024-02-19 15:14:01.000000000","message":"Hopefully fixed unit tests and a few problems with current implementations. Please add release note","commit_id":"da170a3f6494bc59d7ccd140d46492e11fd6969f"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"58f120e2f70a2359a14fe6eff1458698aab073b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"91b2d32c_85de0b57","in_reply_to":"9396e34d_e2b427a3","updated":"2024-02-19 15:33:07.000000000","message":"Done","commit_id":"da170a3f6494bc59d7ccd140d46492e11fd6969f"}],"manifests/storage.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ad361df251d38aea97c125a21d5937257c34209","unresolved":true,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class swift::storage("},{"line_number":28,"context_line":"  $storage_local_net_ip,"},{"line_number":29,"context_line":"  $rsync_use_xinetd                  \u003d $::swift::params::xinetd_available,"},{"line_number":30,"context_line":"  Boolean $use_drive_full_checker    \u003d false,"},{"line_number":31,"context_line":"  String[1] $rsyncd_conf_source_path \u003d \u0027/etc/rsync_template.conf\u0027,"},{"line_number":32,"context_line":") inherits swift::params {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"8bdc8ef1_375cfebc","line":29,"updated":"2024-02-16 14:55:33.000000000","message":"unrelated change","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b08251239872bcc0973beb980b5f61f4809591e4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class swift::storage("},{"line_number":28,"context_line":"  $storage_local_net_ip,"},{"line_number":29,"context_line":"  $rsync_use_xinetd                  \u003d $::swift::params::xinetd_available,"},{"line_number":30,"context_line":"  Boolean $use_drive_full_checker    \u003d false,"},{"line_number":31,"context_line":"  String[1] $rsyncd_conf_source_path \u003d \u0027/etc/rsync_template.conf\u0027,"},{"line_number":32,"context_line":") inherits swift::params {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3ec8ccaa_1d07cbb9","line":29,"in_reply_to":"8bdc8ef1_375cfebc","updated":"2024-02-19 12:02:16.000000000","message":"Done","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"}],"manifests/storage/drive_full_checker.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ad361df251d38aea97c125a21d5937257c34209","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class swift::storage::drive_full_checker"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Set up swift-drive-full-checker cron job"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"70c481de_87544d29","line":1,"updated":"2024-02-16 14:55:33.000000000","message":"this is unrelated","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b08251239872bcc0973beb980b5f61f4809591e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class swift::storage::drive_full_checker"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Set up swift-drive-full-checker cron job"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"00130f4b_b61477cb","line":1,"in_reply_to":"70c481de_87544d29","updated":"2024-02-19 12:02:16.000000000","message":"Done","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"}],"manifests/storage/server.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ad361df251d38aea97c125a21d5937257c34209","unresolved":true,"context_lines":[{"line_number":172,"context_line":"#   (optional) Label used when logging."},{"line_number":173,"context_line":"#   Defaults to \"${type}-server\"."},{"line_number":174,"context_line":"#"},{"line_number":175,"context_line":"# [*per_daemon_log_name*]"},{"line_number":176,"context_line":"#   (optional) Should puppet-swift setup one logging name per type of daemon"},{"line_number":177,"context_line":"#   when logging to rsyslog."},{"line_number":178,"context_line":"#   For example: swift-container-replicator, swift-contaier-sharder, etc."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"202ab86f_982cfcbf","line":175,"range":{"start_line":175,"start_character":4,"end_line":175,"end_character":23},"updated":"2024-02-16 14:55:33.000000000","message":"I\u0027d suggest lon_name_per_daemon .","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b08251239872bcc0973beb980b5f61f4809591e4","unresolved":false,"context_lines":[{"line_number":172,"context_line":"#   (optional) Label used when logging."},{"line_number":173,"context_line":"#   Defaults to \"${type}-server\"."},{"line_number":174,"context_line":"#"},{"line_number":175,"context_line":"# [*per_daemon_log_name*]"},{"line_number":176,"context_line":"#   (optional) Should puppet-swift setup one logging name per type of daemon"},{"line_number":177,"context_line":"#   when logging to rsyslog."},{"line_number":178,"context_line":"#   For example: swift-container-replicator, swift-contaier-sharder, etc."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e549610f_67682469","line":175,"range":{"start_line":175,"start_character":4,"end_line":175,"end_character":23},"in_reply_to":"202ab86f_982cfcbf","updated":"2024-02-19 12:02:16.000000000","message":"Done","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ad361df251d38aea97c125a21d5937257c34209","unresolved":true,"context_lines":[{"line_number":514,"context_line":"          \u0027account-auditor/log_name\u0027    \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-account-auditor\u0027},"},{"line_number":515,"context_line":"          \u0027account-reaper/log_name\u0027     \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-account-reaper\u0027},"},{"line_number":516,"context_line":"        }"},{"line_number":517,"context_line":"      }"},{"line_number":518,"context_line":"    }"},{"line_number":519,"context_line":"    \u0027container\u0027: {"},{"line_number":520,"context_line":"      $type_opts \u003d {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"27f6cb39_58766b25","line":517,"range":{"start_line":517,"start_character":6,"end_line":517,"end_character":7},"updated":"2024-02-16 14:55:33.000000000","message":"please add resources for purge (`{\u0027ensure\u0027 \u003d\u003e absnet}`). Otherwise, if you apply manifests with per daemon true and then do same with per daemon false, the old settings are still left.","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b08251239872bcc0973beb980b5f61f4809591e4","unresolved":false,"context_lines":[{"line_number":514,"context_line":"          \u0027account-auditor/log_name\u0027    \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-account-auditor\u0027},"},{"line_number":515,"context_line":"          \u0027account-reaper/log_name\u0027     \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-account-reaper\u0027},"},{"line_number":516,"context_line":"        }"},{"line_number":517,"context_line":"      }"},{"line_number":518,"context_line":"    }"},{"line_number":519,"context_line":"    \u0027container\u0027: {"},{"line_number":520,"context_line":"      $type_opts \u003d {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"18a27b66_2fa6d871","line":517,"range":{"start_line":517,"start_character":6,"end_line":517,"end_character":7},"in_reply_to":"27f6cb39_58766b25","updated":"2024-02-19 12:02:16.000000000","message":"Done","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ad361df251d38aea97c125a21d5937257c34209","unresolved":true,"context_lines":[{"line_number":550,"context_line":"          \u0027container-sync/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-sync\u0027},"},{"line_number":551,"context_line":"          \u0027container-sharder/log_name\u0027    \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-sharder\u0027},"},{"line_number":552,"context_line":"        }"},{"line_number":553,"context_line":"      }"},{"line_number":554,"context_line":"    }"},{"line_number":555,"context_line":"    \u0027object\u0027: {"},{"line_number":556,"context_line":"      $type_opts \u003d {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"332b0856_594d193e","line":553,"range":{"start_line":553,"start_character":6,"end_line":553,"end_character":7},"updated":"2024-02-16 14:55:33.000000000","message":"ditto","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b08251239872bcc0973beb980b5f61f4809591e4","unresolved":false,"context_lines":[{"line_number":550,"context_line":"          \u0027container-sync/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-sync\u0027},"},{"line_number":551,"context_line":"          \u0027container-sharder/log_name\u0027    \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-sharder\u0027},"},{"line_number":552,"context_line":"        }"},{"line_number":553,"context_line":"      }"},{"line_number":554,"context_line":"    }"},{"line_number":555,"context_line":"    \u0027object\u0027: {"},{"line_number":556,"context_line":"      $type_opts \u003d {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"d9db7e36_41c2af38","line":553,"range":{"start_line":553,"start_character":6,"end_line":553,"end_character":7},"in_reply_to":"332b0856_594d193e","updated":"2024-02-19 12:02:16.000000000","message":"Done","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ad361df251d38aea97c125a21d5937257c34209","unresolved":true,"context_lines":[{"line_number":587,"context_line":"          \u0027object-expirer/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-expirer\u0027},"},{"line_number":588,"context_line":"          \u0027object-relinker/log_name\u0027      \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-relinker\u0027},"},{"line_number":589,"context_line":"        }"},{"line_number":590,"context_line":"      }"},{"line_number":591,"context_line":"    }"},{"line_number":592,"context_line":"    default: {"},{"line_number":593,"context_line":"      # nothing to do"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"2a0fbe91_d6159c42","line":590,"range":{"start_line":590,"start_character":6,"end_line":590,"end_character":7},"updated":"2024-02-16 14:55:33.000000000","message":"ditto","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b08251239872bcc0973beb980b5f61f4809591e4","unresolved":false,"context_lines":[{"line_number":587,"context_line":"          \u0027object-expirer/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-expirer\u0027},"},{"line_number":588,"context_line":"          \u0027object-relinker/log_name\u0027      \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-relinker\u0027},"},{"line_number":589,"context_line":"        }"},{"line_number":590,"context_line":"      }"},{"line_number":591,"context_line":"    }"},{"line_number":592,"context_line":"    default: {"},{"line_number":593,"context_line":"      # nothing to do"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"936c8036_b23049b2","line":590,"range":{"start_line":590,"start_character":6,"end_line":590,"end_character":7},"in_reply_to":"2a0fbe91_d6159c42","updated":"2024-02-19 12:02:16.000000000","message":"Done","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ad361df251d38aea97c125a21d5937257c34209","unresolved":true,"context_lines":[{"line_number":598,"context_line":"    $common_opts,"},{"line_number":599,"context_line":"    $log_statsd_opts,"},{"line_number":600,"context_line":"    $type_opts,"},{"line_number":601,"context_line":"    $type_log_facility,"},{"line_number":602,"context_line":"  ), {"},{"line_number":603,"context_line":"    \u0027require\u0027 \u003d\u003e File[$config_file_full_path]"},{"line_number":604,"context_line":"  })"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"41281186_35df7275","line":601,"range":{"start_line":601,"start_character":5,"end_line":601,"end_character":22},"updated":"2024-02-16 14:55:33.000000000","message":"this is broken in case per_daemon_log_name is false","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b08251239872bcc0973beb980b5f61f4809591e4","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    $common_opts,"},{"line_number":599,"context_line":"    $log_statsd_opts,"},{"line_number":600,"context_line":"    $type_opts,"},{"line_number":601,"context_line":"    $type_log_facility,"},{"line_number":602,"context_line":"  ), {"},{"line_number":603,"context_line":"    \u0027require\u0027 \u003d\u003e File[$config_file_full_path]"},{"line_number":604,"context_line":"  })"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e2c03bbe_2904eb4a","line":601,"range":{"start_line":601,"start_character":5,"end_line":601,"end_character":22},"in_reply_to":"41281186_35df7275","updated":"2024-02-19 12:02:16.000000000","message":"It\u0027s not anymore in my next patch, since I\u0027ll have an else filling-up with {\u0027ensure\u0027 \u003d\u003e \u0027absent\u0027}.","commit_id":"b66fdc7862f803c8e352f00e5556aacf488f1ba5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8d313f7c58aea189f1108fb2f71610912b09262f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Define: swift::storage::server"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configures an account, container or object server"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"b6064efc_dbd42783","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"updated":"2024-02-19 15:08:17.000000000","message":"do not remove this","commit_id":"7a6179dad943e24bb4f9e6de2e81cf5bfd4bd058"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1391d2e69dbeaadd7d7b6a428eec54ce869c6bc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Define: swift::storage::server"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Configures an account, container or object server"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"16d3f610_964d2dee","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"in_reply_to":"b6064efc_dbd42783","updated":"2024-02-19 15:14:01.000000000","message":"Done","commit_id":"7a6179dad943e24bb4f9e6de2e81cf5bfd4bd058"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8d313f7c58aea189f1108fb2f71610912b09262f","unresolved":true,"context_lines":[{"line_number":598,"context_line":"          \u0027object-reconstructor/log_name\u0027 \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-reconstructor\u0027},"},{"line_number":599,"context_line":"          \u0027object-updater/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-updater\u0027},"},{"line_number":600,"context_line":"          \u0027object-auditor/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-auditor\u0027},"},{"line_number":601,"context_line":"          \u0027object-expirer/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-expirer\u0027},"},{"line_number":602,"context_line":"          \u0027object-relinker/log_name\u0027      \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-relinker\u0027},"},{"line_number":603,"context_line":"        }"},{"line_number":604,"context_line":"      } else {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"62646991_6560979c","line":601,"range":{"start_line":601,"start_character":11,"end_line":601,"end_character":34},"updated":"2024-02-19 15:08:17.000000000","message":"expirer is maintained by a separate class.","commit_id":"30f485f4f3949909d4e4dd1bd909dff16b4e2d8c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1391d2e69dbeaadd7d7b6a428eec54ce869c6bc0","unresolved":false,"context_lines":[{"line_number":598,"context_line":"          \u0027object-reconstructor/log_name\u0027 \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-reconstructor\u0027},"},{"line_number":599,"context_line":"          \u0027object-updater/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-updater\u0027},"},{"line_number":600,"context_line":"          \u0027object-auditor/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-auditor\u0027},"},{"line_number":601,"context_line":"          \u0027object-expirer/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-expirer\u0027},"},{"line_number":602,"context_line":"          \u0027object-relinker/log_name\u0027      \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-relinker\u0027},"},{"line_number":603,"context_line":"        }"},{"line_number":604,"context_line":"      } else {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"802d9370_0f3f11ac","line":601,"range":{"start_line":601,"start_character":11,"end_line":601,"end_character":34},"in_reply_to":"62646991_6560979c","updated":"2024-02-19 15:14:01.000000000","message":"Done","commit_id":"30f485f4f3949909d4e4dd1bd909dff16b4e2d8c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8d313f7c58aea189f1108fb2f71610912b09262f","unresolved":true,"context_lines":[{"line_number":599,"context_line":"          \u0027object-updater/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-updater\u0027},"},{"line_number":600,"context_line":"          \u0027object-auditor/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-auditor\u0027},"},{"line_number":601,"context_line":"          \u0027object-expirer/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-expirer\u0027},"},{"line_number":602,"context_line":"          \u0027object-relinker/log_name\u0027      \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-relinker\u0027},"},{"line_number":603,"context_line":"        }"},{"line_number":604,"context_line":"      } else {"},{"line_number":605,"context_line":"        $type_log_facility \u003d {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3299ec58_66c9c873","line":602,"range":{"start_line":602,"start_character":11,"end_line":602,"end_character":26},"updated":"2024-02-19 15:08:17.000000000","message":"we haven\u0027t yer support relinker.","commit_id":"30f485f4f3949909d4e4dd1bd909dff16b4e2d8c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1391d2e69dbeaadd7d7b6a428eec54ce869c6bc0","unresolved":false,"context_lines":[{"line_number":599,"context_line":"          \u0027object-updater/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-updater\u0027},"},{"line_number":600,"context_line":"          \u0027object-auditor/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-auditor\u0027},"},{"line_number":601,"context_line":"          \u0027object-expirer/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-expirer\u0027},"},{"line_number":602,"context_line":"          \u0027object-relinker/log_name\u0027      \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-object-relinker\u0027},"},{"line_number":603,"context_line":"        }"},{"line_number":604,"context_line":"      } else {"},{"line_number":605,"context_line":"        $type_log_facility \u003d {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1aad9d08_bfb568ee","line":602,"range":{"start_line":602,"start_character":11,"end_line":602,"end_character":26},"in_reply_to":"3299ec58_66c9c873","updated":"2024-02-19 15:14:01.000000000","message":"Done","commit_id":"30f485f4f3949909d4e4dd1bd909dff16b4e2d8c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"609d8702df4c07b1519305b341262b12eb34affe","unresolved":true,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"      if $log_name_per_daemon {"},{"line_number":554,"context_line":"        $log_name_opts \u003d {"},{"line_number":555,"context_line":"          \u0027container-auditor/log_name\u0027    \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-auditor\u0027},"},{"line_number":556,"context_line":"          \u0027container-replicator/log_name\u0027 \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-replicator\u0027},"},{"line_number":557,"context_line":"          \u0027container-updater/log_name\u0027    \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-updater\u0027},"},{"line_number":558,"context_line":"          \u0027container-sync/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-sync\u0027},"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"13917e20_f5482c1e","line":555,"range":{"start_line":555,"start_character":58,"end_line":555,"end_character":64},"updated":"2024-02-20 02:17:55.000000000","message":"we should remove \u0027swift-\u0027 prefix to keep consistency with server log names.","commit_id":"0072859db888563f7ed8d042008d1c86512fc362"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"edc1d45347b5e54a4229644aaf6495cbaf27d92b","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"      if $log_name_per_daemon {"},{"line_number":554,"context_line":"        $log_name_opts \u003d {"},{"line_number":555,"context_line":"          \u0027container-auditor/log_name\u0027    \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-auditor\u0027},"},{"line_number":556,"context_line":"          \u0027container-replicator/log_name\u0027 \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-replicator\u0027},"},{"line_number":557,"context_line":"          \u0027container-updater/log_name\u0027    \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-updater\u0027},"},{"line_number":558,"context_line":"          \u0027container-sync/log_name\u0027       \u003d\u003e {\u0027value\u0027 \u003d\u003e \u0027swift-container-sync\u0027},"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"16db8dab_cf2c899d","line":555,"range":{"start_line":555,"start_character":58,"end_line":555,"end_character":64},"in_reply_to":"13917e20_f5482c1e","updated":"2024-02-20 02:25:44.000000000","message":"Done","commit_id":"0072859db888563f7ed8d042008d1c86512fc362"}],"releasenotes/notes/log_name_per_daemon-6e2b522316ab38e4.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9fff5801b461506cd6ab5af5e934f13143eb194f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    By default, puppet-swift used to setup rsyslog logging using a single"},{"line_number":5,"context_line":"    log_name per type of service (swift-account, swift-container and"},{"line_number":6,"context_line":"    swift-object), meaning that all logs for a given server type where done in"},{"line_number":7,"context_line":"    a single file. If setting ``log_name_per_daemon`` to ``true``, it is now"},{"line_number":8,"context_line":"    possible to have different log_name depending on which daemon. For example,"},{"line_number":9,"context_line":"    for the object server, the object-replicator log_name will be"},{"line_number":10,"context_line":"    swift-object-replicator, the object-updater log_name will be"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3a88b2_f021a5ff","line":7,"range":{"start_line":7,"start_character":59,"end_line":7,"end_character":63},"updated":"2024-02-20 00:49:16.000000000","message":"True is python syntax while true is puppet syntax. `true` is better here because we are talking about the puppet parameter.","commit_id":"4cf2acdf1b8485faf7ab0fc94ffdf16a5b39a0f7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"874ab1668d1b7e4ab9a7b655ded28b1f14487e42","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    By default, puppet-swift used to setup rsyslog logging using a single"},{"line_number":5,"context_line":"    log_name per type of service (swift-account, swift-container and"},{"line_number":6,"context_line":"    swift-object), meaning that all logs for a given server type where done in"},{"line_number":7,"context_line":"    a single file. If setting ``log_name_per_daemon`` to ``true``, it is now"},{"line_number":8,"context_line":"    possible to have different log_name depending on which daemon. For example,"},{"line_number":9,"context_line":"    for the object server, the object-replicator log_name will be"},{"line_number":10,"context_line":"    swift-object-replicator, the object-updater log_name will be"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"08836acb_e6c2f072","line":7,"range":{"start_line":6,"start_character":19,"end_line":7,"end_character":18},"updated":"2024-02-20 02:23:11.000000000","message":"this part is not the behavior of puppet-swift but is specific to rsyslog configuration so should be removed from this note, IMO","commit_id":"0072859db888563f7ed8d042008d1c86512fc362"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"edc1d45347b5e54a4229644aaf6495cbaf27d92b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    By default, puppet-swift used to setup rsyslog logging using a single"},{"line_number":5,"context_line":"    log_name per type of service (swift-account, swift-container and"},{"line_number":6,"context_line":"    swift-object), meaning that all logs for a given server type where done in"},{"line_number":7,"context_line":"    a single file. If setting ``log_name_per_daemon`` to ``true``, it is now"},{"line_number":8,"context_line":"    possible to have different log_name depending on which daemon. For example,"},{"line_number":9,"context_line":"    for the object server, the object-replicator log_name will be"},{"line_number":10,"context_line":"    swift-object-replicator, the object-updater log_name will be"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"36d4aa1e_11fc7625","line":7,"range":{"start_line":6,"start_character":19,"end_line":7,"end_character":18},"in_reply_to":"08836acb_e6c2f072","updated":"2024-02-20 02:25:44.000000000","message":"Done","commit_id":"0072859db888563f7ed8d042008d1c86512fc362"}]}