)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4f1c541aa58f60dba0fb2e1a92e66a10a83e38df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa449e09_caa9da28","updated":"2024-06-16 03:01:44.000000000","message":"We also need a release note which explains the new parameter.","commit_id":"ee41198c879bdd76a3b48a7f9ade6ba45b495371"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"44228a81e52d207c3563834527d8ff5da541bf7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c1539e2_f116ead0","updated":"2024-06-13 13:52:48.000000000","message":"recheck","commit_id":"ee41198c879bdd76a3b48a7f9ade6ba45b495371"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"1f9ec34a29f224678657d6afc3c90e2994150daf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4a47a612_0cd7ccb9","in_reply_to":"aa449e09_caa9da28","updated":"2024-06-16 12:09:52.000000000","message":"Done","commit_id":"ee41198c879bdd76a3b48a7f9ade6ba45b495371"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"12541d34fca42d9178778922cd15514d635fe1da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4d1aa7d8_c2c6b391","updated":"2024-06-16 22:23:03.000000000","message":"Thanks for your patience and very good code review.","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":36866,"name":"Valentin Chassignol","display_name":"Vinetos","email":"contact@vinetos.fr","username":"vinetos"},"change_message_id":"b4991229fb4aa10ee3380751d19924e754f8dae3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2f535bc3_e10c0690","updated":"2024-06-19 08:31:30.000000000","message":"successfully tested and working on my side","commit_id":"3d72d3b0ea5fbdc9ac2ff7ad771d9ecd7557d0d5"}],"manifests/keymaster.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"38d41ac8f2c464a67e04f879214bd2b5482b1d7b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027kms_keymaster/user_domain_id\u0027:        value \u003d\u003e $user_domain_id;"},{"line_number":108,"context_line":"    \u0027kms_keymaster/meta_version_to_write\u0027: value \u003d\u003e $meta_version_to_write;"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":"  if $barbican_endpoint {"},{"line_number":111,"context_line":"    swift_keymaster_config {"},{"line_number":112,"context_line":"      \u0027kms_keymaster/barbican_endpoint\u0027: value \u003d\u003e $barbican_endpoint;"},{"line_number":113,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"78236a99_f4d9577f","line":110,"updated":"2024-06-13 14:15:12.000000000","message":"unless something has changed recent, setting $barbian_endpoint \u003d $facts[\u0027os_service_default\u0027] is this logic as if not specified it\u0027s removed from the config. I would use that rather than setting to undef","commit_id":"ee41198c879bdd76a3b48a7f9ade6ba45b495371"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4f1c541aa58f60dba0fb2e1a92e66a10a83e38df","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027kms_keymaster/user_domain_id\u0027:        value \u003d\u003e $user_domain_id;"},{"line_number":108,"context_line":"    \u0027kms_keymaster/meta_version_to_write\u0027: value \u003d\u003e $meta_version_to_write;"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":"  if $barbican_endpoint {"},{"line_number":111,"context_line":"    swift_keymaster_config {"},{"line_number":112,"context_line":"      \u0027kms_keymaster/barbican_endpoint\u0027: value \u003d\u003e $barbican_endpoint;"},{"line_number":113,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"373b3bdc_1f03413f","line":110,"in_reply_to":"78236a99_f4d9577f","updated":"2024-06-16 03:01:44.000000000","message":"+1","commit_id":"ee41198c879bdd76a3b48a7f9ade6ba45b495371"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3de8073cf7ba29f91fb75fd9e0c6f325825c6204","unresolved":true,"context_lines":[{"line_number":43,"context_line":"# [*barbican_endpoint*]"},{"line_number":44,"context_line":"#   (Optional) String. Endpoint of the barbican service. This is useful in"},{"line_number":45,"context_line":"#   a multi-region cluster, where Castellan otherwise doesn\u0027t know in what"},{"line_number":46,"context_line":"#   region is the key. If there is only a single region in the deployment,"},{"line_number":47,"context_line":"#   leave this to default."},{"line_number":48,"context_line":"#   Default to undef."},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# [*project_domain_name*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e32e4877_3ce9ddd0","line":47,"range":{"start_line":46,"start_character":23,"end_line":47,"end_character":26},"updated":"2024-06-16 13:02:47.000000000","message":"The parameter can be technically used in a single region deployment to avoid overhead of endpoint detection, so I\u0027d suggest removing this sentence.","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"12541d34fca42d9178778922cd15514d635fe1da","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# [*barbican_endpoint*]"},{"line_number":44,"context_line":"#   (Optional) String. Endpoint of the barbican service. This is useful in"},{"line_number":45,"context_line":"#   a multi-region cluster, where Castellan otherwise doesn\u0027t know in what"},{"line_number":46,"context_line":"#   region is the key. If there is only a single region in the deployment,"},{"line_number":47,"context_line":"#   leave this to default."},{"line_number":48,"context_line":"#   Default to undef."},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# [*project_domain_name*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ca66bd45_21b94a8c","line":47,"range":{"start_line":46,"start_character":23,"end_line":47,"end_character":26},"in_reply_to":"e32e4877_3ce9ddd0","updated":"2024-06-16 22:23:03.000000000","message":"I rephrased it to \"can be set to default\".","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3de8073cf7ba29f91fb75fd9e0c6f325825c6204","unresolved":true,"context_lines":[{"line_number":45,"context_line":"#   a multi-region cluster, where Castellan otherwise doesn\u0027t know in what"},{"line_number":46,"context_line":"#   region is the key. If there is only a single region in the deployment,"},{"line_number":47,"context_line":"#   leave this to default."},{"line_number":48,"context_line":"#   Default to undef."},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# [*project_domain_name*]"},{"line_number":51,"context_line":"#   (Optional) String. The project domain name may optionally be specified."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e7e09dff_9b68de82","line":48,"range":{"start_line":48,"start_character":15,"end_line":48,"end_character":20},"updated":"2024-06-16 13:02:47.000000000","message":"this needs to be updated.","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"12541d34fca42d9178778922cd15514d635fe1da","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#   a multi-region cluster, where Castellan otherwise doesn\u0027t know in what"},{"line_number":46,"context_line":"#   region is the key. If there is only a single region in the deployment,"},{"line_number":47,"context_line":"#   leave this to default."},{"line_number":48,"context_line":"#   Default to undef."},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# [*project_domain_name*]"},{"line_number":51,"context_line":"#   (Optional) String. The project domain name may optionally be specified."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"4ddeea90_90ca915f","line":48,"range":{"start_line":48,"start_character":15,"end_line":48,"end_character":20},"in_reply_to":"e7e09dff_9b68de82","updated":"2024-06-16 22:23:03.000000000","message":"Done","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3de8073cf7ba29f91fb75fd9e0c6f325825c6204","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    \u0027kms_keymaster/project_domain_id\u0027:     value \u003d\u003e $project_domain_id;"},{"line_number":107,"context_line":"    \u0027kms_keymaster/user_domain_id\u0027:        value \u003d\u003e $user_domain_id;"},{"line_number":108,"context_line":"    \u0027kms_keymaster/meta_version_to_write\u0027: value \u003d\u003e $meta_version_to_write;"},{"line_number":109,"context_line":"    \u0027kms_keymaster/barbican_endpoint\u0027: value \u003d\u003e $barbican_endpoint;"},{"line_number":110,"context_line":"  }"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"31200fa8_9e729df3","line":109,"updated":"2024-06-16 13:02:47.000000000","message":"please align value","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"12541d34fca42d9178778922cd15514d635fe1da","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    \u0027kms_keymaster/project_domain_id\u0027:     value \u003d\u003e $project_domain_id;"},{"line_number":107,"context_line":"    \u0027kms_keymaster/user_domain_id\u0027:        value \u003d\u003e $user_domain_id;"},{"line_number":108,"context_line":"    \u0027kms_keymaster/meta_version_to_write\u0027: value \u003d\u003e $meta_version_to_write;"},{"line_number":109,"context_line":"    \u0027kms_keymaster/barbican_endpoint\u0027: value \u003d\u003e $barbican_endpoint;"},{"line_number":110,"context_line":"  }"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"55ac3109_3a02b005","line":109,"in_reply_to":"09e1953f_92d9def6","updated":"2024-06-16 22:23:03.000000000","message":"Done","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ee4b7a1dd4bd394330be2499399f61cbf7d219f","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    \u0027kms_keymaster/project_domain_id\u0027:     value \u003d\u003e $project_domain_id;"},{"line_number":107,"context_line":"    \u0027kms_keymaster/user_domain_id\u0027:        value \u003d\u003e $user_domain_id;"},{"line_number":108,"context_line":"    \u0027kms_keymaster/meta_version_to_write\u0027: value \u003d\u003e $meta_version_to_write;"},{"line_number":109,"context_line":"    \u0027kms_keymaster/barbican_endpoint\u0027: value \u003d\u003e $barbican_endpoint;"},{"line_number":110,"context_line":"  }"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"09e1953f_92d9def6","line":109,"in_reply_to":"31200fa8_9e729df3","updated":"2024-06-16 15:07:40.000000000","message":"also please make the parameter order consistent. The same comment is applied to the spec file, too.","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"}],"releasenotes/notes/barbican-endpoint-in-keymaster-ef3fe756cbd0a735.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3de8073cf7ba29f91fb75fd9e0c6f325825c6204","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new parameter `barbican_endpoint` has been added to the class"},{"line_number":5,"context_line":"    `swift::keymaster`, that makes it possible to specify the"},{"line_number":6,"context_line":"    Barbican endpoint, which is needed in a multi-region deployment."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4db118f9_ed64641e","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":68},"updated":"2024-06-16 13:02:47.000000000","message":"I\u0027d avoid mentioning this, because the parameter can be used technically in a single-region deployment.","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"}],"spec/classes/swift_keymaster_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3de8073cf7ba29f91fb75fd9e0c6f325825c6204","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/user_domain_name\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":22,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/project_domain_id\u0027).with_value(\u0027default\u0027)"},{"line_number":23,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/user_domain_id\u0027).with_value(\u0027default\u0027)"},{"line_number":24,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/meta_version_to_write\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":25,"context_line":"      end"},{"line_number":26,"context_line":"    end"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"c9cedc81_8bbf560f","line":24,"updated":"2024-06-16 13:02:47.000000000","message":"add the test case for the default value here.","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"12541d34fca42d9178778922cd15514d635fe1da","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/user_domain_name\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":22,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/project_domain_id\u0027).with_value(\u0027default\u0027)"},{"line_number":23,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/user_domain_id\u0027).with_value(\u0027default\u0027)"},{"line_number":24,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/meta_version_to_write\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":25,"context_line":"      end"},{"line_number":26,"context_line":"    end"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9de36bcc_10980264","line":24,"in_reply_to":"c9cedc81_8bbf560f","updated":"2024-06-16 22:23:03.000000000","message":"Done","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3de8073cf7ba29f91fb75fd9e0c6f325825c6204","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/project_domain_name\u0027).with_value(\u0027Default\u0027)"},{"line_number":47,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/user_domain_name\u0027).with_value(\u0027Default\u0027)"},{"line_number":48,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/meta_version_to_write\u0027).with_value(\u00273\u0027)"},{"line_number":49,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/barbican_endpoint\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":50,"context_line":"      end"},{"line_number":51,"context_line":"    end"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"b9b62459_cbe8563d","line":49,"range":{"start_line":49,"start_character":88,"end_line":49,"end_character":110},"updated":"2024-06-16 13:02:47.000000000","message":"here we test parameter overrides.","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"12541d34fca42d9178778922cd15514d635fe1da","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/project_domain_name\u0027).with_value(\u0027Default\u0027)"},{"line_number":47,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/user_domain_name\u0027).with_value(\u0027Default\u0027)"},{"line_number":48,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/meta_version_to_write\u0027).with_value(\u00273\u0027)"},{"line_number":49,"context_line":"        is_expected.to contain_swift_keymaster_config(\u0027kms_keymaster/barbican_endpoint\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":50,"context_line":"      end"},{"line_number":51,"context_line":"    end"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"951a4e31_09167b7b","line":49,"range":{"start_line":49,"start_character":88,"end_line":49,"end_character":110},"in_reply_to":"b9b62459_cbe8563d","updated":"2024-06-16 22:23:03.000000000","message":"Done","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3de8073cf7ba29f91fb75fd9e0c6f325825c6204","unresolved":true,"context_lines":[{"line_number":50,"context_line":"      end"},{"line_number":51,"context_line":"    end"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    describe \"when specifying barbican endpoint\" do"},{"line_number":54,"context_line":"      before :each do"},{"line_number":55,"context_line":"        params.merge!({"},{"line_number":56,"context_line":"          :barbican_endpoint \u003d\u003e \u0027https://barbican.example.com/keymaster\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"90a9aadc_f25ee8e1","line":53,"range":{"start_line":53,"start_character":4,"end_line":53,"end_character":51},"updated":"2024-06-16 13:02:47.000000000","message":"Remove this because parameter override should be tested in L49","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"12541d34fca42d9178778922cd15514d635fe1da","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      end"},{"line_number":51,"context_line":"    end"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    describe \"when specifying barbican endpoint\" do"},{"line_number":54,"context_line":"      before :each do"},{"line_number":55,"context_line":"        params.merge!({"},{"line_number":56,"context_line":"          :barbican_endpoint \u003d\u003e \u0027https://barbican.example.com/keymaster\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1eaa1982_83b5d95d","line":53,"range":{"start_line":53,"start_character":4,"end_line":53,"end_character":51},"in_reply_to":"90a9aadc_f25ee8e1","updated":"2024-06-16 22:23:03.000000000","message":"Done","commit_id":"d89fdab11aefe9f6f9ee4602a4427a7e679ddf54"}]}