)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d252ee551b92fc99978a62039f7d683c71a05fc6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37819720_f186c718","updated":"2024-07-15 16:23:03.000000000","message":"Please also add a release note to explain the new parameter(s).","commit_id":"e9183f287259a092190dc2235a93c672db23a2ab"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27f1c2d3f5bf2ff38c4fe1da78e4bc49f3c6e3de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc024766_5e871677","updated":"2024-07-22 14:01:23.000000000","message":"So https://review.opendev.org/c/openstack/puppet-swift/+/924628 is what I expect once all points are addressed.","commit_id":"404eedd5f6349c6d33e2adf105e0b28523cc3074"}],"manifests/proxy.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d252ee551b92fc99978a62039f7d683c71a05fc6","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    (optional) The list of elements of the swift proxy pipeline."},{"line_number":15,"context_line":"#    Currently supports healthcheck, cache, proxy-server, and"},{"line_number":16,"context_line":"#    one of the following auth_types: tempauth, swauth, keystone."},{"line_number":17,"context_line":"#    Each of the specified elements also need to be declared externally"},{"line_number":18,"context_line":"#    as a puppet class with the exception of proxy-server."},{"line_number":19,"context_line":"#    Defaults to [\u0027catch_errors\u0027, \u0027gatekeeper\u0027, \u0027healthcheck\u0027, \u0027proxy-logging\u0027,"},{"line_number":20,"context_line":"#    \u0027cache\u0027, \u0027listing_formats\u0027, \u0027tempauth\u0027, \u0027copy\u0027, \u0027proxy-logging\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f9fd4d55_1c8faa65","side":"PARENT","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":71},"updated":"2024-07-15 16:23:03.000000000","message":"Why is this line deleted ?","commit_id":"e0cb20b5061515b63484d2aad2abbbebab921c4a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d252ee551b92fc99978a62039f7d683c71a05fc6","unresolved":true,"context_lines":[{"line_number":291,"context_line":"  } else {"},{"line_number":292,"context_line":"    swift_proxy_config {"},{"line_number":293,"context_line":"      \u0027app:proxy-server/sorting_method\u0027: value \u003d\u003e $facts[\u0027os_service_default\u0027];"},{"line_number":294,"context_line":"      \u0027app:proxy-server/read_affinity\u0027:  value \u003d\u003e $facts[\u0027os_service_default\u0027];"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":"  }"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3e8d058f_2c467d46","side":"PARENT","line":294,"range":{"start_line":294,"start_character":6,"end_line":294,"end_character":79},"updated":"2024-07-15 16:23:03.000000000","message":"why is this deleted ?","commit_id":"e0cb20b5061515b63484d2aad2abbbebab921c4a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d252ee551b92fc99978a62039f7d683c71a05fc6","unresolved":true,"context_lines":[{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"#  [*sorting_method*]"},{"line_number":106,"context_line":"#    (optional) Configures sorting_method for swift proxy-server"},{"line_number":107,"context_line":"#    Defaults to $facts[\u0027os_service_default\u0027]."},{"line_number":108,"context_line":"#"},{"line_number":109,"context_line":"#  [*recoverable_node_timeout*]"},{"line_number":110,"context_line":"#    (optional) Configures recoverable_node_timeout for swift proxy-server"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"753d7a5d_491256f8","line":107,"range":{"start_line":107,"start_character":17,"end_line":107,"end_character":46},"updated":"2024-07-15 16:23:03.000000000","message":"this does not align with the actual default.","commit_id":"e9183f287259a092190dc2235a93c672db23a2ab"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d252ee551b92fc99978a62039f7d683c71a05fc6","unresolved":true,"context_lines":[{"line_number":267,"context_line":"    \u0027app:proxy-server/max_containers_per_account\u0027: value \u003d\u003e $max_containers_per_account;"},{"line_number":268,"context_line":"    \u0027app:proxy-server/max_containers_whitelist\u0027:   value \u003d\u003e $max_containers_whitelist;"},{"line_number":269,"context_line":"    \u0027app:proxy-server/node_timeout\u0027:               value \u003d\u003e $node_timeout;"},{"line_number":270,"context_line":"    \u0027app:proxy-server/sorting_method\u0027:             value \u003d\u003e $sorting_method;"},{"line_number":271,"context_line":"    \u0027app:proxy-server/recoverable_node_timeout\u0027:   value \u003d\u003e $recoverable_node_timeout;"},{"line_number":272,"context_line":"  }"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"41c9671e_c31e1e88","line":270,"range":{"start_line":270,"start_character":22,"end_line":270,"end_character":36},"updated":"2024-07-15 16:23:03.000000000","message":"this breaks read_affinity \u003d\u003e true. I\u0027d suggest you rather keep the existing else block and use $sorting_method parameter only when read_affinity is false.","commit_id":"e9183f287259a092190dc2235a93c672db23a2ab"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fea4b4074b75d2a0de237c885a51681fec12e704","unresolved":true,"context_lines":[{"line_number":267,"context_line":"    \u0027app:proxy-server/max_containers_per_account\u0027: value \u003d\u003e $max_containers_per_account;"},{"line_number":268,"context_line":"    \u0027app:proxy-server/max_containers_whitelist\u0027:   value \u003d\u003e $max_containers_whitelist;"},{"line_number":269,"context_line":"    \u0027app:proxy-server/node_timeout\u0027:               value \u003d\u003e $node_timeout;"},{"line_number":270,"context_line":"    \u0027app:proxy-server/sorting_method\u0027:             value \u003d\u003e $sorting_method;"},{"line_number":271,"context_line":"    \u0027app:proxy-server/recoverable_node_timeout\u0027:   value \u003d\u003e $recoverable_node_timeout;"},{"line_number":272,"context_line":"  }"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a0aad64_67cc71e8","line":270,"range":{"start_line":270,"start_character":22,"end_line":270,"end_character":36},"in_reply_to":"41c9671e_c31e1e88","updated":"2024-07-22 13:38:48.000000000","message":"Again this conflicts with the definition in L294.","commit_id":"e9183f287259a092190dc2235a93c672db23a2ab"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fea4b4074b75d2a0de237c885a51681fec12e704","unresolved":true,"context_lines":[{"line_number":293,"context_line":"      \u0027app:proxy-server/sorting_method\u0027: value \u003d\u003e $facts[\u0027os_service_default\u0027];"},{"line_number":294,"context_line":"      \u0027app:proxy-server/read_affinity\u0027:  value \u003d\u003e $facts[\u0027os_service_default\u0027];"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":"  }"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"  # Remove \u0027proxy-server\u0027 from the pipeline, convert pipeline elements"},{"line_number":299,"context_line":"  # into class names then convert \u0027-\u0027 to \u0027_\u0027."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"c82cd1a6_b092bd91","side":"PARENT","line":296,"range":{"start_line":296,"start_character":2,"end_line":296,"end_character":3},"updated":"2024-07-22 13:38:48.000000000","message":"this should NOT be deleted","commit_id":"e0cb20b5061515b63484d2aad2abbbebab921c4a"}],"releasenotes/source/_static/.placeholder":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fea4b4074b75d2a0de237c885a51681fec12e704","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7526b21d_b003efa0","updated":"2024-07-22 13:38:48.000000000","message":"why was this file deleted ?","commit_id":"404eedd5f6349c6d33e2adf105e0b28523cc3074"}],"spec/classes/swift_internal_client_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d252ee551b92fc99978a62039f7d683c71a05fc6","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        should contain_swift_internal_client_config(\u0027app:proxy-server/write_affinity_node_count\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":33,"context_line":"        should contain_swift_internal_client_config(\u0027app:proxy-server/client_timeout\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":34,"context_line":"        should contain_swift_internal_client_config(\u0027app:proxy-server/node_timeout\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":35,"context_line":"        should contain_swift_internal_client_config(\u0027app:proxy-server/sorting_method\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":36,"context_line":"        should contain_swift_internal_client_config(\u0027app:proxy-server/recoverable_node_timeout\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":37,"context_line":"      end"},{"line_number":38,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"4ae3eb33_ca430b96","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":118},"updated":"2024-07-15 16:23:03.000000000","message":"internal_client class is not modified in your patch. Probably you also have to update it ?","commit_id":"e9183f287259a092190dc2235a93c672db23a2ab"}]}