)]}'
{"Gemfile":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a21d2cba4dfa3eb4f7aabee67643528955ac5c33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"source ENV[\u0027GEM_SOURCE\u0027] || \"https://rubygems.org\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"group :development, :test, :system_tests do"},{"line_number":4,"context_line":"  gem \u0027puppet-openstack_spec_helper\u0027, :require \u003d\u003e \u0027false\u0027, :git \u003d\u003e \u0027https://git.openstack.org/openstack/puppet-openstack_spec_helper\u0027"},{"line_number":5,"context_line":"end"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if facterversion \u003d ENV[\u0027FACTER_GEM_VERSION\u0027]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7aa08908_ea03350e","line":4,"updated":"2016-06-14 01:05:59.000000000","message":"Can you skip a line here just to let more readable?\nlike https://review.openstack.org/#/c/323864/3/Gemfile \u003d)","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"3ee2c78b021e7f09137ddd9e86eff17cd4ef2445","unresolved":false,"context_lines":[{"line_number":1,"context_line":"source ENV[\u0027GEM_SOURCE\u0027] || \"https://rubygems.org\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"group :development, :test, :system_tests do"},{"line_number":4,"context_line":"  gem \u0027puppet-openstack_spec_helper\u0027, :require \u003d\u003e \u0027false\u0027, :git \u003d\u003e \u0027https://git.openstack.org/openstack/puppet-openstack_spec_helper\u0027"},{"line_number":5,"context_line":"end"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if facterversion \u003d ENV[\u0027FACTER_GEM_VERSION\u0027]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7aa08908_eb097496","line":4,"in_reply_to":"7aa08908_ea03350e","updated":"2016-06-14 04:51:01.000000000","message":"this seems weird, this is what cookie  cutter and msync generated, but not for the congres module when I used it. I\u0027ll try and regen the content","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"}],"README.md":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a21d2cba4dfa3eb4f7aabee67643528955ac5c33","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Overview"},{"line_number":15,"context_line":"--------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The tacker module is a part of [OpenStack](https://www.openstack.org), an effort by the OpenStack infrastructure team to provide continuous integration testing and code review for OpenStack and OpenStack community projects not part of the core software.  The module its self is used to flexibly configure and manage the servicevm service for OpenStack."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Module Description"},{"line_number":20,"context_line":"------------------"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"7aa08908_8511c254","line":17,"range":{"start_line":17,"start_character":320,"end_line":17,"end_character":329},"updated":"2016-06-14 01:05:59.000000000","message":"same here","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"6a6c4f5718265d90268a488ce744f32930a26c88","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"**What the tacker module affects**"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* [Tacker](https://wiki.openstack.org/wiki/Tacker), the servicevm service for OpenStack."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"### Installing tacker"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":2,"id":"7aa08908_0a8e812d","line":29,"range":{"start_line":29,"start_character":55,"end_line":29,"end_character":65},"updated":"2016-06-14 00:29:57.000000000","message":"Why servicevm? looking at https://wiki.openstack.org/wiki/Tacker i think it should be NFV Orchestration","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"3ee2c78b021e7f09137ddd9e86eff17cd4ef2445","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"**What the tacker module affects**"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* [Tacker](https://wiki.openstack.org/wiki/Tacker), the servicevm service for OpenStack."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"### Installing tacker"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":2,"id":"7aa08908_cb4638bf","line":29,"range":{"start_line":29,"start_character":55,"end_line":29,"end_character":65},"in_reply_to":"7aa08908_0a8e812d","updated":"2016-06-14 04:51:01.000000000","message":"module hasn\u0027t been worked on in a while, looks like this value has been updated since then, I\u0027ll use the new value.","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"}],"manifests/db.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"b60a1ae0e74b7545bf7d525c2c445693e930bdb2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*database_connection*]"},{"line_number":8,"context_line":"#   (Optional) Url used to connect to database."},{"line_number":9,"context_line":"#   Defaults to \"sqlite:////var/lib/tacker/tacker.sqlite\"."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*database_idle_timeout*]"},{"line_number":12,"context_line":"#   (Optional) Timeout when db connections should be reaped."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_ab925e55","line":9,"updated":"2016-06-22 09:33:01.000000000","message":"nit: single quotes were ok. probably we need to fix https://github.com/openstack/puppet-openstack-cookiecutter/blob/master/puppet-%7B%7Bcookiecutter.project_name%7D%7D/manifests/db.pp#L9","commit_id":"85caa0847960e8d6362f33e054b97f11d9ee64d9"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dae1a3d196d6be9a56f21735f5b6684468f600cb","unresolved":false,"context_lines":[{"line_number":250,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":251,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"},{"line_number":252,"context_line":"  $bind_port                          \u003d \u00278888\u0027,"},{"line_number":253,"context_line":"  $verbose                            \u003d undef,"},{"line_number":254,"context_line":"  $debug                              \u003d undef,"},{"line_number":255,"context_line":"  $auth_type                          \u003d \u0027keystone\u0027,"},{"line_number":256,"context_line":"  $auth_uri                           \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_b9d04d20","side":"PARENT","line":253,"updated":"2016-06-14 13:59:26.000000000","message":"not sure that it\u0027s good idea to remove all this stuff - it will be added in next commit right?","commit_id":"6934f153abaee177d89b3304e251e714fc333b92"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f46d8f17d31a1a91f0d46cdec2110ffe04b9b2ee","unresolved":false,"context_lines":[{"line_number":250,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":251,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"},{"line_number":252,"context_line":"  $bind_port                          \u003d \u00278888\u0027,"},{"line_number":253,"context_line":"  $verbose                            \u003d undef,"},{"line_number":254,"context_line":"  $debug                              \u003d undef,"},{"line_number":255,"context_line":"  $auth_type                          \u003d \u0027keystone\u0027,"},{"line_number":256,"context_line":"  $auth_uri                           \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_cee46a0e","side":"PARENT","line":253,"in_reply_to":"7aa08908_b9d04d20","updated":"2016-06-14 14:20:24.000000000","message":"That was my original thought. I guess we need more direction here from someone.","commit_id":"6934f153abaee177d89b3304e251e714fc333b92"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0370eb086726e118a17b89ba0fa208645c1be74b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*sample_parameter*]"},{"line_number":8,"context_line":"#   Explanation of what this parameter affects and what it defaults to."},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"class tacker {"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  include ::tacker::params"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_f0981f77","line":9,"updated":"2016-06-14 15:39:09.000000000","message":"we don\u0027t need that now :)","commit_id":"0fbcb45897f1a5a023496abdafe727d73ee791c1"}],"manifests/keystone/auth.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a21d2cba4dfa3eb4f7aabee67643528955ac5c33","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*service_type*]"},{"line_number":31,"context_line":"#   Type of service. Defaults to \u0027key-manager\u0027."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*region*]"},{"line_number":34,"context_line":"#   Region for endpoint. Defaults to \u0027RegionOne\u0027."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_c5b3ca4b","line":31,"range":{"start_line":31,"start_character":33,"end_line":31,"end_character":45},"updated":"2016-06-14 01:05:59.000000000","message":"key manager? It isn\u0027t this for barbican?","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"3ee2c78b021e7f09137ddd9e86eff17cd4ef2445","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*service_type*]"},{"line_number":31,"context_line":"#   Type of service. Defaults to \u0027key-manager\u0027."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*region*]"},{"line_number":34,"context_line":"#   Region for endpoint. Defaults to \u0027RegionOne\u0027."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_cb1d98bf","line":31,"range":{"start_line":31,"start_character":33,"end_line":31,"end_character":45},"in_reply_to":"7aa08908_c5b3ca4b","updated":"2016-06-14 04:51:01.000000000","message":"this is what came out of cookie cutter and module sync, I have no idea where that came from","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a21d2cba4dfa3eb4f7aabee67643528955ac5c33","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  $configure_user      \u003d true,"},{"line_number":62,"context_line":"  $configure_user_role \u003d true,"},{"line_number":63,"context_line":"  $service_name        \u003d \u0027tacker\u0027,"},{"line_number":64,"context_line":"  $service_description \u003d \u0027tacker servicevm Service\u0027,"},{"line_number":65,"context_line":"  $service_type        \u003d \u0027servicevm\u0027,"},{"line_number":66,"context_line":"  $region              \u003d \u0027RegionOne\u0027,"},{"line_number":67,"context_line":"  $public_url          \u003d \u0027http://127.0.0.1:8888\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_e58d267d","line":64,"range":{"start_line":64,"start_character":33,"end_line":64,"end_character":42},"updated":"2016-06-14 01:05:59.000000000","message":"same thing i put in the README \u003d)","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"6a6c4f5718265d90268a488ce744f32930a26c88","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $service_description \u003d \u0027tacker servicevm Service\u0027,"},{"line_number":65,"context_line":"  $service_type        \u003d \u0027servicevm\u0027,"},{"line_number":66,"context_line":"  $region              \u003d \u0027RegionOne\u0027,"},{"line_number":67,"context_line":"  $public_url          \u003d \u0027http://127.0.0.1:8888\u0027,"},{"line_number":68,"context_line":"  $admin_url           \u003d \u0027http://127.0.0.1:8888\u0027,"},{"line_number":69,"context_line":"  $internal_url        \u003d \u0027http://127.0.0.1:8888\u0027,"},{"line_number":70,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_eaefb5ae","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":47},"updated":"2016-06-14 00:29:57.000000000","message":"9890?","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"3ee2c78b021e7f09137ddd9e86eff17cd4ef2445","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $service_description \u003d \u0027tacker servicevm Service\u0027,"},{"line_number":65,"context_line":"  $service_type        \u003d \u0027servicevm\u0027,"},{"line_number":66,"context_line":"  $region              \u003d \u0027RegionOne\u0027,"},{"line_number":67,"context_line":"  $public_url          \u003d \u0027http://127.0.0.1:8888\u0027,"},{"line_number":68,"context_line":"  $admin_url           \u003d \u0027http://127.0.0.1:8888\u0027,"},{"line_number":69,"context_line":"  $internal_url        \u003d \u0027http://127.0.0.1:8888\u0027,"},{"line_number":70,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_2b853cce","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":47},"in_reply_to":"7aa08908_eaefb5ae","updated":"2016-06-14 04:51:01.000000000","message":"yup, this has changed since we worked on it last too. I\u0027ll get that updated","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dae1a3d196d6be9a56f21735f5b6684468f600cb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $configure_user_role \u003d true,"},{"line_number":63,"context_line":"  $service_name        \u003d \u0027tacker\u0027,"},{"line_number":64,"context_line":"  $service_description \u003d \u0027tacker NFV orchestration Service\u0027,"},{"line_number":65,"context_line":"  $service_type        \u003d \u0027nfv-orchestration\u0027,"},{"line_number":66,"context_line":"  $region              \u003d \u0027RegionOne\u0027,"},{"line_number":67,"context_line":"  $public_url          \u003d \u0027http://127.0.0.1:9890\u0027,"},{"line_number":68,"context_line":"  $admin_url           \u003d \u0027http://127.0.0.1:9890\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_59832903","line":65,"updated":"2016-06-14 13:59:26.000000000","message":"key-manager?","commit_id":"b2d5a080b923984eeeef04a4cb660cd397c09816"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f46d8f17d31a1a91f0d46cdec2110ffe04b9b2ee","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $configure_user_role \u003d true,"},{"line_number":63,"context_line":"  $service_name        \u003d \u0027tacker\u0027,"},{"line_number":64,"context_line":"  $service_description \u003d \u0027tacker NFV orchestration Service\u0027,"},{"line_number":65,"context_line":"  $service_type        \u003d \u0027nfv-orchestration\u0027,"},{"line_number":66,"context_line":"  $region              \u003d \u0027RegionOne\u0027,"},{"line_number":67,"context_line":"  $public_url          \u003d \u0027http://127.0.0.1:9890\u0027,"},{"line_number":68,"context_line":"  $admin_url           \u003d \u0027http://127.0.0.1:9890\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_6e60d6a5","line":65,"in_reply_to":"7aa08908_59832903","updated":"2016-06-14 14:20:24.000000000","message":"Done","commit_id":"b2d5a080b923984eeeef04a4cb660cd397c09816"}],"metadata.json":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"b60a1ae0e74b7545bf7d525c2c445693e930bdb2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    { \"name\": \"puppetlabs/inifile\", \"version_requirement\": \"\u003e\u003d1.0.0 \u003c2.0.0\" },"},{"line_number":31,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d 4.2.0 \u003c5.0.0\" },"},{"line_number":32,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d8.0.0 \u003c9.0.0\" },"},{"line_number":33,"context_line":"    { \"name\": \"openstack/oslo\", \"version_requirement\": \"\u003c9.0.0\" }"},{"line_number":34,"context_line":"  ]"},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":7,"id":"3aaa91ec_0b78d2f1","line":33,"updated":"2016-06-22 09:33:01.000000000","message":"we need to fix versions here as well. 9.0.0 was released some time ago","commit_id":"85caa0847960e8d6362f33e054b97f11d9ee64d9"}],"spec/classes/tacker_keystone_auth_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a21d2cba4dfa3eb4f7aabee67643528955ac5c33","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"      it { is_expected.to contain_keystone_endpoint(\u0027RegionOne/tacker::servicevm\u0027).with("},{"line_number":31,"context_line":"        :ensure       \u003d\u003e \u0027present\u0027,"},{"line_number":32,"context_line":"        :public_url   \u003d\u003e \u0027http://127.0.0.1:8888\u0027,"},{"line_number":33,"context_line":"        :admin_url    \u003d\u003e \u0027http://127.0.0.1:8888\u0027,"},{"line_number":34,"context_line":"        :internal_url \u003d\u003e \u0027http://127.0.0.1:8888\u0027,"},{"line_number":35,"context_line":"      ) }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7aa08908_c5662aba","line":32,"range":{"start_line":32,"start_character":42,"end_line":32,"end_character":47},"updated":"2016-06-14 01:05:59.000000000","message":"same problem for port \u003d)","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a21d2cba4dfa3eb4f7aabee67643528955ac5c33","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      it { is_expected.not_to contain_keystone_user_role(\u0027tacker@services\u0027) }"},{"line_number":109,"context_line":"      it { is_expected.to contain_keystone_service(\u0027tacker::servicevm\u0027).with("},{"line_number":110,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":111,"context_line":"        :description \u003d\u003e \u0027tacker servicevm Service\u0027"},{"line_number":112,"context_line":"      ) }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7aa08908_85f702d2","line":111,"range":{"start_line":111,"start_character":32,"end_line":111,"end_character":41},"updated":"2016-06-14 01:05:59.000000000","message":"Same","commit_id":"c87560a95bc3637e041767f3d672b2bb8d4baa9e"}]}