)]}'
{"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"caa34eee44f635a00af0cc079404bcbf5bfb28ed","unresolved":false,"context_lines":[{"line_number":310,"context_line":"  $disable_ssl_validation        \u003d undef,"},{"line_number":311,"context_line":"  $manage_tests_packages         \u003d false,"},{"line_number":312,"context_line":"  # ec2-api configuration"},{"line_number":313,"context_line":"  $aws_ec2_url                   \u003d undef,"},{"line_number":314,"context_line":"  $aws_secret                    \u003d undef,"},{"line_number":315,"context_line":"  $aws_access                    \u003d undef,"},{"line_number":316,"context_line":"  $aws_region                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ac06dbe_567182a7","line":313,"updated":"2016-08-22 17:58:44.000000000","message":"Is there a reason these aren\u0027t $::os_service_default?","commit_id":"876fb49127d9b1910bb72b1a78ed0d5beaaae08c"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"c1979ee0d33a84ff040a34450bb99863f88b29ee","unresolved":false,"context_lines":[{"line_number":310,"context_line":"  $disable_ssl_validation        \u003d undef,"},{"line_number":311,"context_line":"  $manage_tests_packages         \u003d false,"},{"line_number":312,"context_line":"  # ec2-api configuration"},{"line_number":313,"context_line":"  $aws_ec2_url                   \u003d undef,"},{"line_number":314,"context_line":"  $aws_secret                    \u003d undef,"},{"line_number":315,"context_line":"  $aws_access                    \u003d undef,"},{"line_number":316,"context_line":"  $aws_region                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ac06dbe_be5d497b","line":313,"in_reply_to":"1ac06dbe_567182a7","updated":"2016-08-25 16:08:47.000000000","message":"No, not really. I just saw the other undef, and assumed that\u0027s the right thing to do for an \"optional argument\". So, when to use undef, and when to use os_service_default?","commit_id":"876fb49127d9b1910bb72b1a78ed0d5beaaae08c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cfb608ea7f342e82b11b4b1c9a6dca21f318256b","unresolved":false,"context_lines":[{"line_number":310,"context_line":"  $disable_ssl_validation        \u003d undef,"},{"line_number":311,"context_line":"  $manage_tests_packages         \u003d false,"},{"line_number":312,"context_line":"  # ec2-api configuration"},{"line_number":313,"context_line":"  $aws_ec2_url                   \u003d undef,"},{"line_number":314,"context_line":"  $aws_secret                    \u003d undef,"},{"line_number":315,"context_line":"  $aws_access                    \u003d undef,"},{"line_number":316,"context_line":"  $aws_region                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ac06dbe_c99cd15f","line":313,"in_reply_to":"1ac06dbe_be5d497b","updated":"2016-08-25 16:30:14.000000000","message":"When it\u0027s a value that gets written out via a provider, it should be $::os_service_default which will have the effect of removing the option from the configuration file and falling back to whatever the default is in the python code.  This allows a user to specify a value if they choose but if they change their mind, we\u0027ll cleanup the value from the config when it\u0027s no longer being specified.  We\u0027ve generally moved away from undef unless it\u0027s some sort of configuration option for puppet logic and not an openstack configuration value.","commit_id":"876fb49127d9b1910bb72b1a78ed0d5beaaae08c"}]}