)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ce8f6f8f6f8161af3b122441a987b7192a982f72","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sven Anderson \u003csven@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-02 15:07:15 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add provider for ec2 credentials"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iab02a6f453de1a07cd059276cb46e23a4b0bb434"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da7fb54a_fbfd6f6f","line":7,"updated":"2016-09-02 17:07:32.000000000","message":"could you write a commit message that explain what does the provider, why do we need it etc. Thanks.","commit_id":"b992dc6999a1ab570051e6f25b9817bf5e8bae97"}],"lib/puppet/provider/tempest_ec2_credentials/openstack.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fcf5b62644b1a39a2de64dfcd9d9faef196ce68e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require File.join(File.dirname(__FILE__), \u0027..\u0027,\u0027..\u0027,\u0027..\u0027, \u0027puppet/provider/tempest\u0027)"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Puppet::Type.type(:tempest_ec2_credentials_setter).provide("},{"line_number":4,"context_line":"  :openstack,"},{"line_number":5,"context_line":"  :parent \u003d\u003e Puppet::Provider::Tempest"},{"line_number":6,"context_line":") do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a89bdaa_208624db","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":49},"updated":"2016-09-07 13:22:37.000000000","message":"need to be renamed still","commit_id":"3c63633e07617435290354c238af19e4c63ecae6"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"1082ae6ee81213b8761ab6921578be9aff2f71e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require File.join(File.dirname(__FILE__), \u0027..\u0027,\u0027..\u0027,\u0027..\u0027, \u0027puppet/provider/tempest\u0027)"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Puppet::Type.type(:tempest_ec2_credentials_setter).provide("},{"line_number":4,"context_line":"  :openstack,"},{"line_number":5,"context_line":"  :parent \u003d\u003e Puppet::Provider::Tempest"},{"line_number":6,"context_line":") do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a89bdaa_b76437b9","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":49},"in_reply_to":"9a89bdaa_208624db","updated":"2016-09-07 13:41:49.000000000","message":"Huh? I was sure I did... I missed to save at some point it seems. :-/ Thanks! :-)","commit_id":"3c63633e07617435290354c238af19e4c63ecae6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a149a48108dbd68ab74cdecb76ac45b6a7afa31d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require File.join(File.dirname(__FILE__), \u0027..\u0027,\u0027..\u0027,\u0027..\u0027, \u0027puppet/provider/tempest\u0027)"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Puppet::Type.type(:tempest_ec2_credentials).provide("},{"line_number":4,"context_line":"  :openstack,"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a89bdaa_20fdff6d","line":1,"updated":"2016-09-08 14:21:00.000000000","message":"So you\u0027re going to want to create a unit test for this provider. For example, https://github.com/openstack/puppet-nova/blob/master/spec/unit/provider/nova_flavor/openstack_spec.rb\n\nThe provider unit test will be where you\u0027d mock out the response information and validate that the expected output would be written to a file. Alternatively you could just update the catalog to call tempest_config to do the writing out","commit_id":"0baa7f26a4a45b06cf26a697d2d5b5a0eab8ff44"}],"lib/puppet/provider/tempest_ec2_credentials_setter/openstack.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32e39f7baeec671c71f962aa36e06afed8367488","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require File.join(File.dirname(__FILE__), \u0027..\u0027,\u0027..\u0027,\u0027..\u0027, \u0027puppet/provider/tempest\u0027)"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Puppet::Type.type(:tempest_ec2_credentials_setter).provide("},{"line_number":4,"context_line":"  :openstack,"},{"line_number":5,"context_line":"  :parent \u003d\u003e Puppet::Provider::Tempest"},{"line_number":6,"context_line":") do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a89bdaa_0eb9f3e9","line":3,"updated":"2016-09-02 22:19:25.000000000","message":"Let\u0027s not called it tempest_ec2_credentials_setter, tempest_ec2_credentials should suffice.","commit_id":"b992dc6999a1ab570051e6f25b9817bf5e8bae97"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32e39f7baeec671c71f962aa36e06afed8367488","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  :parent \u003d\u003e Puppet::Provider::Tempest"},{"line_number":6,"context_line":") do"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  @credentials \u003d Puppet::Provider::Openstack::CredentialsV2_0.new"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  def exists?"},{"line_number":11,"context_line":"    lines.each do |l|"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a89bdaa_2eceb783","line":8,"updated":"2016-09-02 22:19:25.000000000","message":"Does it only work with v2? I think the newer stuff we write use CredentialsV3 by default","commit_id":"b992dc6999a1ab570051e6f25b9817bf5e8bae97"}],"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fcf5b62644b1a39a2de64dfcd9d9faef196ce68e","unresolved":false,"context_lines":[{"line_number":698,"context_line":"    tempest_config {"},{"line_number":699,"context_line":"      \u0027aws/ec2_url\u0027: value \u003d\u003e \u0027http://127.0.0.1:8788/\u0027;"},{"line_number":700,"context_line":"    }"},{"line_number":701,"context_line":"    tempest_ec2_credentials_setter { \u0027ec2_test_creds\u0027:"},{"line_number":702,"context_line":"      ensure            \u003d\u003e present,"},{"line_number":703,"context_line":"      tempest_conf_path \u003d\u003e $tempest_conf,"},{"line_number":704,"context_line":"      user              \u003d\u003e $username,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a89bdaa_a04954b9","line":701,"range":{"start_line":701,"start_character":4,"end_line":701,"end_character":34},"updated":"2016-09-07 13:22:37.000000000","message":"same this should just be tempest_ec2_credentials","commit_id":"3c63633e07617435290354c238af19e4c63ecae6"}],"spec/classes/tempest_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a149a48108dbd68ab74cdecb76ac45b6a7afa31d","unresolved":false,"context_lines":[{"line_number":140,"context_line":"      end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      it \u0027creates ec2 credentials\u0027 do"},{"line_number":143,"context_line":"        is_expected.to contain_tempest_config(\u0027aws/aws_access\u0027)"},{"line_number":144,"context_line":"        is_expected.to contain_tempest_config(\u0027aws/aws_secret\u0027)"},{"line_number":145,"context_line":"      end"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a89bdaa_60238756","line":144,"range":{"start_line":143,"start_character":0,"end_line":144,"end_character":63},"updated":"2016-09-08 14:21:00.000000000","message":"So in this test you can\u0027t check these because this is occurring in the provider and isn\u0027t something in the catalog. This should just be like\n\nis_expected.to contain_tempest_ec2_credentials(\u0027ec2_test_creds\u0027).with(\n  ensure               \u003d\u003e \u0027present\u0027,\n  temptest_config_path \u003d\u003e \u0027...\u0027,\n  user                 \u003d\u003e \u0027testuser\u0027,\n  project              \u003d\u003e \u0027testproject\u0027\n)","commit_id":"0baa7f26a4a45b06cf26a697d2d5b5a0eab8ff44"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bb7288db22babe2234884dd5b9b5e371e8d3c3dd","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        is_expected.to contain_tempest_config(\u0027aws/ec2_url\u0027).with_value(\u0027http://127.0.0.1:8788/\u0027)"},{"line_number":140,"context_line":"      end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      is_expected.to contain_tempest_ec2_credentials(\u0027ec2_test_creds\u0027).with("},{"line_number":143,"context_line":"        :ensure               \u003d\u003e \u0027present\u0027,"},{"line_number":144,"context_line":"        :temptest_config_path \u003d\u003e \u0027/var/lib/tempest/etc/tempest.conf\u0027,"},{"line_number":145,"context_line":"        :user                 \u003d\u003e \u0027testuser\u0027,"},{"line_number":146,"context_line":"        :project              \u003d\u003e \u0027testproject\u0027"},{"line_number":147,"context_line":"      )"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    end"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a89bdaa_5f02cbb5","line":147,"range":{"start_line":142,"start_character":0,"end_line":147,"end_character":7},"updated":"2016-09-08 20:13:45.000000000","message":"You dropped the it block around this. You still need it","commit_id":"264cdebcae1a5c2b95aeef5afc03a717a1690cb1"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"d3ceeb1748beec73efe71109e8508b299156fab0","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        is_expected.to contain_tempest_config(\u0027aws/ec2_url\u0027).with_value(\u0027http://127.0.0.1:8788/\u0027)"},{"line_number":140,"context_line":"      end"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      is_expected.to contain_tempest_ec2_credentials(\u0027ec2_test_creds\u0027).with("},{"line_number":143,"context_line":"        :ensure               \u003d\u003e \u0027present\u0027,"},{"line_number":144,"context_line":"        :temptest_config_path \u003d\u003e \u0027/var/lib/tempest/etc/tempest.conf\u0027,"},{"line_number":145,"context_line":"        :user                 \u003d\u003e \u0027testuser\u0027,"},{"line_number":146,"context_line":"        :project              \u003d\u003e \u0027testproject\u0027"},{"line_number":147,"context_line":"      )"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    end"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a89bdaa_6ec976ac","line":147,"range":{"start_line":142,"start_character":0,"end_line":147,"end_character":7},"in_reply_to":"9a89bdaa_5f02cbb5","updated":"2016-09-09 14:09:27.000000000","message":"Yes, also just realized it. \u003e_\u003c\nThanks!","commit_id":"264cdebcae1a5c2b95aeef5afc03a717a1690cb1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5da62ae45ab3e046b99fac3a94359b9cbb441061","unresolved":false,"context_lines":[{"line_number":142,"context_line":"      it \u0027creates ec2 credentials\u0027 do"},{"line_number":143,"context_line":"        is_expected.to contain_tempest_ec2_credentials(\u0027ec2_test_creds\u0027).with("},{"line_number":144,"context_line":"          :ensure               \u003d\u003e \u0027present\u0027,"},{"line_number":145,"context_line":"          :temptest_config_path \u003d\u003e \u0027/var/lib/tempest/etc/tempest.conf\u0027,"},{"line_number":146,"context_line":"          :user                 \u003d\u003e \u0027testuser\u0027,"},{"line_number":147,"context_line":"          :project              \u003d\u003e \u0027testproject\u0027"},{"line_number":148,"context_line":"        )"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"9a89bdaa_d0fdbc6f","line":145,"range":{"start_line":145,"start_character":11,"end_line":145,"end_character":31},"updated":"2016-09-09 14:57:42.000000000","message":"tempest_config_path not temptest_config_path","commit_id":"5a7f88f119e301ed362ea7841376832baeb87550"}]}