)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d1e3d1c957496c1f555699462925991bf1543a6a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sven Anderson \u003csven@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-07 13:52:15 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create user and some fixes for ec2 credentials provider."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2a60bde92e8522362fefebc34c99cbb0346c6347"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_aea77ebb","line":7,"updated":"2016-10-07 15:15:33.000000000","message":"Can you add some more detail as to why we\u0027re creating a seperate ec2api user for this test rather than use the previously created user?","commit_id":"411f83bacb0c36cb3ce9533498ecc610d27923eb"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"c201581b10a5f25bea837d967c40f65b22d1eebe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sven Anderson \u003csven@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-07 13:52:15 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create user and some fixes for ec2 credentials provider."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2a60bde92e8522362fefebc34c99cbb0346c6347"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_bcf13997","line":7,"in_reply_to":"1a95cdbc_aea77ebb","updated":"2016-10-10 13:11:13.000000000","message":"I asked around before if there is already a user that I could use (without admin rights), and nobody could point me to it. Can you?","commit_id":"411f83bacb0c36cb3ce9533498ecc610d27923eb"}],"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a4dd661939e67f4f4417b177c815c64579d06cc5","unresolved":false,"context_lines":[{"line_number":706,"context_line":"    }"},{"line_number":707,"context_line":"    keystone_user_role { \u0027ec2api-tester@openstack\u0027 :"},{"line_number":708,"context_line":"      ensure \u003d\u003e present,"},{"line_number":709,"context_line":"      roles  \u003d\u003e [\u0027Member\u0027],"},{"line_number":710,"context_line":"    }"},{"line_number":711,"context_line":"    tempest_ec2_credentials { \u0027ec2_test_creds\u0027:"},{"line_number":712,"context_line":"      ensure            \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa6399be_19f8a4c2","line":709,"updated":"2016-10-14 15:42:59.000000000","message":"Mhh. It sounds super opinionated but let\u0027s try it and see how it works.","commit_id":"e1dcb9d6aec200e4adc0af8f6e72363cebe3f4f1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0d59b1978b70aadb30bc329864eca198cc84d833","unresolved":false,"context_lines":[{"line_number":700,"context_line":"  }"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"  if $ec2api_available {"},{"line_number":703,"context_line":"    keystone_user { \u0027ec2api-tester\u0027 :"},{"line_number":704,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":705,"context_line":"      enabled \u003d\u003e true,"},{"line_number":706,"context_line":"    }"},{"line_number":707,"context_line":"    keystone_user_role { \u0027ec2api-tester@openstack\u0027 :"},{"line_number":708,"context_line":"      ensure \u003d\u003e present,"},{"line_number":709,"context_line":"      roles  \u003d\u003e [\u0027Member\u0027],"},{"line_number":710,"context_line":"    }"},{"line_number":711,"context_line":"    tempest_ec2_credentials { \u0027ec2_test_creds\u0027:"},{"line_number":712,"context_line":"      ensure            \u003d\u003e present,"},{"line_number":713,"context_line":"      tempest_conf_path \u003d\u003e $tempest_conf,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa6399be_454157a8","line":710,"range":{"start_line":703,"start_character":0,"end_line":710,"end_character":5},"updated":"2016-10-14 12:03:05.000000000","message":"It\u0027s ok for now, because I guess we need to create them, but it\u0027s sounds super opinionated to create these resources.","commit_id":"e1dcb9d6aec200e4adc0af8f6e72363cebe3f4f1"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"f86a9e16eb86071cfbcb9773c1ec0c8107728588","unresolved":false,"context_lines":[{"line_number":700,"context_line":"  }"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"  if $ec2api_available {"},{"line_number":703,"context_line":"    keystone_user { \u0027ec2api-tester\u0027 :"},{"line_number":704,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":705,"context_line":"      enabled \u003d\u003e true,"},{"line_number":706,"context_line":"    }"},{"line_number":707,"context_line":"    keystone_user_role { \u0027ec2api-tester@openstack\u0027 :"},{"line_number":708,"context_line":"      ensure \u003d\u003e present,"},{"line_number":709,"context_line":"      roles  \u003d\u003e [\u0027Member\u0027],"},{"line_number":710,"context_line":"    }"},{"line_number":711,"context_line":"    tempest_ec2_credentials { \u0027ec2_test_creds\u0027:"},{"line_number":712,"context_line":"      ensure            \u003d\u003e present,"},{"line_number":713,"context_line":"      tempest_conf_path \u003d\u003e $tempest_conf,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa6399be_85560f28","line":710,"range":{"start_line":703,"start_character":0,"end_line":710,"end_character":5},"in_reply_to":"fa6399be_454157a8","updated":"2016-10-14 12:12:50.000000000","message":"I\u0027m happy to do it differently... We could instead create such a user in puppet-openstack-integration and pass it as $username here... What do you think?","commit_id":"e1dcb9d6aec200e4adc0af8f6e72363cebe3f4f1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a4dd661939e67f4f4417b177c815c64579d06cc5","unresolved":false,"context_lines":[{"line_number":714,"context_line":"      user              \u003d\u003e \u0027ec2api-tester\u0027,"},{"line_number":715,"context_line":"      project           \u003d\u003e \u0027openstack\u0027,"},{"line_number":716,"context_line":"    }"},{"line_number":717,"context_line":"    Tempest_config\u003c||\u003e -\u003e Tempest_ec2_credentials[\u0027ec2_test_creds\u0027]"},{"line_number":718,"context_line":"    Keystone_user_role\u003c||\u003e -\u003e Tempest_ec2_credentials[\u0027ec2_test_creds\u0027]"},{"line_number":719,"context_line":"  }"},{"line_number":720,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa6399be_3903a8b9","line":717,"updated":"2016-10-14 15:42:59.000000000","message":"I would rather use autorequire in the Puppet Type","commit_id":"e1dcb9d6aec200e4adc0af8f6e72363cebe3f4f1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a4dd661939e67f4f4417b177c815c64579d06cc5","unresolved":false,"context_lines":[{"line_number":715,"context_line":"      project           \u003d\u003e \u0027openstack\u0027,"},{"line_number":716,"context_line":"    }"},{"line_number":717,"context_line":"    Tempest_config\u003c||\u003e -\u003e Tempest_ec2_credentials[\u0027ec2_test_creds\u0027]"},{"line_number":718,"context_line":"    Keystone_user_role\u003c||\u003e -\u003e Tempest_ec2_credentials[\u0027ec2_test_creds\u0027]"},{"line_number":719,"context_line":"  }"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa6399be_59fe9cae","line":718,"updated":"2016-10-14 15:42:59.000000000","message":"Dito","commit_id":"e1dcb9d6aec200e4adc0af8f6e72363cebe3f4f1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0d59b1978b70aadb30bc329864eca198cc84d833","unresolved":false,"context_lines":[{"line_number":714,"context_line":"      user              \u003d\u003e \u0027ec2api-tester\u0027,"},{"line_number":715,"context_line":"      project           \u003d\u003e \u0027openstack\u0027,"},{"line_number":716,"context_line":"    }"},{"line_number":717,"context_line":"    Tempest_config\u003c||\u003e -\u003e Tempest_ec2_credentials[\u0027ec2_test_creds\u0027]"},{"line_number":718,"context_line":"    Keystone_user_role\u003c||\u003e -\u003e Tempest_ec2_credentials[\u0027ec2_test_creds\u0027]"},{"line_number":719,"context_line":"  }"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa6399be_05fcbf70","line":718,"range":{"start_line":717,"start_character":0,"end_line":718,"end_character":71},"updated":"2016-10-14 12:03:05.000000000","message":"I would rather create an autorequire in the Tempest_ec2_credentials Type, to require Tempest_config and Keystone_user_role.\n\nhttps://docs.puppet.com/puppet/latest/reference/lang_relationships.html#auto-relationships\n\nautorequire makes the dependency optional (like here) but is defined in the resource, much cleaner that defining it in the manifest.","commit_id":"e1dcb9d6aec200e4adc0af8f6e72363cebe3f4f1"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"f86a9e16eb86071cfbcb9773c1ec0c8107728588","unresolved":false,"context_lines":[{"line_number":714,"context_line":"      user              \u003d\u003e \u0027ec2api-tester\u0027,"},{"line_number":715,"context_line":"      project           \u003d\u003e \u0027openstack\u0027,"},{"line_number":716,"context_line":"    }"},{"line_number":717,"context_line":"    Tempest_config\u003c||\u003e -\u003e Tempest_ec2_credentials[\u0027ec2_test_creds\u0027]"},{"line_number":718,"context_line":"    Keystone_user_role\u003c||\u003e -\u003e Tempest_ec2_credentials[\u0027ec2_test_creds\u0027]"},{"line_number":719,"context_line":"  }"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa6399be_852d2faa","line":718,"range":{"start_line":717,"start_character":0,"end_line":718,"end_character":71},"in_reply_to":"fa6399be_05fcbf70","updated":"2016-10-14 12:12:50.000000000","message":"Sure, will look it up...","commit_id":"e1dcb9d6aec200e4adc0af8f6e72363cebe3f4f1"}]}