)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0cf558390f4bff233ae45bc3557d951b0579e71a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"#"},{"line_number":203,"context_line":"class tempest("},{"line_number":204,"context_line":"  $ensure_package                \u003d \u0027present\u0027,"},{"line_number":205,"context_line":"  $install_from_source           \u003d false,"},{"line_number":206,"context_line":"  $git_clone                     \u003d false,"},{"line_number":207,"context_line":"  $tempest_config_file           \u003d \u0027/var/lib/tempest/etc/tempest.conf\u0027,"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a461143_ecaf6b92","line":205,"updated":"2017-01-25 13:01:21.000000000","message":"this is not backward compatible for our users, you\u0027re changing the default.","commit_id":"89493b3579aacc01d36dd9980892faa46bc09eb2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0cf558390f4bff233ae45bc3557d951b0579e71a","unresolved":false,"context_lines":[{"line_number":203,"context_line":"class tempest("},{"line_number":204,"context_line":"  $ensure_package                \u003d \u0027present\u0027,"},{"line_number":205,"context_line":"  $install_from_source           \u003d false,"},{"line_number":206,"context_line":"  $git_clone                     \u003d false,"},{"line_number":207,"context_line":"  $tempest_config_file           \u003d \u0027/var/lib/tempest/etc/tempest.conf\u0027,"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  # Clone config"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a461143_0c95973f","line":206,"updated":"2017-01-25 13:01:21.000000000","message":"ditto","commit_id":"89493b3579aacc01d36dd9980892faa46bc09eb2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0cf558390f4bff233ae45bc3557d951b0579e71a","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    }"},{"line_number":433,"context_line":"  }"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"  package { \u0027tempest\u0027:"},{"line_number":436,"context_line":"    ensure \u003d\u003e $ensure_package,"},{"line_number":437,"context_line":"    name   \u003d\u003e $::tempest::params::package_name,"},{"line_number":438,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a461143_cc346f4c","line":435,"updated":"2017-01-25 13:01:21.000000000","message":"you should put this package resource in the else of if $install_from_source because we don\u0027t want to install it if we deploy from source. Also, you want to add it in params.pp like we do for the tempest plugins, because there is no package on Ubuntu.\n\nSo basically, you could do:\n\nif $::tempest::params::tempest_package and ! $install_from_source {\n  package {}\n}","commit_id":"89493b3579aacc01d36dd9980892faa46bc09eb2"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"d2db156815ef9eb19dfacf2ff38c113436f00902","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    }"},{"line_number":433,"context_line":"  }"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"  package { \u0027tempest\u0027:"},{"line_number":436,"context_line":"    ensure \u003d\u003e $ensure_package,"},{"line_number":437,"context_line":"    name   \u003d\u003e $::tempest::params::package_name,"},{"line_number":438,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a461143_807ea6ac","line":435,"in_reply_to":"3a461143_cc346f4c","updated":"2017-01-25 14:32:28.000000000","message":"Ubuntu has a tempest package: http://reqorts.qa.ubuntu.com/reports/ubuntu-server/cloud-archive/ocata_versions.html\n\nThey\u0027ve had it since Newton as far as I can tell.","commit_id":"89493b3579aacc01d36dd9980892faa46bc09eb2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"670e8a1b9d7214859828f3b4fc894605abf4af88","unresolved":false,"context_lines":[{"line_number":439,"context_line":"    package { \u0027tempest\u0027:"},{"line_number":440,"context_line":"    ensure \u003d\u003e $ensure_package,"},{"line_number":441,"context_line":"    name   \u003d\u003e $::tempest::params::package_name,"},{"line_number":442,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"},{"line_number":443,"context_line":"    }"},{"line_number":444,"context_line":"  }"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3a461143_f777fcd1","line":442,"updated":"2017-01-26 13:04:25.000000000","message":"do the package provide tempest.conf? If yes where? I don\u0027t see orchestration saying we need the package *before* executing tempest_config provider and start to write in tempest.conf. Is it something required?","commit_id":"a50fea36dc2a42587671cfe790ef273f91b555a6"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4511c6ffe4fe607dd5808e980c7ecabace4ddfec","unresolved":false,"context_lines":[{"line_number":439,"context_line":"    package { \u0027tempest\u0027:"},{"line_number":440,"context_line":"    ensure \u003d\u003e $ensure_package,"},{"line_number":441,"context_line":"    name   \u003d\u003e $::tempest::params::package_name,"},{"line_number":442,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"},{"line_number":443,"context_line":"    }"},{"line_number":444,"context_line":"  }"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3a461143_093d502b","line":442,"in_reply_to":"3a461143_f777fcd1","updated":"2017-01-26 13:16:48.000000000","message":"Yes, the package provides tempest.conf, lies in /etc/tempest.","commit_id":"a50fea36dc2a42587671cfe790ef273f91b555a6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a264f4f145c74a1825bc2ff3a069a9f314d614d7","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    }"},{"line_number":439,"context_line":"  }"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"  if $::tempest::params::tempest_package and ! $install_from_source {"},{"line_number":442,"context_line":"    package { \u0027tempest\u0027:"},{"line_number":443,"context_line":"    ensure \u003d\u003e $ensure_package,"},{"line_number":444,"context_line":"    name   \u003d\u003e $::tempest::params::package_name,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a461143_d71e3d62","line":441,"range":{"start_line":441,"start_character":25,"end_line":441,"end_character":40},"updated":"2017-01-27 18:07:39.000000000","message":"package_name","commit_id":"2cf2b3e8602d1bcd70944d314311e52932084a4c"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"c9343c8c2622600293af10a5d92f639c0ae83413","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"  if $::tempest::params::package_name and ! $install_from_source {"},{"line_number":442,"context_line":"    package { \u0027tempest\u0027:"},{"line_number":443,"context_line":"    ensure \u003d\u003e $ensure_package,"},{"line_number":444,"context_line":"    name   \u003d\u003e $::tempest::params::package_name,"},{"line_number":445,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"},{"line_number":446,"context_line":"    }"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    # Create tempest workspace by running tempest init."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a461143_5a835404","line":445,"range":{"start_line":443,"start_character":4,"end_line":445,"end_character":47},"updated":"2017-01-27 18:45:16.000000000","message":"Wrong indentation","commit_id":"5b25ed9075f9f0184df3dc24ad294a81f4653e9f"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"0c2e33e4eb46a07380f290f73198a570a7231e2a","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    # Create tempest workspace by running tempest init."},{"line_number":449,"context_line":"    # It will generate etc/tempest.conf, logs and tempest_lock folder"},{"line_number":450,"context_line":"    # in tempest workspace"},{"line_number":451,"context_line":"    exec {\u0027tempest-workspace\u0027:"},{"line_number":452,"context_line":"      command \u003d\u003e \"tempest init ${tempest_workspace}\","},{"line_number":453,"context_line":"      cwd     \u003d\u003e $tempest_workspace,"},{"line_number":454,"context_line":"      require \u003d\u003e $::tempest::params::package_name,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a461143_7ae1f0fd","line":451,"range":{"start_line":451,"start_character":4,"end_line":451,"end_character":30},"updated":"2017-01-27 18:44:07.000000000","message":"We should enforce order somehow, exec must be after package is installed and tempest_config after workspace is created.","commit_id":"5b25ed9075f9f0184df3dc24ad294a81f4653e9f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f1ba2d5d34cb54a633bd05d0ace74fa974eb4932","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    # Create tempest workspace by running tempest init."},{"line_number":449,"context_line":"    # It will generate etc/tempest.conf, logs and tempest_lock folder"},{"line_number":450,"context_line":"    # in tempest workspace"},{"line_number":451,"context_line":"    exec {\u0027tempest-workspace\u0027:"},{"line_number":452,"context_line":"      command \u003d\u003e \"tempest init ${tempest_workspace}\","},{"line_number":453,"context_line":"      cwd     \u003d\u003e $tempest_workspace,"},{"line_number":454,"context_line":"      require \u003d\u003e $::tempest::params::package_name,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a461143_9af93c83","line":451,"range":{"start_line":451,"start_character":4,"end_line":451,"end_character":30},"in_reply_to":"3a461143_7ae1f0fd","updated":"2017-01-27 18:48:15.000000000","message":"require \u003d\u003e $::tempest::params::package_name, will solve the problem then tempest_workspace is created.","commit_id":"5b25ed9075f9f0184df3dc24ad294a81f4653e9f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6435dad9a89d41b7b9f36c571e37468364846675","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    $tempest_conf \u003d \"${tempest_workspace}/etc/tempest.conf\""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    Exec[\u0027tempest-workspace\u0027] -\u003e Tempest_config\u003c||\u003e"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    # Create tempest workspace by running tempest init."},{"line_number":453,"context_line":"    # It will generate etc/tempest.conf, logs and tempest_lock folder"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a461143_950e3839","line":450,"updated":"2017-01-30 17:19:09.000000000","message":"This should be below the exec definition. Move to line 461.","commit_id":"ca74b121f877f4c1cde9136628de5e7a0307f49b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6435dad9a89d41b7b9f36c571e37468364846675","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    exec {\u0027tempest-workspace\u0027:"},{"line_number":456,"context_line":"      command \u003d\u003e \"tempest init ${tempest_workspace}\","},{"line_number":457,"context_line":"      cwd     \u003d\u003e $tempest_workspace,"},{"line_number":458,"context_line":"      require \u003d\u003e $::tempest::params::package_name,"},{"line_number":459,"context_line":"    }"},{"line_number":460,"context_line":"  }"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a461143_986aefb1","line":458,"range":{"start_line":458,"start_character":16,"end_line":458,"end_character":50},"updated":"2017-01-30 17:19:09.000000000","message":"Package[\u0027tempest\u0027]","commit_id":"ca74b121f877f4c1cde9136628de5e7a0307f49b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3a473a70a8635f9b6aa406e77dc1ad214618d1dc","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    # Create tempest workspace by running tempest init."},{"line_number":451,"context_line":"    # It will generate etc/tempest.conf, logs and tempest_lock folder"},{"line_number":452,"context_line":"    # in tempest workspace"},{"line_number":453,"context_line":"    exec {\u0027tempest-workspace\u0027:"},{"line_number":454,"context_line":"      command \u003d\u003e \"tempest init ${tempest_workspace}\","},{"line_number":455,"context_line":"      cwd     \u003d\u003e $tempest_workspace,"},{"line_number":456,"context_line":"      require \u003d\u003e Package[\u0027tempest\u0027],"},{"line_number":457,"context_line":"    }"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    Exec[\u0027tempest-workspace\u0027] -\u003e Tempest_config\u003c||\u003e"},{"line_number":460,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a461143_a7af8628","line":457,"range":{"start_line":453,"start_character":0,"end_line":457,"end_character":5},"updated":"2017-01-30 19:53:44.000000000","message":"As previously mentioned in irc, this is not idempotent. You have two options.\n\n1) add refreshonly \u003d\u003e true and then use Package[\u0027tempest\u0027] ~\u003e Exec[\u0027tempest-workspace\u0027]. This would rerun this everytime the package is installed (and also upgraded)\n\n2) add creates \u003d\u003e $tempest_workspace, which would only run this once after the package is installed and if $tempest_workspace does not exist.","commit_id":"66e9f1bda4ef7554c20a1b947af42e7740816282"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"debb9874f9c2687f03d950a64daa993d352b1fdf","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    # Create tempest workspace by running tempest init."},{"line_number":451,"context_line":"    # It will generate etc/tempest.conf, logs and tempest_lock folder"},{"line_number":452,"context_line":"    # in tempest workspace"},{"line_number":453,"context_line":"    exec {\u0027tempest-workspace\u0027:"},{"line_number":454,"context_line":"      command \u003d\u003e \"tempest init ${tempest_workspace}\","},{"line_number":455,"context_line":"      cwd     \u003d\u003e $tempest_workspace,"},{"line_number":456,"context_line":"      require \u003d\u003e Package[\u0027tempest\u0027],"},{"line_number":457,"context_line":"    }"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    Exec[\u0027tempest-workspace\u0027] -\u003e Tempest_config\u003c||\u003e"},{"line_number":460,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a461143_590c063b","line":457,"range":{"start_line":453,"start_character":0,"end_line":457,"end_character":5},"in_reply_to":"3a461143_a7af8628","updated":"2017-01-30 19:58:24.000000000","message":"Oh also this needs path set path \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027] or it\u0027ll fail. It would be beneficial to include this in an acceptance test if the package already exists because I\u0027m pretty sure this exec will fail.","commit_id":"66e9f1bda4ef7554c20a1b947af42e7740816282"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"98979f3b5a26e0b706036464ad874a5c4449223e","unresolved":false,"context_lines":[{"line_number":451,"context_line":"    # It will generate etc/tempest.conf, logs and tempest_lock folder"},{"line_number":452,"context_line":"    # in tempest workspace"},{"line_number":453,"context_line":"    exec {\u0027tempest-workspace\u0027:"},{"line_number":454,"context_line":"      command \u003d\u003e \"tempest init ${tempest_workspace}\","},{"line_number":455,"context_line":"      cwd     \u003d\u003e $tempest_workspace,"},{"line_number":456,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":457,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":458,"context_line":"      require \u003d\u003e Package[\u0027tempest\u0027],"},{"line_number":459,"context_line":"    }"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    Package[\u0027tempest\u0027] ~\u003e Exec[\u0027tempest-workspace\u0027]"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a461143_6f973448","line":458,"range":{"start_line":454,"start_character":0,"end_line":458,"end_character":36},"updated":"2017-01-30 21:14:05.000000000","message":"lint will fail because the \u003d\u003e need to be lined up","commit_id":"6aea63a8984da533a6d751dc8b94f36e5fd90da9"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2b1533414ef61c972ad8434b1da140cbe0a69cd2","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    }"},{"line_number":439,"context_line":"  }"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"  if $::tempest::params::package_name and ! $install_from_source {"},{"line_number":442,"context_line":"    package { \u0027tempest\u0027:"},{"line_number":443,"context_line":"      ensure \u003d\u003e $ensure_package,"},{"line_number":444,"context_line":"      name   \u003d\u003e $::tempest::params::package_name,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"3a461143_affafc40","line":441,"range":{"start_line":441,"start_character":5,"end_line":441,"end_character":41},"updated":"2017-01-30 21:27:00.000000000","message":"This is redundant and can be removed, package_name will always be set - it has a value for both Ubuntu and CentOS.","commit_id":"bfff519edc2c4855c4135df3f82491e933a1dc4e"}],"releasenotes/notes/manifests-to-install-tempest-from-package-dbf74b77aced0ec4.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"670e8a1b9d7214859828f3b4fc894605abf4af88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Replace this text with content to appear at the top of the section for this"},{"line_number":4,"context_line":"    release. All of the prelude content is merged together and then rendered"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a461143_9736b801","line":1,"updated":"2017-01-26 13:04:25.000000000","message":"I think you forgot to edit this file.","commit_id":"a50fea36dc2a42587671cfe790ef273f91b555a6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f4487117239e477340a35e7ecad5a819fb58dfea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added manifests to install tempest from package"},{"line_number":4,"context_line":"  - Create tempest workspace to run tests"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a461143_e7a50e47","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":41},"updated":"2017-01-30 19:53:13.000000000","message":"this is not a feature, it doesn\u0027t need to be mentioned in the release note.","commit_id":"66e9f1bda4ef7554c20a1b947af42e7740816282"}],"spec/classes/tempest_init_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7fa994968161d03e8600b3e22529a95534921750","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      it \u0027configures image_ref\u0027 do"},{"line_number":34,"context_line":"        is_expected.to contain_tempest_config(\u0027compute/image_ref\u0027).with_value(\u00274c423fc6-87f7-4e6d-9d3c-abc13058ae5b\u0027)"},{"line_number":35,"context_line":"      end"},{"line_number":36,"context_line":"    enid"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    context \u0027with image_name\u0027 do"},{"line_number":39,"context_line":"      let :params do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a461143_8c909cee","line":36,"updated":"2017-01-25 16:44:38.000000000","message":"?","commit_id":"b0e673fc8bdbb2c7afa0b7f269eb6930e8d74d11"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7fa994968161d03e8600b3e22529a95534921750","unresolved":false,"context_lines":[{"line_number":198,"context_line":"          )"},{"line_number":199,"context_line":"        end"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"\t    it \u0027install Tempest packages\u0027 do"},{"line_number":202,"context_line":"          is_expected.to contain_package(\u0027tempest\u0027).with("},{"line_number":203,"context_line":"            :ensure \u003d\u003e \u0027present\u0027,"},{"line_number":204,"context_line":"            :tag \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027]"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a461143_ece760aa","line":201,"updated":"2017-01-25 16:44:38.000000000","message":"identation is not good here.","commit_id":"b0e673fc8bdbb2c7afa0b7f269eb6930e8d74d11"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7fa994968161d03e8600b3e22529a95534921750","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        end"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"\t    it \u0027install Tempest packages\u0027 do"},{"line_number":202,"context_line":"          is_expected.to contain_package(\u0027tempest\u0027).with("},{"line_number":203,"context_line":"            :ensure \u003d\u003e \u0027present\u0027,"},{"line_number":204,"context_line":"            :tag \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027]"},{"line_number":205,"context_line":"          )"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a461143_8ca7bc4e","line":202,"updated":"2017-01-25 16:44:38.000000000","message":"this test will fail, default is to setup from source. You need a new context to test this use case.","commit_id":"b0e673fc8bdbb2c7afa0b7f269eb6930e8d74d11"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"670e8a1b9d7214859828f3b4fc894605abf4af88","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    context \u0027Install Tempest package\u0027 do"},{"line_number":148,"context_line":"      let :params do"},{"line_number":149,"context_line":"        {:ensure_package \u003d\u003e \u0027present\u0027,"},{"line_number":150,"context_line":"         :install_from_source \u003d\u003e false"},{"line_number":151,"context_line":"        }"},{"line_number":152,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3a461143_1723a8be","line":149,"updated":"2017-01-26 13:04:25.000000000","message":"it\u0027s already the default. Unless you override it, no need to set it here.","commit_id":"a50fea36dc2a42587671cfe790ef273f91b555a6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8212d311d3c2de562d1398e08e15f4df84396c76","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    context \u0027with image_name parameters\u0027 do"},{"line_number":18,"context_line":"      let :params do"},{"line_number":19,"context_line":"        { :image_name \u003d\u003e \u0027image_name\u0027 }"},{"line_number":20,"context_line":"      end"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"      describe \"should raise error\" do"},{"line_number":23,"context_line":"        it { expect { is_expected.to contain_class(\u0027tempest::params\u0027) }.to raise_error(Puppet::Error, /A value for either image_name_alt or image_ref_alt/) }"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a461143_3d068dce","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":9},"updated":"2017-01-27 14:53:23.000000000","message":"add this block in your context.","commit_id":"2cf2b3e8602d1bcd70944d314311e52932084a4c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8bf12794d8d6c6e28f4fba9c61b6edb44a803b1f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    context \u0027with image_name parameters\u0027 do"},{"line_number":18,"context_line":"      let :params do"},{"line_number":19,"context_line":"        { :image_name \u003d\u003e \u0027image_name\u0027 }"},{"line_number":20,"context_line":"      end"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"      describe \"should raise error\" do"},{"line_number":23,"context_line":"        it { expect { is_expected.to contain_class(\u0027tempest::params\u0027) }.to raise_error(Puppet::Error, /A value for either image_name_alt or image_ref_alt/) }"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a461143_fd0405c1","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":9},"in_reply_to":"3a461143_3d068dce","updated":"2017-01-27 14:53:52.000000000","message":"well, just the image_name param.","commit_id":"2cf2b3e8602d1bcd70944d314311e52932084a4c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6435dad9a89d41b7b9f36c571e37468364846675","unresolved":false,"context_lines":[{"line_number":326,"context_line":"          is_expected.to contain_exec(\u0027tempest-workspace\u0027).with("},{"line_number":327,"context_line":"            :command \u003d\u003e \u0027tempest init /var/lib/tempest\u0027,"},{"line_number":328,"context_line":"            :cwd  \u003d\u003e \u0027/var/lib/tempest\u0027,"},{"line_number":329,"context_line":"            :require \u003d\u003e platform_params[:package_name]"},{"line_number":330,"context_line":"       )"},{"line_number":331,"context_line":"      end"},{"line_number":332,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3a461143_18d27f5c","line":329,"range":{"start_line":329,"start_character":24,"end_line":329,"end_character":54},"updated":"2017-01-30 17:19:09.000000000","message":"\u0027Package[tempest]\u0027","commit_id":"ca74b121f877f4c1cde9136628de5e7a0307f49b"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2b1533414ef61c972ad8434b1da140cbe0a69cd2","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        end"},{"line_number":308,"context_line":"      end"},{"line_number":309,"context_line":"    end"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    context \u0027install Tempest from package\u0027 do"},{"line_number":312,"context_line":"      let :params do"},{"line_number":313,"context_line":"        {:install_from_source \u003d\u003e false,"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"3a461143_0fc310ee","line":310,"updated":"2017-01-30 21:27:00.000000000","message":"Need an additional test to see that workspace path customization works","commit_id":"bfff519edc2c4855c4135df3f82491e933a1dc4e"}]}