)]}'
{"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1654dc86bd952818010c04f302866a2078fca27b","unresolved":false,"context_lines":[{"line_number":647,"context_line":"        name   \u003d\u003e $::tempest::params::python_neutron_tests,"},{"line_number":648,"context_line":"        tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"},{"line_number":649,"context_line":"      }"},{"line_number":650,"context_line":"     if $neutron_bgpvpn_available and $::tempest::params::python_bgpvpn_tests {"},{"line_number":651,"context_line":"        package { \u0027python-networking-bgpvpn-tests\u0027:"},{"line_number":652,"context_line":"          ensure \u003d\u003e present,"},{"line_number":653,"context_line":"          name   \u003d\u003e $::tempest::params::python_bgpvpn_tests,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bff0334d_4353e6e2","line":650,"updated":"2017-04-11 22:24:10.000000000","message":"lint is complaining because this needs another space in front","commit_id":"d60a96a907a0a4c4f4d4e61e0772659f05b500ca"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1654dc86bd952818010c04f302866a2078fca27b","unresolved":false,"context_lines":[{"line_number":653,"context_line":"          name   \u003d\u003e $::tempest::params::python_bgpvpn_tests,"},{"line_number":654,"context_line":"          tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"},{"line_number":655,"context_line":"        }"},{"line_number":656,"context_line":"     }"},{"line_number":657,"context_line":"     if $neutron_fwaas_available {"},{"line_number":658,"context_line":"        package { \u0027python-neutron-fwaas-tests\u0027:"},{"line_number":659,"context_line":"          ensure \u003d\u003e present,"},{"line_number":660,"context_line":"          name   \u003d\u003e $::tempest::params::python_fwaas_tests,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bff0334d_234ea237","line":657,"range":{"start_line":656,"start_character":0,"end_line":657,"end_character":34},"updated":"2017-04-11 22:24:10.000000000","message":"these two lines also need another space","commit_id":"d60a96a907a0a4c4f4d4e61e0772659f05b500ca"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"917b9c9ac64a2e2d2b2eff11f8ac5a1c8f5ad4bb","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"},{"line_number":649,"context_line":"      }"},{"line_number":650,"context_line":"      if $neutron_bgpvpn_available and $::tempest::params::python_bgpvpn_tests {"},{"line_number":651,"context_line":"        package { \u0027python-networking-bgpvpn-tests\u0027:"},{"line_number":652,"context_line":"          ensure \u003d\u003e present,"},{"line_number":653,"context_line":"          name   \u003d\u003e $::tempest::params::python_bgpvpn_tests,"},{"line_number":654,"context_line":"          tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_ca9dbbbc","line":651,"range":{"start_line":651,"start_character":19,"end_line":651,"end_character":49},"updated":"2017-04-12 08:48:33.000000000","message":"This seems to assume that the tempest plugin of networking-bgpvpn repo is packaged separately in a package named python-neutron-tests. I haven\u0027t checked, but I don\u0027t recall having seen this being done.\n\n\u003d\u003e Adding Luke as a reviewer for this specific point.","commit_id":"2d4d2eec69e6b1c5a95f8b542eff00de7701d7e0"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"2430d8ff28d8c7adfdf1e2a8296b20a7e90edd51","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"},{"line_number":649,"context_line":"      }"},{"line_number":650,"context_line":"      if $neutron_bgpvpn_available and $::tempest::params::python_bgpvpn_tests {"},{"line_number":651,"context_line":"        package { \u0027python-networking-bgpvpn-tests\u0027:"},{"line_number":652,"context_line":"          ensure \u003d\u003e present,"},{"line_number":653,"context_line":"          name   \u003d\u003e $::tempest::params::python_bgpvpn_tests,"},{"line_number":654,"context_line":"          tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7ffa3b31_24af3de4","line":651,"range":{"start_line":651,"start_character":19,"end_line":651,"end_character":49},"in_reply_to":"7ffa3b31_731ad87d","updated":"2017-04-18 14:38:02.000000000","message":"This seems to follow the standards, where the packages are split in code/docs/tests, looks good to me.","commit_id":"2d4d2eec69e6b1c5a95f8b542eff00de7701d7e0"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"1526438a7700d39b06cb0739a3953fb2157e32bb","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"},{"line_number":649,"context_line":"      }"},{"line_number":650,"context_line":"      if $neutron_bgpvpn_available and $::tempest::params::python_bgpvpn_tests {"},{"line_number":651,"context_line":"        package { \u0027python-networking-bgpvpn-tests\u0027:"},{"line_number":652,"context_line":"          ensure \u003d\u003e present,"},{"line_number":653,"context_line":"          name   \u003d\u003e $::tempest::params::python_bgpvpn_tests,"},{"line_number":654,"context_line":"          tag    \u003d\u003e [\u0027openstack\u0027, \u0027tempest-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7ffa3b31_731ad87d","line":651,"range":{"start_line":651,"start_character":19,"end_line":651,"end_character":49},"in_reply_to":"bff0334d_ca9dbbbc","updated":"2017-04-17 09:45:45.000000000","message":"Hi Thomas, we always try to split packages as much as possible and keeping the right dependencies. Please, take a look at this: https://github.com/rdo-packages/networking-bgpvpn-distgit/blob/rpm-master/python-networking-bgpvpn.spec#L81","commit_id":"2d4d2eec69e6b1c5a95f8b542eff00de7701d7e0"}]}