)]}'
{"manifests/init.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"46ce3f3b17644cafd425882ce7632b591609f669","unresolved":false,"context_lines":[{"line_number":212,"context_line":"#  [*baremetal_driver*]"},{"line_number":213,"context_line":"#   Defaults to \u0027fake-hardware\u0027"},{"line_number":214,"context_line":"#  [*baremetal_enabled_drivers*]"},{"line_number":215,"context_line":"#   Defaults to \u0027fake-hardware\u0027"},{"line_number":216,"context_line":"#  [*baremetal_enabled_hardware_types*]"},{"line_number":217,"context_line":"#   Defaults to \u0027ipmi,fake-hardware\u0027"},{"line_number":218,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_6e89f8c7","line":215,"updated":"2018-06-13 12:06:07.000000000","message":"1. The default should be \"fake\", 2. Let\u0027s mention that it\u0027s deprecated in Queens. Actually, if puppet-tempest is branched, we don\u0027t need it at all.","commit_id":"ff1723643ebb6201f2daca43b59ab739d71990e3"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cc6b46a5de4f0509cc7bb46a13221a9d7472050d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"#  [*baremetal_driver*]"},{"line_number":213,"context_line":"#   Defaults to \u0027fake-hardware\u0027"},{"line_number":214,"context_line":"#  [*baremetal_enabled_drivers*]"},{"line_number":215,"context_line":"#   Defaults to \u0027fake-hardware\u0027"},{"line_number":216,"context_line":"#  [*baremetal_enabled_hardware_types*]"},{"line_number":217,"context_line":"#   Defaults to \u0027ipmi,fake-hardware\u0027"},{"line_number":218,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_0e1e446f","line":215,"in_reply_to":"5f7c97a3_6e89f8c7","updated":"2018-06-13 12:12:27.000000000","message":"Done","commit_id":"ff1723643ebb6201f2daca43b59ab739d71990e3"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2595f25e0988b96b4dbae13f2acadbe93cbd87b2","unresolved":false,"context_lines":[{"line_number":355,"context_line":"  # designate options"},{"line_number":356,"context_line":"  $designate_nameservers            \u003d undef,"},{"line_number":357,"context_line":"  # ironic options"},{"line_number":358,"context_line":"  $baremetal_driver                 \u003d \u0027fake-hardware\u0027,"},{"line_number":359,"context_line":"  $baremetal_enabled_hardware_types \u003d \u0027ipmi,fake-hardware\u0027,"},{"line_number":360,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":361,"context_line":"  $tenant_name                      \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_749534e3","line":358,"range":{"start_line":358,"start_character":39,"end_line":358,"end_character":53},"updated":"2018-06-14 09:48:55.000000000","message":"defaults must be backwards compatible or we will break things until we get ironic changes promoted and in the repos.","commit_id":"f628aeebd74b8d7c5089b6c65824d40b7c7a1a6c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1cc458da1daa219fddd7805c90f8de57296df351","unresolved":false,"context_lines":[{"line_number":355,"context_line":"  # designate options"},{"line_number":356,"context_line":"  $designate_nameservers            \u003d undef,"},{"line_number":357,"context_line":"  # ironic options"},{"line_number":358,"context_line":"  $baremetal_driver                 \u003d \u0027fake-hardware\u0027,"},{"line_number":359,"context_line":"  $baremetal_enabled_hardware_types \u003d \u0027ipmi,fake-hardware\u0027,"},{"line_number":360,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":361,"context_line":"  $tenant_name                      \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_8879d093","line":358,"range":{"start_line":358,"start_character":39,"end_line":358,"end_character":53},"in_reply_to":"5f7c97a3_749534e3","updated":"2018-06-14 10:05:10.000000000","message":"What is incompatible here? This should work even in Pike..","commit_id":"f628aeebd74b8d7c5089b6c65824d40b7c7a1a6c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1df4da6fd63c163f9e88a2c91d78c21f9b2790f6","unresolved":false,"context_lines":[{"line_number":210,"context_line":"#   Valid primary flavor to use in Trove tests."},{"line_number":211,"context_line":"#   Defaults to $::os_service_default"},{"line_number":212,"context_line":"#  [*baremetal_driver*]"},{"line_number":213,"context_line":"#   Defaults to \u0027fake\u0027"},{"line_number":214,"context_line":"#  [*baremetal_enabled_hardware_types*]"},{"line_number":215,"context_line":"#   Defaults to \u0027ipmi\u0027"},{"line_number":216,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_61becf65","line":213,"range":{"start_line":213,"start_character":4,"end_line":213,"end_character":22},"updated":"2018-06-14 13:10:42.000000000","message":"please don\u0027t forget to change this to fake-hardware once we fix the integration tests","commit_id":"fae4bdd453b887a68f5339f133d28762f9682460"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d463fd3b3e6c4497ed5a00439476efbd0db57790","unresolved":false,"context_lines":[{"line_number":210,"context_line":"#   Valid primary flavor to use in Trove tests."},{"line_number":211,"context_line":"#   Defaults to $::os_service_default"},{"line_number":212,"context_line":"#  [*baremetal_driver*]"},{"line_number":213,"context_line":"#   Defaults to \u0027fake\u0027"},{"line_number":214,"context_line":"#  [*baremetal_enabled_hardware_types*]"},{"line_number":215,"context_line":"#   Defaults to \u0027ipmi\u0027"},{"line_number":216,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_811d2b74","line":213,"range":{"start_line":213,"start_character":4,"end_line":213,"end_character":22},"in_reply_to":"5f7c97a3_61becf65","updated":"2018-06-14 13:13:50.000000000","message":"sure, will take care.","commit_id":"fae4bdd453b887a68f5339f133d28762f9682460"}]}