)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"752c9ae8c42df8830e8f6bd8cc0fd468e8168030","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd03efd9_78abb94f","updated":"2022-01-22 12:12:40.000000000","message":"... and the following test patch revealed one problem.\n\nhttps://review.opendev.org/c/openstack/puppet-openstack-integration/+/825711","commit_id":"e75a769175ce85683cfab2e2df92e03890dbe81d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6f5d431f270a0a2bad75e1842d753618a53dfd7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7dcf2335_499336ea","updated":"2022-01-21 04:50:57.000000000","message":"The intention makes sense and the implementation looks almost good at my first glance.\n-1 mainly because of missing unit tests about the new parameter. It seems we haven\u0027t implemented unit tests for the other _setter type/provider so we can leave that for follow-up.\n\nI\u0027ve submitted a test patch to p-o-i to test this feature. We can use this for validation.\n https://review.opendev.org/c/openstack/puppet-openstack-integration/+/825711","commit_id":"e75a769175ce85683cfab2e2df92e03890dbe81d"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a4f57819e640f4dff9a625cb776514acb53ecdfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ef6d45fc_03537c93","updated":"2022-02-20 12:06:40.000000000","message":"Sorry for I missed some of Takashi\u0027s changes. I believe it\u0027s now all fixed.","commit_id":"9866b6c2088e0e9b93117e9405cfc249e32d851a"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"505de386c8e916fea73f5c60c4bf6f850c8dcdc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"11c776de_49d386a7","updated":"2022-02-20 09:58:17.000000000","message":"missing changes requested by Takashi","commit_id":"9866b6c2088e0e9b93117e9405cfc249e32d851a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64ad96b0e42a31a2b14aeb64549fcbe9a7c4a84d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b57a435_5439b837","in_reply_to":"ef6d45fc_03537c93","updated":"2022-02-20 13:52:57.000000000","message":"NP. I\u0027ve fixed one remaining comment which was still open.","commit_id":"9866b6c2088e0e9b93117e9405cfc249e32d851a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fcd5d1509f93bd40cbe56cddde4dc4b5a0ee2d68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1632ba0c_d8675ee9","updated":"2022-02-22 04:47:52.000000000","message":"tested in https://review.opendev.org/c/openstack/puppet-openstack-integration/+/825711","commit_id":"cb3c4e08252adc7d779c780a9c446bd7288455dc"}],"lib/puppet/provider/tempest_flavor_id_setter/openstack.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5313587066691af6b5c567b40a7f905eb2545ab1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  def get_flavor_id"},{"line_number":29,"context_line":"    if resource[:ensure] \u003d\u003d :present or resource[:ensure].nil?"},{"line_number":30,"context_line":"      if @image_id.nil?"},{"line_number":31,"context_line":"        images \u003d self.class.request(\u0027flavor\u0027, \u0027list\u0027, file_path)"},{"line_number":32,"context_line":"        img \u003d images.detect {|img| img[:name] \u003d\u003d resource[:image_name]}"},{"line_number":33,"context_line":"        if img.nil?"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"4958e222_777ef391","line":30,"range":{"start_line":30,"start_character":10,"end_line":30,"end_character":18},"updated":"2022-02-18 04:10:00.000000000","message":"flavor_id","commit_id":"26a6bd68c850ef3880ab0c2334f92217dd6b1e08"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f73585a1eeef62689e364f031e21f926cb130355","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  def get_flavor_id"},{"line_number":29,"context_line":"    if resource[:ensure] \u003d\u003d :present or resource[:ensure].nil?"},{"line_number":30,"context_line":"      if @image_id.nil?"},{"line_number":31,"context_line":"        images \u003d self.class.request(\u0027flavor\u0027, \u0027list\u0027, file_path)"},{"line_number":32,"context_line":"        img \u003d images.detect {|img| img[:name] \u003d\u003d resource[:image_name]}"},{"line_number":33,"context_line":"        if img.nil?"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7977e369_cd9fb134","line":30,"range":{"start_line":30,"start_character":10,"end_line":30,"end_character":18},"updated":"2022-02-18 10:19:09.000000000","message":"flavor_id. See patch set , to find what should be replaced.","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a4f57819e640f4dff9a625cb776514acb53ecdfa","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  def get_flavor_id"},{"line_number":29,"context_line":"    if resource[:ensure] \u003d\u003d :present or resource[:ensure].nil?"},{"line_number":30,"context_line":"      if @image_id.nil?"},{"line_number":31,"context_line":"        images \u003d self.class.request(\u0027flavor\u0027, \u0027list\u0027, file_path)"},{"line_number":32,"context_line":"        img \u003d images.detect {|img| img[:name] \u003d\u003d resource[:image_name]}"},{"line_number":33,"context_line":"        if img.nil?"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"ffddd525_70159730","line":30,"range":{"start_line":30,"start_character":10,"end_line":30,"end_character":18},"in_reply_to":"7977e369_cd9fb134","updated":"2022-02-20 12:06:40.000000000","message":"Done","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f73585a1eeef62689e364f031e21f926cb130355","unresolved":true,"context_lines":[{"line_number":28,"context_line":"  def get_flavor_id"},{"line_number":29,"context_line":"    if resource[:ensure] \u003d\u003d :present or resource[:ensure].nil?"},{"line_number":30,"context_line":"      if @image_id.nil?"},{"line_number":31,"context_line":"        images \u003d self.class.request(\u0027flavor\u0027, \u0027list\u0027, file_path)"},{"line_number":32,"context_line":"        img \u003d images.detect {|img| img[:name] \u003d\u003d resource[:image_name]}"},{"line_number":33,"context_line":"        if img.nil?"},{"line_number":34,"context_line":"          raise(Puppet::Error, \"Flavor #{resource[:image_name]} not found!\")"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"86478461_aa41292d","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":14},"updated":"2022-02-18 10:19:09.000000000","message":"flavors","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a4f57819e640f4dff9a625cb776514acb53ecdfa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  def get_flavor_id"},{"line_number":29,"context_line":"    if resource[:ensure] \u003d\u003d :present or resource[:ensure].nil?"},{"line_number":30,"context_line":"      if @image_id.nil?"},{"line_number":31,"context_line":"        images \u003d self.class.request(\u0027flavor\u0027, \u0027list\u0027, file_path)"},{"line_number":32,"context_line":"        img \u003d images.detect {|img| img[:name] \u003d\u003d resource[:image_name]}"},{"line_number":33,"context_line":"        if img.nil?"},{"line_number":34,"context_line":"          raise(Puppet::Error, \"Flavor #{resource[:image_name]} not found!\")"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"b5ae6aa0_70f4f34a","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":14},"in_reply_to":"86478461_aa41292d","updated":"2022-02-20 12:06:40.000000000","message":"Done","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f73585a1eeef62689e364f031e21f926cb130355","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    if resource[:ensure] \u003d\u003d :present or resource[:ensure].nil?"},{"line_number":30,"context_line":"      if @image_id.nil?"},{"line_number":31,"context_line":"        images \u003d self.class.request(\u0027flavor\u0027, \u0027list\u0027, file_path)"},{"line_number":32,"context_line":"        img \u003d images.detect {|img| img[:name] \u003d\u003d resource[:image_name]}"},{"line_number":33,"context_line":"        if img.nil?"},{"line_number":34,"context_line":"          raise(Puppet::Error, \"Flavor #{resource[:image_name]} not found!\")"},{"line_number":35,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"337d48ea_1d762837","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":11},"updated":"2022-02-18 10:19:09.000000000","message":"flavor","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a4f57819e640f4dff9a625cb776514acb53ecdfa","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    if resource[:ensure] \u003d\u003d :present or resource[:ensure].nil?"},{"line_number":30,"context_line":"      if @image_id.nil?"},{"line_number":31,"context_line":"        images \u003d self.class.request(\u0027flavor\u0027, \u0027list\u0027, file_path)"},{"line_number":32,"context_line":"        img \u003d images.detect {|img| img[:name] \u003d\u003d resource[:image_name]}"},{"line_number":33,"context_line":"        if img.nil?"},{"line_number":34,"context_line":"          raise(Puppet::Error, \"Flavor #{resource[:image_name]} not found!\")"},{"line_number":35,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"2150fba3_3031d6a9","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":11},"in_reply_to":"337d48ea_1d762837","updated":"2022-02-20 12:06:40.000000000","message":"Done","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"}],"lib/puppet/type/tempest_flavor_id_setter.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5313587066691af6b5c567b40a7f905eb2545ab1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  tempest_flavor_id_setter { \u0027flavor_id\u0027:"},{"line_number":4,"context_line":"#    tempest_conf_path \u003d\u003e \u0027/var/lib/tempest/etc/tempest.conf\u0027,"},{"line_number":5,"context_line":"#    image_name        \u003d\u003e $name,"},{"line_number":6,"context_line":"#  }"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"b155e1a1_741c2520","line":5,"range":{"start_line":5,"start_character":5,"end_line":5,"end_character":15},"updated":"2022-02-18 04:10:00.000000000","message":"flavor_name","commit_id":"26a6bd68c850ef3880ab0c2334f92217dd6b1e08"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f73585a1eeef62689e364f031e21f926cb130355","unresolved":true,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  tempest_flavor_id_setter { \u0027flavor_id\u0027:"},{"line_number":4,"context_line":"#    tempest_conf_path \u003d\u003e \u0027/var/lib/tempest/etc/tempest.conf\u0027,"},{"line_number":5,"context_line":"#    image_name        \u003d\u003e $name,"},{"line_number":6,"context_line":"#  }"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"08aebf22_025c866a","line":5,"updated":"2022-02-18 10:19:09.000000000","message":"flavor_name","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a4f57819e640f4dff9a625cb776514acb53ecdfa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#  tempest_flavor_id_setter { \u0027flavor_id\u0027:"},{"line_number":4,"context_line":"#    tempest_conf_path \u003d\u003e \u0027/var/lib/tempest/etc/tempest.conf\u0027,"},{"line_number":5,"context_line":"#    image_name        \u003d\u003e $name,"},{"line_number":6,"context_line":"#  }"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"b140b8db_7609c799","line":5,"in_reply_to":"08aebf22_025c866a","updated":"2022-02-20 12:06:40.000000000","message":"Done","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"}],"manifests/init.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6f5d431f270a0a2bad75e1842d753618a53dfd7e","unresolved":true,"context_lines":[{"line_number":318,"context_line":"  # Sahara config"},{"line_number":319,"context_line":"  $sahara_plugins                   \u003d undef,"},{"line_number":320,"context_line":"  # Trove config"},{"line_number":321,"context_line":"  $db_flavor_ref                    \u003d $::os_service_default,"},{"line_number":322,"context_line":"  # Service configuration"},{"line_number":323,"context_line":"  $cinder_available                 \u003d true,"},{"line_number":324,"context_line":"  $cinder_backup_available          \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"c10b5aab_fb9d4f1a","line":321,"range":{"start_line":321,"start_character":3,"end_line":321,"end_character":16},"updated":"2022-01-21 04:50:57.000000000","message":"Can we implement the same ?","commit_id":"e75a769175ce85683cfab2e2df92e03890dbe81d"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"339629bc5f3c5637709cf57719469aa017d5d7cf","unresolved":false,"context_lines":[{"line_number":318,"context_line":"  # Sahara config"},{"line_number":319,"context_line":"  $sahara_plugins                   \u003d undef,"},{"line_number":320,"context_line":"  # Trove config"},{"line_number":321,"context_line":"  $db_flavor_ref                    \u003d $::os_service_default,"},{"line_number":322,"context_line":"  # Service configuration"},{"line_number":323,"context_line":"  $cinder_available                 \u003d true,"},{"line_number":324,"context_line":"  $cinder_backup_available          \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"50579324_d2a9445a","line":321,"range":{"start_line":321,"start_character":3,"end_line":321,"end_character":16},"in_reply_to":"c10b5aab_fb9d4f1a","updated":"2022-02-17 21:30:40.000000000","message":"I\u0027m sorry, but I don\u0027t understand. Do you mean the flavor for Trove? Hum... Ok, adding it to the patch.","commit_id":"e75a769175ce85683cfab2e2df92e03890dbe81d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6f5d431f270a0a2bad75e1842d753618a53dfd7e","unresolved":true,"context_lines":[{"line_number":750,"context_line":"  }"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"  if ! $flavor_ref and $flavor_name {"},{"line_number":753,"context_line":"    tempest_flavor_id_setter { \u0027flavor_ref\u0027:"},{"line_number":754,"context_line":"      ensure            \u003d\u003e present,"},{"line_number":755,"context_line":"      tempest_conf_path \u003d\u003e $tempest_conf,"},{"line_number":756,"context_line":"      flavor_name       \u003d\u003e $flavor_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e9af1683_e69728f2","line":753,"range":{"start_line":753,"start_character":4,"end_line":753,"end_character":28},"updated":"2022-01-21 04:50:57.000000000","message":"Please add some unit test cases in spec/classes/tempest_init_conf_spec.rb to cover this new feature.","commit_id":"e75a769175ce85683cfab2e2df92e03890dbe81d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5313587066691af6b5c567b40a7f905eb2545ab1","unresolved":false,"context_lines":[{"line_number":750,"context_line":"  }"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"  if ! $flavor_ref and $flavor_name {"},{"line_number":753,"context_line":"    tempest_flavor_id_setter { \u0027flavor_ref\u0027:"},{"line_number":754,"context_line":"      ensure            \u003d\u003e present,"},{"line_number":755,"context_line":"      tempest_conf_path \u003d\u003e $tempest_conf,"},{"line_number":756,"context_line":"      flavor_name       \u003d\u003e $flavor_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dd434b09_a46b7a4a","line":753,"range":{"start_line":753,"start_character":4,"end_line":753,"end_character":28},"in_reply_to":"6aebfb79_197d189a","updated":"2022-02-18 04:10:00.000000000","message":"There already exists some tests to ensure *_setter resource is called, and you can add the same here.","commit_id":"e75a769175ce85683cfab2e2df92e03890dbe81d"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"339629bc5f3c5637709cf57719469aa017d5d7cf","unresolved":false,"context_lines":[{"line_number":750,"context_line":"  }"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"  if ! $flavor_ref and $flavor_name {"},{"line_number":753,"context_line":"    tempest_flavor_id_setter { \u0027flavor_ref\u0027:"},{"line_number":754,"context_line":"      ensure            \u003d\u003e present,"},{"line_number":755,"context_line":"      tempest_conf_path \u003d\u003e $tempest_conf,"},{"line_number":756,"context_line":"      flavor_name       \u003d\u003e $flavor_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6aebfb79_197d189a","line":753,"range":{"start_line":753,"start_character":4,"end_line":753,"end_character":28},"in_reply_to":"e9af1683_e69728f2","updated":"2022-02-17 21:30:40.000000000","message":"I\u0027m really unsure how to do this, and as you wrote, it\u0027s probably better to just use this in p-o-i.","commit_id":"e75a769175ce85683cfab2e2df92e03890dbe81d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"752c9ae8c42df8830e8f6bd8cc0fd468e8168030","unresolved":true,"context_lines":[{"line_number":765,"context_line":"    tempest_flavor_id_setter { \u0027flavor_ref_alt\u0027:"},{"line_number":766,"context_line":"      ensure            \u003d\u003e present,"},{"line_number":767,"context_line":"      tempest_conf_path \u003d\u003e $tempest_conf,"},{"line_number":768,"context_line":"      flavor_name_alt   \u003d\u003e $flavor_name_alt,"},{"line_number":769,"context_line":"    }"},{"line_number":770,"context_line":"    Tempest_config\u003c||\u003e -\u003e Tempest_flavor_id_setter[\u0027flavor_ref_alt\u0027]"},{"line_number":771,"context_line":"    Keystone_user_role\u003c||\u003e -\u003e Tempest_flavor_id_setter[\u0027flavor_ref_alt\u0027]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"02831cf9_57cc69e8","line":768,"range":{"start_line":768,"start_character":6,"end_line":768,"end_character":21},"updated":"2022-01-22 12:12:40.000000000","message":"should be flavor_name","commit_id":"e75a769175ce85683cfab2e2df92e03890dbe81d"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"339629bc5f3c5637709cf57719469aa017d5d7cf","unresolved":false,"context_lines":[{"line_number":765,"context_line":"    tempest_flavor_id_setter { \u0027flavor_ref_alt\u0027:"},{"line_number":766,"context_line":"      ensure            \u003d\u003e present,"},{"line_number":767,"context_line":"      tempest_conf_path \u003d\u003e $tempest_conf,"},{"line_number":768,"context_line":"      flavor_name_alt   \u003d\u003e $flavor_name_alt,"},{"line_number":769,"context_line":"    }"},{"line_number":770,"context_line":"    Tempest_config\u003c||\u003e -\u003e Tempest_flavor_id_setter[\u0027flavor_ref_alt\u0027]"},{"line_number":771,"context_line":"    Keystone_user_role\u003c||\u003e -\u003e Tempest_flavor_id_setter[\u0027flavor_ref_alt\u0027]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"471a76f1_de112dec","line":768,"range":{"start_line":768,"start_character":6,"end_line":768,"end_character":21},"in_reply_to":"02831cf9_57cc69e8","updated":"2022-02-17 21:30:40.000000000","message":"Done","commit_id":"e75a769175ce85683cfab2e2df92e03890dbe81d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aef957f1150e44764f67a4346a82c562269e66be","unresolved":true,"context_lines":[{"line_number":216,"context_line":"#   Valid primary flavor to use in Trove tests."},{"line_number":217,"context_line":"#   Defaults to $::os_service_default"},{"line_number":218,"context_line":"#  [*db_flavor_name*]"},{"line_number":219,"context_line":"#   Defaults to undef"},{"line_number":220,"context_line":"#  [*db_flavor_name*]"},{"line_number":221,"context_line":"#   Defaults to undef"},{"line_number":222,"context_line":"#  [*baremetal_driver*]"},{"line_number":223,"context_line":"#   Defaults to \u0027fake\u0027"},{"line_number":224,"context_line":"#  [*baremetal_enabled_hardware_types*]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bf661f22_dbfb5f6b","line":221,"range":{"start_line":219,"start_character":21,"end_line":221,"end_character":21},"updated":"2022-02-18 10:20:32.000000000","message":"this is duplicate.","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a4f57819e640f4dff9a625cb776514acb53ecdfa","unresolved":false,"context_lines":[{"line_number":216,"context_line":"#   Valid primary flavor to use in Trove tests."},{"line_number":217,"context_line":"#   Defaults to $::os_service_default"},{"line_number":218,"context_line":"#  [*db_flavor_name*]"},{"line_number":219,"context_line":"#   Defaults to undef"},{"line_number":220,"context_line":"#  [*db_flavor_name*]"},{"line_number":221,"context_line":"#   Defaults to undef"},{"line_number":222,"context_line":"#  [*baremetal_driver*]"},{"line_number":223,"context_line":"#   Defaults to \u0027fake\u0027"},{"line_number":224,"context_line":"#  [*baremetal_enabled_hardware_types*]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"55722157_849668da","line":221,"range":{"start_line":219,"start_character":21,"end_line":221,"end_character":21},"in_reply_to":"bf661f22_dbfb5f6b","updated":"2022-02-20 12:06:40.000000000","message":"Done","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"30af50ad6bab668b23c5a2d171367f70c7506bb1","unresolved":false,"context_lines":[{"line_number":811,"context_line":"    fail(\u0027flavor_ref_alt and flavor_name_alt are both set: please set only one of them\u0027)"},{"line_number":812,"context_line":"  }"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"  if ! $db_flavor_ref and $db_flavor_name {"},{"line_number":815,"context_line":"    tempest_flavor_id_setter { \u0027db_flavor_ref\u0027:"},{"line_number":816,"context_line":"      ensure            \u003d\u003e present,"},{"line_number":817,"context_line":"      tempest_conf_path \u003d\u003e $tempest_conf,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"c7e11639_5b3e15e9","line":814,"range":{"start_line":814,"start_character":8,"end_line":814,"end_character":21},"updated":"2022-02-20 15:14:55.000000000","message":"We should use is_service_default, because this defaults to $::os_service_default","commit_id":"f6a7e04a79959e38fedad32397489af433bb2653"}],"spec/classes/tempest_init_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3502f31d14ec854424d6f5dc13a83f9077105179","unresolved":true,"context_lines":[{"line_number":436,"context_line":"    end"},{"line_number":437,"context_line":"  end"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"  context \u0027with flavor_name parameters\u0027 do"},{"line_number":440,"context_line":"    let :params do"},{"line_number":441,"context_line":"      {"},{"line_number":442,"context_line":"        :flavor_name       \u003d\u003e \u0027m1.tiny\u0027,"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"a7450ec6_f2506d1d","line":439,"updated":"2022-02-18 10:17:26.000000000","message":"These should be put into shared_examples_for block. I previously put this to the 2nd block but it\u0027s better we add this to the 1st block.","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64ad96b0e42a31a2b14aeb64549fcbe9a7c4a84d","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    end"},{"line_number":437,"context_line":"  end"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"  context \u0027with flavor_name parameters\u0027 do"},{"line_number":440,"context_line":"    let :params do"},{"line_number":441,"context_line":"      {"},{"line_number":442,"context_line":"        :flavor_name       \u003d\u003e \u0027m1.tiny\u0027,"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"2bde4e06_1e802e14","line":439,"in_reply_to":"a7450ec6_f2506d1d","updated":"2022-02-20 13:52:57.000000000","message":"Done","commit_id":"8e365c7500fdec5059c17b3ac3ffdd361f9a27dd"}]}