)]}'
{"manifests/firewall/post.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"3a5a75a421a772a836b29fdf30bd391b20f85fd8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      proto \u003d\u003e \u0027all\u0027,"},{"line_number":41,"context_line":"      jump  \u003d\u003e \u0027LOG\u0027,"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":"    cloud::firewall::rule{ \u0027999 drop all\u0027:"},{"line_number":44,"context_line":"      proto  \u003d\u003e \u0027all\u0027,"},{"line_number":45,"context_line":"      action \u003d\u003e \u0027drop\u0027,"},{"line_number":46,"context_line":"      extras \u003d\u003e $firewall_settings,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_f7ad78e9","line":43,"updated":"2015-06-10 16:02:51.000000000","message":"s/cloud/tripleo/","commit_id":"00fae188876a52eaccbe4c6111549ef71190485c"}],"manifests/firewall/pre.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"3a5a75a421a772a836b29fdf30bd391b20f85fd8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  include ::firewall"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  # defaults \u0027pre\u0027 rules"},{"line_number":35,"context_line":"  cloud::firewall::rule{ \u0027000 accept related established rules\u0027:"},{"line_number":36,"context_line":"    proto  \u003d\u003e \u0027all\u0027,"},{"line_number":37,"context_line":"    state  \u003d\u003e [\u0027RELATED\u0027, \u0027ESTABLISHED\u0027],"},{"line_number":38,"context_line":"    extras \u003d\u003e $firewall_settings,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_f794588b","line":35,"updated":"2015-06-10 16:02:51.000000000","message":"s/cloud/tripleo/ and below too","commit_id":"00fae188876a52eaccbe4c6111549ef71190485c"}],"manifests/firewall/rule.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"3a5a75a421a772a836b29fdf30bd391b20f85fd8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"#  (optional) Hash of any puppetlabs-firewall supported parameters."},{"line_number":52,"context_line":"#  Defaults to {}"},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"define tripleo::firewall::rule ("},{"line_number":55,"context_line":"  $port    \u003d undef,"},{"line_number":56,"context_line":"  $proto   \u003d \u0027tcp\u0027,"},{"line_number":57,"context_line":"  $action  \u003d \u0027accept\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_770bc8d6","line":54,"updated":"2015-06-10 16:02:51.000000000","message":"What\u0027s the benfit of having this, why not just create firewall resources directly? (I\u0027m not against this, just trying to figure it out. The firewall resource doesn\u0027t seem very complicated to me so i\u0027m not sure if we need to wrap it.)","commit_id":"00fae188876a52eaccbe4c6111549ef71190485c"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"40d6e86a3f6a7177c83a0be12ac71f7824bd6741","unresolved":false,"context_lines":[{"line_number":51,"context_line":"#  (optional) Hash of any puppetlabs-firewall supported parameters."},{"line_number":52,"context_line":"#  Defaults to {}"},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"define tripleo::firewall::rule ("},{"line_number":55,"context_line":"  $port    \u003d undef,"},{"line_number":56,"context_line":"  $proto   \u003d \u0027tcp\u0027,"},{"line_number":57,"context_line":"  $action  \u003d \u0027accept\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_68498230","line":54,"in_reply_to":"3afb71cf_22599035","updated":"2015-06-11 12:36:57.000000000","message":"Not necessary to make both versions :) If you like it this way better, let\u0027s keep it this way. I don\u0027t think there\u0027s a big difference anyway, and if we have some trouble, we can switch any time. Let\u0027s go with this solution.","commit_id":"00fae188876a52eaccbe4c6111549ef71190485c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"32a7bb045074b370931911ca9fcfa746988dc644","unresolved":false,"context_lines":[{"line_number":51,"context_line":"#  (optional) Hash of any puppetlabs-firewall supported parameters."},{"line_number":52,"context_line":"#  Defaults to {}"},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"define tripleo::firewall::rule ("},{"line_number":55,"context_line":"  $port    \u003d undef,"},{"line_number":56,"context_line":"  $proto   \u003d \u0027tcp\u0027,"},{"line_number":57,"context_line":"  $action  \u003d \u0027accept\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3afb71cf_22599035","line":54,"in_reply_to":"3afb71cf_770bc8d6","updated":"2015-06-10 16:16:45.000000000","message":"I\u0027ll produce a PoC with both solutions and you\u0027ll decide which one you prefer.\nThis composition layer aimed to have lightweight code in our THT without useless parameters, that could have been leveraged by this code.","commit_id":"00fae188876a52eaccbe4c6111549ef71190485c"}],"spec/classes/tripleo_init_spec.rb":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"fed01e73b9dfb7e491100c1d5cabfd7ad114f33b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Unit tests for tripleo"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"require \u0027spec_helper\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba3cc151_043cebe0","line":16,"updated":"2015-06-30 14:47:22.000000000","message":"awesome","commit_id":"d091e46dc061d81c3a9e2f561efa15a4ee94a187"}]}