)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8f9199f7bcc8842271dc616926e4127aa954a9c2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add hiera calls to allow management of ports and protocols"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allows for the definition of ports and protocols (http vs https) to be"},{"line_number":10,"context_line":"offloaded to the HEAT templates ( https://review.openstack.org/231930 ) and avoids"},{"line_number":11,"context_line":"hard coding the port numbers for exposed ports"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1bbaa6fa7a3e9a7eea00d6771bb1be3c5bf6a15e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7a740942_15b6418a","line":10,"updated":"2015-12-11 08:50:19.000000000","message":"I think you should probably be pointing at https://review.openstack.org/#/c/238887/\nIe3270909beca3d63f2d7e4bcb04c559380ddc54d","commit_id":"563090a2a940e7867b78601d99318c5ac0a3b6f7"},{"author":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"change_message_id":"ce5fa10fb433cb51d35d6cdd93ff7a426559527b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add hiera calls to allow management of ports and protocols"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allows for the definition of ports and protocols (http vs https) to be"},{"line_number":10,"context_line":"offloaded to the HEAT templates ( https://review.openstack.org/231930 ) and avoids"},{"line_number":11,"context_line":"hard coding the port numbers for exposed ports"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1bbaa6fa7a3e9a7eea00d6771bb1be3c5bf6a15e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7a740942_18e8b87b","line":10,"in_reply_to":"7a740942_15b6418a","updated":"2015-12-11 08:59:59.000000000","message":"Yup, you\u0027re right here.","commit_id":"563090a2a940e7867b78601d99318c5ac0a3b6f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"756412ab32688e8791d965a145bc3014f9fc1756","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add hiera calls to allow management of ports and protocols"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allows for the definition of ports and protocols (http vs https) to be"},{"line_number":10,"context_line":"offloaded to the HEAT templates ( https://review.openstack.org/231930 ) and avoids"},{"line_number":11,"context_line":"hard coding the port numbers for exposed ports"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1bbaa6fa7a3e9a7eea00d6771bb1be3c5bf6a15e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7a740942_5382a153","line":10,"updated":"2015-12-11 09:06:20.000000000","message":"reminder for pointing to endpointmap","commit_id":"d35f86f2cefc26d0ac98634276be608885bf492f"}],"manifests/loadbalancer.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8f9199f7bcc8842271dc616926e4127aa954a9c2","unresolved":false,"context_lines":[{"line_number":518,"context_line":"      api_protocol     \u003d\u003e $keystone_admin_api_proto,"},{"line_number":519,"context_line":"      bind_certificate \u003d\u003e $keystone_bind_certificate,"},{"line_number":520,"context_line":"      ip_addresses     \u003d\u003e $keystone_admin_ips,"},{"line_number":521,"context_line":"    }"},{"line_number":522,"context_line":"  }"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"  if $keystone_public {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a740942_d872307c","line":521,"updated":"2015-12-11 08:50:19.000000000","message":"I think you miss the listen_options here please check the others too","commit_id":"563090a2a940e7867b78601d99318c5ac0a3b6f7"},{"author":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"change_message_id":"ce5fa10fb433cb51d35d6cdd93ff7a426559527b","unresolved":false,"context_lines":[{"line_number":518,"context_line":"      api_protocol     \u003d\u003e $keystone_admin_api_proto,"},{"line_number":519,"context_line":"      bind_certificate \u003d\u003e $keystone_bind_certificate,"},{"line_number":520,"context_line":"      ip_addresses     \u003d\u003e $keystone_admin_ips,"},{"line_number":521,"context_line":"    }"},{"line_number":522,"context_line":"  }"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"  if $keystone_public {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a740942_f8d60cc2","line":521,"in_reply_to":"7a740942_d872307c","updated":"2015-12-11 08:59:59.000000000","message":"The default in  tripleo::loadbalancer::balancer was set to match what\u0027s basically a huge pile of C\u0026P:\n\n$member_options \u003d [\u0027check\u0027, \u0027inter 2000\u0027, \u0027rise 2\u0027, \u0027fall 5\u0027]","commit_id":"563090a2a940e7867b78601d99318c5ac0a3b6f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c730616a7ac4c374aa391a30dacc33b0d18ca8c6","unresolved":false,"context_lines":[{"line_number":518,"context_line":"      api_protocol     \u003d\u003e $keystone_admin_api_proto,"},{"line_number":519,"context_line":"      bind_certificate \u003d\u003e $keystone_bind_certificate,"},{"line_number":520,"context_line":"      ip_addresses     \u003d\u003e $keystone_admin_ips,"},{"line_number":521,"context_line":"    }"},{"line_number":522,"context_line":"  }"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"  if $keystone_public {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a740942_78669c2a","line":521,"in_reply_to":"7a740942_f8d60cc2","updated":"2015-12-11 09:01:17.000000000","message":"yeah thanks mark and irc chat, completely missed it on balancer.pp","commit_id":"563090a2a940e7867b78601d99318c5ac0a3b6f7"}]}
