)]}'
{".fixtures.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"296a4f4a4e9a6740c077f1d82e11aa345041e817","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    tomcat: \u0027puppetlabs-tomcat\u0027"},{"line_number":10,"context_line":"    inifile: \u0027puppetlabs-inifile\u0027"},{"line_number":11,"context_line":"    cassandra: \u0027midonet-cassandra\u0027"},{"line_number":12,"context_line":"    zookeeper: \u0027deric-zookeeper\u0027"},{"line_number":13,"context_line":"    datacat: \u0027richardc-datacat\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da85f559_90989f1d","line":12,"updated":"2015-11-12 08:57:00.000000000","message":"i see deric-zookeeper seems the \u0027official\u0027 forge module (at least most popular/downloads)... for midonet-cassandra, just wondering, is there a need to use that specifically here... afaics you are just using cassandra::run so at least in the use here doesn\u0027t seem to be anything midonet specific?","commit_id":"46b8a9b2805dc4ec726c4e95ebdc6916722c0d7d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \u0027stdlib\u0027: \u0027git://github.com/puppetlabs/puppetlabs-stdlib.git\u0027"},{"line_number":5,"context_line":"  symlinks:"},{"line_number":6,"context_line":"    \"tripleo\": \"#{source_dir}\""},{"line_number":7,"context_line":"  forge_modules:"},{"line_number":8,"context_line":"    midonet: \u0027midonet-midonet\u0027"},{"line_number":9,"context_line":"    tomcat: \u0027puppetlabs-tomcat\u0027"},{"line_number":10,"context_line":"    inifile: \u0027puppetlabs-inifile\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba8a016a_3a4cac6f","line":7,"updated":"2015-11-17 17:47:14.000000000","message":"why are we pulling them from the forge? I suggest we keep consistency and use repositories, it will allow us to use custom branches if needed.","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d63ff712e2f31518dffa8ba81637d52823fa607","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \u0027stdlib\u0027: \u0027git://github.com/puppetlabs/puppetlabs-stdlib.git\u0027"},{"line_number":5,"context_line":"  symlinks:"},{"line_number":6,"context_line":"    \"tripleo\": \"#{source_dir}\""},{"line_number":7,"context_line":"  forge_modules:"},{"line_number":8,"context_line":"    midonet: \u0027midonet-midonet\u0027"},{"line_number":9,"context_line":"    tomcat: \u0027puppetlabs-tomcat\u0027"},{"line_number":10,"context_line":"    inifile: \u0027puppetlabs-inifile\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba8a016a_32b25e4d","line":7,"updated":"2015-11-18 14:54:57.000000000","message":"I think we should be consistent and use modules from repositories. Any reason to use Puppetforge?","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"47b21441cc14234d0cfac44550ce878059bb86f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \u0027stdlib\u0027: \u0027git://github.com/puppetlabs/puppetlabs-stdlib.git\u0027"},{"line_number":5,"context_line":"  symlinks:"},{"line_number":6,"context_line":"    \"tripleo\": \"#{source_dir}\""},{"line_number":7,"context_line":"  forge_modules:"},{"line_number":8,"context_line":"    midonet: \u0027midonet-midonet\u0027"},{"line_number":9,"context_line":"    tomcat: \u0027puppetlabs-tomcat\u0027"},{"line_number":10,"context_line":"    inifile: \u0027puppetlabs-inifile\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba8a016a_d238b2f1","line":7,"in_reply_to":"ba8a016a_32b25e4d","updated":"2015-11-18 15:18:48.000000000","message":"Because I thought they were more stable. But ok on changing them.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0294d346d1e17ba96c72c6295ca597eb524aefb9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      ref: \u00270.6.2\u0027"},{"line_number":23,"context_line":"    \u0027java\u0027:"},{"line_number":24,"context_line":"      repo: \u0027git://github.com/puppetlabs/puppetlabs-java\u0027"},{"line_number":25,"context_line":"      ref: \u00271.4.2\u0027"},{"line_number":26,"context_line":"  symlinks:"},{"line_number":27,"context_line":"    \"tripleo\": \"#{source_dir}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a8ffd7b_5fdffb0c","line":25,"updated":"2015-11-26 10:02:15.000000000","message":"do you have a bugzilla to track the modules we need to add in OPM? Otherwise they\u0027ll never be installed in RDO Manager.","commit_id":"95c87ea79bee85373c68befb43f46d975dafe241"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"ecc8acef2e4d17e5c6e6b488fe7f48b642384af9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      ref: \u00270.6.2\u0027"},{"line_number":23,"context_line":"    \u0027java\u0027:"},{"line_number":24,"context_line":"      repo: \u0027git://github.com/puppetlabs/puppetlabs-java\u0027"},{"line_number":25,"context_line":"      ref: \u00271.4.2\u0027"},{"line_number":26,"context_line":"  symlinks:"},{"line_number":27,"context_line":"    \"tripleo\": \"#{source_dir}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a8ffd7b_c52f9e86","line":25,"in_reply_to":"9a8ffd7b_5fdffb0c","updated":"2015-11-26 10:13:58.000000000","message":"Hi Emilien,\n\nThese modules are installed on the overcloud-network-midonet element.\n\nhttps://review.openstack.org/#/c/247382/\n\nIs that enough?","commit_id":"95c87ea79bee85373c68befb43f46d975dafe241"}],"lib/puppet/parser/functions/extract_id.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Custom function to extract the index from a list."},{"line_number":2,"context_line":"# The list are a list of hostname, and the index is the n\u0027th"},{"line_number":3,"context_line":"# position of the host in list"},{"line_number":4,"context_line":"module Puppet::Parser::Functions"},{"line_number":5,"context_line":"  newfunction(:extract_id, :type \u003d\u003e :rvalue) do |argv|"},{"line_number":6,"context_line":"    hosts \u003d argv[0]"},{"line_number":7,"context_line":"    if hosts.class !\u003d Array"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"ba8a016a_da124009","line":4,"updated":"2015-11-17 17:47:14.000000000","message":"Is it something stdlib can already do?\n\nhttps://github.com/puppetlabs/puppetlabs-stdlib/blob/master/lib/puppet/parser/functions/values_at.rb","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d63ff712e2f31518dffa8ba81637d52823fa607","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Custom function to extract the index from a list."},{"line_number":2,"context_line":"# The list are a list of hostname, and the index is the n\u0027th"},{"line_number":3,"context_line":"# position of the host in list"},{"line_number":4,"context_line":"module Puppet::Parser::Functions"},{"line_number":5,"context_line":"  newfunction(:extract_id, :type \u003d\u003e :rvalue) do |argv|"},{"line_number":6,"context_line":"    hosts \u003d argv[0]"},{"line_number":7,"context_line":"    if hosts.class !\u003d Array"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"ba8a016a_12c4fa5c","line":4,"updated":"2015-11-18 14:54:57.000000000","message":"not sure why this function is needed in tripleo and not in puppet-zookeeper","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"47b21441cc14234d0cfac44550ce878059bb86f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Custom function to extract the index from a list."},{"line_number":2,"context_line":"# The list are a list of hostname, and the index is the n\u0027th"},{"line_number":3,"context_line":"# position of the host in list"},{"line_number":4,"context_line":"module Puppet::Parser::Functions"},{"line_number":5,"context_line":"  newfunction(:extract_id, :type \u003d\u003e :rvalue) do |argv|"},{"line_number":6,"context_line":"    hosts \u003d argv[0]"},{"line_number":7,"context_line":"    if hosts.class !\u003d Array"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"ba8a016a_b5015807","line":4,"in_reply_to":"ba8a016a_12c4fa5c","updated":"2015-11-18 15:18:48.000000000","message":"Some background here:\n\nTo configure a zookeeper cluster, let\u0027s say with three nodes, you need something like this on the zoo.cfg file of all nodes:\n\n  server.1\u003d\u003cip_address_1\u003e\n  server.2\u003d\u003cip_address_2\u003e\n  server.3\u003d\u003cip_address_3\u003e\n\nThen, each server, arbitrarily, has to have one of the previous numeric values after the \u0027server\u0027 word on its \u0027/etc/zookeeper/conf/myid\u0027 file. So first node will have \u00271\u0027, second node will have \u00272\u0027, and third node will have \u00273\u0027. Well, it does not matter the value of each node as long as two of them don\u0027t use the same one. \n\nThis function extracts the index of the host\u0027s hostname inside a list of hostnames. It\u0027s a way to assign the numeric value for each node as good as any other one.\n\nSo, no. This can not be done in the zookeeper module but in the module that calls the zookeeper module and knows the hostnames of all the nodes involved in a cluster.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"572ecb312afdb182818da989ebf2dfc3563a912c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Custom function to extract the index from a list."},{"line_number":2,"context_line":"# The list are a list of hostname, and the index is the n\u0027th"},{"line_number":3,"context_line":"# position of the host in list"},{"line_number":4,"context_line":"module Puppet::Parser::Functions"},{"line_number":5,"context_line":"  newfunction(:extract_id, :type \u003d\u003e :rvalue) do |argv|"},{"line_number":6,"context_line":"    hosts \u003d argv[0]"},{"line_number":7,"context_line":"    if hosts.class !\u003d Array"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"ba8a016a_4795de3c","line":4,"in_reply_to":"ba8a016a_5bb05d8a","updated":"2015-11-18 16:57:20.000000000","message":"According to the module, this is how it should be done: https://github.com/deric/puppet-zookeeper#cluster-setup\n\nIs the caller who decides which value has to be on each node. I put this function on heat-templates-tripleo, but Steven Hardy didn\u0027t like it as well. I end up thinking is a design problem of the puppet module... However, puppetlabs people recommended me to use this module.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f33f3ea6d252eb96b6ef003213de891a12681eed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Custom function to extract the index from a list."},{"line_number":2,"context_line":"# The list are a list of hostname, and the index is the n\u0027th"},{"line_number":3,"context_line":"# position of the host in list"},{"line_number":4,"context_line":"module Puppet::Parser::Functions"},{"line_number":5,"context_line":"  newfunction(:extract_id, :type \u003d\u003e :rvalue) do |argv|"},{"line_number":6,"context_line":"    hosts \u003d argv[0]"},{"line_number":7,"context_line":"    if hosts.class !\u003d Array"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"ba8a016a_5bb05d8a","line":4,"in_reply_to":"ba8a016a_b5015807","updated":"2015-11-18 15:42:29.000000000","message":"Usually in Puppet, calling a module should works out of the box without any trick like this.\n\nI never saw a Puppet module that required such functions.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"}],"lib/puppet/parser/functions/list_to_zookeeper_hash.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"module Puppet::Parser::Functions"},{"line_number":7,"context_line":"  newfunction(:list_to_zookeeper_hash, :type \u003d\u003e :rvalue, :doc \u003d\u003e \u003c\u003c-EOS"},{"line_number":8,"context_line":"    This function returns Zookeper configuration list of hash"},{"line_number":9,"context_line":"    EOS"},{"line_number":10,"context_line":"  ) do |argv|"},{"line_number":11,"context_line":"    zk_list \u003d argv[0]"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"ba8a016a_da29e038","line":8,"updated":"2015-11-17 17:47:14.000000000","message":"That\u0027s some kind of code I would like to see in puppet-zookeeper module.\nIt has nothing to do with TripleO (or maybe?)","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d63ff712e2f31518dffa8ba81637d52823fa607","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# because a not-so-good design of the puppet-midonet module"},{"line_number":4,"context_line":"# and we hope to deprecate it soon."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"module Puppet::Parser::Functions"},{"line_number":7,"context_line":"  newfunction(:list_to_zookeeper_hash, :type \u003d\u003e :rvalue, :doc \u003d\u003e \u003c\u003c-EOS"},{"line_number":8,"context_line":"    This function returns Zookeper configuration list of hash"},{"line_number":9,"context_line":"    EOS"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"ba8a016a_7297863a","line":6,"updated":"2015-11-18 14:54:57.000000000","message":"same question","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"47b21441cc14234d0cfac44550ce878059bb86f2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# because a not-so-good design of the puppet-midonet module"},{"line_number":4,"context_line":"# and we hope to deprecate it soon."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"module Puppet::Parser::Functions"},{"line_number":7,"context_line":"  newfunction(:list_to_zookeeper_hash, :type \u003d\u003e :rvalue, :doc \u003d\u003e \u003c\u003c-EOS"},{"line_number":8,"context_line":"    This function returns Zookeper configuration list of hash"},{"line_number":9,"context_line":"    EOS"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"ba8a016a_353d68c4","line":6,"in_reply_to":"ba8a016a_7297863a","updated":"2015-11-18 15:18:48.000000000","message":"This function is needed by midonet::api and midonet::agent to to configure them with zookeeper data. The returning data does not configure zookeeper itself.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"}],"lib/puppet/parser/functions/validate_ip_address.rb":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b0cd450a830e6f8922758d2529a8713d096a5bed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Puppet::Parser::Functions"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  newfunction(:validate_ip_address, :doc \u003d\u003e \u003c\u003c-ENDHEREDOC"},{"line_number":4,"context_line":"    Validate that all values passed are valid IP addresses,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"ba8a016a_063215a7","line":1,"updated":"2015-11-20 08:27:47.000000000","message":"This really seems out of place here. If we *really* need to carry this function, but only until it is pushed to where it should live (where is validate_ipv4_address defined?), please put a bit TODO comment on this. I think others may feel more strongly...","commit_id":"61b00393e8e6964ac2880452f6f18c8468859a66"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"019a9795d3b7be501218aeb7f938d2e7b01fa379","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Puppet::Parser::Functions"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  newfunction(:validate_ip_address, :doc \u003d\u003e \u003c\u003c-ENDHEREDOC"},{"line_number":4,"context_line":"    Validate that all values passed are valid IP addresses,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"ba8a016a_817a6f22","line":1,"in_reply_to":"ba8a016a_063215a7","updated":"2015-11-20 08:52:58.000000000","message":"Agree. I already created a pull request to puppetlabs-stdlib:\n\nhttps://github.com/puppetlabs/puppetlabs-stdlib/pull/546\n\n:)","commit_id":"61b00393e8e6964ac2880452f6f18c8468859a66"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ea27c7507f281289c352b899a196aaa8280aec02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Puppet::Parser::Functions"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  newfunction(:validate_ip_address, :doc \u003d\u003e \u003c\u003c-ENDHEREDOC"},{"line_number":4,"context_line":"    Validate that all values passed are valid IP addresses,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"ba8a016a_bcdeb83b","line":1,"in_reply_to":"ba8a016a_817a6f22","updated":"2015-11-20 09:16:36.000000000","message":"jaume that is great","commit_id":"61b00393e8e6964ac2880452f6f18c8468859a66"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b0cd450a830e6f8922758d2529a8713d096a5bed","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    $my_ip \u003d \"1.2.3.4\""},{"line_number":9,"context_line":"    validate_ip_address($my_ip)"},{"line_number":10,"context_line":"    validate_bool(\"8.8.8.8\", \"172.16.0.1\", $my_ip)"},{"line_number":11,"context_line":"    "},{"line_number":12,"context_line":"    $my_ip \u003d \"3ffe:505:2\""},{"line_number":13,"context_line":"    validate_ip_address(1)"},{"line_number":14,"context_line":"    validate_ip_address($my_ip)"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"ba8a016a_2375cb30","line":11,"updated":"2015-11-20 08:27:47.000000000","message":"whitespace nit and below","commit_id":"61b00393e8e6964ac2880452f6f18c8468859a66"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8b128b6e89834ae2b9e06bcee818def0cbe65555","unresolved":false,"context_lines":[{"line_number":1,"context_line":"module Puppet::Parser::Functions"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  newfunction(:validate_ip_address, :doc \u003d\u003e \u003c\u003c-ENDHEREDOC"},{"line_number":4,"context_line":"    Validate that all values passed are valid IP addresses,"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"ba8a016a_3204e57c","line":1,"updated":"2015-11-23 10:43:30.000000000","message":"if you get another pass please add a TODO here to remove with pointer @ https://github.com/puppetlabs/puppetlabs-stdlib/pull/546","commit_id":"bbdf0cd994956c032a9a16e51a5a94e0827c3f7c"}],"manifests/cluster/cassandra.pp":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"0f2bd351cfbbb5f2ab56df3327263bc3c1060309","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"class tripleo::cluster::cassandra("},{"line_number":41,"context_line":"  $cassandra_servers  \u003d [],"},{"line_number":42,"context_line":"  $cassandra_ip       \u003d nil,"},{"line_number":43,"context_line":"  $storage_port       \u003d \u00277000\u0027,"},{"line_number":44,"context_line":"  $ssl_storage_port   \u003d \u00277001\u0027,"},{"line_number":45,"context_line":"  $client_port        \u003d \u00279042\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"da85f559_adf8a2c5","line":42,"updated":"2015-11-13 10:47:55.000000000","message":"Are these two parameters mandatory? if yes, please don\u0027t set them and mention it in the parameters documentation.\nIf no, please set $cassandra_ip to the undef value, not the nil one.","commit_id":"010ed154c0d97fa6eb0d191ef751dd28ba6055b5"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"10c66ea0e7eaa95db5c8276203294644a08c47b3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"class tripleo::cluster::cassandra("},{"line_number":41,"context_line":"  $cassandra_servers  \u003d [],"},{"line_number":42,"context_line":"  $cassandra_ip       \u003d nil,"},{"line_number":43,"context_line":"  $storage_port       \u003d \u00277000\u0027,"},{"line_number":44,"context_line":"  $ssl_storage_port   \u003d \u00277001\u0027,"},{"line_number":45,"context_line":"  $client_port        \u003d \u00279042\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"da85f559_4dc016e1","line":42,"in_reply_to":"da85f559_adf8a2c5","updated":"2015-11-13 11:05:30.000000000","message":"Done. Should I mention the mandatory ones? It is not just enough to mention the optionals?","commit_id":"010ed154c0d97fa6eb0d191ef751dd28ba6055b5"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"b35c1e0fd9f4f413be66643a2d5eaa281ab11dda","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# \u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*cassandra_servers*]"},{"line_number":23,"context_line":"#  All the IP addresses of the cassandra cluster"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*cassandra_ip*]"},{"line_number":26,"context_line":"#  IP address of the current host."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba8a016a_d67354b3","line":23,"updated":"2015-11-16 09:44:40.000000000","message":"Yes you should mention that this is a required parameter and which kind of data type this parameter should be set.","commit_id":"9af01acd1fda50122e62b7f67df48e270e3495ed"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"b35c1e0fd9f4f413be66643a2d5eaa281ab11dda","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#  All the IP addresses of the cassandra cluster"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*cassandra_ip*]"},{"line_number":26,"context_line":"#  IP address of the current host."},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*storage_port*]"},{"line_number":29,"context_line":"#  (optional) Inter-node cluster communication port. Default value: 7000."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba8a016a_f678d891","line":26,"updated":"2015-11-16 09:44:40.000000000","message":"Same here about the required mention","commit_id":"9af01acd1fda50122e62b7f67df48e270e3495ed"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"b35c1e0fd9f4f413be66643a2d5eaa281ab11dda","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  $client_port        \u003d \u00279042\u0027,"},{"line_number":46,"context_line":"  $client_port_thrift \u003d \u00279160\u0027"},{"line_number":47,"context_line":")"},{"line_number":48,"context_line":"{"},{"line_number":49,"context_line":"  class {\u0027::cassandra::run\u0027:"},{"line_number":50,"context_line":"    seeds              \u003d\u003e $cassandra_servers,"},{"line_number":51,"context_line":"    seed_address       \u003d\u003e $cassandra_ip,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba8a016a_966dccce","line":48,"updated":"2015-11-16 09:44:40.000000000","message":"Here I would suggest to add data types validation using puppet functions from the stdlib\nvalidate_array($cassandra_servers)\nvalidate_ipv4_address($cassandra_ip)","commit_id":"9af01acd1fda50122e62b7f67df48e270e3495ed"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#  (optional) Cassandra client port thrift."},{"line_number":44,"context_line":"#  Defaults to 9160."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class tripleo::cluster::cassandra("},{"line_number":47,"context_line":"  $cassandra_servers,"},{"line_number":48,"context_line":"  $cassandra_ip,"},{"line_number":49,"context_line":"  $storage_port       \u003d \u00277000\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_35635dde","line":46,"updated":"2015-11-17 17:47:14.000000000","message":"IMHO, we should not have such a class but rather use Hiera in TripleO Heat Templates directly.","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":53,"context_line":")"},{"line_number":54,"context_line":"{"},{"line_number":55,"context_line":"  validate_array($cassandra_servers)"},{"line_number":56,"context_line":"  validate_ipv4_address($cassandra_ip)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  class {\u0027::cassandra::run\u0027:"},{"line_number":59,"context_line":"    seeds              \u003d\u003e $cassandra_servers,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_daaec097","line":56,"updated":"2015-11-17 17:47:14.000000000","message":"can\u0027t we use IPv6?","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d63ff712e2f31518dffa8ba81637d52823fa607","unresolved":false,"context_lines":[{"line_number":53,"context_line":")"},{"line_number":54,"context_line":"{"},{"line_number":55,"context_line":"  validate_array($cassandra_servers)"},{"line_number":56,"context_line":"  validate_ipv4_address($cassandra_ip)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  class {\u0027::cassandra::run\u0027:"},{"line_number":59,"context_line":"    seeds              \u003d\u003e $cassandra_servers,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_f2ab7673","line":56,"updated":"2015-11-18 14:54:57.000000000","message":"what about ipv6? don\u0027t we support it?","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"572ecb312afdb182818da989ebf2dfc3563a912c","unresolved":false,"context_lines":[{"line_number":53,"context_line":")"},{"line_number":54,"context_line":"{"},{"line_number":55,"context_line":"  validate_array($cassandra_servers)"},{"line_number":56,"context_line":"  validate_ipv4_address($cassandra_ip)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  class {\u0027::cassandra::run\u0027:"},{"line_number":59,"context_line":"    seeds              \u003d\u003e $cassandra_servers,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_f9f59656","line":56,"in_reply_to":"ba8a016a_786c47d0","updated":"2015-11-18 16:57:20.000000000","message":"It seems like cassandra does not support ipv6 address for this: http://docs.datastax.com/en/cassandra/2.1/cassandra/configuration/configCassandra_yaml_r.html \n\nOnly it mentions IPv6 for rpc/client connections.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"47b21441cc14234d0cfac44550ce878059bb86f2","unresolved":false,"context_lines":[{"line_number":53,"context_line":")"},{"line_number":54,"context_line":"{"},{"line_number":55,"context_line":"  validate_array($cassandra_servers)"},{"line_number":56,"context_line":"  validate_ipv4_address($cassandra_ip)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  class {\u0027::cassandra::run\u0027:"},{"line_number":59,"context_line":"    seeds              \u003d\u003e $cassandra_servers,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_786c47d0","line":56,"in_reply_to":"ba8a016a_f2ab7673","updated":"2015-11-18 15:18:48.000000000","message":"Never tried a ipv6 address to configure cassandra... what\u0027s the \u0027generic\u0027 function? validate_ip_address?","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"}],"manifests/cluster/zookeeper.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"323fbe229dc0c59f3555c6d4c494977bcc6972fd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{"},{"line_number":38,"context_line":"  file {[\u0027/usr/lib\u0027, \u0027/usr/lib/zookeeper\u0027, \u0027/usr/lib/zookeeper/bin/\u0027]:"},{"line_number":39,"context_line":"    ensure \u003d\u003e directory"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  file {\u0027/usr/lib/zookeeper/bin/zkEnv.sh\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e link,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_cddc6a75","line":40,"updated":"2015-11-11 19:06:25.000000000","message":"Curious: Does the zookeeper package not create these directories for us?","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"3995ba7c36b619bc2d8170db9832eb6ae41d0f1d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{"},{"line_number":38,"context_line":"  file {[\u0027/usr/lib\u0027, \u0027/usr/lib/zookeeper\u0027, \u0027/usr/lib/zookeeper/bin/\u0027]:"},{"line_number":39,"context_line":"    ensure \u003d\u003e directory"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  file {\u0027/usr/lib/zookeeper/bin/zkEnv.sh\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e link,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_198dd3d5","line":40,"in_reply_to":"da85f559_cddc6a75","updated":"2015-11-11 21:15:06.000000000","message":"Actually it doesn\u0027t. For some reason the package creates a file on /usr/libexec/zkEnv.sh with the environment variables, but the service expects the zkEnv.sh on /usr/lib/zookeeper/bin. I ingore why. I have to say that this version of zookeeper is shipped in midonet repos (http://repo.midonet.org/misc/RHEL/7/misc/x86_64/), I don\u0027t know exactly when it was built, and may have deprecated behavior.","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"323fbe229dc0c59f3555c6d4c494977bcc6972fd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  file {\u0027/usr/lib/zookeeper/bin/zkEnv.sh\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e link,"},{"line_number":44,"context_line":"    target \u003d\u003e \u0027/usr/libexec/zkEnv.sh\u0027"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  class {\u0027::zookeeper\u0027:"},{"line_number":48,"context_line":"    servers   \u003d\u003e $zookeeper_server_ips,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_2dd2d65c","line":45,"updated":"2015-11-11 19:06:25.000000000","message":"Is :midonet::midonet_api::run the class that generates the actual zkEnv.sh here?","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"3995ba7c36b619bc2d8170db9832eb6ae41d0f1d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  file {\u0027/usr/lib/zookeeper/bin/zkEnv.sh\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e link,"},{"line_number":44,"context_line":"    target \u003d\u003e \u0027/usr/libexec/zkEnv.sh\u0027"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  class {\u0027::zookeeper\u0027:"},{"line_number":48,"context_line":"    servers   \u003d\u003e $zookeeper_server_ips,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_d9a98b25","line":45,"in_reply_to":"da85f559_2dd2d65c","updated":"2015-11-11 21:15:06.000000000","message":"No. midonet_api::run only generates and configures the web.xml for the tomcat endpoint.","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"296a4f4a4e9a6740c077f1d82e11aa345041e817","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# \u003d\u003d Class: tripleo::cluster::zookeeper"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Deploys a cassandra service that belongs to a cluster. Uses puppet-cassandra"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# \u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_7c6957f8","line":18,"updated":"2015-11-12 08:57:00.000000000","message":"nit ^^","commit_id":"46b8a9b2805dc4ec726c4e95ebdc6916722c0d7d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"296a4f4a4e9a6740c077f1d82e11aa345041e817","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    ensure \u003d\u003e directory"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  file {\u0027/usr/lib/zookeeper/bin/zkEnv.sh\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e link,"},{"line_number":44,"context_line":"    target \u003d\u003e \u0027/usr/libexec/zkEnv.sh\u0027"},{"line_number":45,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_bc7b3fbd","line":42,"updated":"2015-11-12 08:57:00.000000000","message":"to be clear, are we talking about this file https://github.com/apache/zookeeper/blob/trunk/bin/zkEnv.sh","commit_id":"46b8a9b2805dc4ec726c4e95ebdc6916722c0d7d"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"0f2bd351cfbbb5f2ab56df3327263bc3c1060309","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class tripleo::cluster::zookeeper("},{"line_number":33,"context_line":"  $zookeeper_server_ips \u003d [],"},{"line_number":34,"context_line":"  $zookeeper_client_ip  \u003d nil,"},{"line_number":35,"context_line":"  $zookeeper_hostnames  \u003d []"},{"line_number":36,"context_line":")"},{"line_number":37,"context_line":"{"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"da85f559_6d02bab6","line":34,"updated":"2015-11-13 10:47:55.000000000","message":"Same here, s/nil/undef/","commit_id":"010ed154c0d97fa6eb0d191ef751dd28ba6055b5"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"10c66ea0e7eaa95db5c8276203294644a08c47b3","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class tripleo::cluster::zookeeper("},{"line_number":33,"context_line":"  $zookeeper_server_ips \u003d [],"},{"line_number":34,"context_line":"  $zookeeper_client_ip  \u003d nil,"},{"line_number":35,"context_line":"  $zookeeper_hostnames  \u003d []"},{"line_number":36,"context_line":")"},{"line_number":37,"context_line":"{"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"da85f559_ad5421ca","line":34,"in_reply_to":"da85f559_6d02bab6","updated":"2015-11-13 11:05:30.000000000","message":"Done","commit_id":"010ed154c0d97fa6eb0d191ef751dd28ba6055b5"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"b35c1e0fd9f4f413be66643a2d5eaa281ab11dda","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class tripleo::cluster::zookeeper("},{"line_number":33,"context_line":"  $zookeeper_server_ips,"},{"line_number":34,"context_line":"  $zookeeper_client_ip,"},{"line_number":35,"context_line":"  $zookeeper_hostnames"},{"line_number":36,"context_line":")"},{"line_number":37,"context_line":"{"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba8a016a_5668c4ba","line":34,"updated":"2015-11-16 09:44:40.000000000","message":"The same here.","commit_id":"9af01acd1fda50122e62b7f67df48e270e3495ed"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5cb821bb7e5d5adf2826f06e79ad40bbced34f16","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# \u003d\u003d Class: tripleo::cluster::zookeeper"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Deploys a cassandra service that belongs to a cluster. Uses puppet-cassandra"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# \u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_a57df11d","line":18,"updated":"2015-11-17 13:03:36.000000000","message":"nit ^^^","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#  Array of strings value."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class tripleo::cluster::zookeeper("},{"line_number":37,"context_line":"  $zookeeper_server_ips,"},{"line_number":38,"context_line":"  $zookeeper_client_ip,"},{"line_number":39,"context_line":"  $zookeeper_hostnames"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_950fa92d","line":36,"updated":"2015-11-17 17:47:14.000000000","message":"IMHO, we should not have such a class but rather use Hiera in TripleO Heat Templates directly.","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":40,"context_line":")"},{"line_number":41,"context_line":"{"},{"line_number":42,"context_line":"  validate_array($zookeeper_server_ips)"},{"line_number":43,"context_line":"  validate_ipv4_address($zookeeper_client_ip)"},{"line_number":44,"context_line":"  validate_array($zookeeper_hostnames)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  file {[\u0027/usr/lib\u0027, \u0027/usr/lib/zookeeper\u0027, \u0027/usr/lib/zookeeper/bin/\u0027]:"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_1a8c4834","line":43,"updated":"2015-11-17 17:47:14.000000000","message":"same question","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  validate_ipv4_address($zookeeper_client_ip)"},{"line_number":44,"context_line":"  validate_array($zookeeper_hostnames)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  file {[\u0027/usr/lib\u0027, \u0027/usr/lib/zookeeper\u0027, \u0027/usr/lib/zookeeper/bin/\u0027]:"},{"line_number":47,"context_line":"    ensure \u003d\u003e directory"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_fa04e47e","line":46,"updated":"2015-11-17 17:47:14.000000000","message":"It should be managed by packaging and not Puppet.\nCreating such directories is confusing and overlaps with packaging work. It\u0027s also dangerous because of default Puppet SElinux contexts. We\u0027ve seen a lot of issues when managing such files/directories.\n\nPlease do not do this.","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ensure \u003d\u003e directory"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  file {\u0027/usr/lib/zookeeper/bin/zkEnv.sh\u0027:"},{"line_number":51,"context_line":"    ensure \u003d\u003e link,"},{"line_number":52,"context_line":"    target \u003d\u003e \u0027/usr/libexec/zkEnv.sh\u0027"},{"line_number":53,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_5aee50b5","line":50,"updated":"2015-11-17 17:47:14.000000000","message":"you should rather rely on packaging for the dependency.","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d63ff712e2f31518dffa8ba81637d52823fa607","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  validate_ipv4_address($zookeeper_client_ip)"},{"line_number":44,"context_line":"  validate_array($zookeeper_hostnames)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  file {[\u0027/usr/lib\u0027, \u0027/usr/lib/zookeeper\u0027, \u0027/usr/lib/zookeeper/bin/\u0027]:"},{"line_number":47,"context_line":"    ensure \u003d\u003e directory"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_f21e16ba","line":46,"updated":"2015-11-18 14:54:57.000000000","message":"like I said in my previous comment this should be managed by packaging.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"194c25be781d4c414b1538af9faad43a159621dc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  validate_ipv4_address($zookeeper_client_ip)"},{"line_number":44,"context_line":"  validate_array($zookeeper_hostnames)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  file {[\u0027/usr/lib\u0027, \u0027/usr/lib/zookeeper\u0027, \u0027/usr/lib/zookeeper/bin/\u0027]:"},{"line_number":47,"context_line":"    ensure \u003d\u003e directory"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_fbab5173","line":46,"in_reply_to":"ba8a016a_38e0ff28","updated":"2015-11-18 15:35:34.000000000","message":"I suggest in the meanwhile we keep this code, but add a #TODO to fix the zookeeper packaging as soon as possible because this is very bad practice to write this kind of code in Puppet manifests.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"47b21441cc14234d0cfac44550ce878059bb86f2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  validate_ipv4_address($zookeeper_client_ip)"},{"line_number":44,"context_line":"  validate_array($zookeeper_hostnames)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  file {[\u0027/usr/lib\u0027, \u0027/usr/lib/zookeeper\u0027, \u0027/usr/lib/zookeeper/bin/\u0027]:"},{"line_number":47,"context_line":"    ensure \u003d\u003e directory"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_38e0ff28","line":46,"in_reply_to":"ba8a016a_f21e16ba","updated":"2015-11-18 15:18:48.000000000","message":"Agree... But what to do meanwhile?","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"572ecb312afdb182818da989ebf2dfc3563a912c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  validate_ipv4_address($zookeeper_client_ip)"},{"line_number":44,"context_line":"  validate_array($zookeeper_hostnames)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  file {[\u0027/usr/lib\u0027, \u0027/usr/lib/zookeeper\u0027, \u0027/usr/lib/zookeeper/bin/\u0027]:"},{"line_number":47,"context_line":"    ensure \u003d\u003e directory"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_a7c92a28","line":46,"in_reply_to":"ba8a016a_fbab5173","updated":"2015-11-18 16:57:20.000000000","message":"Done","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"}],"manifests/network/midonet/agent.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"323fbe229dc0c59f3555c6d4c494977bcc6972fd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# \u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*zookeeper_servers*]"},{"line_number":23,"context_line":"#  List of IPs of the zookeeper server cluster. MidoNet needs to connect to"},{"line_number":24,"context_line":"#  ZooKeeper to know the virtual network topology and execute netlink requests"},{"line_number":25,"context_line":"#  to the kernel. It will configure the connection using the 2181 port."},{"line_number":26,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_0a86d8da","line":23,"updated":"2015-11-11 19:06:25.000000000","message":"Mentioning MidoNet here is probably not the right place for this documentation. Perhaps this goes into the calling manifest?","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"3995ba7c36b619bc2d8170db9832eb6ae41d0f1d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# \u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*zookeeper_servers*]"},{"line_number":23,"context_line":"#  List of IPs of the zookeeper server cluster. MidoNet needs to connect to"},{"line_number":24,"context_line":"#  ZooKeeper to know the virtual network topology and execute netlink requests"},{"line_number":25,"context_line":"#  to the kernel. It will configure the connection using the 2181 port."},{"line_number":26,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_9966a328","line":23,"in_reply_to":"da85f559_0a86d8da","updated":"2015-11-11 21:15:06.000000000","message":"True. I\u0027ll remove it.","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"323fbe229dc0c59f3555c6d4c494977bcc6972fd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  service {\u0027openvswitch\u0027:"},{"line_number":38,"context_line":"    ensure \u003d\u003e stopped,"},{"line_number":39,"context_line":"    enable \u003d\u003e false"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  exec {\u0027delete datapaths\u0027:"},{"line_number":43,"context_line":"    command \u003d\u003e \u0027/usr/bin/mm-dpctl --delete-dp ovs-system\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_ca253009","line":40,"updated":"2015-11-11 19:06:25.000000000","message":"We may want to simply control this via Hiera. Ideally the vswitch puppet module would support parameters to enable/disable openvwitch. Perhaps just leave a FIXME on this for now until we can land that upstream in the vswitch module.","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"3995ba7c36b619bc2d8170db9832eb6ae41d0f1d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  service {\u0027openvswitch\u0027:"},{"line_number":38,"context_line":"    ensure \u003d\u003e stopped,"},{"line_number":39,"context_line":"    enable \u003d\u003e false"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  exec {\u0027delete datapaths\u0027:"},{"line_number":43,"context_line":"    command \u003d\u003e \u0027/usr/bin/mm-dpctl --delete-dp ovs-system\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_b96927fb","line":40,"in_reply_to":"da85f559_ca253009","updated":"2015-11-11 21:15:06.000000000","message":"Done","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"323fbe229dc0c59f3555c6d4c494977bcc6972fd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  notify {\u0027tetas\u0027:"},{"line_number":49,"context_line":"  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  notice(\u0027tetas\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  # Configure and run the agent"},{"line_number":54,"context_line":"  class {\u0027::midonet::midonet_agent::run\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_cacd3086","line":51,"updated":"2015-11-11 19:06:25.000000000","message":"is this log statement meant to be here?","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"3995ba7c36b619bc2d8170db9832eb6ae41d0f1d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  notify {\u0027tetas\u0027:"},{"line_number":49,"context_line":"  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  notice(\u0027tetas\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  # Configure and run the agent"},{"line_number":54,"context_line":"  class {\u0027::midonet::midonet_agent::run\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_994d439c","line":51,"in_reply_to":"da85f559_cacd3086","updated":"2015-11-11 21:15:06.000000000","message":"Hahah. No. I forgot it. Please don\u0027t look for the spanish translation.","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"296a4f4a4e9a6740c077f1d82e11aa345041e817","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*zookeeper_servers*]"},{"line_number":23,"context_line":"#  List of IPs of the zookeeper server cluster. It will configure the"},{"line_number":24,"context_line":"#  connection using the 2181 port."},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*cassandra_seeds*]"},{"line_number":27,"context_line":"#  List of IPs of the cassandra cluster."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_304a1327","line":24,"updated":"2015-11-12 08:57:00.000000000","message":"may want to point to/mention list_to_zookeeper_hash.rb though if i understood it is a temp hack","commit_id":"46b8a9b2805dc4ec726c4e95ebdc6916722c0d7d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"296a4f4a4e9a6740c077f1d82e11aa345041e817","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  exec {\u0027delete datapaths\u0027:"},{"line_number":43,"context_line":"    command \u003d\u003e \u0027/usr/bin/mm-dpctl --delete-dp ovs-system\u0027,"},{"line_number":44,"context_line":"    path    \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin\u0027,"},{"line_number":45,"context_line":"    onlyif  \u003d\u003e \u0027/usr/bin/mm-dpctl --show-dp ovs-system\u0027"},{"line_number":46,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_30121358","line":43,"updated":"2015-11-12 08:57:00.000000000","message":"i guess mm-dpctl is installed by the mido packages","commit_id":"46b8a9b2805dc4ec726c4e95ebdc6916722c0d7d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#  (required) List of IPs of the cassandra cluster."},{"line_number":29,"context_line":"#  Array of strings value."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"class tripleo::network::midonet::agent ("},{"line_number":32,"context_line":"  $zookeeper_servers,"},{"line_number":33,"context_line":"  $cassandra_seeds"},{"line_number":34,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_9afef836","line":31,"updated":"2015-11-17 17:47:14.000000000","message":"this class should not exist, you should rather have this code in ::midonet::midonet_agent. See my remarks:","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  service {\u0027openvswitch\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e stopped,"},{"line_number":44,"context_line":"    enable \u003d\u003e false"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  exec {\u0027delete datapaths\u0027:"},{"line_number":48,"context_line":"    command \u003d\u003e \u0027/usr/bin/mm-dpctl --delete-dp ovs-system\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_ba9f3c02","line":45,"updated":"2015-11-17 17:47:14.000000000","message":"why not putting it in ::midonet::midonet_agent ?","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    enable \u003d\u003e false"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  exec {\u0027delete datapaths\u0027:"},{"line_number":48,"context_line":"    command \u003d\u003e \u0027/usr/bin/mm-dpctl --delete-dp ovs-system\u0027,"},{"line_number":49,"context_line":"    path    \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin\u0027,"},{"line_number":50,"context_line":"    onlyif  \u003d\u003e \u0027/usr/bin/mm-dpctl --show-dp ovs-system\u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_9a8598ae","line":47,"updated":"2015-11-17 17:47:14.000000000","message":"same question","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d63ff712e2f31518dffa8ba81637d52823fa607","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  # FIXME: This statement should be controlled by hiera on heat templates"},{"line_number":40,"context_line":"  # project"},{"line_number":41,"context_line":"  # Make sure openvswitch service is not running"},{"line_number":42,"context_line":"  service {\u0027openvswitch\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e stopped,"},{"line_number":44,"context_line":"    enable \u003d\u003e false"},{"line_number":45,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_32dededd","line":42,"updated":"2015-11-18 14:54:57.000000000","message":"why not putting this code in ::midonet::midonet_agent ?","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"47b21441cc14234d0cfac44550ce878059bb86f2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  # FIXME: This statement should be controlled by hiera on heat templates"},{"line_number":40,"context_line":"  # project"},{"line_number":41,"context_line":"  # Make sure openvswitch service is not running"},{"line_number":42,"context_line":"  service {\u0027openvswitch\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e stopped,"},{"line_number":44,"context_line":"    enable \u003d\u003e false"},{"line_number":45,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_785687cf","line":42,"in_reply_to":"ba8a016a_32dededd","updated":"2015-11-18 15:18:48.000000000","message":"If it is on midonet::midonet_agent, we are assuming that openvswitch service is available in all the machines. That\u0027s true for TripleO, but does not need to be on other environments.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"135a3fe91fc6e32f7b925d578d7242f73f66561b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  # FIXME: This statement should be controlled by hiera on heat templates"},{"line_number":40,"context_line":"  # project"},{"line_number":41,"context_line":"  # Make sure openvswitch service is not running"},{"line_number":42,"context_line":"  service {\u0027openvswitch\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e stopped,"},{"line_number":44,"context_line":"    enable \u003d\u003e false"},{"line_number":45,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_1b7df5b0","line":42,"in_reply_to":"ba8a016a_785687cf","updated":"2015-11-18 15:44:01.000000000","message":"fair enough, keep it then...","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d63ff712e2f31518dffa8ba81637d52823fa607","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    enable \u003d\u003e false"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  exec {\u0027delete datapaths\u0027:"},{"line_number":48,"context_line":"    command \u003d\u003e \u0027/usr/bin/mm-dpctl --delete-dp ovs-system\u0027,"},{"line_number":49,"context_line":"    path    \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin\u0027,"},{"line_number":50,"context_line":"    onlyif  \u003d\u003e \u0027/usr/bin/mm-dpctl --show-dp ovs-system\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_12e15a9a","line":47,"updated":"2015-11-18 14:54:57.000000000","message":"same question","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"47b21441cc14234d0cfac44550ce878059bb86f2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    enable \u003d\u003e false"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  exec {\u0027delete datapaths\u0027:"},{"line_number":48,"context_line":"    command \u003d\u003e \u0027/usr/bin/mm-dpctl --delete-dp ovs-system\u0027,"},{"line_number":49,"context_line":"    path    \u003d\u003e \u0027/usr/bin:/usr/sbin:/bin\u0027,"},{"line_number":50,"context_line":"    onlyif  \u003d\u003e \u0027/usr/bin/mm-dpctl --show-dp ovs-system\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_985b2bf6","line":47,"in_reply_to":"ba8a016a_12e15a9a","updated":"2015-11-18 15:18:48.000000000","message":"same answer :)","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"}],"manifests/network/midonet/api.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"323fbe229dc0c59f3555c6d4c494977bcc6972fd","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  package {\u0027midonet-api\u0027:"},{"line_number":77,"context_line":"    ensure \u003d\u003e present"},{"line_number":78,"context_line":"  } -\u003e"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  class {\u0027::midonet::midonet_api::run\u0027:"},{"line_number":81,"context_line":"    zk_servers           \u003d\u003e list_to_zookeeper_hash($zookeeper_servers),"},{"line_number":82,"context_line":"    keystone_auth        \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_ad9806c1","line":79,"updated":"2015-11-11 19:06:25.000000000","message":"Presumably this is what generates the zkEnv.sh file? Perhaps leave a note here that explains how this works...","commit_id":"6d8f3793fee28af9658c6b089aada012f63665fa"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"0f2bd351cfbbb5f2ab56df3327263bc3c1060309","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $bind_address              \u003d nil,"},{"line_number":65,"context_line":"  $admin_user_name           \u003d \u0027admin\u0027,"},{"line_number":66,"context_line":"  $admin_password            \u003d nil,"},{"line_number":67,"context_line":"  $admin_tenant_name         \u003d \u0027admin\u0027"},{"line_number":68,"context_line":")"},{"line_number":69,"context_line":"{"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"da85f559_cdf5e6cb","line":67,"updated":"2015-11-13 10:47:55.000000000","message":"Please, use undef value instead of nil value.","commit_id":"010ed154c0d97fa6eb0d191ef751dd28ba6055b5"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"10c66ea0e7eaa95db5c8276203294644a08c47b3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $bind_address              \u003d nil,"},{"line_number":65,"context_line":"  $admin_user_name           \u003d \u0027admin\u0027,"},{"line_number":66,"context_line":"  $admin_password            \u003d nil,"},{"line_number":67,"context_line":"  $admin_tenant_name         \u003d \u0027admin\u0027"},{"line_number":68,"context_line":")"},{"line_number":69,"context_line":"{"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"da85f559_cdff25a9","line":67,"in_reply_to":"da85f559_cdf5e6cb","updated":"2015-11-13 11:05:30.000000000","message":"Done","commit_id":"010ed154c0d97fa6eb0d191ef751dd28ba6055b5"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"b35c1e0fd9f4f413be66643a2d5eaa281ab11dda","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $bind_address,"},{"line_number":65,"context_line":"  $admin_user_name       \u003d \u0027admin\u0027,"},{"line_number":66,"context_line":"  $admin_password,"},{"line_number":67,"context_line":"  $admin_tenant_name     \u003d \u0027admin\u0027"},{"line_number":68,"context_line":")"},{"line_number":69,"context_line":"{"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba8a016a_b67250ac","line":67,"updated":"2015-11-16 09:44:40.000000000","message":"The required parametes should be listed first.","commit_id":"9af01acd1fda50122e62b7f67df48e270e3495ed"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e6e8f3faa1f6f4e813ae7cf146b4faad46d17f7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"#  Defaults to \u0027admin\u0027"},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class tripleo::network::midonet::api("},{"line_number":69,"context_line":"  $zookeeper_servers,"},{"line_number":70,"context_line":"  $vip,"},{"line_number":71,"context_line":"  $keystone_ip,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba8a016a_5a541020","line":68,"updated":"2015-11-17 17:47:14.000000000","message":"IMHO, we should not have such a class but rather use Hiera in TripleO Heat Templates directly.\n\nAll this logic should reside in puppet-midonet itself.","commit_id":"26d672e901cbae211302fa1995a3ca4ef7c441c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4d63ff712e2f31518dffa8ba81637d52823fa607","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  validate_array($zookeeper_servers)"},{"line_number":82,"context_line":"  validate_ipv4_address($vip)"},{"line_number":83,"context_line":"  validate_ipv4_address($keystone_ip)"},{"line_number":84,"context_line":"  validate_ipv4_address($bind_address)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  # Run Tomcat and MidoNet API"},{"line_number":87,"context_line":"  class {\u0027::tomcat\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_b2972eeb","line":84,"updated":"2015-11-18 14:54:57.000000000","message":"what about ipv6?","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"572ecb312afdb182818da989ebf2dfc3563a912c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  validate_array($zookeeper_servers)"},{"line_number":82,"context_line":"  validate_ipv4_address($vip)"},{"line_number":83,"context_line":"  validate_ipv4_address($keystone_ip)"},{"line_number":84,"context_line":"  validate_ipv4_address($bind_address)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  # Run Tomcat and MidoNet API"},{"line_number":87,"context_line":"  class {\u0027::tomcat\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_670d82e7","line":84,"in_reply_to":"ba8a016a_5b25bdbe","updated":"2015-11-18 16:57:20.000000000","message":"Yep, I don\u0027t see any problems here, I\u0027ll do.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"135a3fe91fc6e32f7b925d578d7242f73f66561b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  validate_array($zookeeper_servers)"},{"line_number":82,"context_line":"  validate_ipv4_address($vip)"},{"line_number":83,"context_line":"  validate_ipv4_address($keystone_ip)"},{"line_number":84,"context_line":"  validate_ipv4_address($bind_address)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  # Run Tomcat and MidoNet API"},{"line_number":87,"context_line":"  class {\u0027::tomcat\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_5b25bdbe","line":84,"in_reply_to":"ba8a016a_7824475f","updated":"2015-11-18 15:44:01.000000000","message":"it would be great to support ipv6, which is a general interest in tripleo.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"47b21441cc14234d0cfac44550ce878059bb86f2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  validate_array($zookeeper_servers)"},{"line_number":82,"context_line":"  validate_ipv4_address($vip)"},{"line_number":83,"context_line":"  validate_ipv4_address($keystone_ip)"},{"line_number":84,"context_line":"  validate_ipv4_address($bind_address)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  # Run Tomcat and MidoNet API"},{"line_number":87,"context_line":"  class {\u0027::tomcat\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba8a016a_7824475f","line":84,"in_reply_to":"ba8a016a_b2972eeb","updated":"2015-11-18 15:18:48.000000000","message":"I have never tried to deploy it, but yeah, we can move it to a more generic validation.","commit_id":"697c99cb7ae232558a84e3fcd91fe9e51bf90eab"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b0cd450a830e6f8922758d2529a8713d096a5bed","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  validate_array($zookeeper_servers)"},{"line_number":82,"context_line":"  validate_ip_address($vip)"},{"line_number":83,"context_line":"  validate_ip_address($keystone_ip)"},{"line_number":84,"context_line":"  validate_ip_address($bind_address)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  # Run Tomcat and MidoNet API"},{"line_number":87,"context_line":"  class {\u0027::tomcat\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba8a016a_06a1b5f7","line":84,"updated":"2015-11-20 08:27:47.000000000","message":"why do we have to carry this function here, is there no way to push that validation into wherever validate_ipv4_address is defined. (couldn\u0027t quickly find this)","commit_id":"61b00393e8e6964ac2880452f6f18c8468859a66"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"019a9795d3b7be501218aeb7f938d2e7b01fa379","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  validate_array($zookeeper_servers)"},{"line_number":82,"context_line":"  validate_ip_address($vip)"},{"line_number":83,"context_line":"  validate_ip_address($keystone_ip)"},{"line_number":84,"context_line":"  validate_ip_address($bind_address)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  # Run Tomcat and MidoNet API"},{"line_number":87,"context_line":"  class {\u0027::tomcat\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba8a016a_61a66baf","line":84,"in_reply_to":"ba8a016a_06a1b5f7","updated":"2015-11-20 08:52:58.000000000","message":"It should be on puppetlabs-stdlib. See my other comment.","commit_id":"61b00393e8e6964ac2880452f6f18c8468859a66"}]}
