)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"fe0ab3a3804d4daf147754f6e16e24fc02ae17a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is provided by either:"},{"line_number":14,"context_line":"- Facter version 3.x"},{"line_number":15,"context_line":"- Facter 2.x containing the netmask6 facts"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Otherwise no interface would be matched."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_b3c17a31","line":15,"updated":"2015-12-11 12:59:50.000000000","message":"Shouldn\u0027t we reference the necessary code developed here https://bugzilla.redhat.com/show_bug.cgi?id\u003d1283387 as a example of how to have it on facter 2.X ?","commit_id":"2f92dc0d6eca30ee52c24a247057a3f52df046e8"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"a668e4f1ac61e5f82f2eee0f970a954726104cb8","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is provided by either:"},{"line_number":14,"context_line":"- Facter version 3.x"},{"line_number":15,"context_line":"- Facter 2.x containing the netmask6 facts"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Otherwise no interface would be matched."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_5fe57fd9","line":15,"in_reply_to":"7a740942_b3c17a31","updated":"2015-12-14 00:45:55.000000000","message":"Done","commit_id":"2f92dc0d6eca30ee52c24a247057a3f52df046e8"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a23645f2a99b95aba94e00784d6f511b3c11c601","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- Facter version 3.x"},{"line_number":16,"context_line":"- Facter 2.x containing the netmask6 facts"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Fix bugs https://bugzilla.redhat.com/show_bug.cgi?id\u003d1280523"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ide26ca1740dc12ea5f47a28f4cecacd6ef0b18f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a740942_5e332f14","line":18,"updated":"2015-12-14 11:22:52.000000000","message":"I though that a message more in the line of \"This code won\u0027t work on puppet 2.X if you don\u0027t have the code uploaded in there https://bugzilla....\".  But, what you did may be enough.  Your choice.","commit_id":"8648a4dcd2a3596d5a5b07a9612ecc38777d8517"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"262263de937d31212ccf84128a3fb62468f785d2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- Facter version 3.x"},{"line_number":16,"context_line":"- Facter 2.x containing the netmask6 facts"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Fix bugs https://bugzilla.redhat.com/show_bug.cgi?id\u003d1280523"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ide26ca1740dc12ea5f47a28f4cecacd6ef0b18f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a710552_382b92ed","line":18,"in_reply_to":"7a740942_5e332f14","updated":"2015-12-15 05:06:41.000000000","message":"Maybe both the link and the message would be ideal.\n\nAlthough that\u0027s going to be superseded with the new patch set which is going to be providing custom facts to avoid dependencies issues.","commit_id":"8648a4dcd2a3596d5a5b07a9612ecc38777d8517"}],"lib/facter/netmask_ipv6.rb":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"2f691b30926c6844ced2b946f6c88336a7bca2e5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        tmp.shift if tmp"},{"line_number":30,"context_line":"      end"},{"line_number":31,"context_line":"    end"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  Facter.add(\u0027netmask6\u0027) do"},{"line_number":35,"context_line":"    setcode do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a7e1126_a867c04b","line":32,"updated":"2015-12-18 16:30:11.000000000","message":"Don\u0027t know if it\u0027s relevant for this use case, but ipaddress6_ goes into great length to avoid \"local\" ipv6 address.  Shouldn\u0027t the netmask6_ code do the same.  But I\u0027m not sure that it\u0027s useful here : the code complexity/ratio would increase a lot for not that useful feature.  So unless somebody see in which case that could be a problem.  I tend to think it\u0027s better like this.\n\nI check when adding a \"public\" ipv6 address, this address get chosen instead of the \"private\" one.","commit_id":"11a0619a290d64f3caa45435a23f3e503530087a"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"59dca813972aef9b2d5029fb444bf4b37b195c4c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        tmp.shift if tmp"},{"line_number":30,"context_line":"      end"},{"line_number":31,"context_line":"    end"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  Facter.add(\u0027netmask6\u0027) do"},{"line_number":35,"context_line":"    setcode do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a7e1126_407f02ab","line":32,"in_reply_to":"3a7e1126_a867c04b","updated":"2015-12-19 02:40:27.000000000","message":"I\u0027m not following what you mean by \u0027avoid local ipv6 address\u0027.\n\nThe netmask6_ code has to find the ipv6 address related to each interface, at contrary we already know the address for netmask6 by using ipaddress6 fact.\n\nAlso the lifespan of this code is only for facter \u003c 3.","commit_id":"11a0619a290d64f3caa45435a23f3e503530087a"}],"lib/puppet/parser/functions/interface_for_ip.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2731da1f31da49093521c6e7efdc72b9e740891a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      begin"},{"line_number":11,"context_line":"        ip1 \u003d IPAddr.new(arg[0])"},{"line_number":12,"context_line":"        Dir.foreach(\u0027/sys/class/net/\u0027) do |interface|"},{"line_number":13,"context_line":"          next if interface \u003d\u003d \u0027.\u0027 || interface \u003d\u003d \u0027..\u0027"},{"line_number":14,"context_line":"          iface_no_dash \u003d interface.gsub(\u0027-\u0027, \u0027_\u0027)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"          if ip1.ipv4?"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7a740942_24aea998","line":13,"updated":"2015-12-11 10:17:21.000000000","message":"why you changed \u0027or\u0027 to \u0027||\u0027? it should be the same, shouldn\u0027t it?","commit_id":"2f92dc0d6eca30ee52c24a247057a3f52df046e8"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"fe0ab3a3804d4daf147754f6e16e24fc02ae17a2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      begin"},{"line_number":11,"context_line":"        ip1 \u003d IPAddr.new(arg[0])"},{"line_number":12,"context_line":"        Dir.foreach(\u0027/sys/class/net/\u0027) do |interface|"},{"line_number":13,"context_line":"          next if interface \u003d\u003d \u0027.\u0027 || interface \u003d\u003d \u0027..\u0027"},{"line_number":14,"context_line":"          iface_no_dash \u003d interface.gsub(\u0027-\u0027, \u0027_\u0027)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"          if ip1.ipv4?"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7a740942_87bc3cbc","line":13,"in_reply_to":"7a740942_24aea998","updated":"2015-12-11 12:59:50.000000000","message":"I think it\u0027s because of https://github.com/bbatsov/ruby-style-guide#no-and-or-or","commit_id":"2f92dc0d6eca30ee52c24a247057a3f52df046e8"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b7d9ec50ea994a1b1f3ccb33407de21cc247fc25","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      begin"},{"line_number":11,"context_line":"        ip1 \u003d IPAddr.new(arg[0])"},{"line_number":12,"context_line":"        Dir.foreach(\u0027/sys/class/net/\u0027) do |interface|"},{"line_number":13,"context_line":"          next if interface \u003d\u003d \u0027.\u0027 || interface \u003d\u003d \u0027..\u0027"},{"line_number":14,"context_line":"          iface_no_dash \u003d interface.gsub(\u0027-\u0027, \u0027_\u0027)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"          if ip1.ipv4?"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7a740942_79bba5c4","line":13,"in_reply_to":"7a740942_6a668552","updated":"2015-12-14 11:30:31.000000000","message":"Thank you Athlan.","commit_id":"2f92dc0d6eca30ee52c24a247057a3f52df046e8"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"a668e4f1ac61e5f82f2eee0f970a954726104cb8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      begin"},{"line_number":11,"context_line":"        ip1 \u003d IPAddr.new(arg[0])"},{"line_number":12,"context_line":"        Dir.foreach(\u0027/sys/class/net/\u0027) do |interface|"},{"line_number":13,"context_line":"          next if interface \u003d\u003d \u0027.\u0027 || interface \u003d\u003d \u0027..\u0027"},{"line_number":14,"context_line":"          iface_no_dash \u003d interface.gsub(\u0027-\u0027, \u0027_\u0027)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"          if ip1.ipv4?"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7a740942_6a668552","line":13,"in_reply_to":"7a740942_87bc3cbc","updated":"2015-12-14 00:45:55.000000000","message":"Indeed","commit_id":"2f92dc0d6eca30ee52c24a247057a3f52df046e8"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"fe0ab3a3804d4daf147754f6e16e24fc02ae17a2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            return interface if ip1.mask(netmask) \u003d\u003d ip2.mask(netmask)"},{"line_number":29,"context_line":"          end"},{"line_number":30,"context_line":"        end"},{"line_number":31,"context_line":"      rescue JSON::ParserError"},{"line_number":32,"context_line":"        raise Puppet::ParseError, \"Syntax error: #{arg[0]} is invalid\""},{"line_number":33,"context_line":"      end"},{"line_number":34,"context_line":"    else"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7a740942_b373ba4d","line":31,"updated":"2015-12-11 12:59:50.000000000","message":"The error IPAddr::InvalidAddressError: invalid address should be catch as ip1 \u003d IPAddr.new can fail if invalid ip is received.","commit_id":"2f92dc0d6eca30ee52c24a247057a3f52df046e8"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"a668e4f1ac61e5f82f2eee0f970a954726104cb8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            return interface if ip1.mask(netmask) \u003d\u003d ip2.mask(netmask)"},{"line_number":29,"context_line":"          end"},{"line_number":30,"context_line":"        end"},{"line_number":31,"context_line":"      rescue JSON::ParserError"},{"line_number":32,"context_line":"        raise Puppet::ParseError, \"Syntax error: #{arg[0]} is invalid\""},{"line_number":33,"context_line":"      end"},{"line_number":34,"context_line":"    else"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7a740942_ea003536","line":31,"in_reply_to":"7a740942_b373ba4d","updated":"2015-12-14 00:45:55.000000000","message":"Yes we can improve the legacy code too.\nConsider it done.","commit_id":"2f92dc0d6eca30ee52c24a247057a3f52df046e8"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"a23645f2a99b95aba94e00784d6f511b3c11c601","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            return interface if ip1.mask(netmask) \u003d\u003d ip2.mask(netmask)"},{"line_number":29,"context_line":"          end"},{"line_number":30,"context_line":"        end"},{"line_number":31,"context_line":"      rescue IPAddr::InvalidAddressError \u003d\u003e e"},{"line_number":32,"context_line":"        raise Puppet::ParseError, \"#{e}: #{arg[0]}\""},{"line_number":33,"context_line":"      end"},{"line_number":34,"context_line":"    else"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"7a740942_be701309","line":31,"updated":"2015-12-14 11:22:52.000000000","message":"I didn\u0027t think about removing JSON::ParserError.  What I had in mind was more like:\n\n   rescue JSON::ParserError, IPAddr::InvalidAddressError \u003d\u003e e\n\nbut now that I look at it, I cannot see what would raise the JSON::ParserError.  So you might be right removing it altogether.  Can you confirm ?\n\nAs for the \"legacy\" part of it, it\u0027s not really the case as the IP might be a string but not a IP.  But, now the first thing done is ip1 \u003d IPAddr.new(arg[0]) which blows very quickly if the arg[0] is a string but not a valid IP, so it\u0027s required because of the change, not a legacy fix.","commit_id":"8648a4dcd2a3596d5a5b07a9612ecc38777d8517"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"262263de937d31212ccf84128a3fb62468f785d2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            return interface if ip1.mask(netmask) \u003d\u003d ip2.mask(netmask)"},{"line_number":29,"context_line":"          end"},{"line_number":30,"context_line":"        end"},{"line_number":31,"context_line":"      rescue IPAddr::InvalidAddressError \u003d\u003e e"},{"line_number":32,"context_line":"        raise Puppet::ParseError, \"#{e}: #{arg[0]}\""},{"line_number":33,"context_line":"      end"},{"line_number":34,"context_line":"    else"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"5a710552_d8c7ee43","line":31,"in_reply_to":"7a740942_be701309","updated":"2015-12-15 05:06:41.000000000","message":"Yes I can\u0027t see any JSON around here.\n\nI agree for the rest.\n\nThanks!","commit_id":"8648a4dcd2a3596d5a5b07a9612ecc38777d8517"}]}
