)]}'
{"manifests/ssl/nova_config.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb1df12dbb38d8c87441855303557d93c83d8309","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class tripleo::ssl::nova_config {"},{"line_number":22,"context_line":"  nova_paste_api_ini { \u0027filter:ssl_header_handler/paste.filter_factory\u0027:"},{"line_number":23,"context_line":"    value \u003d\u003e \u0027oslo_middleware.http_proxy_to_wsgi:HTTPProxyToWSGI.factory\u0027;"},{"line_number":24,"context_line":"  }"},{"line_number":25,"context_line":"  # API v2.1"},{"line_number":26,"context_line":"  tripleo::ssl::nova_middleware_filter { \u0027nova_ssl_middleware_in_v21_if\u0027 :"},{"line_number":27,"context_line":"    pipeline        \u003d\u003e \u0027composite:openstack_compute_api_v21\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_43622718","line":24,"updated":"2016-01-16 16:42:01.000000000","message":"OK","commit_id":"4d1d80be6aef3738b03b8a8edc4cd0dc7923cade"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb1df12dbb38d8c87441855303557d93c83d8309","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    pipeline        \u003d\u003e \u0027composite:openstack_compute_api_v21\u0027,"},{"line_number":28,"context_line":"    paste_config    \u003d\u003e \u0027/etc/nova/api-paste.ini\u0027,"},{"line_number":29,"context_line":"    pipeline_ending \u003d\u003e \u0027keystonecontext osapi_compute_app_v21\u0027,"},{"line_number":30,"context_line":"  }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  # API v2"},{"line_number":33,"context_line":"  tripleo::ssl::nova_middleware_filter { \u0027nova_ssl_middleware_in_v2_if\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_e3731be6","line":30,"updated":"2016-01-16 16:42:01.000000000","message":"This should not be useful:\nhttps://github.com/openstack/nova/blob/master/etc/nova/api-paste.ini#L45-L48","commit_id":"4d1d80be6aef3738b03b8a8edc4cd0dc7923cade"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"48e97b412f051e3f97527cfc7de4e238ffcdc7a7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    pipeline        \u003d\u003e \u0027composite:openstack_compute_api_v21\u0027,"},{"line_number":28,"context_line":"    paste_config    \u003d\u003e \u0027/etc/nova/api-paste.ini\u0027,"},{"line_number":29,"context_line":"    pipeline_ending \u003d\u003e \u0027keystonecontext osapi_compute_app_v21\u0027,"},{"line_number":30,"context_line":"  }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  # API v2"},{"line_number":33,"context_line":"  tripleo::ssl::nova_middleware_filter { \u0027nova_ssl_middleware_in_v2_if\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_ebc9a95b","line":30,"in_reply_to":"da6ed579_e3731be6","updated":"2016-01-17 08:37:17.000000000","message":"how is this not useful? I know how the pipeline definition looks like, what this code does is that it inserts the ssl middleware into the keystone pipeline of that section. You never actually explained why is it useless and it seems that the resulting patch doesn\u0027t do what is needed. Can you give more explanation to your comment? Maybe I\u0027m missing something.\n\nBut basically the initial pipeline looks like this:\n\n[composite:openstack_compute_api_v21]\n...\nkeystone \u003d cors compute_req_id faultwrap sizelimit authtoken keystonecontext osapi_compute_app_v21\n\nthe resulting pipeline looks like this:\n\n[composite:openstack_compute_api_v21]\n...\nkeystone \u003d cors compute_req_id faultwrap sizelimit ssl_header_middleware authtoken keystonecontext osapi_compute_app_v21","commit_id":"4d1d80be6aef3738b03b8a8edc4cd0dc7923cade"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb1df12dbb38d8c87441855303557d93c83d8309","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    pipeline        \u003d\u003e \u0027composite:openstack_compute_api_v21_legacy_v2_compatible\u0027,"},{"line_number":35,"context_line":"    paste_config    \u003d\u003e \u0027/etc/nova/api-paste.ini\u0027,"},{"line_number":36,"context_line":"    pipeline_ending \u003d\u003e \u0027legacy_v2_compatible osapi_compute_app_v21\u0027,"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  # versions"},{"line_number":40,"context_line":"  tripleo::ssl::nova_middleware_filter { \u0027nova_ssl_middleware_in_versions_if\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_4349c78d","line":37,"updated":"2016-01-16 16:42:01.000000000","message":"This should not be useful:\nhttps://github.com/openstack/nova/blob/master/etc/nova/api-paste.ini#L50-L53","commit_id":"4d1d80be6aef3738b03b8a8edc4cd0dc7923cade"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb1df12dbb38d8c87441855303557d93c83d8309","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    pipeline_ending \u003d\u003e \u0027computeversionapp\u0027,"},{"line_number":44,"context_line":"    setting         \u003d\u003e \u0027pipeline\u0027,"},{"line_number":45,"context_line":"    after_filter    \u003d\u003e \u0027faultwrap\u0027,"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_0343cf6d","line":46,"updated":"2016-01-16 16:42:01.000000000","message":"This should not be useful:\nhttps://github.com/openstack/nova/blob/master/etc/nova/api-paste.ini#L82-L83","commit_id":"4d1d80be6aef3738b03b8a8edc4cd0dc7923cade"}],"manifests/ssl/nova_middleware_filter.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4c6fc9f4ec8af4c72c5d6fbae2ff2b7c25f4a1dc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $after_filter \u003d \u0027sizelimit\u0027,"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":"  if ! generate(\u0027/bin/bash\u0027, \u0027-c\u0027,"},{"line_number":50,"context_line":"                \"/bin/grep -e \u0027^${setting} .*ssl_header_handler.*${pipeline_ending}$\u0027 /etc/nova/api-paste.ini || true\") {"},{"line_number":51,"context_line":"    ini_subsetting { \"nova_ssl_middleware_in_${pipeline}\":"},{"line_number":52,"context_line":"      ensure     \u003d\u003e present,"},{"line_number":53,"context_line":"      path       \u003d\u003e $paste_config,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_a3ed23f1","line":50,"updated":"2016-01-16 16:06:56.000000000","message":"This is terrible puppet code... Please never do that.\n\nWe have:\nhttps://github.com/openstack/puppet-nova/blob/master/lib/puppet/provider/nova_paste_api_ini/ini_setting.rb\n\nUse it with love!","commit_id":"4d1d80be6aef3738b03b8a8edc4cd0dc7923cade"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b25bc08afbba68e3927e12fd8b4d9eae82532619","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $after_filter \u003d \u0027sizelimit\u0027,"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":"  if ! generate(\u0027/bin/bash\u0027, \u0027-c\u0027,"},{"line_number":50,"context_line":"                \"/bin/grep -e \u0027^${setting} .*ssl_header_handler.*${pipeline_ending}$\u0027 /etc/nova/api-paste.ini || true\") {"},{"line_number":51,"context_line":"    ini_subsetting { \"nova_ssl_middleware_in_${pipeline}\":"},{"line_number":52,"context_line":"      ensure     \u003d\u003e present,"},{"line_number":53,"context_line":"      path       \u003d\u003e $paste_config,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"da6ed579_4378e7f8","line":50,"in_reply_to":"da6ed579_a3ed23f1","updated":"2016-01-16 16:29:23.000000000","message":"It sounds like we just want to add some filters which is something we could do with Augeas.\n\nI\u0027m wondering if we should just update packaging for that.","commit_id":"4d1d80be6aef3738b03b8a8edc4cd0dc7923cade"}]}