)]}'
{"manifests/loadbalancer.pp":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"570aaa542da98db3a49b111acf8b594d96406a60","unresolved":false,"context_lines":[{"line_number":533,"context_line":"  $keystone_admin_api_port \u003d hiera(\u0027keystone_admin_api_port\u0027, \u002735357\u0027)"},{"line_number":534,"context_line":"  if $keystone_bind_certificate {"},{"line_number":535,"context_line":"    $keystone_public_api_pub_endpoint_port \u003d hiera(\u0027keystone_public_api_pub_endpoint_port\u0027, \u002713000\u0027)"},{"line_number":536,"context_line":"    $keystone_admin_api_pub_endpoint_port \u003d hiera(\u0027keystone_admin_api_pub_endpoint_port\u0027, \u002713357\u0027)"},{"line_number":537,"context_line":"    $keystone_public_bind_opts \u003d {"},{"line_number":538,"context_line":"      \"${keystone_public_api_vip}:${keystone_public_api_port}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":539,"context_line":"      \"${public_virtual_ip}:${keystone_public_api_pub_endpoint_port}\" \u003d\u003e union($haproxy_listen_bind_param, [\u0027ssl\u0027, \u0027crt\u0027, $keystone_bind_certificate]),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7af24918_af30d3e9","line":536,"updated":"2016-03-04 23:33:15.000000000","message":"These names make me kind of sad.  Is there any reason we can\u0027t name them like keystone_admin_api_ssl_port?  That makes it way clearer to me what it does.\n\nIt\u0027s doubly weird in this particular case because I don\u0027t think we actually expose this SSL endpoint, so the setting doesn\u0027t do much.  Sort of a tangent though.","commit_id":"6542f852629536e40e3a4f0c7a3bc5c566d48ef7"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"5367a50fdb3a4984716167298c0b2cdd715262b8","unresolved":false,"context_lines":[{"line_number":533,"context_line":"  $keystone_admin_api_port \u003d hiera(\u0027keystone_admin_api_port\u0027, \u002735357\u0027)"},{"line_number":534,"context_line":"  if $keystone_bind_certificate {"},{"line_number":535,"context_line":"    $keystone_public_api_pub_endpoint_port \u003d hiera(\u0027keystone_public_api_pub_endpoint_port\u0027, \u002713000\u0027)"},{"line_number":536,"context_line":"    $keystone_admin_api_pub_endpoint_port \u003d hiera(\u0027keystone_admin_api_pub_endpoint_port\u0027, \u002713357\u0027)"},{"line_number":537,"context_line":"    $keystone_public_bind_opts \u003d {"},{"line_number":538,"context_line":"      \"${keystone_public_api_vip}:${keystone_public_api_port}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":539,"context_line":"      \"${public_virtual_ip}:${keystone_public_api_pub_endpoint_port}\" \u003d\u003e union($haproxy_listen_bind_param, [\u0027ssl\u0027, \u0027crt\u0027, $keystone_bind_certificate]),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5aef4532_39d6c4c5","line":536,"in_reply_to":"7af24918_13d8f4ee","updated":"2016-03-07 16:51:44.000000000","message":"Yeah, that\u0027s the other thing.  At some point we\u0027re going to be applying these ports to something other than the public endpoint, once we support \"SSL all the things\".  Unless we add another two variables for each service for the admin and internal endpoints, this would be confusing.  Keystone is a bit of an odd case because we have the admin endpoint on the public network, but especially for the other services I don\u0027t think we want to get that specific with the variable name.","commit_id":"6542f852629536e40e3a4f0c7a3bc5c566d48ef7"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d16f5d9b3024e7d540eeaf835ac00038ea45bb68","unresolved":false,"context_lines":[{"line_number":533,"context_line":"  $keystone_admin_api_port \u003d hiera(\u0027keystone_admin_api_port\u0027, \u002735357\u0027)"},{"line_number":534,"context_line":"  if $keystone_bind_certificate {"},{"line_number":535,"context_line":"    $keystone_public_api_pub_endpoint_port \u003d hiera(\u0027keystone_public_api_pub_endpoint_port\u0027, \u002713000\u0027)"},{"line_number":536,"context_line":"    $keystone_admin_api_pub_endpoint_port \u003d hiera(\u0027keystone_admin_api_pub_endpoint_port\u0027, \u002713357\u0027)"},{"line_number":537,"context_line":"    $keystone_public_bind_opts \u003d {"},{"line_number":538,"context_line":"      \"${keystone_public_api_vip}:${keystone_public_api_port}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":539,"context_line":"      \"${public_virtual_ip}:${keystone_public_api_pub_endpoint_port}\" \u003d\u003e union($haproxy_listen_bind_param, [\u0027ssl\u0027, \u0027crt\u0027, $keystone_bind_certificate]),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7af24918_13d8f4ee","line":536,"in_reply_to":"7af24918_732058f8","updated":"2016-03-07 05:38:17.000000000","message":"On the other hand, even though the admin ports are not currently being exposed for ssl through the os-cloud-config script. It\u0027s something that might be needed at some point. As the keystone client has the default behaviour of changing some keystone operations to use the admin port instead of the public one. that should change in Newton hopefully.","commit_id":"6542f852629536e40e3a4f0c7a3bc5c566d48ef7"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"522661d5c881095a68529a1bbbaf9acc1bd6a4ac","unresolved":false,"context_lines":[{"line_number":533,"context_line":"  $keystone_admin_api_port \u003d hiera(\u0027keystone_admin_api_port\u0027, \u002735357\u0027)"},{"line_number":534,"context_line":"  if $keystone_bind_certificate {"},{"line_number":535,"context_line":"    $keystone_public_api_pub_endpoint_port \u003d hiera(\u0027keystone_public_api_pub_endpoint_port\u0027, \u002713000\u0027)"},{"line_number":536,"context_line":"    $keystone_admin_api_pub_endpoint_port \u003d hiera(\u0027keystone_admin_api_pub_endpoint_port\u0027, \u002713357\u0027)"},{"line_number":537,"context_line":"    $keystone_public_bind_opts \u003d {"},{"line_number":538,"context_line":"      \"${keystone_public_api_vip}:${keystone_public_api_port}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":539,"context_line":"      \"${public_virtual_ip}:${keystone_public_api_pub_endpoint_port}\" \u003d\u003e union($haproxy_listen_bind_param, [\u0027ssl\u0027, \u0027crt\u0027, $keystone_bind_certificate]),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7af24918_732058f8","line":536,"in_reply_to":"7af24918_af30d3e9","updated":"2016-03-07 05:35:34.000000000","message":"Alright, I can change it. I had initially ssl_port as a suffix but thought that the public endpoint alternative made more sense, since it reflected also what this is.","commit_id":"6542f852629536e40e3a4f0c7a3bc5c566d48ef7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"642d5545497e44ce0f470bfbd697a97eee0c923a","unresolved":false,"context_lines":[{"line_number":426,"context_line":"    swift_proxy_port \u003d\u003e 8080,"},{"line_number":427,"context_line":"    swift_proxy_ssl_port \u003d\u003e 13808,"},{"line_number":428,"context_line":"  }"},{"line_number":429,"context_line":"  $ports \u003d merge($default_service_ports, $service_ports)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"  if !$controller_host and !$controller_hosts {"},{"line_number":432,"context_line":"    fail(\u0027$controller_hosts or $controller_host (now deprecated) is a mandatory parameter\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5aef4532_0464e1e1","line":429,"updated":"2016-03-09 08:20:55.000000000","message":"nice, had to look it up and indeed the second one takes precedence https://forge.puppetlabs.com/puppetlabs/stdlib#merge","commit_id":"304d076f1d7ee534fdf814e326c084c4a08d5756"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"0117539ea2ab248ac33b3f190a09282e357c5a9e","unresolved":false,"context_lines":[{"line_number":426,"context_line":"    swift_proxy_port \u003d\u003e 8080,"},{"line_number":427,"context_line":"    swift_proxy_ssl_port \u003d\u003e 13808,"},{"line_number":428,"context_line":"  }"},{"line_number":429,"context_line":"  $ports \u003d merge($default_service_ports, $service_ports)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"  if !$controller_host and !$controller_hosts {"},{"line_number":432,"context_line":"    fail(\u0027$controller_hosts or $controller_host (now deprecated) is a mandatory parameter\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5aef4532_f53521da","line":429,"in_reply_to":"5aef4532_0464e1e1","updated":"2016-03-09 09:06:14.000000000","message":"Yep, that\u0027s why I did it that way, the given (maybe through hieradata or the templates) service ports will override the default ones.","commit_id":"304d076f1d7ee534fdf814e326c084c4a08d5756"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"642d5545497e44ce0f470bfbd697a97eee0c923a","unresolved":false,"context_lines":[{"line_number":857,"context_line":"    }"},{"line_number":858,"context_line":"  } else {"},{"line_number":859,"context_line":"    $ironic_bind_opts \u003d {"},{"line_number":860,"context_line":"      \"${ironic_api_vip}:${ports[ironic_api_port]}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":861,"context_line":"      \"${public_virtual_ip}:${ports[ironic_api_port]}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":862,"context_line":"    }"},{"line_number":863,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5aef4532_693f7ed6","line":860,"updated":"2016-03-09 08:20:55.000000000","message":"the ironic api port is hardcoded to 6385 below ~ line 1265 (grep for 6385) - might want to fix it there too","commit_id":"304d076f1d7ee534fdf814e326c084c4a08d5756"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"0117539ea2ab248ac33b3f190a09282e357c5a9e","unresolved":false,"context_lines":[{"line_number":857,"context_line":"    }"},{"line_number":858,"context_line":"  } else {"},{"line_number":859,"context_line":"    $ironic_bind_opts \u003d {"},{"line_number":860,"context_line":"      \"${ironic_api_vip}:${ports[ironic_api_port]}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":861,"context_line":"      \"${public_virtual_ip}:${ports[ironic_api_port]}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":862,"context_line":"    }"},{"line_number":863,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5aef4532_f5ba4122","line":860,"in_reply_to":"5aef4532_693f7ed6","updated":"2016-03-09 09:06:14.000000000","message":"This is only meant to change the external ports which haproxy is listening on. The internal ports for all services will stay the same. That is not covered in this patch.","commit_id":"304d076f1d7ee534fdf814e326c084c4a08d5756"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"83864514b44f7a3156893a489564c76688b74a19","unresolved":false,"context_lines":[{"line_number":857,"context_line":"    }"},{"line_number":858,"context_line":"  } else {"},{"line_number":859,"context_line":"    $ironic_bind_opts \u003d {"},{"line_number":860,"context_line":"      \"${ironic_api_vip}:${ports[ironic_api_port]}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":861,"context_line":"      \"${public_virtual_ip}:${ports[ironic_api_port]}\" \u003d\u003e $haproxy_listen_bind_param,"},{"line_number":862,"context_line":"    }"},{"line_number":863,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5aef4532_f56d2199","line":860,"in_reply_to":"5aef4532_f5ba4122","updated":"2016-03-09 09:09:51.000000000","message":"thanks for checking jaosorior revoting","commit_id":"304d076f1d7ee534fdf814e326c084c4a08d5756"}]}