)]}'
{"manifests/profile/base/neutron/dhcp.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"eb84fae3838911663866059503f1203621df290a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    enabled        \u003d\u003e $enabled"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  file { \u0027/etc/neutron/dnsmasq-neutron.conf\u0027:"},{"line_number":49,"context_line":"    content \u003d\u003e $neutron_dnsmasq_options,"},{"line_number":50,"context_line":"    owner   \u003d\u003e \u0027neutron\u0027,"},{"line_number":51,"context_line":"    group   \u003d\u003e \u0027neutron\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba0121b8_babb62e4","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":43},"updated":"2016-03-31 11:44:28.000000000","message":"Can you please clarify why do you need this file?","commit_id":"18a375a07417c729e6f40bf7d52cf6f0b4c8f59c"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"adb9f333f1f029e17efee9939ded22c3d7ed604a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    enabled        \u003d\u003e $enabled"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  file { \u0027/etc/neutron/dnsmasq-neutron.conf\u0027:"},{"line_number":49,"context_line":"    content \u003d\u003e $neutron_dnsmasq_options,"},{"line_number":50,"context_line":"    owner   \u003d\u003e \u0027neutron\u0027,"},{"line_number":51,"context_line":"    group   \u003d\u003e \u0027neutron\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba0121b8_dfef21e7","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":43},"in_reply_to":"ba0121b8_babb62e4","updated":"2016-03-31 13:08:14.000000000","message":"I\u0027m just porting what\u0027s already there:\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/puppet/manifests/overcloud_controller.pp#L367","commit_id":"18a375a07417c729e6f40bf7d52cf6f0b4c8f59c"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"eb84fae3838911663866059503f1203621df290a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    require \u003d\u003e Package[\u0027neutron\u0027],"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  neutron_dhcp_agent_config {"},{"line_number":57,"context_line":"    \u0027DEFAULT/ovs_use_veth\u0027: value \u003d\u003e $neutron_ovs_use_veth;"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  Service\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Service \u003c| title \u003d\u003d \u0027neutron-dhcp\u0027 |\u003e"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba0121b8_3a975249","line":58,"range":{"start_line":56,"start_character":2,"end_line":58,"end_character":3},"updated":"2016-03-31 11:44:28.000000000","message":"This can be implemented in puppet-neutron I think","commit_id":"18a375a07417c729e6f40bf7d52cf6f0b4c8f59c"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"adb9f333f1f029e17efee9939ded22c3d7ed604a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    require \u003d\u003e Package[\u0027neutron\u0027],"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  neutron_dhcp_agent_config {"},{"line_number":57,"context_line":"    \u0027DEFAULT/ovs_use_veth\u0027: value \u003d\u003e $neutron_ovs_use_veth;"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  Service\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Service \u003c| title \u003d\u003d \u0027neutron-dhcp\u0027 |\u003e"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba0121b8_bf718d46","line":58,"range":{"start_line":56,"start_character":2,"end_line":58,"end_character":3},"in_reply_to":"ba0121b8_3a975249","updated":"2016-03-31 13:08:14.000000000","message":"As above, this is already in the manifest here: https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/manifests/overcloud_controller.pp#L420","commit_id":"18a375a07417c729e6f40bf7d52cf6f0b4c8f59c"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"5a6f393865fac50be93cc5fc3d27dc2b06fddd11","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*neutron_ovs_use_veth*]"},{"line_number":26,"context_line":"#   (Optional) Whether to set ovs_use_veth (for older kernel support)"},{"line_number":27,"context_line":"#   Defaults to hiera(\u0027neutron_ovs_use_veth\u0027, false)"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*enabled*]"},{"line_number":30,"context_line":"#   (Optional) Whether to enable the Neutron DHCP Agent service"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"5a18252c_de83f002","line":27,"updated":"2016-04-13 16:32:12.000000000","message":"This was deprecated in mitaka IIUC. Is this something that we need to carry through for now or can we just ditch it?","commit_id":"2c0ef5d8ce4d9403c81756df66607e155d090923"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"c64754476cd440d0af9699126e42ce0620b4587e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*neutron_ovs_use_veth*]"},{"line_number":26,"context_line":"#   (Optional) Whether to set ovs_use_veth (for older kernel support)"},{"line_number":27,"context_line":"#   Defaults to hiera(\u0027neutron_ovs_use_veth\u0027, false)"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*enabled*]"},{"line_number":30,"context_line":"#   (Optional) Whether to enable the Neutron DHCP Agent service"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1a122d0e_714ecf3b","line":27,"in_reply_to":"5a18252c_de83f002","updated":"2016-04-21 02:45:39.000000000","message":"I originally wanted these patches to be a straight port of all code in t-h-t, warts and all to start with, but they\u0027ve grown in scope since then so I\u0027ve removed it in the latest patchset.","commit_id":"2c0ef5d8ce4d9403c81756df66607e155d090923"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      enabled        \u003d\u003e $enabled"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    file { \u0027/etc/neutron/dnsmasq-neutron.conf\u0027:"},{"line_number":52,"context_line":"      content \u003d\u003e $neutron_dnsmasq_options,"},{"line_number":53,"context_line":"      owner   \u003d\u003e \u0027neutron\u0027,"},{"line_number":54,"context_line":"      group   \u003d\u003e \u0027neutron\u0027,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_cf6d6a04","line":51,"updated":"2016-04-29 21:58:11.000000000","message":"This is not needed anymore, let\u0027s clean it up:\n\n\"Since Mitaka, Neutron does the right job to calculate and advertise correct MTU to instances, out of the box.\"\n\nSource: https://review.openstack.org/#/c/311263/\n\nIt can be done in a future patch, but at least I would like to see a TODO so we don\u0027t miss it.","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"9ae2f2d9a71bdaf5969f5938bbd97896a27fcf0f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      enabled        \u003d\u003e $enabled"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    file { \u0027/etc/neutron/dnsmasq-neutron.conf\u0027:"},{"line_number":52,"context_line":"      content \u003d\u003e $neutron_dnsmasq_options,"},{"line_number":53,"context_line":"      owner   \u003d\u003e \u0027neutron\u0027,"},{"line_number":54,"context_line":"      group   \u003d\u003e \u0027neutron\u0027,"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_92538de2","line":51,"in_reply_to":"1a122d0e_cf6d6a04","updated":"2016-04-30 19:03:03.000000000","message":"I think I nuked the other deprecated thing that was found (use_veth) so I\u0027ll get rid of this too. Will need to check it\u0027s also gone at the other end in t-h-t.","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      require \u003d\u003e Package[\u0027neutron\u0027],"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    Service\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Service \u003c| title \u003d\u003d \u0027neutron-dhcp\u0027 |\u003e"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_af4bce85","line":59,"updated":"2016-04-29 21:58:11.000000000","message":"Hum. That logic might need to live in puppet-neutron.","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"9ae2f2d9a71bdaf5969f5938bbd97896a27fcf0f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      require \u003d\u003e Package[\u0027neutron\u0027],"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    Service\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Service \u003c| title \u003d\u003d \u0027neutron-dhcp\u0027 |\u003e"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_d27fc567","line":59,"in_reply_to":"1a122d0e_af4bce85","updated":"2016-04-30 19:03:03.000000000","message":"Ported from here, just so you know I\u0027m not crazy: https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/manifests/overcloud_controller.pp#L372\n\nIn the HA scenario this ordering should be handled by the pacemaker resources anyway, so this is only a problem in the non-ha scenario. The question is then whether this should be a part of puppet-neutron, removed completely, be modeled in heat, or be handled here along with the assumption that in the non-ha case these two services are always on the same node.","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"}],"manifests/profile/base/neutron/l3.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"5a6f393865fac50be93cc5fc3d27dc2b06fddd11","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*neutron_ovs_use_veth*]"},{"line_number":22,"context_line":"#   (Optional) Whether to set ovs_use_veth (for older kernel support)"},{"line_number":23,"context_line":"#   Defaults to hiera(\u0027neutron_ovs_use_veth\u0027, false)"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*enabled*]"},{"line_number":26,"context_line":"#   (Optional) Whether to enable the Neutron L3 Agent service"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"5a18252c_1e972849","line":23,"range":{"start_line":23,"start_character":16,"end_line":23,"end_character":21},"updated":"2016-04-13 16:32:12.000000000","message":"This was deprecated in mitaka IIUC. Is this something that we need to carry through for now or can we just ditch it?","commit_id":"2c0ef5d8ce4d9403c81756df66607e155d090923"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class tripleo::profile::base::neutron::l3 ("},{"line_number":39,"context_line":"  $enabled              \u003d undef,"},{"line_number":40,"context_line":"  $manage_service       \u003d undef,"},{"line_number":41,"context_line":"  $step                 \u003d hiera(\u0027step\u0027),"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":44,"context_line":"    include ::tripleo::profile::base::neutron"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_ef414664","line":41,"updated":"2016-04-29 21:58:11.000000000","message":"please align correctly...","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      enabled        \u003d\u003e $enabled"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    Service\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Service \u003c| title \u003d\u003d \u0027neutron-l3\u0027 |\u003e"},{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_8f4ed293","line":50,"updated":"2016-04-29 21:58:11.000000000","message":"same thing","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"}],"manifests/profile/base/neutron/metadata.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class tripleo::profile::base::neutron::metadata ("},{"line_number":35,"context_line":"  $enabled              \u003d undef,"},{"line_number":36,"context_line":"  $manage_service       \u003d undef,"},{"line_number":37,"context_line":"  $step                 \u003d hiera(\u0027step\u0027),"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":40,"context_line":"    include ::tripleo::profile::base::neutron"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_2f605e00","line":37,"updated":"2016-04-29 21:58:11.000000000","message":"fix alignment","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      enabled        \u003d\u003e $enabled"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    Service\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Service\u003c| title \u003d\u003d \u0027neutron-metadata\u0027 |\u003e"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_4f515a2f","line":46,"updated":"2016-04-29 21:58:11.000000000","message":"same thing, should live in puppet-neutron","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"}],"manifests/profile/base/neutron/midonet.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      service_plugins \u003d\u003e []"},{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # Run zookeeper in the controller if configured"},{"line_number":93,"context_line":"    if zk_on_controller {"},{"line_number":94,"context_line":"      class {\u0027::tripleo::cluster::zookeeper\u0027:"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_8f3532f8","line":91,"updated":"2016-04-29 21:58:11.000000000","message":"one empty line is enough","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"}],"manifests/profile/base/neutron/ml2.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::base::neutron::ml2 ("},{"line_number":31,"context_line":"  $mechanism_drivers  \u003d hiera(\u0027neutron::plugins::ml2::mechanism_drivers\u0027),"},{"line_number":32,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_cf3baae8","line":32,"updated":"2016-04-29 21:58:11.000000000","message":"alignment","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"}],"manifests/profile/base/neutron/ovs.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Optional since manage_service may be false and neutron server may not be colocated."},{"line_number":49,"context_line":"    Service\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Service\u003c| title \u003d\u003d \u0027neutron-ovs-agent-service\u0027 |\u003e"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_6f2d36a7","line":49,"updated":"2016-04-29 21:58:11.000000000","message":"please fix it in puppet-neutron","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"}],"manifests/profile/base/neutron/server.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"afd21a74c4630bc0583097bf11ba331cc46954cc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":37,"context_line":"#"},{"line_number":38,"context_line":"class tripleo::profile::base::neutron::server ("},{"line_number":39,"context_line":"  $sync_db          \u003d undef,"},{"line_number":40,"context_line":"  $manage_service   \u003d undef,"},{"line_number":41,"context_line":"  $enabled          \u003d undef,"},{"line_number":42,"context_line":"  $step             \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"1a122d0e_68930bfb","line":39,"updated":"2016-05-04 10:43:18.000000000","message":"I think this should default to true and we pass false for non-master nodes","commit_id":"8819706f98ed8488dd34cd385eac23fb3d2ce8bb"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"fc296b6598b708bbdde52a35235e46727fec1f57","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $step \u003e\u003d 2 and $sync_db {"},{"line_number":48,"context_line":"    include ::neutron::db::mysql"},{"line_number":49,"context_line":"  }"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"1a122d0e_7cd2a45c","line":47,"updated":"2016-05-04 13:34:23.000000000","message":"this should probably be step 3, as discussed on irc; we don\u0027t want to rely on clustercheck anyway because the role could have been deployed on a role where clustercheck istn\u0027t available","commit_id":"4a231646c0a9e471757522b53aa7053ff7f20f60"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"9700133aa5858445e9549ef6fa33352ce4a7cc2a","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  include ::tripleo::profile::base::neutron"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $step \u003e\u003d 2 and $sync_db {"},{"line_number":48,"context_line":"    include ::neutron::db::mysql"},{"line_number":49,"context_line":"  }"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"1a122d0e_3b480d5c","line":47,"in_reply_to":"1a122d0e_7cd2a45c","updated":"2016-05-05 05:55:28.000000000","message":"Done","commit_id":"4a231646c0a9e471757522b53aa7053ff7f20f60"}],"manifests/profile/pacemaker/neutron.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"ef0741fb7f262989b584837cbd29d0ab95aae5f7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      } -\u003e"},{"line_number":78,"context_line":"      pacemaker::resource::service { $::neutron::params::server_service:"},{"line_number":79,"context_line":"        clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"},{"line_number":80,"context_line":"        require      \u003d\u003e Pacemaker::Resource::Ocf[\u0027openstack-core\u0027]"},{"line_number":81,"context_line":"      }"},{"line_number":82,"context_line":"    } else {"},{"line_number":83,"context_line":"      pacemaker::resource::service { $::neutron::params::server_service:"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1a122d0e_94648b22","line":80,"updated":"2016-04-26 20:15:15.000000000","message":"for the commit that\u0027s actually using this in t-h-t I\u0027m seeing an error such as this:\n\nError: Could not find dependency Pacemaker::Resource::Ocf[openstack-core] for Pacemaker::Resource::Service[neutron-server] at /etc/puppet/modules/tripleo/manifests/profile/pacemaker/neutron.pp:81","commit_id":"ec03a57579bf4615181e207b960ac4389446e5d6"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"b50f7c500342381fd4e4940c28d18b627c177ea7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      } -\u003e"},{"line_number":78,"context_line":"      pacemaker::resource::service { $::neutron::params::server_service:"},{"line_number":79,"context_line":"        clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"},{"line_number":80,"context_line":"        require      \u003d\u003e Pacemaker::Resource::Ocf[\u0027openstack-core\u0027]"},{"line_number":81,"context_line":"      }"},{"line_number":82,"context_line":"    } else {"},{"line_number":83,"context_line":"      pacemaker::resource::service { $::neutron::params::server_service:"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1a122d0e_0ab32f9b","line":80,"in_reply_to":"1a122d0e_94648b22","updated":"2016-04-27 05:05:14.000000000","message":"Which commit? There\u0027s several for neutron, but looking at the ml2 one I didn\u0027t see that error in the log. I also don\u0027t see a neutron-server role patch yet either so I guess that might still be wip.","commit_id":"ec03a57579bf4615181e207b960ac4389446e5d6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"30992e7c943813696778754ca49e625d13cef210","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    include ::tripleo::profile::base::neutron"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    neutron_config {"},{"line_number":60,"context_line":"      \u0027DEFAULT/notification_driver\u0027: value \u003d\u003e \u0027messaging\u0027;"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_6f91b6f0","line":60,"updated":"2016-04-29 21:58:11.000000000","message":"just fyi, we\u0027re moving oslo options to puppet-oslo and try to move forward with it.\nmaybe we could patch puppet-neutron to support the puppet-oslo class that configure this parameter, see\nhttps://github.com/openstack/puppet-oslo/blob/master/manifests/messaging/notifications.pp#L46\n\nI won\u0027t block on it, but it\u0027s a nice to have. Otherwise, tripleo CI will fail the day we add the class in puppet-neutron, because of duplicated resource.\n\nAnother comment about this one, why put it in this class and not in base?","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"9ae2f2d9a71bdaf5969f5938bbd97896a27fcf0f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    include ::tripleo::profile::base::neutron"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    neutron_config {"},{"line_number":60,"context_line":"      \u0027DEFAULT/notification_driver\u0027: value \u003d\u003e \u0027messaging\u0027;"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1a122d0e_d28ce530","line":60,"in_reply_to":"1a122d0e_6f91b6f0","updated":"2016-04-30 19:03:03.000000000","message":"Set here: https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/manifests/overcloud_controller_pacemaker.pp#L662\n\nNot set in the non-ha version but I\u0027m not sure why that is. I think the default is still empty for this option, so it should be set to \u0027messaging\u0027 for all projects iiuc. If I remove it, then I guess notifications won\u0027t work until puppet-oslo is added, what\u0027s the timeline for that?","commit_id":"7ba17c4036c0701e170b3941f8745db38856e467"}]}
