)]}'
{"manifests/profile/base/glance.pp":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"311bef68157163c61b42628ea2a6b122aedafaf9","unresolved":false,"context_lines":[{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":51,"context_line":"    $glance_backend \u003d downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027))"},{"line_number":52,"context_line":"    case $glance_backend {"},{"line_number":53,"context_line":"        \u0027swift\u0027: { $backend_store \u003d \u0027glance.store.swift.Store\u0027 }"},{"line_number":54,"context_line":"        \u0027file\u0027: { $backend_store \u003d \u0027glance.store.filesystem.Store\u0027 }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_db4015a8","line":51,"updated":"2016-03-22 21:36:06.000000000","message":"I think move the hiera call to parameter, ditto for the pacemaker class.","commit_id":"a2c7127201b96f8ef218ab8fef97b4f2777ee48e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"54b71749e3e9c1bd2b86a39a7c7b9e354ba12e9a","unresolved":false,"context_lines":[{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":51,"context_line":"    $glance_backend \u003d downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027))"},{"line_number":52,"context_line":"    case $glance_backend {"},{"line_number":53,"context_line":"        \u0027swift\u0027: { $backend_store \u003d \u0027glance.store.swift.Store\u0027 }"},{"line_number":54,"context_line":"        \u0027file\u0027: { $backend_store \u003d \u0027glance.store.filesystem.Store\u0027 }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_86b800e7","line":51,"in_reply_to":"fa0719c6_db4015a8","updated":"2016-03-22 21:52:13.000000000","message":"Done","commit_id":"a2c7127201b96f8ef218ab8fef97b4f2777ee48e"}],"manifests/profile/base/glance/api.pp":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"714ceb43e4ba8d17bd2202600e8df922ffcc947f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    include ::glance::config"},{"line_number":58,"context_line":"    class { \u0027::glance::api\u0027:"},{"line_number":59,"context_line":"      known_stores   \u003d\u003e $glance_store,"},{"line_number":60,"context_line":"      manage_service \u003d\u003e false,"},{"line_number":61,"context_line":"      enabled        \u003d\u003e false,"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":"    include ::glance::notify::rabbitmq"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a061dce_ee93d4a1","line":60,"updated":"2016-04-05 06:11:22.000000000","message":"manage_service \u003d\u003e $manage_service","commit_id":"15e4c74f89e673207abc65245057fef73d6c3a81"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"898716007f78504fa6f2436d4f11f5bce5dd0b05","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    include ::glance::config"},{"line_number":58,"context_line":"    class { \u0027::glance::api\u0027:"},{"line_number":59,"context_line":"      known_stores   \u003d\u003e $glance_store,"},{"line_number":60,"context_line":"      manage_service \u003d\u003e false,"},{"line_number":61,"context_line":"      enabled        \u003d\u003e false,"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":"    include ::glance::notify::rabbitmq"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a061dce_b80a5188","line":60,"in_reply_to":"9a061dce_ee93d4a1","updated":"2016-04-06 19:55:52.000000000","message":"Done","commit_id":"15e4c74f89e673207abc65245057fef73d6c3a81"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"714ceb43e4ba8d17bd2202600e8df922ffcc947f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    class { \u0027::glance::api\u0027:"},{"line_number":59,"context_line":"      known_stores   \u003d\u003e $glance_store,"},{"line_number":60,"context_line":"      manage_service \u003d\u003e false,"},{"line_number":61,"context_line":"      enabled        \u003d\u003e false,"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":"    include ::glance::notify::rabbitmq"},{"line_number":64,"context_line":"    include join([\u0027::glance::backend::\u0027, $glance_backend])"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a061dce_cef37009","line":61,"updated":"2016-04-05 06:11:22.000000000","message":"enabled \u003d\u003e $enabled","commit_id":"15e4c74f89e673207abc65245057fef73d6c3a81"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"898716007f78504fa6f2436d4f11f5bce5dd0b05","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    class { \u0027::glance::api\u0027:"},{"line_number":59,"context_line":"      known_stores   \u003d\u003e $glance_store,"},{"line_number":60,"context_line":"      manage_service \u003d\u003e false,"},{"line_number":61,"context_line":"      enabled        \u003d\u003e false,"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":"    include ::glance::notify::rabbitmq"},{"line_number":64,"context_line":"    include join([\u0027::glance::backend::\u0027, $glance_backend])"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a061dce_d805857a","line":61,"in_reply_to":"9a061dce_cef37009","updated":"2016-04-06 19:55:52.000000000","message":"Done","commit_id":"15e4c74f89e673207abc65245057fef73d6c3a81"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"37e363c7631058f83223aaf69a5a1dafbadb2f3d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  $manage_service \u003d undef,"},{"line_number":40,"context_line":"  $enabled        \u003d undef,"},{"line_number":41,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":42,"context_line":"  $glance_backend \u003d downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027)),"},{"line_number":43,"context_line":") {"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a18252c_6be61316","line":42,"updated":"2016-04-14 18:06:53.000000000","message":"wouldn be nice to make this a class parameter I think","commit_id":"2aaae65493beb85d4ca71eb028dfaab58d69f31c"}],"manifests/profile/base/glance/glance-registry.pp":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"9e404217617942747e9ec98be4a1992210cc46f4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   (Optional) Glance backend(s) to use."},{"line_number":40,"context_line":"#   Defaults to downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027))"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"class tripleo::profile::base::glance::registry ("},{"line_number":43,"context_line":"  $sync_db        \u003d undef,"},{"line_number":44,"context_line":"  $manage_service \u003d undef,"},{"line_number":45,"context_line":"  $enabled        \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_5df05dfe","line":42,"range":{"start_line":42,"start_character":38,"end_line":42,"end_character":46},"updated":"2016-03-30 20:36:05.000000000","message":"should this be glance-registry to match the file name? Or the file name registry.pp","commit_id":"da889533b5814f0000b95a3c590379a3074f7777"}],"manifests/profile/base/glance/registry.pp":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"fb623c51e3e3f44d5688b432a265a9b7b545eedc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    include ::glance::config"},{"line_number":54,"context_line":"    class { \u0027::glance::registry\u0027 :"},{"line_number":55,"context_line":"      sync_db        \u003d\u003e $sync_db,"},{"line_number":56,"context_line":"      manage_service \u003d\u003e false,"},{"line_number":57,"context_line":"      enabled        \u003d\u003e false,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"    include ::glance::notify::rabbitmq"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ba0121b8_2c9ff65f","line":56,"updated":"2016-04-01 02:33:31.000000000","message":"This should be manage_service \u003d\u003e $manage_service so the non-ha version has a service.","commit_id":"949d67d372db514cc44054c01bab0a1771fac3f0"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"fb623c51e3e3f44d5688b432a265a9b7b545eedc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    class { \u0027::glance::registry\u0027 :"},{"line_number":55,"context_line":"      sync_db        \u003d\u003e $sync_db,"},{"line_number":56,"context_line":"      manage_service \u003d\u003e false,"},{"line_number":57,"context_line":"      enabled        \u003d\u003e false,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"    include ::glance::notify::rabbitmq"},{"line_number":60,"context_line":"    include join([\u0027::glance::backend::\u0027, $glance_backend])"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ba0121b8_0c9af26d","line":57,"updated":"2016-04-01 02:33:31.000000000","message":"enabled \u003d\u003e $enabled","commit_id":"949d67d372db514cc44054c01bab0a1771fac3f0"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"37e363c7631058f83223aaf69a5a1dafbadb2f3d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":"  $glance_backend \u003d downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027)),"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":51,"context_line":"    # TODO: notifications, scrubber, etc."},{"line_number":52,"context_line":"    include ::glance"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a18252c_cb4c87ca","line":49,"updated":"2016-04-14 18:06:53.000000000","message":"I think we need\n\n  include ::glance::db::mysql\n\nin step \u003e\u003d 2","commit_id":"2aaae65493beb85d4ca71eb028dfaab58d69f31c"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"2f8b0a7bcf4b1b0e47c0deed4eabd8a818196de3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":"  $glance_backend \u003d downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027)),"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":51,"context_line":"    # TODO: notifications, scrubber, etc."},{"line_number":52,"context_line":"    include ::glance"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_d67e1518","line":49,"in_reply_to":"1a122d0e_a00d2a92","updated":"2016-04-19 15:11:33.000000000","message":"Yes, yes we do. That slipped through :(\n\nFix here:\n\nhttps://review.openstack.org/#/c/307863/","commit_id":"2aaae65493beb85d4ca71eb028dfaab58d69f31c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b8b0413be89a2fb193cf9214be26f3cf6cde89ac","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":"  $glance_backend \u003d downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027)),"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":51,"context_line":"    # TODO: notifications, scrubber, etc."},{"line_number":52,"context_line":"    include ::glance"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_a00d2a92","line":49,"in_reply_to":"5a18252c_7ce08dcd","updated":"2016-04-19 08:00:11.000000000","message":"so Michael Chapman isn\u0027t lying :) https://github.com/openstack/puppet-tripleo/blob/6c25f57d78d47419365e2238647228a186a0137f/manifests/profile/base/database/schemas.pp#L80 \n\nI poked a bit more - I expected to see a step in the corresponding pacemaker database manifest https://github.com/openstack/puppet-tripleo/blob/6c25f57d78d47419365e2238647228a186a0137f/manifests/profile/pacemaker/database/schemas.pp - do we need to add that?","commit_id":"2aaae65493beb85d4ca71eb028dfaab58d69f31c"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"908106ed8dbd7c313e8836fe5963a7093b8c09d5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":47,"context_line":"  $glance_backend \u003d downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027)),"},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":51,"context_line":"    # TODO: notifications, scrubber, etc."},{"line_number":52,"context_line":"    include ::glance"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a18252c_7ce08dcd","line":49,"in_reply_to":"5a18252c_cb4c87ca","updated":"2016-04-15 01:19:52.000000000","message":"That\u0027s part of the db schema profile, which would be included by the db role rather than the glance registry role. It\u0027s in ::tripleo::profile::base::database::schemas - the glance role needs to set a flag there to enable it.","commit_id":"2aaae65493beb85d4ca71eb028dfaab58d69f31c"}],"manifests/profile/pacemaker/glance.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"a90425dde8d81e7d10c44d7890e431dceba99096","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  $step                       \u003d hiera(\u0027step\u0027),"},{"line_number":57,"context_line":"  $glance_backend             \u003d downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027)),"},{"line_number":58,"context_line":"  $glance_file_pcmk_manage    \u003d hiera(\u0027glance_file_pcmk_manage\u0027, false),"},{"line_number":59,"context_line":"  $glance_file_pcmk_device    \u003d hiera(\u0027glance_file_pcmk_device\u0027),"},{"line_number":60,"context_line":"  $glance_file_pcmk_directory \u003d hiera(\u0027glance_file_pcmk_directory\u0027),"},{"line_number":61,"context_line":"  $glance_file_pcmk_fstype    \u003d hiera(\u0027glance_file_pcmk_fstype\u0027),"},{"line_number":62,"context_line":"  $glance_file_pcmk_options   \u003d hiera(\u0027glance_file_pcmk_options\u0027, \u0027\u0027),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa0719c6_c3455843","line":59,"updated":"2016-03-24 15:57:56.000000000","message":"We don\u0027t currently set a default for glance_file_pcmk_device in t-h-t. So this currently causes failures when using the glance pacemaker profile.\n\nTypically this would only get set if glance_file_pcmk_manage was also set to true. I think the best thing might be to default this to \u0027\u0027 if it isn\u0027t set.","commit_id":"e9b5b52b7c7d929dfd45ea7fa36a763e75595183"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"c11ff0bfdac581591ec5471db9d3c49ab9c609a2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":72,"context_line":"    class { \u0027::tripleo::profile::base::glance\u0027:"},{"line_number":73,"context_line":"      sync_db          \u003d\u003e $pacemaker_master,"},{"line_number":74,"context_line":"      manage_service   \u003d\u003e false,"},{"line_number":75,"context_line":"      enabled          \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba0121b8_d03f04b2","line":72,"updated":"2016-03-31 16:15:53.000000000","message":"We need base::glance::api and base::glance::registry here right?","commit_id":"037bbe4dc6f8304e6cef2c5ccfc07aa19bd1f065"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8feb8f1b821265cd9c2a37ac3c4d2a93b6e8337e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":72,"context_line":"    class { \u0027::tripleo::profile::base::glance\u0027:"},{"line_number":73,"context_line":"      sync_db          \u003d\u003e $pacemaker_master,"},{"line_number":74,"context_line":"      manage_service   \u003d\u003e false,"},{"line_number":75,"context_line":"      enabled          \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba0121b8_a1bf995f","line":72,"in_reply_to":"ba0121b8_d03f04b2","updated":"2016-03-31 20:38:50.000000000","message":"Done","commit_id":"037bbe4dc6f8304e6cef2c5ccfc07aa19bd1f065"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"37e363c7631058f83223aaf69a5a1dafbadb2f3d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"class tripleo::profile::pacemaker::glance ("},{"line_number":55,"context_line":"  $bootstrap_node             \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":56,"context_line":"  $step                       \u003d hiera(\u0027step\u0027),"},{"line_number":57,"context_line":"  $glance_backend             \u003d downcase(hiera(\u0027glance_backend\u0027, \u0027swift\u0027)),"},{"line_number":58,"context_line":"  $glance_file_pcmk_manage    \u003d hiera(\u0027glance_file_pcmk_manage\u0027, false),"},{"line_number":59,"context_line":"  $glance_file_pcmk_device    \u003d hiera(\u0027glance_file_pcmk_device\u0027, \u0027\u0027),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a18252c_6b7613d8","line":56,"updated":"2016-04-14 18:06:53.000000000","message":"these can all be turned into class parameters, except for step and bootstrap_node which are shared with the other manifests","commit_id":"2aaae65493beb85d4ca71eb028dfaab58d69f31c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"37e363c7631058f83223aaf69a5a1dafbadb2f3d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  } else {"},{"line_number":68,"context_line":"    $pacemaker_master \u003d false"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":72,"context_line":"    class { \u0027::tripleo::profile::base::glance::api\u0027:"},{"line_number":73,"context_line":"      manage_service \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a18252c_8b60cf02","line":70,"updated":"2016-04-14 18:06:53.000000000","message":"we need to do the following in step \u003e\u003d 2 as well\n\n    class { \u0027::glance::db::mysql\u0027:\n      require \u003d\u003e Exec[\u0027galera-ready\u0027],\n    }","commit_id":"2aaae65493beb85d4ca71eb028dfaab58d69f31c"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"eee968b963c69ddba0ed3ca35a024dba1a741b9c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  } else {"},{"line_number":68,"context_line":"    $pacemaker_master \u003d false"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":72,"context_line":"    class { \u0027::tripleo::profile::base::glance::api\u0027:"},{"line_number":73,"context_line":"      manage_service \u003d\u003e false,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a18252c_fcfbfd76","line":70,"in_reply_to":"5a18252c_8b60cf02","updated":"2016-04-15 01:24:52.000000000","message":"Similar to the other comment, this is in ::tripleo::profile::pacemaker::database::schemas","commit_id":"2aaae65493beb85d4ca71eb028dfaab58d69f31c"}]}
