)]}'
{"manifests/loadbalancer.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"13303813016765b47f7b279eba15a9aac8cbf66d","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#    \u0027nova_novnc_port\u0027 (Defaults to 6080)"},{"line_number":361,"context_line":"#    \u0027nova_novnc_ssl_port\u0027 (Defaults to 13080)"},{"line_number":362,"context_line":"#    \u0027sahara_api_port\u0027 (Defaults to 8386)"},{"line_number":363,"context_line":"#    \u0027sahara_api_ssl_port\u0027 (Defaults to 13779)"},{"line_number":364,"context_line":"#    \u0027swift_proxy_port\u0027 (Defaults to 8080)"},{"line_number":365,"context_line":"#    \u0027swift_proxy_ssl_port\u0027 (Defaults to 13808)"},{"line_number":366,"context_line":"#    \u0027trove_api_port\u0027 (Defaults to 8779)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a1b2928_91738b4d","line":363,"range":{"start_line":363,"start_character":40,"end_line":363,"end_character":46},"updated":"2016-04-11 08:04:29.000000000","message":"oh noes!","commit_id":"f3bb9638788d51fe72684cfabdba142a66acc0af"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b2d8c3e0363de3dd382e420722aa08fe89ba5442","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#    \u0027nova_novnc_port\u0027 (Defaults to 6080)"},{"line_number":361,"context_line":"#    \u0027nova_novnc_ssl_port\u0027 (Defaults to 13080)"},{"line_number":362,"context_line":"#    \u0027sahara_api_port\u0027 (Defaults to 8386)"},{"line_number":363,"context_line":"#    \u0027sahara_api_ssl_port\u0027 (Defaults to 13779)"},{"line_number":364,"context_line":"#    \u0027swift_proxy_port\u0027 (Defaults to 8080)"},{"line_number":365,"context_line":"#    \u0027swift_proxy_ssl_port\u0027 (Defaults to 13808)"},{"line_number":366,"context_line":"#    \u0027trove_api_port\u0027 (Defaults to 8779)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a1b2928_4cadd830","line":363,"range":{"start_line":363,"start_character":40,"end_line":363,"end_character":46},"in_reply_to":"7a1b2928_0ceda08b","updated":"2016-04-11 08:29:29.000000000","message":":( sorry missed the comment. i think that\u0027s enough reviews for today.","commit_id":"f3bb9638788d51fe72684cfabdba142a66acc0af"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"66523709e10f86d234ffe24c9fc1718a152a42fc","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#    \u0027nova_novnc_port\u0027 (Defaults to 6080)"},{"line_number":361,"context_line":"#    \u0027nova_novnc_ssl_port\u0027 (Defaults to 13080)"},{"line_number":362,"context_line":"#    \u0027sahara_api_port\u0027 (Defaults to 8386)"},{"line_number":363,"context_line":"#    \u0027sahara_api_ssl_port\u0027 (Defaults to 13779)"},{"line_number":364,"context_line":"#    \u0027swift_proxy_port\u0027 (Defaults to 8080)"},{"line_number":365,"context_line":"#    \u0027swift_proxy_ssl_port\u0027 (Defaults to 13808)"},{"line_number":366,"context_line":"#    \u0027trove_api_port\u0027 (Defaults to 8779)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a1b2928_cc2f28f5","line":363,"range":{"start_line":363,"start_character":40,"end_line":363,"end_character":46},"in_reply_to":"7a1b2928_91738b4d","updated":"2016-04-11 08:26:35.000000000","message":"we just had a chat about this jaosorior:\n\n11:15 \u003c jaosorior\u003e so rebasing \"Add missing services ports to service_ports map\" also rebases \"Remove individual service certificates\" and \"Add generic manifest for loadbalancer endpoints\" and eventually \"Add support for internal/admin endpoint TLS in HAProxy\" which is the leaf\n\nOK - so I can appreciate the issue - I know you\u0027d follow up asap with a fix once we land these (it would probably help other reviewers if you were more explicit about your intent here - especially given you\u0027ve pointed out the issue yourself above).\n\nWill we have issues though with duplicate port for sahara/trove if we land like this?","commit_id":"f3bb9638788d51fe72684cfabdba142a66acc0af"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e0a29aa27a084ea80571de57bed41ae308c3efb0","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#    \u0027nova_novnc_port\u0027 (Defaults to 6080)"},{"line_number":361,"context_line":"#    \u0027nova_novnc_ssl_port\u0027 (Defaults to 13080)"},{"line_number":362,"context_line":"#    \u0027sahara_api_port\u0027 (Defaults to 8386)"},{"line_number":363,"context_line":"#    \u0027sahara_api_ssl_port\u0027 (Defaults to 13779)"},{"line_number":364,"context_line":"#    \u0027swift_proxy_port\u0027 (Defaults to 8080)"},{"line_number":365,"context_line":"#    \u0027swift_proxy_ssl_port\u0027 (Defaults to 13808)"},{"line_number":366,"context_line":"#    \u0027trove_api_port\u0027 (Defaults to 8779)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a1b2928_0ceda08b","line":363,"range":{"start_line":363,"start_character":40,"end_line":363,"end_character":46},"in_reply_to":"7a1b2928_cc2f28f5","updated":"2016-04-11 08:27:59.000000000","message":"Actually this is just the documentation, so it\u0027s no issue really. As I commented below, the correct port was actually put on the code.","commit_id":"f3bb9638788d51fe72684cfabdba142a66acc0af"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d49d3b3d36d89039881b00f42ee77de15d849700","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    nova_novnc_port \u003d\u003e 6080,"},{"line_number":474,"context_line":"    nova_novnc_ssl_port \u003d\u003e 13080,"},{"line_number":475,"context_line":"    sahara_api_port \u003d\u003e 8386,"},{"line_number":476,"context_line":"    sahara_api_ssl_port \u003d\u003e 13786,"},{"line_number":477,"context_line":"    swift_proxy_port \u003d\u003e 8080,"},{"line_number":478,"context_line":"    swift_proxy_ssl_port \u003d\u003e 13808,"},{"line_number":479,"context_line":"    trove_api_port \u003d\u003e 8779,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a1b2928_d1086394","line":476,"range":{"start_line":476,"start_character":27,"end_line":476,"end_character":32},"updated":"2016-04-11 08:06:26.000000000","message":"it\u0027s correct here though","commit_id":"f3bb9638788d51fe72684cfabdba142a66acc0af"}]}