)]}'
{"manifests/profile/base/keystone.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"625ebb57c6e9041a8675661a9ab18c53bf839090","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      include ::heat::keystone::auth"},{"line_number":86,"context_line":"      include ::neutron::keystone::auth"},{"line_number":87,"context_line":"      include ::nova::keystone::auth"},{"line_number":88,"context_line":"      include ::swift::keystone::auth"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"      Keystone_service\u003c||\u003e -\u003e Keystone_endpoint\u003c||\u003e"},{"line_number":91,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_0f75a2c9","line":88,"updated":"2016-04-21 11:47:11.000000000","message":"can we add sahara:: here and depend on I348e4d38b9969e4cc2c331f67062975c61edb553 ?","commit_id":"a55c0b7e878c223ebb3e1f3a4d223ca6f5e9a9e2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"dc8baf6707b2944d99d7d624b1bd30a3a9f82829","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    if $manage_endpoint {"},{"line_number":85,"context_line":"      include ::keystone::endpoint"},{"line_number":86,"context_line":"      # FIXME(jaosorior): This is a first iteration. These will be moved to"},{"line_number":87,"context_line":"      # the services\u0027 profiles."},{"line_number":88,"context_line":"      include ::aodh::keystone::auth"},{"line_number":89,"context_line":"      include ::ceilometer::keystone::auth"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"dab17558_021fc65f","line":86,"updated":"2016-05-09 21:47:08.000000000","message":"no, it should not move to the service profiles. Because you need to execute these classes on the same node where Keystone is running.","commit_id":"2975d754a10f61a2870969166adc646cd1992777"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"dc8baf6707b2944d99d7d624b1bd30a3a9f82829","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      include ::sahara::keystone::auth"},{"line_number":97,"context_line":"      include ::swift::keystone::auth"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"      Keystone_service\u003c||\u003e -\u003e Keystone_endpoint\u003c||\u003e"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    #TODO: need a cleanup-keystone-tokens.sh solution here"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"dab17558_22780a8f","line":99,"updated":"2016-05-09 21:47:08.000000000","message":"This should not exist, it overlaps with:\nhttps://github.com/openstack/puppet-keystone/blob/master/manifests/deps.pp#L57\n\nCan you explain why we have that?","commit_id":"2975d754a10f61a2870969166adc646cd1992777"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"bb448af1446da7627503315a3c14f45f8080e4be","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      # TODO(jaosorior): This is a first iteration. The point is to get this"},{"line_number":87,"context_line":"      # nicely working and then we can figure out where this should go. There"},{"line_number":88,"context_line":"      # have been people wanting these endpoints to be configured both here and"},{"line_number":89,"context_line":"      # in separate services; So we need to figure out where."},{"line_number":90,"context_line":"      include ::aodh::keystone::auth"},{"line_number":91,"context_line":"      include ::ceilometer::keystone::auth"},{"line_number":92,"context_line":"      include ::cinder::keystone::auth"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dab17558_14f5d1eb","line":89,"range":{"start_line":89,"start_character":55,"end_line":89,"end_character":61},"updated":"2016-05-11 18:09:18.000000000","message":"Can we have each service profile create it\u0027s own endpoint?\n\nIdeally we want the endpoints in keystone to match the list of deployed services I think, which implies either creating each service endpoint via puppet/services/foo.yaml, or feeding some data out of those templates to assemble an EndpointMap that reflects what is actually running vs a hard-coded list.\n\nLooking at the earlier feedback from Emilien it looks like we can\u0027t create the endpoint in the service profile, so instead can we do as Dan suggested, and break this out into a profile that just creates endpoints, and accepts a list of endpoints to create?\n\nThen we can potentially generate the list of endpoints based on the services that are enabled (e.g an output from the ControllerServiceChain in addition to the step_config)","commit_id":"fc63fcab1ce2eff4839b35d11a107b28f12a2154"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bd384ede96da0d7f1879d4333a803e68ec17cb13","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      # TODO(jaosorior): This is a first iteration. The point is to get this"},{"line_number":87,"context_line":"      # nicely working and then we can figure out where this should go. There"},{"line_number":88,"context_line":"      # have been people wanting these endpoints to be configured both here and"},{"line_number":89,"context_line":"      # in separate services; So we need to figure out where."},{"line_number":90,"context_line":"      include ::aodh::keystone::auth"},{"line_number":91,"context_line":"      include ::ceilometer::keystone::auth"},{"line_number":92,"context_line":"      include ::cinder::keystone::auth"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dab17558_4ec6794a","line":89,"range":{"start_line":89,"start_character":55,"end_line":89,"end_character":61},"in_reply_to":"dab17558_14f5d1eb","updated":"2016-05-12 12:53:42.000000000","message":"so in Puppet OpenStack modules, we have Ruby providers, that create some resources: Keystone endpoints, Keystone services, Glance images, etc.\n\nThey all use (or almost?) python-openstackclient, which means you need to auth against Keystone first to get a token and then do the actions.\n\nThere are 2 methods of auth:\n\n1) read /etc/keystone/keystone.conf and get token value\nIt requires ::keystone class to be run (keystone server) on the same node where resources are managed (endpoints, etc).\nIt\u0027s more secure, because you have a single point of information where token is stored (keystone.conf) but less flexible if (like here) you want something composable, where resources are created from another node.\n\n2) create /root/openrc using openstack_extras module (and openrc class) on every node where resources are executed. (endpoints, etc). So in this case, we might want that:\ninclude openstack_extras::auth_file where we manage resources (endpoints, etc), feed its data via hieradata/common.yaml and declare nova::keystone::auth (same for neutron, etc) on the nodes that we want. It\u0027s less secure, because we have /root/openrc on more nodes, but very flexible and allow us to compose how we want\n\nIf you want to see the code that does auth, please look https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack/auth.rb\nThe openrc file class:\nhttps://github.com/openstack/puppet-openstack_extras/blob/master/manifests/auth_file.pp\nAn example of usage:\nhttps://github.com/openstack/puppet-openstack-integration/blob/master/manifests/keystone.pp#L82-L87","commit_id":"fc63fcab1ce2eff4839b35d11a107b28f12a2154"}]}
