)]}'
{"manifests/profile/base/database/redis.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e36d61a4bd2ad69a2f768c68b4442353dc6e280b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class tripleo::profile::base::database::redis ("},{"line_number":26,"context_line":"  $manage_service \u003d undef,"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  $redis_node_ips \u003d hiera(\u0027redis_node_ips\u0027)"},{"line_number":29,"context_line":"  $redis_master_hostname \u003d downcase(hiera(\u0027bootstrap_nodeid\u0027))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $redis_master_hostname \u003d\u003d $::hostname {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a18252c_c0604238","line":28,"updated":"2016-04-13 11:47:33.000000000","message":"in https://review.openstack.org/#/c/304675/ I am removing a bunch of hiera calls making them into class parameters\n\nI personally like that approach more as it cleans up what are the puppet-tripleo params from what could be parameters we\u0027ll still propagate in the overcloud_* manifests\n\nwould you try that too? not sure what others think on the matter so not leaving any positive or negative vote for now","commit_id":"8bdaedd3423bdee32a132310c4cf567f0721e592"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"027777c859cbfd899ce8c0fcaf126bd0cd429339","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class tripleo::profile::base::database::redis ("},{"line_number":26,"context_line":"  $manage_service \u003d undef,"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  $redis_node_ips \u003d hiera(\u0027redis_node_ips\u0027)"},{"line_number":29,"context_line":"  $redis_master_hostname \u003d downcase(hiera(\u0027bootstrap_nodeid\u0027))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $redis_master_hostname \u003d\u003d $::hostname {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a18252c_cab853e8","line":28,"in_reply_to":"5a18252c_c0604238","updated":"2016-04-13 14:26:59.000000000","message":"I\u0027m cool with doing that if thats the preferred approach. Lets see what others say and i\u0027m happy to change it.","commit_id":"8bdaedd3423bdee32a132310c4cf567f0721e592"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"dcf23b7c713048d931de1f54e821cd363ffe435b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class tripleo::profile::base::database::redis ("},{"line_number":26,"context_line":"  $manage_service \u003d undef,"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":"  $redis_node_ips \u003d hiera(\u0027redis_node_ips\u0027)"},{"line_number":29,"context_line":"  $redis_master_hostname \u003d downcase(hiera(\u0027bootstrap_nodeid\u0027))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if $redis_master_hostname \u003d\u003d $::hostname {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a18252c_688e227a","line":28,"in_reply_to":"5a18252c_cab853e8","updated":"2016-04-14 15:14:22.000000000","message":"+1 to what Guilio said. The reason I\u0027m pushing for this approach is that it clearly defines the interface between heat and the profiles, lets us auto-generate documentation for all inputs via the parameter doc that is linted, and in general improves readability for the puppet classes since the inputs are all at the top rather than spread out.","commit_id":"8bdaedd3423bdee32a132310c4cf567f0721e592"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"49201a1e45a2784545163ebe7b574ba609432fdb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# [*redis_master_hostname*]"},{"line_number":25,"context_line":"#   Hostname of Redis master"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*manage_service*]"},{"line_number":28,"context_line":"#   (Optional) Whether to manage the redis service"},{"line_number":29,"context_line":"#   Defaults to undef"},{"line_number":30,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_79621fda","line":27,"updated":"2016-04-15 10:06:40.000000000","message":"I think we are passing this as a parameter to the ::redis module itself in the non-pacemaker scenario","commit_id":"f99ebfc46a2e8e179e1ebbb1f87b9ea593a77a08"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"49201a1e45a2784545163ebe7b574ba609432fdb","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class tripleo::profile::base::database::redis ("},{"line_number":33,"context_line":"  $redis_node_ips,"},{"line_number":34,"context_line":"  $redis_master_hostname,"},{"line_number":35,"context_line":"  $manage_service         \u003d undef,"},{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_794b3f5a","line":34,"updated":"2016-04-15 10:06:40.000000000","message":"I think this could just be bootstrap_nodeid","commit_id":"f99ebfc46a2e8e179e1ebbb1f87b9ea593a77a08"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"49201a1e45a2784545163ebe7b574ba609432fdb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  $redis_master_hostname,"},{"line_number":35,"context_line":"  $manage_service         \u003d undef,"},{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if $redis_master_hostname \u003d\u003d $::hostname {"},{"line_number":39,"context_line":"    $slaveof \u003d undef"},{"line_number":40,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_f91f4f59","line":37,"updated":"2016-04-15 10:06:40.000000000","message":"we miss the if step \u003e\u003d 2 conditinal","commit_id":"f99ebfc46a2e8e179e1ebbb1f87b9ea593a77a08"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2952048aac9ad621c1c5d94316bd8c52d3e8afb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      $slaveof \u003d \"${bootstrap_nodeid} 6379\""},{"line_number":45,"context_line":"    }"},{"line_number":46,"context_line":"    class { \u0027::redis\u0027 :"},{"line_number":47,"context_line":"      slaveof        \u003d\u003e $slaveof,"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    if count($redis_node_ips) \u003e 1 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_0ff642d6","line":47,"updated":"2016-04-29 21:35:33.000000000","message":"could you align it correctly?","commit_id":"c044c1d447519a54a5c733c8da54ba760ac5879a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2952048aac9ad621c1c5d94316bd8c52d3e8afb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    if count($redis_node_ips) \u003e 1 {"},{"line_number":51,"context_line":"      Class[\u0027::tripleo::redis_notification\u0027] -\u003e Service[\u0027redis-sentinel\u0027]"},{"line_number":52,"context_line":"      include ::redis::sentinel"},{"line_number":53,"context_line":"      include ::tripleo::redis_notification"},{"line_number":54,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_cf260a66","line":51,"updated":"2016-04-29 21:35:33.000000000","message":"I would rather do that:\n\n  File[\u0027/usr/local/bin/redis-notifications.sh\u0027] ~\u003e Service[\u0027redis-sentinel\u0027]\n\nSo we rely on a specific resource, and we notify the service every time the file is updated (if that\u0027s what we want, otherwise replace the ~\u003e by -\u003e)\nSee https://docs.puppet.com/puppet/latest/reference/lang_relationships.html#syntax-chaining-arrows","commit_id":"c044c1d447519a54a5c733c8da54ba760ac5879a"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"9f9ba08289e5b6193d9490d4927e5373458ad4fe","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    if count($redis_node_ips) \u003e 1 {"},{"line_number":51,"context_line":"      Class[\u0027::tripleo::redis_notification\u0027] -\u003e Service[\u0027redis-sentinel\u0027]"},{"line_number":52,"context_line":"      include ::redis::sentinel"},{"line_number":53,"context_line":"      include ::tripleo::redis_notification"},{"line_number":54,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_c75097d7","line":51,"in_reply_to":"1a122d0e_cf260a66","updated":"2016-05-02 12:24:44.000000000","message":"hmm this is basically what we do in the t-h-t code right now. Do we want to change that behavior?","commit_id":"c044c1d447519a54a5c733c8da54ba760ac5879a"}],"manifests/profile/pacemaker/database/redis.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"49201a1e45a2784545163ebe7b574ba609432fdb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $enable_load_balancer \u003d hiera(\u0027enable_load_balancer\u0027, true),"},{"line_number":53,"context_line":"  $step                 \u003d hiera(\u0027step\u0027),"},{"line_number":54,"context_line":") {"},{"line_number":55,"context_line":"  if $::hostname \u003d\u003d downcase($bootstrap_node) {"},{"line_number":56,"context_line":"    $pacemaker_master \u003d true"},{"line_number":57,"context_line":"  } else {"},{"line_number":58,"context_line":"    $pacemaker_master \u003d false"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_19932ba5","line":55,"updated":"2016-04-15 10:06:40.000000000","message":"I think we can do this within the conditional on L68","commit_id":"f99ebfc46a2e8e179e1ebbb1f87b9ea593a77a08"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"49201a1e45a2784545163ebe7b574ba609432fdb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      $redis_vip_netmask \u003d \u002732\u0027"},{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":"    if $redis_vip and $redis_vip !\u003d $controller_virtual_ip {"},{"line_number":77,"context_line":"      pacemaker::resource::ip { \u0027redis_vip\u0027:"},{"line_number":78,"context_line":"        ip_address   \u003d\u003e $redis_vip,"},{"line_number":79,"context_line":"        cidr_netmask \u003d\u003e $redis_vip_netmask,"},{"line_number":80,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_19c16b81","line":77,"updated":"2016-04-15 10:06:40.000000000","message":"I think this can now be:\n\n  tripleo::pacemaker::haproxy_with_vip","commit_id":"f99ebfc46a2e8e179e1ebbb1f87b9ea593a77a08"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"faebffbd1982546c9f2ea3700faf705bdfe8248c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master and $enable_load_balancer {"},{"line_number":58,"context_line":"    $control_vip \u003d hiera(\u0027tripleo::loadbalancer::controller_virtual_ip\u0027)"},{"line_number":59,"context_line":"    if $redis_vip and $redis_vip !\u003d $control_vip {"},{"line_number":60,"context_line":"      tripleo::pacemaker::haproxy_with_vip { \u0027redis_vip\u0027:"},{"line_number":61,"context_line":"        vip_name   \u003d\u003e \u0027redis_vip\u0027,"},{"line_number":62,"context_line":"        ip_address \u003d\u003e $redis_vip,"},{"line_number":63,"context_line":"      }"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    pacemaker::resource::ocf { \u0027redis\u0027:"},{"line_number":67,"context_line":"      ocf_agent_name  \u003d\u003e \u0027heartbeat:redis\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9abb7d3a_60e8a97d","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":5},"updated":"2016-05-27 15:06:39.000000000","message":"Hello!!\nThis code makes the pacemaker deployment fail with this code error:\n\n  Error: Duplicate declaration: Pcmk_resource[ip-192.0.2.19] is already declared in file /etc/puppet/modules/pacemaker/manifests/resource/ip.pp:106;\n  Cannot redeclare at /etc/puppet/modules/pacemaker/manifests/resource/ip.pp:106 on node overcloud-controller-0.localdomain\n\nAlso I\u0027m not able to find this code in current THT logic.","commit_id":"64d81ea8808fe50281f669d62b2b5a9f03660cd0"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"056c628fb65fa0bea314e692db2f8f9daaebf6e9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master and $enable_load_balancer {"},{"line_number":58,"context_line":"#    $control_vip \u003d hiera(\u0027tripleo::loadbalancer::controller_virtual_ip\u0027)"},{"line_number":59,"context_line":"#    if $redis_vip and $redis_vip !\u003d $control_vip {"},{"line_number":60,"context_line":"#      tripleo::pacemaker::haproxy_with_vip { \u0027redis_vip\u0027:"},{"line_number":61,"context_line":"#        vip_name   \u003d\u003e \u0027redis_vip\u0027,"},{"line_number":62,"context_line":"#        ip_address \u003d\u003e $redis_vip,"},{"line_number":63,"context_line":"#      }"},{"line_number":64,"context_line":"#    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    pacemaker::resource::ocf { \u0027redis\u0027:"},{"line_number":67,"context_line":"      ocf_agent_name  \u003d\u003e \u0027heartbeat:redis\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9abb7d3a_8230fa02","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":6},"updated":"2016-05-30 11:07:52.000000000","message":"what\u0027s up witht his commented part?","commit_id":"66bb87b95f0a7c5f25f446d14e9bd814abb17e6b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"9303a6609c0e7fa489cb081fdcefba6deae2b611","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master and $enable_load_balancer {"},{"line_number":58,"context_line":"#    $control_vip \u003d hiera(\u0027tripleo::loadbalancer::controller_virtual_ip\u0027)"},{"line_number":59,"context_line":"#    if $redis_vip and $redis_vip !\u003d $control_vip {"},{"line_number":60,"context_line":"#      tripleo::pacemaker::haproxy_with_vip { \u0027redis_vip\u0027:"},{"line_number":61,"context_line":"#        vip_name   \u003d\u003e \u0027redis_vip\u0027,"},{"line_number":62,"context_line":"#        ip_address \u003d\u003e $redis_vip,"},{"line_number":63,"context_line":"#      }"},{"line_number":64,"context_line":"#    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    pacemaker::resource::ocf { \u0027redis\u0027:"},{"line_number":67,"context_line":"      ocf_agent_name  \u003d\u003e \u0027heartbeat:redis\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9abb7d3a_a8d07d54","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":6},"in_reply_to":"9abb7d3a_0d927b9f","updated":"2016-05-30 11:31:00.000000000","message":"The commented lines were conflicting with the pacemaker deployment http://paste.openstack.org/show/506256/\nAlso this lines aren\u0027t in current THT logic I\u0027m re-running it locally and it works fine.","commit_id":"66bb87b95f0a7c5f25f446d14e9bd814abb17e6b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"5e0d867c7270c90cc27fa5a4d92f8983321157e4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master and $enable_load_balancer {"},{"line_number":58,"context_line":"#    $control_vip \u003d hiera(\u0027tripleo::loadbalancer::controller_virtual_ip\u0027)"},{"line_number":59,"context_line":"#    if $redis_vip and $redis_vip !\u003d $control_vip {"},{"line_number":60,"context_line":"#      tripleo::pacemaker::haproxy_with_vip { \u0027redis_vip\u0027:"},{"line_number":61,"context_line":"#        vip_name   \u003d\u003e \u0027redis_vip\u0027,"},{"line_number":62,"context_line":"#        ip_address \u003d\u003e $redis_vip,"},{"line_number":63,"context_line":"#      }"},{"line_number":64,"context_line":"#    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    pacemaker::resource::ocf { \u0027redis\u0027:"},{"line_number":67,"context_line":"      ocf_agent_name  \u003d\u003e \u0027heartbeat:redis\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9abb7d3a_0d927b9f","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":6},"in_reply_to":"9abb7d3a_8230fa02","updated":"2016-05-30 11:11:21.000000000","message":"Hello Juan, I\u0027m just checking if this code is actually breaking CI as is conflicting in my local env. If this is the problem I\u0027ll remove the commented lines.","commit_id":"66bb87b95f0a7c5f25f446d14e9bd814abb17e6b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"844a332c20683f7d8b4f0877ea12156fdf60c3f2","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":51,"context_line":"    class { \u0027::redis\u0027 :"},{"line_number":52,"context_line":"      service_manage \u003d\u003e false,"},{"line_number":53,"context_line":"      notify_service \u003d\u003e false,"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9abb7d3a_e9cd5d5e","line":52,"updated":"2016-05-30 15:44:12.000000000","message":"I think these can go in the pacemaker template","commit_id":"901e6eb82945256f24c300a57489c091ada1ab25"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"730037d194fd2e99abb91587c92bb5d87d95fe82","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":51,"context_line":"    class { \u0027::redis\u0027 :"},{"line_number":52,"context_line":"      service_manage \u003d\u003e false,"},{"line_number":53,"context_line":"      notify_service \u003d\u003e false,"},{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9abb7d3a_b4c5538f","line":52,"in_reply_to":"9abb7d3a_e9cd5d5e","updated":"2016-05-31 07:33:37.000000000","message":"Done","commit_id":"901e6eb82945256f24c300a57489c091ada1ab25"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"844a332c20683f7d8b4f0877ea12156fdf60c3f2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":"  }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master and $enable_load_balancer {"},{"line_number":58,"context_line":"    pacemaker::resource::ocf { \u0027redis\u0027:"},{"line_number":59,"context_line":"      ocf_agent_name  \u003d\u003e \u0027heartbeat:redis\u0027,"},{"line_number":60,"context_line":"      master_params   \u003d\u003e \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9abb7d3a_49f46985","line":57,"updated":"2016-05-30 15:44:12.000000000","message":"I don\u0027t think we want the $enable_load_balancer in the if condition","commit_id":"901e6eb82945256f24c300a57489c091ada1ab25"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"730037d194fd2e99abb91587c92bb5d87d95fe82","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    }"},{"line_number":55,"context_line":"  }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master and $enable_load_balancer {"},{"line_number":58,"context_line":"    pacemaker::resource::ocf { \u0027redis\u0027:"},{"line_number":59,"context_line":"      ocf_agent_name  \u003d\u003e \u0027heartbeat:redis\u0027,"},{"line_number":60,"context_line":"      master_params   \u003d\u003e \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9abb7d3a_94c00f7e","line":57,"in_reply_to":"9abb7d3a_49f46985","updated":"2016-05-31 07:33:37.000000000","message":"Done","commit_id":"901e6eb82945256f24c300a57489c091ada1ab25"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"31177622e16cfeb05d98c98cb222c6c836fa86d6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":51,"context_line":"    class { \u0027::redis\u0027 :"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"9abb7d3a_12a54fb4","line":51,"updated":"2016-05-31 08:18:39.000000000","message":"to make it possible to include the class multiple times you can use: \u0027include ::redis\u0027 when you don\u0027t need to pass custom params","commit_id":"8a8a03ec024723e1f9c5bfe3dd67715000627459"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"3c441201f98523b0c7c8162bbc71751cef2f3478","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":51,"context_line":"    class { \u0027::redis\u0027 :"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"9abb7d3a_6842ec11","line":51,"in_reply_to":"9abb7d3a_12a54fb4","updated":"2016-05-31 08:52:13.000000000","message":"Fixed, thanks Giulio!","commit_id":"8a8a03ec024723e1f9c5bfe3dd67715000627459"}]}