)]}'
{"manifests/profile/base/database/mongodb.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5f532669ac434c510ce7684552700a7d0e545646","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $mongodb_replset,"},{"line_number":42,"context_line":"  $mongodb_ipv6_enabled \u003d false,"},{"line_number":43,"context_line":"  $bootstrap_node \u003d downcase(hiera(\u0027bootstrap_nodeid\u0027)),"},{"line_number":44,"context_line":"  $manage_service \u003d undef,"},{"line_number":45,"context_line":") {"},{"line_number":46,"context_line":"  include ::mongodb::globals"},{"line_number":47,"context_line":"  include ::mongodb::client"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_8fbed2d1","line":44,"updated":"2016-04-29 21:38:18.000000000","message":"I don\u0027t like this default, usually we should either False or True.\nWe might want to set True by default, and override it when using pacemaker?","commit_id":"aeb8b05bcda4590adca3c650f0112b40c968fe8d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e24469f3bcfd84678f9c204809ea4a222665d534","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    include ::mongodb::globals"},{"line_number":54,"context_line":"    include ::mongodb::client"},{"line_number":55,"context_line":"    class { \u0027::mongodb::server\u0027 :"},{"line_number":56,"context_line":"      service_manage \u003d\u003e $manage_service,"},{"line_number":57,"context_line":"      replset        \u003d\u003e $mongodb_replset,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"9abb7d3a_45a35300","line":56,"updated":"2016-06-01 08:14:03.000000000","message":"this could be passed as:\n\n::mongodb::server::service_manage\n\nfrom the pcmk template","commit_id":"286505ec0251eb0d7188fa607590583ff7219ccc"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"50a4dbaf1af5a08b311843e20c14a16fb3412457","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    include ::mongodb::globals"},{"line_number":54,"context_line":"    include ::mongodb::client"},{"line_number":55,"context_line":"    class { \u0027::mongodb::server\u0027 :"},{"line_number":56,"context_line":"      service_manage \u003d\u003e $manage_service,"},{"line_number":57,"context_line":"      replset        \u003d\u003e $mongodb_replset,"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"9abb7d3a_85d09b20","line":56,"in_reply_to":"9abb7d3a_45a35300","updated":"2016-06-01 08:17:21.000000000","message":"Ill apply the change in the THT submission","commit_id":"286505ec0251eb0d7188fa607590583ff7219ccc"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a04e9891380b6667164294d3eaebe714b6c6b3e4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    $mongo_node_string \u003d join($mongo_node_ips_with_port, \u0027,\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if $bootstrap_node \u003d\u003d $::hostname {"},{"line_number":73,"context_line":"      mongodb_replset { $mongodb_replset :"},{"line_number":74,"context_line":"        members \u003d\u003e $mongo_node_ips_with_port_nobr,"},{"line_number":75,"context_line":"      }"},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"9abb7d3a_6c6917f9","line":76,"range":{"start_line":72,"start_character":3,"end_line":76,"end_character":5},"updated":"2016-06-01 11:25:24.000000000","message":"this will run both in the pacemaker case and in the non-ha case. While the pacemaker manifest also has this code... When you were trying to reduce code repetition, you should have put the common stuff in a separate manifest. Now you get this running twice.","commit_id":"f31620d42ce13afa8535662682890e9de4ff58b9"}],"manifests/profile/base/database/mongodbcommon.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"78295faac5d98a17d41224a9fd992db1e81a2e5b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    include ::mongodb::server"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  # NOTE(gfidente): the following vars are needed on all nodes so they"},{"line_number":48,"context_line":"  # need to stay out of pacemaker_master conditional."},{"line_number":49,"context_line":"  # The addresses mangling will hopefully go away when we\u0027ll be able to"},{"line_number":50,"context_line":"  # configure the connection string via hostnames, until then, we need to pass"},{"line_number":51,"context_line":"  # the list of IPv6 addresses *with* port and without the brackets as \u0027members\u0027"},{"line_number":52,"context_line":"  # argument for the \u0027mongodb_replset\u0027 resource."},{"line_number":53,"context_line":"  if str2bool($mongodb_ipv6_enabled) {"},{"line_number":54,"context_line":"    $mongo_node_ips_with_port_prefixed \u003d prefix($mongodb_node_ips, \u0027[\u0027)"},{"line_number":55,"context_line":"    $mongo_node_ips_with_port \u003d suffix("},{"line_number":56,"context_line":"      $mongo_node_ips_with_port_prefixed, \"]:${port}\")"},{"line_number":57,"context_line":"    $mongo_node_ips_with_port_nobr \u003d suffix($mongodb_node_ips, \":${port}\")"},{"line_number":58,"context_line":"  } else {"},{"line_number":59,"context_line":"    $mongo_node_ips_with_port \u003d suffix($mongodb_node_ips, \":${port}\")"},{"line_number":60,"context_line":"    $mongo_node_ips_with_port_nobr \u003d suffix($mongodb_node_ips, \":${port}\")"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"  $mongo_node_string \u003d join($mongo_node_ips_with_port, \u0027,\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7aa08908_919d015c","line":62,"range":{"start_line":47,"start_character":0,"end_line":62,"end_character":59},"updated":"2016-06-10 08:25:15.000000000","message":"I guess this whole section could end up being a resource by itself.","commit_id":"f6df5927b5bbf2f94dcfbe15385e1334c6531b47"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e7d23a2e80d801db9a9315e76d2c18b2936612f9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    $mongo_node_ips_with_port \u003d suffix($mongodb_node_ips, \":${port}\")"},{"line_number":60,"context_line":"    $mongo_node_ips_with_port_nobr \u003d suffix($mongodb_node_ips, \":${port}\")"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"  $mongo_node_string \u003d join($mongo_node_ips_with_port, \u0027,\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7aa08908_71cfb5b3","line":62,"updated":"2016-06-10 08:16:25.000000000","message":"I see the includes are common over at the tripleo-heat-templates side (https://review.openstack.org/#/c/315051/40/puppet/manifests/overcloud_controller_pacemaker.pp https://review.openstack.org/#/c/315051/40/puppet/manifests/overcloud_controller.pp ) but is this bit ^^^ ? I guess it could be a non-ha ipv6 deployment. just checking. I commented over at tht do you want to remove the block from there (is only @ the pacemaker.pp one )","commit_id":"f6df5927b5bbf2f94dcfbe15385e1334c6531b47"}],"manifests/profile/pacemaker/database/mongodb.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5f532669ac434c510ce7684552700a7d0e545646","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#   (Optional) Whether load balancing is enabled for this cluster"},{"line_number":42,"context_line":"#   Defaults to hiera(\u0027enable_load_balancer\u0027, true)"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"class tripleo::profile::pacemaker::database::mongodb ("},{"line_number":45,"context_line":"  $mongodb_node_ips,"},{"line_number":46,"context_line":"  $mongodb_replset,"},{"line_number":47,"context_line":"  $mongodb_ipv6_enabled \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_afa2aeab","line":44,"updated":"2016-04-29 21:38:18.000000000","message":"I don\u0027t like this class, we are repeating a lot of bits. Please look how Glance is done.","commit_id":"aeb8b05bcda4590adca3c650f0112b40c968fe8d"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1d955e3388f65441c667e8a6072163e28635ac1a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"    # NOTE (spredzy) : The replset can only be run"},{"line_number":93,"context_line":"    # once all the nodes have joined the cluster."},{"line_number":94,"context_line":"    mongodb_conn_validator { $mongo_node_ips_with_port :"},{"line_number":95,"context_line":"      timeout \u003d\u003e \u0027600\u0027,"},{"line_number":96,"context_line":"      require \u003d\u003e Pacemaker::Resource::Service[$::mongodb::params::service_name],"},{"line_number":97,"context_line":"      before  \u003d\u003e Mongodb_replset[$mongodb_replset],"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"    mongodb_replset { $mongodb_replset :"},{"line_number":100,"context_line":"      members \u003d\u003e $mongo_node_ips_with_port_nobr,"},{"line_number":101,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9abb7d3a_06d1c757","line":98,"range":{"start_line":94,"start_character":3,"end_line":98,"end_character":5},"updated":"2016-05-30 07:38:06.000000000","message":"This needs to have the \u0027server\u0027 attribute set. Else it will try to validate localhost.","commit_id":"002d031dc34f7c66dce8b2ae2ec3bf64a8794d1b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e24469f3bcfd84678f9c204809ea4a222665d534","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  $step                 \u003d hiera(\u0027step\u0027),"},{"line_number":50,"context_line":"  $enable_load_balancer \u003d hiera(\u0027enable_load_balancer\u0027, true),"},{"line_number":51,"context_line":") {"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  $port \u003d \u002727017\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  if $::hostname \u003d\u003d downcase($bootstrap_node) {"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"9abb7d3a_25f60ff9","line":52,"updated":"2016-06-01 08:14:03.000000000","message":"I think this could just include \n\n  ::tripleo::profile::base::database::mongodb\n\nso it won\u0027t duplicate class params and logic and only add lines from 89?","commit_id":"286505ec0251eb0d7188fa607590583ff7219ccc"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"92bc31840e55be5a72155ebcc725c4861543dd0d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  $step                 \u003d hiera(\u0027step\u0027),"},{"line_number":50,"context_line":"  $enable_load_balancer \u003d hiera(\u0027enable_load_balancer\u0027, true),"},{"line_number":51,"context_line":") {"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  $port \u003d \u002727017\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  if $::hostname \u003d\u003d downcase($bootstrap_node) {"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"9abb7d3a_c091f1f2","line":52,"in_reply_to":"9abb7d3a_25f60ff9","updated":"2016-06-01 08:39:17.000000000","message":"Right, ill remove the duplicated code","commit_id":"286505ec0251eb0d7188fa607590583ff7219ccc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e24469f3bcfd84678f9c204809ea4a222665d534","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    $mongo_node_string \u003d join($mongo_node_ips_with_port, \u0027,\u0027)"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master and $enable_load_balancer {"},{"line_number":90,"context_line":"    pacemaker::resource::service { $::mongodb::params::service_name :"},{"line_number":91,"context_line":"      op_params    \u003d\u003e \u0027start timeout\u003d370s stop timeout\u003d200s\u0027,"},{"line_number":92,"context_line":"      clone_params \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"9abb7d3a_45c873a8","line":89,"updated":"2016-06-01 08:14:03.000000000","message":"I don\u0027t think this should depend on $enable_load_balancer","commit_id":"286505ec0251eb0d7188fa607590583ff7219ccc"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"92bc31840e55be5a72155ebcc725c4861543dd0d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    $mongo_node_string \u003d join($mongo_node_ips_with_port, \u0027,\u0027)"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master and $enable_load_balancer {"},{"line_number":90,"context_line":"    pacemaker::resource::service { $::mongodb::params::service_name :"},{"line_number":91,"context_line":"      op_params    \u003d\u003e \u0027start timeout\u003d370s stop timeout\u003d200s\u0027,"},{"line_number":92,"context_line":"      clone_params \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"9abb7d3a_c0a8d122","line":89,"in_reply_to":"9abb7d3a_45335362","updated":"2016-06-01 08:39:17.000000000","message":"ack","commit_id":"286505ec0251eb0d7188fa607590583ff7219ccc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"33046234a8bfae3d37182b5c3c979e44b07cec36","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    $mongo_node_string \u003d join($mongo_node_ips_with_port, \u0027,\u0027)"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  if $step \u003e\u003d 2 and $pacemaker_master and $enable_load_balancer {"},{"line_number":90,"context_line":"    pacemaker::resource::service { $::mongodb::params::service_name :"},{"line_number":91,"context_line":"      op_params    \u003d\u003e \u0027start timeout\u003d370s stop timeout\u003d200s\u0027,"},{"line_number":92,"context_line":"      clone_params \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"9abb7d3a_45335362","line":89,"in_reply_to":"9abb7d3a_45c873a8","updated":"2016-06-01 08:20:25.000000000","message":"should *not*","commit_id":"286505ec0251eb0d7188fa607590583ff7219ccc"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a04e9891380b6667164294d3eaebe714b6c6b3e4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"      before  \u003d\u003e Mongodb_replset[$mongodb_replset],"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":"    mongodb_replset { $mongodb_replset :"},{"line_number":82,"context_line":"      members \u003d\u003e $mongo_node_ips_with_port_nobr,"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":"  }"},{"line_number":85,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"9abb7d3a_6c3757ff","line":82,"range":{"start_line":82,"start_character":17,"end_line":82,"end_character":47},"updated":"2016-06-01 11:25:24.000000000","message":"this was define in the section that was removed. Now there\u0027s some undefined value getting here and the replset is being misconfigured.","commit_id":"f31620d42ce13afa8535662682890e9de4ff58b9"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"78295faac5d98a17d41224a9fd992db1e81a2e5b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  $step                 \u003d hiera(\u0027step\u0027),"},{"line_number":37,"context_line":") {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":40,"context_line":"    include ::mongodb::globals"},{"line_number":41,"context_line":"    include ::mongodb::client"},{"line_number":42,"context_line":"    include ::mongodb::server"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7aa08908_f1d0c5f9","line":43,"range":{"start_line":39,"start_character":1,"end_line":43,"end_character":3},"updated":"2016-06-10 08:25:15.000000000","message":"these are included in mongodbcommon and in a different step. O_o weird","commit_id":"f6df5927b5bbf2f94dcfbe15385e1334c6531b47"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"29b2f143bff82973f0ce9d9cbd1d1cfe3c10ec3c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  $step                 \u003d hiera(\u0027step\u0027),"},{"line_number":37,"context_line":") {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":40,"context_line":"    include ::mongodb::globals"},{"line_number":41,"context_line":"    include ::mongodb::client"},{"line_number":42,"context_line":"    include ::mongodb::server"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7aa08908_6ca07aa6","line":43,"range":{"start_line":39,"start_character":1,"end_line":43,"end_character":3},"in_reply_to":"7aa08908_f1d0c5f9","updated":"2016-06-10 09:31:49.000000000","message":"I added that conditional because for pacemaker, this should run in step one, but for all other roles they should run in step 2, so they should not overlap, right? But I will try to split as discussed in IRC creating a resource and taking out the include ::mongodb* section.","commit_id":"f6df5927b5bbf2f94dcfbe15385e1334c6531b47"}]}