)]}'
{"manifests/profile/base/ceilometer.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"29dec201d7bafcbb8bcf3424ff6acaef1a324d8b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class tripleo::profile::base::ceilometer ("},{"line_number":39,"context_line":"  $ceilometer_database_connection,"},{"line_number":40,"context_line":"  $manage_service     \u003d undef,"},{"line_number":41,"context_line":"  $enabled            \u003d undef,"},{"line_number":42,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":43,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_8f8c1236","line":40,"updated":"2016-04-29 21:39:39.000000000","message":"I don\u0027t like the default for the 2 parameters, IMHO we should rather use false or true.","commit_id":"cee0d5038c6b5c19cf0e9050a1007a64782fb4e5"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"29dec201d7bafcbb8bcf3424ff6acaef1a324d8b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  $ceilometer_database_connection,"},{"line_number":40,"context_line":"  $manage_service     \u003d undef,"},{"line_number":41,"context_line":"  $enabled            \u003d undef,"},{"line_number":42,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":43,"context_line":") {"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_6f741635","line":42,"updated":"2016-04-29 21:39:39.000000000","message":"please align all params correctly.","commit_id":"cee0d5038c6b5c19cf0e9050a1007a64782fb4e5"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"844e64f21a8f584656f5b91f55cf91e3dfc55d27","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    class { \u0027::ceilometer::api\u0027 :"},{"line_number":50,"context_line":"      manage_service \u003d\u003e $manage_service,"},{"line_number":51,"context_line":"      enabled        \u003d\u003e $enabled,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"    class { \u0027::ceilometer::agent::notification\u0027 :"},{"line_number":54,"context_line":"      manage_service \u003d\u003e $manage_service,"},{"line_number":55,"context_line":"      enabled        \u003d\u003e $enabled,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_453597d8","line":52,"updated":"2016-05-18 19:41:27.000000000","message":"One question would be should we split the Ceilometer stuff out into separate services. There may not be a lot of value in that for baremetal but it would probably make sense for future containers.","commit_id":"a56943c3fac73e579ee75f2e2c0e382d7bd3085b"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"6bc7d760d65fa614045af48f60bd82d8df63334c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    class { \u0027::ceilometer::api\u0027 :"},{"line_number":50,"context_line":"      manage_service \u003d\u003e $manage_service,"},{"line_number":51,"context_line":"      enabled        \u003d\u003e $enabled,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"    class { \u0027::ceilometer::agent::notification\u0027 :"},{"line_number":54,"context_line":"      manage_service \u003d\u003e $manage_service,"},{"line_number":55,"context_line":"      enabled        \u003d\u003e $enabled,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_05f1196b","line":52,"in_reply_to":"bab6814e_453597d8","updated":"2016-05-23 14:21:05.000000000","message":"We could but i dont know how much value it adds. The event stuff is splitting out into its own project called Panko but its not ready yet. So for now it seems we can just keep it under one profile. But i dont have a strong opinion either way.","commit_id":"a56943c3fac73e579ee75f2e2c0e382d7bd3085b"}],"manifests/profile/base/ceilometer/agent/compute.pp":[{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"31f76e8eba185ab8bdbc0efb7a7184340f6a3c69","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":34,"context_line":"    include ::ceilometer::agent::auth"},{"line_number":35,"context_line":"    include ::ceilometer::agent::compute"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3aaa91ec_6cc43b40","line":35,"updated":"2016-06-21 16:13:19.000000000","message":"manifests/agent/compute.pp in puppet-ceilometer says:\n\nwarning(\u0027This class is deprecated. Please use ceilometer::agent::polling with compute namespace instead.\u0027)\n\nSo, shouldn\u0027t we use ceilometer::agent::polling instead?","commit_id":"cfb077da78a93bf7112748976920d24d03002263"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"06a8f233a16ca08ed268d6393d6974a335d4af06","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":34,"context_line":"    include ::ceilometer::agent::auth"},{"line_number":35,"context_line":"    include ::ceilometer::agent::compute"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3aaa91ec_4fefb1b0","line":35,"in_reply_to":"3aaa91ec_6cc43b40","updated":"2016-06-21 16:29:54.000000000","message":"Given we already do this in t-h-t I\u0027d be okay to let this land as is I think for parity. We could follow up with another puppet-tripleo patch to switch afterwards to make the switch you suggest here.","commit_id":"cfb077da78a93bf7112748976920d24d03002263"}]}
