)]}'
{"manifests/firewall/rule.pp":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"06aca00e0ee884bce46281598ed6f4b29941c11b","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  $basic \u003d {"},{"line_number":81,"context_line":"    \u0027port\u0027        \u003d\u003e $port,"},{"line_number":82,"context_line":"    \u0027dport\u0027        \u003d\u003e $port,"},{"line_number":83,"context_line":"    \u0027sport\u0027        \u003d\u003e $port,"},{"line_number":84,"context_line":"    \u0027proto\u0027       \u003d\u003e $proto,"},{"line_number":85,"context_line":"    \u0027action\u0027      \u003d\u003e $action,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_106cc39a","line":82,"updated":"2016-04-20 20:13:30.000000000","message":"This should use $dport if set, and fall back to $port otherwise.  Ditto for $sport.  Or we should drop the dport and sport input params since they\u0027re being ignored anyway.","commit_id":"5e9086cebb2f754113d17e19f056c7f40b146c00"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"1259c32ca19c7bbba09133d674a95b15153fd6ad","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  $basic \u003d {"},{"line_number":81,"context_line":"    \u0027port\u0027        \u003d\u003e $port,"},{"line_number":82,"context_line":"    \u0027dport\u0027        \u003d\u003e $port,"},{"line_number":83,"context_line":"    \u0027sport\u0027        \u003d\u003e $port,"},{"line_number":84,"context_line":"    \u0027proto\u0027       \u003d\u003e $proto,"},{"line_number":85,"context_line":"    \u0027action\u0027      \u003d\u003e $action,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_4f9e9907","line":82,"in_reply_to":"1a122d0e_106cc39a","updated":"2016-04-20 21:12:04.000000000","message":"my ruby is pretty weak, but i think i fixed it now","commit_id":"5e9086cebb2f754113d17e19f056c7f40b146c00"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"03737dbd8a80de086fad253eab2551eb195136f7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*port*]"},{"line_number":23,"context_line":"#  (optional) The port associated to the rule."},{"line_number":24,"context_line":"#  Defaults to undef"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*dport*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_e5636faf","line":23,"updated":"2016-04-27 20:17:43.000000000","message":"should we mention deprecation here?","commit_id":"5a921ed09b7635f46ddfd8ef7eb90d6104054e9f"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"31f30a08ecc8f5c3b3ae6ee341cc7ef046ecb980","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*port*]"},{"line_number":23,"context_line":"#  (optional) The port associated to the rule."},{"line_number":24,"context_line":"#  Defaults to undef"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*dport*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a122d0e_387f4a18","line":23,"in_reply_to":"1a122d0e_e5636faf","updated":"2016-04-27 21:01:08.000000000","message":"This would be useful","commit_id":"5a921ed09b7635f46ddfd8ef7eb90d6104054e9f"}],"spec/classes/tripleo_firewall_spec.rb":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"06aca00e0ee884bce46281598ed6f4b29941c11b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            \u0027300 add custom application 1\u0027 \u003d\u003e {\u0027port\u0027 \u003d\u003e \u0027999\u0027, \u0027proto\u0027 \u003d\u003e \u0027udp\u0027, \u0027action\u0027 \u003d\u003e \u0027accept\u0027},"},{"line_number":76,"context_line":"            \u0027301 add custom application 2\u0027 \u003d\u003e {\u0027port\u0027 \u003d\u003e \u00278081\u0027, \u0027proto\u0027 \u003d\u003e \u0027tcp\u0027, \u0027action\u0027 \u003d\u003e \u0027accept\u0027},"},{"line_number":77,"context_line":"            \u0027302 fwd custom cidr 1\u0027        \u003d\u003e {\u0027chain\u0027 \u003d\u003e \u0027FORWARD\u0027, \u0027destination\u0027 \u003d\u003e \u0027192.0.2.0/24\u0027},"},{"line_number":78,"context_line":"            \u0027303 add custom application 3\u0027 \u003d\u003e {\u0027port\u0027 \u003d\u003e \u00278081\u0027, \u0027proto\u0027 \u003d\u003e \u0027tcp\u0027, \u0027action\u0027 \u003d\u003e \u0027accept\u0027}"},{"line_number":79,"context_line":"          }"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a122d0e_50d3db5f","line":78,"updated":"2016-04-20 20:13:30.000000000","message":"This seems to exactly duplicate 301.  Did you mean to use sport and dport here?  Seems like something we should have a test for anyway.","commit_id":"5e9086cebb2f754113d17e19f056c7f40b146c00"}]}