)]}'
{"manifests/profile/base/time/ntp.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6097d9afc60ee9a21a0a6fb6fb6f2ffc54ec59ca","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# \u003d\u003d Class: tripleo::profile::base::time::ntp"},{"line_number":18,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_616f3992","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"updated":"2016-06-14 18:11:07.000000000","message":"please remove the 2 lines and just add a #","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ba4810429addb379d12cbb986535e163be932e81","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# \u003d\u003d Class: tripleo::profile::base::time::ntp"},{"line_number":18,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_221b561e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"7aa08908_616f3992","updated":"2016-06-15 08:34:45.000000000","message":"Done","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6097d9afc60ee9a21a0a6fb6fb6f2ffc54ec59ca","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#  Interfaces to listen on"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"#This class allows the configuration of the NTP service"},{"line_number":36,"context_line":"#The class parameters are defined based in the service"},{"line_number":37,"context_line":"#configuration file \u003cservice\u003e-base.yaml from tripleo-heat-templates"},{"line_number":38,"context_line":"#This particular file for NTP is located in THT:/puppet/services/time/ntp-base.yaml"},{"line_number":39,"context_line":"#which is called from THT:/puppet/services/time/ntp.yaml"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class tripleo::profile::base::time::ntp ("},{"line_number":42,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_61f619d8","line":39,"range":{"start_line":35,"start_character":0,"end_line":39,"end_character":56},"updated":"2016-06-14 18:11:07.000000000","message":"please add a space between # and your description. Also please move it after \"Enable NTP via composable services.\" line.","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ba4810429addb379d12cbb986535e163be932e81","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#  Interfaces to listen on"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"#This class allows the configuration of the NTP service"},{"line_number":36,"context_line":"#The class parameters are defined based in the service"},{"line_number":37,"context_line":"#configuration file \u003cservice\u003e-base.yaml from tripleo-heat-templates"},{"line_number":38,"context_line":"#This particular file for NTP is located in THT:/puppet/services/time/ntp-base.yaml"},{"line_number":39,"context_line":"#which is called from THT:/puppet/services/time/ntp.yaml"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class tripleo::profile::base::time::ntp ("},{"line_number":42,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_82184a20","line":39,"range":{"start_line":35,"start_character":0,"end_line":39,"end_character":56},"in_reply_to":"7aa08908_61f619d8","updated":"2016-06-15 08:34:45.000000000","message":"Done","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6097d9afc60ee9a21a0a6fb6fb6f2ffc54ec59ca","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#which is called from THT:/puppet/services/time/ntp.yaml"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class tripleo::profile::base::time::ntp ("},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  #We get the configuration step in which we can choose which steps to execute"},{"line_number":44,"context_line":"  $step          \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers    \u003d [],"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_c101cdb0","line":42,"updated":"2016-06-14 18:11:07.000000000","message":"useless line","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ba4810429addb379d12cbb986535e163be932e81","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#which is called from THT:/puppet/services/time/ntp.yaml"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class tripleo::profile::base::time::ntp ("},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  #We get the configuration step in which we can choose which steps to execute"},{"line_number":44,"context_line":"  $step          \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers    \u003d [],"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_c2d0922e","line":42,"in_reply_to":"7aa08908_c101cdb0","updated":"2016-06-15 08:34:45.000000000","message":"Done","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6097d9afc60ee9a21a0a6fb6fb6f2ffc54ec59ca","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class tripleo::profile::base::time::ntp ("},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  #We get the configuration step in which we can choose which steps to execute"},{"line_number":44,"context_line":"  $step          \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers    \u003d [],"},{"line_number":46,"context_line":"  $ntpinterfaces \u003d [],"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_012e3542","line":43,"updated":"2016-06-14 18:11:07.000000000","message":"we don\u0027t need this comment, we have it everywhere already","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ba4810429addb379d12cbb986535e163be932e81","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class tripleo::profile::base::time::ntp ("},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  #We get the configuration step in which we can choose which steps to execute"},{"line_number":44,"context_line":"  $step          \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers    \u003d [],"},{"line_number":46,"context_line":"  $ntpinterfaces \u003d [],"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_82efaae8","line":43,"in_reply_to":"7aa08908_012e3542","updated":"2016-06-15 08:34:45.000000000","message":"Done","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6097d9afc60ee9a21a0a6fb6fb6f2ffc54ec59ca","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $step          \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers    \u003d [],"},{"line_number":46,"context_line":"  $ntpinterfaces \u003d [],"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":"  #step assigned for core modules."},{"line_number":50,"context_line":"  #(Check for further referencies about the configuration steps)"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_e13049a0","line":47,"updated":"2016-06-14 18:11:07.000000000","message":"useless line","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ba4810429addb379d12cbb986535e163be932e81","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $step          \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers    \u003d [],"},{"line_number":46,"context_line":"  $ntpinterfaces \u003d [],"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":"  #step assigned for core modules."},{"line_number":50,"context_line":"  #(Check for further referencies about the configuration steps)"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_e2b66ef8","line":47,"in_reply_to":"7aa08908_e13049a0","updated":"2016-06-15 08:34:45.000000000","message":"Done","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2336969ec8858eb9f7ccb38b35b4d2d27b3e3562","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class tripleo::profile::base::time::ntp ("},{"line_number":36,"context_line":"  $step          \u003d hiera(\u0027step\u0027),"},{"line_number":37,"context_line":"  $ntpservers    \u003d [],"},{"line_number":38,"context_line":"  $ntpinterfaces \u003d [],"},{"line_number":39,"context_line":"){"},{"line_number":40,"context_line":"  if ($step \u003e\u003d 2){"},{"line_number":41,"context_line":"    if count($ntpservers) \u003e 0 {"}],"source_content_type":"text/x-puppet","patch_set":36,"id":"7aa08908_ee0262b3","line":38,"updated":"2016-06-17 08:07:24.000000000","message":"apart from the comment about defaults below, this is fine imo. Just wondering if we really need the params ntpservers/interfaces here at all? Can\u0027t we set these t-h-t side directly from the https://review.openstack.org/#/c/310421/37/puppet/services/time/ntp.yaml - that way you don\u0027t have to worry about defaults or anything here and we can just include ::ntp class. OR there is a reason we want these params here so you\u0027ll have to deal with making sure we do the right thing wrt setting ntpservers to [] as in comment below","commit_id":"e2d01f79b57149bec64b23aa9a74c36ff1b71008"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2336969ec8858eb9f7ccb38b35b4d2d27b3e3562","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    if count($ntpservers) \u003e 0 {"},{"line_number":42,"context_line":"      class { \u0027::ntp\u0027:"},{"line_number":43,"context_line":"        servers    \u003d\u003e $ntpservers,"},{"line_number":44,"context_line":"        interfaces \u003d\u003e $ntpinterfaces,"},{"line_number":45,"context_line":"      }"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":36,"id":"7aa08908_8e0d9e37","line":44,"updated":"2016-06-17 08:07:24.000000000","message":"how does this compare to current behaviour and also the puppet-ntp module default? \n\nMy comment is mainly about the ntpinterfaces, because we\u0027re urrently afaics not setting that i.e. we have ./puppet/controller.yaml:1056: ntp::servers: {get_input: ntp_servers} for example but not for interfaces. So i was wondering about if we should explicitly set that to [] or just let the module default to what it wants. Now assuming we\u0027re using https://github.com/redhat-openstack/openstack-puppet-modules/blob/ab63b3886cf0b5e9bdb0a83322ba9b4af201dee3/ntp/manifests/params.pp#L23 then it is indeed \u0027[]\u0027.\n\n\n[EDIT]: so in fact the case of the ntpservers turns out to be more interesting because current behaviour is we specify nothing at all and then it gets defaulted to something like https://github.com/redhat-openstack/openstack-puppet-modules/blob/ab63b3886cf0b5e9bdb0a83322ba9b4af201dee3/ntp/manifests/params.pp#L70 - my point is we should let the module default rather than explicitly setting [] in general and this is a good case of why","commit_id":"e2d01f79b57149bec64b23aa9a74c36ff1b71008"}],"manifests/profile/pacemaker/time/ntp.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6097d9afc60ee9a21a0a6fb6fb6f2ffc54ec59ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_81222550","line":1,"updated":"2016-06-14 18:11:07.000000000","message":"same comments as other manifest","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ba4810429addb379d12cbb986535e163be932e81","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_a2a3c6b0","line":1,"in_reply_to":"7aa08908_81222550","updated":"2016-06-15 08:34:45.000000000","message":"Done","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6ccda3bad568de030ae8c20e42ac3b77d24448ba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_41979d39","line":2,"updated":"2016-06-14 18:13:30.000000000","message":"I think you can remove this profile, it\u0027s very useless at this stage, there is no diff between nonha \u0026 ha deployments.","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ba4810429addb379d12cbb986535e163be932e81","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_02a9fa90","line":2,"in_reply_to":"7aa08908_41979d39","updated":"2016-06-15 08:34:45.000000000","message":"Done","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6097d9afc60ee9a21a0a6fb6fb6f2ffc54ec59ca","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  #http://git.openstack.org/cgit/openstack/tripleo-heat-templates/tree/puppet/services/README.rst"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  if ($step \u003e\u003d 1){"},{"line_number":54,"context_line":"    #We will call the NTP puppet class and assign our configuration values."},{"line_number":55,"context_line":"    #If needed additional Puppet packages can be added/installed by using the repo tripleo-puppet-elements"},{"line_number":56,"context_line":"    if count($ntpservers) \u003e 0 {"},{"line_number":57,"context_line":"      class { \u0027::ntp\u0027:"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_61e4590c","line":54,"updated":"2016-06-14 18:11:07.000000000","message":"why not including tripleo::profile::base::time::ntp like we do with other services?","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"ba4810429addb379d12cbb986535e163be932e81","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  #http://git.openstack.org/cgit/openstack/tripleo-heat-templates/tree/puppet/services/README.rst"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  if ($step \u003e\u003d 1){"},{"line_number":54,"context_line":"    #We will call the NTP puppet class and assign our configuration values."},{"line_number":55,"context_line":"    #If needed additional Puppet packages can be added/installed by using the repo tripleo-puppet-elements"},{"line_number":56,"context_line":"    if count($ntpservers) \u003e 0 {"},{"line_number":57,"context_line":"      class { \u0027::ntp\u0027:"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"7aa08908_e2adce9c","line":54,"in_reply_to":"7aa08908_61e4590c","updated":"2016-06-15 08:34:45.000000000","message":"Done","commit_id":"2c3bacdd31da52a8a53d1c125a379bfeb0fa0023"}],"manifests/services/time/ntp.pp":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"125e31885853e1c014f792f318c8897e7467e19f","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  #We get the configuration step in which we can choose which steps to execute"},{"line_number":44,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers         \u003d hiera(\u0027ntpservers\u0027),"},{"line_number":46,"context_line":"  $ntpinterfaces      \u003d hiera(\u0027ntpinterfaces\u0027),"},{"line_number":47,"context_line":"  $ntppackagemanaged  \u003d hiera(\u0027ntppackagemanaged\u0027),"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_13a478a4","line":45,"updated":"2016-05-18 19:34:07.000000000","message":"perhaps default ntpservers to an empty array instead of this Hiera variable.","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"777b6d241d19d9142a12a354568d9c7e1e8c3967","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  #We get the configuration step in which we can choose which steps to execute"},{"line_number":44,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers         \u003d hiera(\u0027ntpservers\u0027),"},{"line_number":46,"context_line":"  $ntpinterfaces      \u003d hiera(\u0027ntpinterfaces\u0027),"},{"line_number":47,"context_line":"  $ntppackagemanaged  \u003d hiera(\u0027ntppackagemanaged\u0027),"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_1dfe2d38","line":45,"in_reply_to":"bab6814e_13a478a4","updated":"2016-05-19 09:28:42.000000000","message":"Done","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"125e31885853e1c014f792f318c8897e7467e19f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  #We get the configuration step in which we can choose which steps to execute"},{"line_number":44,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers         \u003d hiera(\u0027ntpservers\u0027),"},{"line_number":46,"context_line":"  $ntpinterfaces      \u003d hiera(\u0027ntpinterfaces\u0027),"},{"line_number":47,"context_line":"  $ntppackagemanaged  \u003d hiera(\u0027ntppackagemanaged\u0027),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_93b6a8da","line":46,"updated":"2016-05-18 19:34:07.000000000","message":"ditto here, default to an empty array? or false.","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"777b6d241d19d9142a12a354568d9c7e1e8c3967","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  #We get the configuration step in which we can choose which steps to execute"},{"line_number":44,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers         \u003d hiera(\u0027ntpservers\u0027),"},{"line_number":46,"context_line":"  $ntpinterfaces      \u003d hiera(\u0027ntpinterfaces\u0027),"},{"line_number":47,"context_line":"  $ntppackagemanaged  \u003d hiera(\u0027ntppackagemanaged\u0027),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_5df8b549","line":46,"in_reply_to":"bab6814e_93b6a8da","updated":"2016-05-19 09:28:42.000000000","message":"Done","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"125e31885853e1c014f792f318c8897e7467e19f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers         \u003d hiera(\u0027ntpservers\u0027),"},{"line_number":46,"context_line":"  $ntpinterfaces      \u003d hiera(\u0027ntpinterfaces\u0027),"},{"line_number":47,"context_line":"  $ntppackagemanaged  \u003d hiera(\u0027ntppackagemanaged\u0027),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":"  #step assigned for core modules."}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_33ab7c76","line":47,"updated":"2016-05-18 19:34:07.000000000","message":"ditto here.","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"777b6d241d19d9142a12a354568d9c7e1e8c3967","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $step               \u003d hiera(\u0027step\u0027),"},{"line_number":45,"context_line":"  $ntpservers         \u003d hiera(\u0027ntpservers\u0027),"},{"line_number":46,"context_line":"  $ntpinterfaces      \u003d hiera(\u0027ntpinterfaces\u0027),"},{"line_number":47,"context_line":"  $ntppackagemanaged  \u003d hiera(\u0027ntppackagemanaged\u0027),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":"  #step assigned for core modules."}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_bd9561e5","line":47,"in_reply_to":"bab6814e_33ab7c76","updated":"2016-05-19 09:28:42.000000000","message":"Done","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"b4dacefdecdc56f24e3d3851d4213c75e5c6e064","unresolved":false,"context_lines":[{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":"  #step assigned for core modules."},{"line_number":51,"context_line":"  #(Check for further referencies about the configuration steps https://review.openstack.org/#/c/245804/2/specs/mitaka/composable-services-within-roles.rst)"},{"line_number":52,"context_line":"  #Please note that the spec is abandoned but until now is the only documented reference about config steps."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if ($step \u003d\u003d 2){"},{"line_number":55,"context_line":"    #We will call the NTP puppet class and assign our configuration values."}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_f3cbb470","line":52,"updated":"2016-05-18 19:31:23.000000000","message":"Instead of referencing this would this file work: http://git.openstack.org/cgit/openstack/tripleo-heat-templates/tree/puppet/services/README.rst","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"777b6d241d19d9142a12a354568d9c7e1e8c3967","unresolved":false,"context_lines":[{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":"  #step assigned for core modules."},{"line_number":51,"context_line":"  #(Check for further referencies about the configuration steps https://review.openstack.org/#/c/245804/2/specs/mitaka/composable-services-within-roles.rst)"},{"line_number":52,"context_line":"  #Please note that the spec is abandoned but until now is the only documented reference about config steps."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if ($step \u003d\u003d 2){"},{"line_number":55,"context_line":"    #We will call the NTP puppet class and assign our configuration values."}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_fd9fe900","line":52,"in_reply_to":"bab6814e_f3cbb470","updated":"2016-05-19 09:28:42.000000000","message":"Done","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"125e31885853e1c014f792f318c8897e7467e19f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if ($step \u003d\u003d 2){"},{"line_number":55,"context_line":"    #We will call the NTP puppet class and assign our configuration values."},{"line_number":56,"context_line":"    #If needed additional Puppet packages can be added/installed by using the repo tripleo-puppet-elements"},{"line_number":57,"context_line":"    class { \u0027::ntp\u0027:"},{"line_number":58,"context_line":"      servers        \u003d\u003e $ntpservers,"},{"line_number":59,"context_line":"      interfaces     \u003d\u003e $ntpinterfaces,"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_7394e436","line":56,"updated":"2016-05-18 19:34:07.000000000","message":"Could you add a check here so that the ntp class is only included of ntpservers \u003e 0.","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"777b6d241d19d9142a12a354568d9c7e1e8c3967","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if ($step \u003d\u003d 2){"},{"line_number":55,"context_line":"    #We will call the NTP puppet class and assign our configuration values."},{"line_number":56,"context_line":"    #If needed additional Puppet packages can be added/installed by using the repo tripleo-puppet-elements"},{"line_number":57,"context_line":"    class { \u0027::ntp\u0027:"},{"line_number":58,"context_line":"      servers        \u003d\u003e $ntpservers,"},{"line_number":59,"context_line":"      interfaces     \u003d\u003e $ntpinterfaces,"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"bab6814e_dda2e54a","line":56,"in_reply_to":"bab6814e_7394e436","updated":"2016-05-19 09:28:42.000000000","message":"Done","commit_id":"964b219dca83d6d460b809924bedab836120dd1d"}]}