)]}'
{"manifests/profile/base/cinder/volume.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eaf399eef8f3d84f7b85217fdf4dd1ca43427f93","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":58,"context_line":"#   for more details."},{"line_number":59,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"class tripleo::profile::base::cinder::volume ("},{"line_number":62,"context_line":"  $cinder_enable_dellsc_backend \u003d false,"},{"line_number":63,"context_line":"  $cinder_enable_eqlx_backend   \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_3311e854","line":60,"updated":"2016-04-29 22:01:14.000000000","message":"some parameters are missing doc, see:\nhttp://logs.openstack.org/39/310939/2/check/gate-puppet-tripleo-puppet-lint/487f208/console.html#_2016-04-28_22_51_12_446","commit_id":"2c778f92f1be6e2198469cb2e20aa79edadac8e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"84b2b208a1028c6b75d283d3cc615a0130674bcd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":58,"context_line":"#   for more details."},{"line_number":59,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"class tripleo::profile::base::cinder::volume ("},{"line_number":62,"context_line":"  $cinder_enable_dellsc_backend \u003d false,"},{"line_number":63,"context_line":"  $cinder_enable_eqlx_backend   \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_dff06169","line":60,"in_reply_to":"1a122d0e_3311e854","updated":"2016-05-02 07:49:32.000000000","message":"yeah I have to split these into separate manifests","commit_id":"2c778f92f1be6e2198469cb2e20aa79edadac8e2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ed6a227f3310cfce8d7411b7ae2ddfb9388bd10e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  $cinder_enable_iscsi_backend  \u003d true,"},{"line_number":65,"context_line":"  $cinder_enable_netapp_backend \u003d false,"},{"line_number":66,"context_line":"  $cinder_enable_nfs_backend    \u003d false,"},{"line_number":67,"context_line":"  $cinder_enable_rbd_backend    \u003d fasle,"},{"line_number":68,"context_line":"  $cinder_iscsi_address,"},{"line_number":69,"context_line":"  $cinder_iscsi_helper          \u003d \u0027tgtadm\u0027,"},{"line_number":70,"context_line":"  $cinder_lvm_loop_device_size  \u003d \u002710280\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_d688ff24","line":67,"updated":"2016-05-09 12:53:36.000000000","message":"false","commit_id":"2c778f92f1be6e2198469cb2e20aa79edadac8e2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ed6a227f3310cfce8d7411b7ae2ddfb9388bd10e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $cinder_enable_netapp_backend \u003d false,"},{"line_number":66,"context_line":"  $cinder_enable_nfs_backend    \u003d false,"},{"line_number":67,"context_line":"  $cinder_enable_rbd_backend    \u003d fasle,"},{"line_number":68,"context_line":"  $cinder_iscsi_address,"},{"line_number":69,"context_line":"  $cinder_iscsi_helper          \u003d \u0027tgtadm\u0027,"},{"line_number":70,"context_line":"  $cinder_lvm_loop_device_size  \u003d \u002710280\u0027,"},{"line_number":71,"context_line":"  $cinder_nfs_servers           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_96a037a1","line":68,"updated":"2016-05-09 12:53:36.000000000","message":"why no default here (even undef?) i see it is passed/set from https://review.openstack.org/#/c/310940/2/puppet/controller.yaml\n\nalso do you want to expose this at all here? could just be set on the tht side ? i am debating whether to keep the listen_ip for memcached at https://review.openstack.org/#/c/312877/","commit_id":"2c778f92f1be6e2198469cb2e20aa79edadac8e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"02758c310f24f64aa453b0549d9dc4f976214707","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $cinder_enable_netapp_backend \u003d false,"},{"line_number":66,"context_line":"  $cinder_enable_nfs_backend    \u003d false,"},{"line_number":67,"context_line":"  $cinder_enable_rbd_backend    \u003d fasle,"},{"line_number":68,"context_line":"  $cinder_iscsi_address,"},{"line_number":69,"context_line":"  $cinder_iscsi_helper          \u003d \u0027tgtadm\u0027,"},{"line_number":70,"context_line":"  $cinder_lvm_loop_device_size  \u003d \u002710280\u0027,"},{"line_number":71,"context_line":"  $cinder_nfs_servers           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_87e8e8b5","line":68,"in_reply_to":"dab17558_96a037a1","updated":"2016-05-09 21:33:50.000000000","message":"it\u0027s required by puppet-cinder itself","commit_id":"2c778f92f1be6e2198469cb2e20aa79edadac8e2"}],"manifests/profile/base/cinder/volume/dellsc.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"28d03eaadb25d65e1f9445fc249603e4cbd60772","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  include ::tripleo::profile::base::cinder::volume"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":33,"context_line":"    $cinder_dellsc_backend \u003d hiera(\u0027cinder::backend::dellsc_iscsi::volume_backend_name\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    cinder::backend::dellsc_iscsi{ $cinder_dellsc_backend :"},{"line_number":36,"context_line":"      volume_backend_name   \u003d\u003e hiera(\u0027cinder::backend::dellsc_iscsi::volume_backend_name\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"dab17558_24ca681b","line":33,"updated":"2016-05-11 16:45:23.000000000","message":"unfortunately we have to do this because the cinder backends are \u0027defined resources\u0027 not \u0027classes\u0027","commit_id":"74528e317ca4c9a919fbdfb079e384c81bc1a72d"}],"manifests/profile/pacemaker/cinder.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eaf399eef8f3d84f7b85217fdf4dd1ca43427f93","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::pacemaker::cinder ("},{"line_number":31,"context_line":"  $bootstrap_node             \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":32,"context_line":"  $step                       \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_9328bc87","line":31,"updated":"2016-04-29 22:01:14.000000000","message":"fix alignment","commit_id":"2c778f92f1be6e2198469cb2e20aa79edadac8e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"84b2b208a1028c6b75d283d3cc615a0130674bcd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"class tripleo::profile::pacemaker::cinder ("},{"line_number":31,"context_line":"  $bootstrap_node             \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":32,"context_line":"  $step                       \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_3fe6b5b0","line":31,"in_reply_to":"1a122d0e_9328bc87","updated":"2016-05-02 07:49:32.000000000","message":"will do","commit_id":"2c778f92f1be6e2198469cb2e20aa79edadac8e2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eaf399eef8f3d84f7b85217fdf4dd1ca43427f93","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  $step                       \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  Service \u003c| tag \u003d\u003d \u0027cinder-service\u0027 |\u003e {"},{"line_number":36,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":37,"context_line":"    restart    \u003d\u003e \u0027/bin/true\u0027,"},{"line_number":38,"context_line":"    start      \u003d\u003e \u0027/bin/true\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_f31db063","line":35,"updated":"2016-04-29 22:01:14.000000000","message":"w00t? can you explain that code?","commit_id":"2c778f92f1be6e2198469cb2e20aa79edadac8e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"84b2b208a1028c6b75d283d3cc615a0130674bcd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  $step                       \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  Service \u003c| tag \u003d\u003d \u0027cinder-service\u0027 |\u003e {"},{"line_number":36,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":37,"context_line":"    restart    \u003d\u003e \u0027/bin/true\u0027,"},{"line_number":38,"context_line":"    start      \u003d\u003e \u0027/bin/true\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_9ff70959","line":35,"in_reply_to":"1a122d0e_f31db063","updated":"2016-05-02 07:49:32.000000000","message":"overriding start/stop/restart for every service tagged cinder-service","commit_id":"2c778f92f1be6e2198469cb2e20aa79edadac8e2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b6fcc1bb9626e07c20bd19ee3a5ae484b98492d2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":53,"context_line":"    pacemaker::resource::service { $::cinder::params::api_service :"},{"line_number":54,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"},{"line_number":55,"context_line":"      require      \u003d\u003e Pacemaker::Resource::Ocf[\u0027openstack-core\u0027],"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":"    pacemaker::resource::service { $::cinder::params::scheduler_service :"},{"line_number":58,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dab17558_c6e56d09","line":55,"updated":"2016-05-11 13:54:13.000000000","message":"where is the openstack-core going to end up/defined btw - do we need to make a tripleo::profile::pacemaker::core - feels bad for the dummy resource but we have these constraints which refer to it. I am interested because memcached has:\n\n    pacemaker::constraint::base { \u0027memcached-then-openstack-core-constraint\u0027:\n\nwhich am removing in https://review.openstack.org/#/c/312899/2/puppet/manifests/overcloud_controller_pacemaker.pp and adding at https://review.openstack.org/#/c/312877/2/manifests/profile/pacemaker/memcached.pp but as jistr notes we should think about how this and the similar galera one (afaics is the only other constraint going to openstack-core)","commit_id":"db8caf8f08f5bee92eb5a78c662afb7e28354e57"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d927a7dc0e033b5955c558888797469d6c299e35","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":53,"context_line":"    pacemaker::resource::service { $::cinder::params::api_service :"},{"line_number":54,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"},{"line_number":55,"context_line":"      require      \u003d\u003e Pacemaker::Resource::Ocf[\u0027openstack-core\u0027],"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":"    pacemaker::resource::service { $::cinder::params::scheduler_service :"},{"line_number":58,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dab17558_e9a95925","line":55,"in_reply_to":"dab17558_c6e56d09","updated":"2016-05-11 16:33:44.000000000","message":"comes from _pacemaker.pp file for now and I think it\u0027s fine as first iteration\n\nit will go away with lightweight/ha anyway","commit_id":"db8caf8f08f5bee92eb5a78c662afb7e28354e57"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7abac199fae530682cbff2e7d9f84f4191f410ea","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":53,"context_line":"    pacemaker::resource::service { $::cinder::params::api_service :"},{"line_number":54,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"},{"line_number":55,"context_line":"      require      \u003d\u003e Pacemaker::Resource::Ocf[\u0027openstack-core\u0027],"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":"    pacemaker::resource::service { $::cinder::params::scheduler_service :"},{"line_number":58,"context_line":"      clone_params \u003d\u003e \u0027interleave\u003dtrue\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dab17558_2eb5fe7d","line":55,"in_reply_to":"dab17558_e9a95925","updated":"2016-05-12 10:36:15.000000000","message":"wfm... so to be clear for now we will keep the resource definition in step 2 of controller_pacemaker.pp ?? I thought that would ultimately go away though?\nSo since this dummy resource won\u0027t be necessary anymore ultimately, we will have a review then which removes all the constraints that refer to it here, or in memcached etc","commit_id":"db8caf8f08f5bee92eb5a78c662afb7e28354e57"}]}