)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"c07040a1dde2809d74a2409c99a0f83ef0c4bbbb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Prince \u003cdprince@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-29 13:13:38 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a Cinder backup Ceph profile."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"FIXME: needs a pacemaker version"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_e7b3a04b","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":33},"updated":"2016-06-13 04:09:23.000000000","message":"Do we have other backup profiles? For example Swift?\nDo you create somewhere a dedicated Ceph pool to store Cinder backups? Unfortunately commit message doesn\u0027t explain much.","commit_id":"5a34ffbff937568670707cf1bba4f08ac3fc801f"}],"manifests/profile/base/cinder/backup.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"71969258392265ddd4c273486110f4de25c2cd31","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":23,"context_line":"#   for more details."},{"line_number":24,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class tripleo::profile::base::cinder::backup ("},{"line_number":27,"context_line":"  $step \u003d hiera(\u0027step\u0027),"},{"line_number":28,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_d21064ab","line":25,"updated":"2016-06-21 16:49:57.000000000","message":"I think we need to add a parameter to control which backend to enable, see glance for example [1], and include ::ceph for example when the backend is set to ceph\n\n1. https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/glance/api.pp#L32","commit_id":"e4c5de7455968feab850ff1f039b5fe0b695cc92"}],"manifests/profile/base/cinder/backup/ceph.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"04769c6cf2b9e637afa086a9edebe424483466be","unresolved":false,"context_lines":[{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":31,"context_line":"    include ::cinder::backup"},{"line_number":32,"context_line":"    include ::cinder::backup::ceph"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_73146be8","line":31,"updated":"2016-06-13 19:43:13.000000000","message":"why not including tripleo::profile::base::cinder::backup instead? We usually do that for other profiles.","commit_id":"8e8841b41a413f85ca5851b38fea788c8b586601"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e2ca6cbd6b050b37745bfc879d82cb6d59dca1fe","unresolved":false,"context_lines":[{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":31,"context_line":"    include ::tripleo::profile::base::cinder::backup"},{"line_number":32,"context_line":"    include ::cinder::backup::ceph"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a9d85d2_2fd8011d","line":31,"updated":"2016-06-21 14:32:23.000000000","message":"I think this should go out of the step \u003e\u003d 4 conditional","commit_id":"e79f8403d6a1f4cf0ffa1f79ba21c4c84b34eb9b"}],"manifests/profile/base/cinder/backup_ceph.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7b33e99324cf859b84df0f922bc6d646f2aafd7a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class tripleo::profile::base::cinder::backup_ceph ("},{"line_number":27,"context_line":"  $step             \u003d hiera(\u0027step\u0027),"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a122d0e_be002202","line":27,"updated":"2016-04-29 19:20:16.000000000","message":"please align it correctly, for readability.","commit_id":"5a34ffbff937568670707cf1bba4f08ac3fc801f"}],"manifests/profile/pacemaker/cinder/backup.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"04769c6cf2b9e637afa086a9edebe424483466be","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    $pacemaker_master \u003d false"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  include ::tripleo::profile::base::cinder::backup"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 5 and $pacemaker_master {"},{"line_number":51,"context_line":"    pacemaker::resource::service { $::cinder::params::backup_service : }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_33e5c308","line":48,"updated":"2016-06-13 19:43:13.000000000","message":"great :)","commit_id":"8e8841b41a413f85ca5851b38fea788c8b586601"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3bbb6144f92d9673fe5535e80c06e90cf30713e4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      second_resource \u003d\u003e $::cinder::params::backup_service,"},{"line_number":56,"context_line":"      first_action    \u003d\u003e \u0027start\u0027,"},{"line_number":57,"context_line":"      second_action   \u003d\u003e \u0027start\u0027,"},{"line_number":58,"context_line":"      require         \u003d\u003e [Pacemaker::Resource::Service[$::cinder::params::volume_service],"},{"line_number":59,"context_line":"                          Pacemaker::Resource::Service[$::cinder::params::backup_service]],"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"    pacemaker::constraint::colocation { \u0027cinder-backup-with-cinder-volume-colocation\u0027:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_af06b8ca","line":58,"updated":"2016-06-16 16:29:42.000000000","message":"it\u0027s ok for now but when we\u0027ll split services on nodes, it won\u0027t work. Also, I\u0027m not sure this requirement is really useful.","commit_id":"dae22bd40753b800ccae2ba59e17201426395329"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d57571e683d816c3f8cf55c87e91cebbb9c59995","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      second_resource \u003d\u003e $::cinder::params::backup_service,"},{"line_number":56,"context_line":"      first_action    \u003d\u003e \u0027start\u0027,"},{"line_number":57,"context_line":"      second_action   \u003d\u003e \u0027start\u0027,"},{"line_number":58,"context_line":"      require         \u003d\u003e [Pacemaker::Resource::Service[$::cinder::params::volume_service],"},{"line_number":59,"context_line":"                          Pacemaker::Resource::Service[$::cinder::params::backup_service]],"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"    pacemaker::constraint::colocation { \u0027cinder-backup-with-cinder-volume-colocation\u0027:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_2c1461e7","line":58,"in_reply_to":"7aa08908_78e9117f","updated":"2016-06-17 14:02:38.000000000","message":"I was hasty ... on my deployment the backup indeed did not respond to me but cinder-api did.","commit_id":"dae22bd40753b800ccae2ba59e17201426395329"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2519bba2c94ff53ca3bdb92ba8d5b0f48348bd62","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      second_resource \u003d\u003e $::cinder::params::backup_service,"},{"line_number":56,"context_line":"      first_action    \u003d\u003e \u0027start\u0027,"},{"line_number":57,"context_line":"      second_action   \u003d\u003e \u0027start\u0027,"},{"line_number":58,"context_line":"      require         \u003d\u003e [Pacemaker::Resource::Service[$::cinder::params::volume_service],"},{"line_number":59,"context_line":"                          Pacemaker::Resource::Service[$::cinder::params::backup_service]],"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"    pacemaker::constraint::colocation { \u0027cinder-backup-with-cinder-volume-colocation\u0027:"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_78e9117f","line":58,"in_reply_to":"7aa08908_af06b8ca","updated":"2016-06-17 11:22:22.000000000","message":"++ cinder backup does not need volume on the same node. It does work as it is \u0027though (just deployed with this patch locally and cinder backup seems to be responding).","commit_id":"dae22bd40753b800ccae2ba59e17201426395329"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3bbb6144f92d9673fe5535e80c06e90cf30713e4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      target  \u003d\u003e $::cinder::params::volume_service,"},{"line_number":64,"context_line":"      score   \u003d\u003e \u0027INFINITY\u0027,"},{"line_number":65,"context_line":"      require \u003d\u003e [Pacemaker::Resource::Service[$::cinder::params::volume_service],"},{"line_number":66,"context_line":"                  Pacemaker::Resource::Service[$::cinder::params::backup_service]],"},{"line_number":67,"context_line":"    }"},{"line_number":68,"context_line":"  }"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_4ff8f4c4","line":66,"updated":"2016-06-16 16:29:42.000000000","message":"same thing","commit_id":"dae22bd40753b800ccae2ba59e17201426395329"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c8ba5f74c3d762ec62ae51a8e75d852d9c791d25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_5fa8fb77","line":1,"updated":"2016-07-13 18:52:50.000000000","message":"I think we can safely remove this class, as we\u0027ll run ha-lite.","commit_id":"a61eaf1e97baa44d2e59587a0409d1e689a385ce"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"004125b92cb656b823263ae154ce0e2de39a3bae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bacf61ea_37aebf98","line":1,"in_reply_to":"1aa78d24_5fa8fb77","updated":"2016-08-03 14:35:48.000000000","message":"for cinder-backup we need a/p configuration","commit_id":"a61eaf1e97baa44d2e59587a0409d1e689a385ce"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"004125b92cb656b823263ae154ce0e2de39a3bae","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  Service \u003c| tag \u003d\u003d \u0027cinder-service\u0027 |\u003e {"},{"line_number":36,"context_line":"    hasrestart \u003d\u003e true,"},{"line_number":37,"context_line":"    restart    \u003d\u003e \u0027/bin/true\u0027,"},{"line_number":38,"context_line":"    start      \u003d\u003e \u0027/bin/true\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bacf61ea_5799b36d","line":35,"updated":"2016-08-03 14:35:48.000000000","message":"we shouldn\u0027t do this for all services tagged cinder-service but only for cinder-backup service","commit_id":"a61eaf1e97baa44d2e59587a0409d1e689a385ce"}]}